Hello guys,
Recently, I found that spice have supported gstremer:h264 encoding, so I want
to have a try.
But I'm not sure how to test this feature(I am a spice newbie)
If I play a h264 encoding video in the guest, how can I *confirm* that the
gstremer:h264 works or not ?
If I miss something,
Pushed as a395ac59447dedfb922f997c7c9cff93edd53600
On Thu, 2016-07-28 at 15:51 +0200, Lukas Venhoda wrote:
> When using GtkDrawingArea and EGL was not used, it was still initialized.
> This produced warning messages on systems where EGL is not supported.
>
> Move spice_egl_init from drawing_area_
ack
- Original Message -
> Create it on SPICE_PORT_EVENT_OPENED
>
> Reusing the cancellable leads to a crash:
> #0 0x71662940 in g_task_return_error () at /lib64/libgio-2.0.so.0
> #1 0x71662b60 in g_task_return_new_error () at
> /lib64/libgio-2.0.so.0
> #2 0x7ff
Hi,
On Thu, Jul 28, 2016 at 06:55:11PM +0200, Pavel Grunt wrote:
> Create it on SPICE_PORT_EVENT_OPENED
I would make reference to the g_cancellable_reset() documentation where
it states one should not re-use a GCancellable if it was cancelled.
With this change, we might not need to create it on
Create it on SPICE_PORT_EVENT_OPENED
Reusing the cancellable leads to a crash:
#0 0x71662940 in g_task_return_error () at /lib64/libgio-2.0.so.0
#1 0x71662b60 in g_task_return_new_error () at /lib64/libgio-2.0.so.0
#2 0x757916e0 in read_cancelled (cancellable=,
user_
When using GtkDrawingArea and EGL was not used, it was still initialized.
This produced warning messages on systems where EGL is not supported.
Move spice_egl_init from drawing_area_realize to gl_scanout.
---
Fixup
- Forgot to delete GError *err = NULL;
Changes since v3:
- changed drawing_area_
On Thu, Jul 28, 2016 at 3:40 PM, Marc-André Lureau
wrote:
> Hi
>
> - Original Message -
> > When using GtkDrawingArea and EGL was not used, it was still initialized.
> > This produced warning messages on systems where EGL is not supported.
> >
> > Move spice_egl_init from drawing_area_rea
Hi
- Original Message -
> When using GtkDrawingArea and EGL was not used, it was still initialized.
> This produced warning messages on systems where EGL is not supported.
>
> Move spice_egl_init from drawing_area_realize to gl_scanout.
> ---
> Changes since v3:
> - changed drawing_area_
When using GtkDrawingArea and EGL was not used, it was still initialized.
This produced warning messages on systems where EGL is not supported.
Move spice_egl_init from drawing_area_realize to gl_scanout.
---
Changes since v3:
- changed drawing_area_realized variable to gtk_widget_get_realized()
AFAIK My setup is very basic. I'm using a gnome-boxes machine, and
modifying the xml for libvirt machine to setup a spice graphics adapter
with autoport enabled.
Then I run websockify and connect with spice-html5 client. Nothing strange.
If you want to look to implementation I do for setting up t
On Thu, Jul 28, 2016 at 12:59:05PM +0100, Oliver Gutierrez wrote:
> The problem I was having was the spice-html5 client was throwing exceptions
> for trying to access that property in cases where it is not a valid value.
>
> I got to the error because I'm developing a plugin for cockpit that makes
- Original Message -
> When using GtkDrawingArea and EGL was not used, it was still initialized.
> This produced warning messages on systems where EGL is not supported.
>
> Move spice_egl_init from drawing_area_realize to gl_scanout.
> ---
> Changes since v2:
> - added drawing_area_real
When using GtkDrawingArea and EGL was not used, it was still initialized.
This produced warning messages on systems where EGL is not supported.
Move spice_egl_init from drawing_area_realize to gl_scanout.
---
Changes since v2:
- added drawing_area_realized variable
- only enable egl after spi
The problem I was having was the spice-html5 client was throwing exceptions
for trying to access that property in cases where it is not a valid value.
I got to the error because I'm developing a plugin for cockpit that makes
use of spice-html5 for connecting to VMs, and when spice-html5 starts
dis
Hey,
Thanks for the patch!
I'd expand a bit in the commit log, that this.source_buffer can be used
before being checked for null, and that this commit moves the check
before the first use of this.source_buffer.
You could also describe what happens when this triggers/how this
triggers (I assume pl
On Thu, Jul 28, 2016 at 06:00:15AM -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > On Thu, Jul 28, 2016 at 11:52:45AM +0200, Christophe Fergeau wrote:
> > > Hey,
> > >
> > > Not overly familiar with the migration code (guess I should experiment
> > > more with it and try
Hi
- Original Message -
> On Thu, Jul 28, 2016 at 11:52:45AM +0200, Christophe Fergeau wrote:
> > Hey,
> >
> > Not overly familiar with the migration code (guess I should experiment
> > more with it and try to write some documentation...), but this seems to
> > make sense..
> >
> > Acked
On Thu, Jul 28, 2016 at 11:52:45AM +0200, Christophe Fergeau wrote:
> Hey,
>
> Not overly familiar with the migration code (guess I should experiment
> more with it and try to write some documentation...), but this seems to
> make sense..
>
> Acked-by: Christophe Fergeau
I've pushed this patch
On Wed, Jul 27, 2016 at 05:00:03PM +0300, Uri Lublin wrote:
> On 07/25/2016 07:37 PM, Francois Gouget wrote:
> > On Sun, 24 Jul 2016, Uri Lublin wrote:
> > [...]
> > > This patch prevents a crash as few lines below there is access
> > > to agent->video_encoder->codec_type.
> > >
> > > I think it w
---
playback.js | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/playback.js b/playback.js
index 9659381..b5954da 100644
--- a/playback.js
+++ b/playback.js
@@ -107,21 +107,20 @@ SpicePlaybackConn.prototype.process_channel_message =
function(msg)
So we do
Hey,
Not overly familiar with the migration code (guess I should experiment
more with it and try to write some documentation...), but this seems to
make sense..
Acked-by: Christophe Fergeau
Can you backport it to the 0.12 branch, or do you prefer that I do it?
Christophe
On Wed, Jul 20, 2016
From: Marc-André Lureau
It is not actually used by msg_SpiceMsgCompressedData since it must be
appended manually.
Signed-off-by: Marc-André Lureau
---
src/channel-usbredir.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 0e7a0b0..cacdc5
Tested with valgrind, looks good.
On 07/11/2016 06:16 PM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
While reviewing lz4 patch, I found that there are potential leaks. This
is untested, fyi. It would be nice if someone could confirm with running
ASAN for example.
Signed-off-b
23 matches
Mail list logo
