Re: [Spice-devel] [PATCH v9 1/2] Modifying ioctl structures

On Tue, Aug 16, 2016 at 7:10 PM, Frediano Ziglio wrote: > > > > This patch modifies the Qxl ioctl structures in order > > to make them unified. Ioctls now should inherit QXL_ESCAPE > > structure. > > > > Signed-off-by: Sameeh Jubran > > Yes, but doing so

Re: [Spice-devel] [PATCH v9 1/2] Modifying ioctl structures

> > This patch modifies the Qxl ioctl structures in order > to make them unified. Ioctls now should inherit QXL_ESCAPE > structure. > > Signed-off-by: Sameeh Jubran Yes, but doing so with a XDDM driver will fail. ExtEscape ABI should remain the same. The structure with the

[Spice-devel] [PATCH v9 1/2] Modifying ioctl structures

This patch modifies the Qxl ioctl structures in order to make them unified. Ioctls now should inherit QXL_ESCAPE structure. Signed-off-by: Sameeh Jubran --- vdagent/display_configuration.cpp | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-)

[Spice-devel] [PATCH v9 0/2] Adding multiple monitors and arbitrary resolution for Windows 10

Diffrences from previous patch: * Rebased on master. Tested on both Windows 10 and XP and seems to be working great. I've modified the driver accordingly, I'll send the driver patches soon. Those patches require the following patch to be applied first to spice-protocol:

[Spice-devel] [PATCH v9 2/2] Implementing WDDM interface to support multiple monitors and arbitrary resolution

The Direct3D 9 API operates on either the Windows XP display driver model (XPDM) or the Windows Vista display driver model (WDDM), depending on the operating system installed. This patch implements the WDDM interface while using the CCD API to do so. Moreover it introduces multiple monitors

Re: [Spice-devel] [PATCH qxl-wddm-dod 05/26] Fix Code Integrity error generated by the Drive Verifier

> From: Sandy Stutsman > > Add MdlMappingNoExecute to MmGetSystemAddressForMDLSafe call in > ExecutePresentDisplayOnly. > --- > qxldod/QxlDod.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp > index

Re: [Spice-devel] [PATCH qxl-wddm-dod 03/26] Add printer class to dump debug print statements to kernel debugger output

> > From: Sandy Stutsman > > Allows the usage of Kd_IHVVIDEO_Mask to control print level while debugging > > Signed-off-by: Sameeh Jubran > --- > qxldod/driver.cpp | 24 +++- > qxldod/driver.h | 20 > 2 files

Re: [Spice-devel] [PATCH qxl-wddm-dod 02/26] Add delete operator

> > Based on a patch by Sandy Stutsman > > Signed-off-by: Sameeh Jubran > --- > qxldod/BaseObject.cpp | 11 +++ > qxldod/BaseObject.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/qxldod/BaseObject.cpp b/qxldod/BaseObject.cpp >

Re: [Spice-devel] [PATCH win-vdagent v8 0/2] Adding multiple monitors and arbitrary resolution for Windows 10

> > Diffrences from previous patch: > * Modified the ioctls structures > > NOTE: The patch "Encapsulating XPDM implementation" was pushed, However > I've modified the patch again. > Please rebase on master Frediano > Tested on both Windows 10 and XP and seems to be working great. I've

Re: [Spice-devel] [spice 2/2] streaming: Stop streaming if the client reports a streaming error

Hi, On Thu, Aug 11, 2016 at 01:04:15PM +0200, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > > If there's enough bandwidth it's as if nothing wrong ever happened :-) > > server/dcc.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git

[Spice-devel] [PATCH win-vdagent v8 2/2] Implementing WDDMinterface to support multiple monitors and arbitrary resolution

The Direct3D 9 API operates on either the Windows XP display driver model (XPDM) or the Windows Vista display driver model (WDDM), depending on the operating system installed. This patch implements the WDDM interface while using the CCD API to do so. Moreover it introduces multiple monitors

[Spice-devel] [PATCH win-vdagent v8 0/2] Adding multiple monitors and arbitrary resolution for Windows 10

Diffrences from previous patch: * Modified the ioctls structures NOTE: The patch "Encapsulating XPDM implementation" was pushed, However I've modified the patch again. Tested on both Windows 10 and XP and seems to be working great. I've modified the driver accordingly, I'll send the driver

Re: [Spice-devel] [client 1/2] streaming: Send a special stream report to signal streaming errors

Hi, On Thu, Aug 11, 2016 at 01:04:09PM +0200, Francois Gouget wrote: > Servers that recognize this special report then stop streaming (sending > regular screen updates instead) while older ones essentially ignore it. > > Signed-off-by: Francois Gouget > --- > > This

Re: [Spice-devel] [PATCH 5/5] Avoid to use _singleton for VDService

> > Hi, > > Sorry for taking some time with the other patches ;) > Remaining patches are good to go! > > Acked-by: Victor Toso > Thanks Frediano > On Fri, Aug 12, 2016 at 12:02:09PM +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio

[Spice-devel] [PATCH win-vdagent v8 1/2] Encapsulating XPDM implementation

The Direct3D 9 API operates on either the Windows XP display driver model (XPDM) or the Windows Vista display driver model (WDDM), depending on the operating system installed. This patch encapsulates the current XPDM interface implementation into XPDMInterface class which inherits DisplayConfig

[Spice-devel] [PATCH spice-protocol v3] Add ioctls structures to qxl_windows.h

This patch defines the structures of ioctls that are used between win-vdagent and the qxl-wddm-dod driver. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/spice/qxl_windows.h

Re: [Spice-devel] [PATCH 5/5] Avoid to use _singleton for VDService

Hi, Sorry for taking some time with the other patches ;) Remaining patches are good to go! Acked-by: Victor Toso On Fri, Aug 12, 2016 at 12:02:09PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > vdservice/vdservice.cpp | 32

Re: [Spice-devel] [PATCH spice-protocol v2] Add ioctls structures to qxl_windows.h

On Tue, Aug 16, 2016 at 03:58:50PM +0300, Sameeh Jubran wrote: > This patch defines the structures of ioctls that are used between > win-vdagent and the qxl-wddm-dod driver. > > Signed-off-by: Sameeh Jubran > --- > spice/qxl_windows.h | 15 +++ > 1 file changed,

[Spice-devel] [PATCH spice-protocol v2] Add ioctls structures to qxl_windows.h

This patch defines the structures of ioctls that are used between win-vdagent and the qxl-wddm-dod driver. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/spice/qxl_windows.h

Re: [Spice-devel] [PATCH libcacard] Do not fail, if the caller didn't pick up response from previous call

On Tue, 2016-08-16 at 12:15 +0200, Jakub Jelen wrote: > On 08/16/2016 11:11 AM, Marc-André Lureau wrote: > > > > Hi > > > > - Original Message - > > > > > > Hello all, > > > cross-posting the originally opened pull request on github [1] (with > > > attached patch): > > > > > > During

Re: [Spice-devel] [PATCH libcacard] Do not fail, if the caller didn't pick up response from previous call

On 08/16/2016 11:11 AM, Marc-André Lureau wrote: Hi - Original Message - Hello all, cross-posting the originally opened pull request on github [1] (with attached patch): During our testing of a new CAC driver in OpenSC, with this library, we encountered a problem with |libcacard|

Re: [Spice-devel] [PATCH spice-protocol] Add ioctls structures to qxl_windows.h

> On Tue, Aug 16, 2016 at 1:27 PM, Frediano Ziglio < fzig...@redhat.com > > wrote: > > > > > > > This patch defines the structures of ioctls that are used between > > > > win-vdagent and the qxl-wddm-dod driver. > > > > > > > > Signed-off-by: Sameeh Jubran < sam...@daynix.com > > > > > --- >

Re: [Spice-devel] [PATCH win-vdagent v7 2/3] Encapsulating XPDM implementation

great thanks :) On Tue, Aug 16, 2016 at 1:37 PM, Frediano Ziglio wrote: > > > > The Direct3D 9 API operates on either the Windows XP display driver > > model (XPDM) or the Windows Vista display driver model (WDDM), depending > > on the operating system installed. > > > >

Re: [Spice-devel] [PATCH win-vdagent v7 1/3] Introducing Windows CCD API

> > The Connecting and Configuring Displays (CCD) Win32 APIs > provide more control over the desktop display setup. The CCD APIs > move away from using Windows Graphics Device Interface (GDI) > concepts like view name and toward Windows Display Driver Model > (WDDM) concepts like adapter, source,

Re: [Spice-devel] [PATCH spice-protocol] Add ioctls structures to qxl_windows.h

On Tue, Aug 16, 2016 at 1:27 PM, Frediano Ziglio wrote: > > > > This patch defines the structures of ioctls that are used between > > win-vdagent and the qxl-wddm-dod driver. > > > > Signed-off-by: Sameeh Jubran > > --- > > spice/qxl_windows.h | 16

Re: [Spice-devel] [PATCH spice-protocol] Adding ioctl structures for win-vdagent/qxl-wddm-dod

> spice-protocol is a sub-project for win-vdagent. This patch intreduces the > structures that are used in this patch > https://lists.freedesktop.org/archives/spice-devel/2016-August/031389.html No, it's not used... otherwise it won't compile... > On Tue, Aug 16, 2016 at 1:22 PM, Frediano

Re: [Spice-devel] [PATCH spice-protocol] Adding ioctl structures for win-vdagent/qxl-wddm-dod

spice-protocol is a sub-project for win-vdagent. This patch intreduces the structures that are used in this patch *https://lists.freedesktop.org/archives/spice-devel/2016-August/031389.html * On Tue, Aug 16, 2016 at 1:22

Re: [Spice-devel] [PATCH spice-protocol] Add ioctls structures to qxl_windows.h

> > This patch defines the structures of ioctls that are used between > win-vdagent and the qxl-wddm-dod driver. > > Signed-off-by: Sameeh Jubran > --- > spice/qxl_windows.h | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-protocol] Adding ioctl structures for win-vdagent/qxl-wddm-dod

> > This patch introduces structures that are used to communicate between > win-vdagent and qxl-wddm-dod. > > This patch should be applied before applying this patch: > https://lists.freedesktop.org/archives/spice-devel/2016-August/031386.html > Why? Code compile even without this patch >

[Spice-devel] [PATCH spice-protocol] Adding ioctl structures for win-vdagent/qxl-wddm-dod

This patch introduces structures that are used to communicate between win-vdagent and qxl-wddm-dod. This patch should be applied before applying this patch: https://lists.freedesktop.org/archives/spice-devel/2016-August/031386.html Sameeh Jubran (1): Add ioctls structures to qxl_windows.h

[Spice-devel] [PATCH spice-protocol] Add ioctls structures to qxl_windows.h

This patch defines the structures of ioctls that are used between win-vdagent and the qxl-wddm-dod driver. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/spice/qxl_windows.h

Re: [Spice-devel] [PATCH libcacard] Do not fail, if the caller didn't pick up response from previous call

Hi - Original Message - > Hello all, > cross-posting the originally opened pull request on github [1] (with > attached patch): > > During our testing of a new CAC driver in OpenSC, with this library, we > encountered a problem with |libcacard| failing and the driver returning > only a

[Spice-devel] [PATCH win-vdagent v7 3/3] Implementing WDDM interface to support multiple monitors and arbitrary resolution

The Direct3D 9 API operates on either the Windows XP display driver model (XPDM) or the Windows Vista display driver model (WDDM), depending on the operating system installed. This patch implements the WDDM interface while using the CCD API to do so. Moreover it introduces multiple monitors

[Spice-devel] [PATCH win-vdagent v7 0/3] Adding multiple monitors and arbitrary resolution for Windows 10

Diffrences from previous patches: * Fixed a bug when driver is disabled and enabled. * Moved ioctls structures to qxl_windows.h * Changes pointed out by Frediano. * Cosmetic changes. Sameeh Jubran (3): Introducing Windows CCD API Encapsulating XPDM implementation Implementing WDDM

[Spice-devel] [PATCH win-vdagent v7 2/3] Encapsulating XPDM implementation

The Direct3D 9 API operates on either the Windows XP display driver model (XPDM) or the Windows Vista display driver model (WDDM), depending on the operating system installed. This patch encapsulates the current XPDM interface implementation into XPDMInterface class which inherits DisplayConfig

[Spice-devel] [PATCH win-vdagent v7 1/3] Introducing Windows CCD API

The Connecting and Configuring Displays (CCD) Win32 APIs provide more control over the desktop display setup. The CCD APIs move away from using Windows Graphics Device Interface (GDI) concepts like view name and toward Windows Display Driver Model (WDDM) concepts like adapter, source, and target