On Fri, 2016-09-16 at 12:57 -0400, Frediano Ziglio wrote:
> >
> >
> > Fix potential infinite loop
> > ---
> > server/stream.c | 11 ---
> > 1 file changed, 4 insertions(+), 7 deletions(-)
> >
> > diff --git a/server/stream.c b/server/stream.c
> > index 934b236..49b5910 100644
> > --- a/
>
> Fix potential infinite loop
> ---
> server/stream.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/server/stream.c b/server/stream.c
> index 934b236..49b5910 100644
> --- a/server/stream.c
> +++ b/server/stream.c
> @@ -331,11 +331,10 @@ void detach_strea
Fix potential infinite loop
---
server/stream.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/server/stream.c b/server/stream.c
index 934b236..49b5910 100644
--- a/server/stream.c
+++ b/server/stream.c
@@ -331,11 +331,10 @@ void detach_stream(DisplayChannel *displ
On Fri, 2016-09-16 at 12:25 -0400, Frediano Ziglio wrote:
> >
> >
> > Fix potential infinite loop
> > ---
> > You can still introduce a foreach macro if you'd like, but this
> > should fix
> > the
> > infinite loop for now.
> >
>
> Macro could be introduced back later if we decide to.
>
> >
>
>
> Fix potential infinite loop
> ---
> You can still introduce a foreach macro if you'd like, but this should fix
> the
> infinite loop for now.
>
Macro could be introduced back later if we decide to.
> server/stream.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --
Hi,
I came to this code in dcc.c (dcc_clear_surface_drawables_from_pipe function):
/*
* in case that the pipe didn't contain any item that is dependent on the
surface, but
* there is one during sending. Use a shorter timeout, since it is just one
item
*/
return red_chann
Fix potential infinite loop
---
You can still introduce a foreach macro if you'd like, but this should fix the
infinite loop for now.
server/stream.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/stream.c b/server/stream.c
index 934b236..be3e437 100644
--- a/ser
On Fri, 2016-09-16 at 10:05 +0100, Frediano Ziglio wrote:
> Minor changes:
> - use same name for dcc_add_surface_area_image argument in header
> and source;
> - avoid using 2 variable in a for loop, is not much readable and
> confusing. This also was fixing a regression quite hard to spot
> s
On Thu, 2016-09-15 at 14:51 -0500, Jonathon Jongsma wrote:
> On Thu, 2016-09-15 at 16:55 +0200, Pavel Grunt wrote:
> >
> > Hey,
> >
> > On Wed, 2016-09-14 at 11:53 -0500, Jonathon Jongsma wrote:
> > >
> > >
> > > Change a couple more Rings to GQueue
> > > ---
> > > Changes in v2:
> > > - use G
Noting that coding by hand these loop introduced some regression
I'm trying to introduce back from macros.
Before trying something harder to make possible to bind the type of
the content I'm trying some simple macro as were before.
I added the type to avoid some blindly void* casts.
Also the GListI
>
> On Wed, 2016-09-14 at 06:30 -0400, Frediano Ziglio wrote:
> > >
> > >
> > > I haven't looked very carefully at the changes, but a few comments
> > > about readability:
> > >
> > > On Mon, Sep 12, 2016 at 04:32:03PM +0100, Frediano Ziglio wrote:
> > > >
> > > > This avoid to have the search
Signed-off-by: Frediano Ziglio
---
server/red-channel.c | 50 +++---
1 file changed, 23 insertions(+), 27 deletions(-)
diff --git a/server/red-channel.c b/server/red-channel.c
index 474fe68..166221e 100644
--- a/server/red-channel.c
+++ b/server/red-ch
With the introduction of GList/GQueue these macro were removed
at the expense of some minor regressions.
The first patch was started time ago and resemble more to old
macro while the second try to use some more safe way.
Frediano Ziglio (2):
RedChannel: Add FOREACH_CHANNEL and use it to iterate
Hi,
On Fri, Sep 16, 2016 at 10:38:56AM -0400, Frediano Ziglio wrote:
> >
> > ---
> > .gitignore | 6 +
> > Makefile.am| 28
> > +++---
> > src/vdagent/{vdagent-audio.c => audio.c} | 2
>
> ---
> .gitignore | 6 +
> Makefile.am| 28
> +++---
> src/vdagent/{vdagent-audio.c => audio.c} | 2 +-
> src/vdagent/{vdagent-audio.h => audio.h} | 4 ++--
> src/vdagent
On Fri, 2016-09-16 at 10:39 +0100, Frediano Ziglio wrote:
> Remove added FIXME introducing an helper function.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel.c | 12
> server/display-channel.h | 2 ++
> server/red-worker.c | 16 ++--
> 3 files ch
> >
> > Add a couple new functions to the header so that they can be called by
> > other objects rather than poking into the internals of the struct.
> > ---
> > server/dcc-send.c| 16 +--
> > server/display-channel.c | 71
> >
> >
On Fri, 2016-09-16 at 13:26 +0100, Frediano Ziglio wrote:
> Style fix
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/display-channel.c | 4 ++--
> server/display-channel.h | 3 +--
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/server/display-chann
Style fix
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 4 ++--
server/display-channel.h | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 56bb029..4e643dd 100644
--- a/server/display-channel.c
+++ b/
Do the check after replay_fscanf to make sure everything
is fine before calling red_replay_compat_drawable or
red_replay_native_drawable.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-replay-qxl.c b/serve
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
index 6914c17..6950f98 100644
--- a/server/red-replay-qxl.c
+++ b/server/red-replay-qxl.c
@@ -57,16 +57,14 @@
Avoid negative syntax. Also could prevent some memory problem is number
get too big.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
index 1442686..69
Currently on Linux PRIu64 and SCNu64 are the same but just to make
sure in the future use the correct macros.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
i
Change the return to ssize_t to be able to distinguish from
empty buffer to error.
Check result returned and avoid continuing potentially
deferencing NULL pointers.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 37 ++---
1 file changed, 26 insertion
Detect error in files and handle more gracefully.
This version:
- fix some formatting issue (Pavel);
- merged some patches;
- improved an error check (Pavel);
- added two patches to improve replay.
Frediano Ziglio (8):
replay: Record allocations in a GList to handle errors
replay: Handle error
Avoid to free invalid pointer.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
index 5fcb243..6914c17 100644
--- a/server/red-replay-qxl.c
+++ b/server/red-repl
To check fscanf read all needed information a dummy "%n" is appended
to any string and the value stored there is tested. This as scanf family
could return a valid value but not entirely process the string so
adding a "%n" and checking this was processed make sure all expected
string is found.
The c
Allocations are kept into a GList to be able to free in case some
errors happened.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 68 -
1 file changed, 56 insertions(+), 12 deletions(-)
diff --git a/server/red-replay-qxl.c b/server/r
>
> Reuse and handle the return value from agent_msg_filter_process_data
> ---
> v3: discard AGENT_MSG_FILTER_MONITORS_CONFIG
> ---
> server/reds.c | 66
> ++-
> 1 file changed, 29 insertions(+), 37 deletions(-)
>
> diff --git a/server/red
>
> Explicitely discard AGENT_MSG_FILTER_MONITORS_CONFIG messages
> from the agent.
>
> Also remove unused AGENT_MSG_FILTER_END
> ---
> v3: discard AGENT_MSG_FILTER_MONITORS_CONFIG
> ---
> server/agent-msg-filter.c | 4 ++--
> server/agent-msg-filter.h | 11 +--
> server/reds.c
On Thu, 2016-09-15 at 23:19 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-replay-qxl.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index 73f9cd4..fe4f7a9 100644
> ---
On Thu, 2016-09-15 at 23:19 +0100, Frediano Ziglio wrote:
> read_binary do not allocate a buffer for no-NULL pointers.
> Avoid using uninitialized data and allocate proper buffer.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/red-replay-qxl.c | 2 +-
> 1 file changed,
On Thu, 2016-09-15 at 23:19 +0100, Frediano Ziglio wrote:
> The eof variable and enumeration will be used for all errors
> so avoid confusion.
Ok, ack
Pavel
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-replay-qxl.c | 38 +++---
> 1 file changed, 19 inser
On Thu, 2016-09-15 at 23:19 +0100, Frediano Ziglio wrote:
> Same check is done inside replay_fscanf
But removing it will not prevent calling red_replay_compat_drawable or
red_replay_native_drawable
Maybe you want to check the return value of replay_fscanf
Pavel
>
> Signed-off-by: Frediano Zigl
Explicitely discard AGENT_MSG_FILTER_MONITORS_CONFIG messages
from the agent.
Also remove unused AGENT_MSG_FILTER_END
---
v3: discard AGENT_MSG_FILTER_MONITORS_CONFIG
---
server/agent-msg-filter.c | 4 ++--
server/agent-msg-filter.h | 11 +--
server/reds.c | 6 --
3 file
Reuse and handle the return value from agent_msg_filter_process_data
---
v3: discard AGENT_MSG_FILTER_MONITORS_CONFIG
---
server/reds.c | 66 ++-
1 file changed, 29 insertions(+), 37 deletions(-)
diff --git a/server/reds.c b/server/reds.c
in
Remove unneeded header inclusion.
Signed-off-by: Frediano Ziglio
---
server/stream.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/stream.c b/server/stream.c
index c3877c7..4732dee 100644
--- a/server/stream.c
+++ b/server/stream.c
@@ -20,7 +20,6 @@
#include "stream.h"
#include "
Remove added FIXME introducing an helper function.
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 12
server/display-channel.h | 2 ++
server/red-worker.c | 16 ++--
3 files changed, 16 insertions(+), 14 deletions(-)
diff --git a/server/display-chan
>
> On Thu, 2016-09-15 at 15:06 -0500, Jonathon Jongsma wrote:
> > On Thu, 2016-09-15 at 11:22 -0500, Jonathon Jongsma wrote:
> > > Move all of the DisplayChannel data memembers into a private
> > > struct
...
> > > @@ -783,11 +787,13 @@ static void handle_dev_oom(void *opaque,
> > > void
> > > *
>
> Add a couple new functions to the header so that they can be called by
> other objects rather than poking into the internals of the struct.
> ---
> server/dcc-send.c| 16 +--
> server/display-channel.c | 71
>
> server/display-
Minor changes:
- use same name for dcc_add_surface_area_image argument in header
and source;
- avoid using 2 variable in a for loop, is not much readable and
confusing. This also was fixing a regression quite hard to spot
so make sure code is less easy to break in the future;
- remove check i
On Thu, 2016-09-15 at 15:06 -0500, Jonathon Jongsma wrote:
> On Thu, 2016-09-15 at 11:22 -0500, Jonathon Jongsma wrote:
> > Move all of the DisplayChannel data memembers into a private
> > struct
> > to
> > encapsulate things better. This necessitated a few new 'public'
> > methods
> > and a small
On Thu, 2016-09-15 at 11:22 -0500, Jonathon Jongsma wrote:
> Add a couple new functions to the header so that they can be called
> by
> other objects rather than poking into the internals of the struct.
> ---
> server/dcc-send.c| 16 +--
> server/display-channel.c | 71
> ++
On Fri, 2016-09-16 at 08:30 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/dcc-send.c | 33 -
> 1 file changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/server/dcc-send.c b/server/dcc-send.c
> index 5
On Fri, 2016-09-16 at 08:30 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/dcc-send.c | 26 --
> 1 file changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/server/dcc-send.c b/server/dcc-send.c
> index 89c3dc5.
>
> This improves the readability of the code and keeps things
> encapsulated better.
> ---
> Changes in v2:
> - changed some loops from while to for
> - moved some declarations within loop scope
>
> server/dcc.c | 12 +---
> server/dcc.h | 1 -
> server/displa
On Fri, 2016-09-16 at 08:30 +0100, Frediano Ziglio wrote:
> Pass boolean directly.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/dcc-send.c | 15 +++
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/server/dcc-send.c b/server/dcc-send.
>
> Make RedsState::mig_target_clients into a GList to improve encapsulation
> and maintainability. Also RedsMigTargetClient::pending_links. With
> GList, a type implementation can be ignorant of whether they're
> contained within a list or not.
Acked-by: Frediano Ziglio
Frediano
> ---
> Chang
Signed-off-by: Frediano Ziglio
---
server/dcc-send.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index 89c3dc5..1d32276 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -102,28 +102,26 @@ static in
Pass boolean directly.
Signed-off-by: Frediano Ziglio
---
server/dcc-send.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index 317d906..89c3dc5 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -147,11 +147,7 @
Signed-off-by: Frediano Ziglio
---
server/dcc-send.c | 33 -
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index 521e6a2..317d906 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -131,7 +131,7 @@ stat
51 matches
Mail list logo
