Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

Hi Frediano! Thank you for looking into it imho it is confusing to document spice-protocol which is defined in spice-common in spice server git repository. ^ that sentence is strange I know the documentation files are in the spice server git repo, imo it is wrong. I would put this kind of info

Re: [Spice-devel] spice performance tweaking

Hi, I'm not using TLS to connect the spice session, so unless there is another encryption that I'm not aware of, it's already off And I already tried switching of lzo compression, but if there was an improvement I couldn't see it. I'm not sure where the microsoft windows display driver entered th

[Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

Small update for this patchset: - fix headers in "Extended protocol documentation"; - added some more documentation on attributes. Frediano Ziglio (4): Start adding protocol file documentation Start writing some documentation on protocol Extended protocol documentation More work on attribu

[Spice-devel] [PATCH v2 3/4] Extended protocol documentation

Signed-off-by: Frediano Ziglio --- docs/spice_protocol.txt | 360 1 file changed, 360 insertions(+) diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt index 3406cb9..832ea73 100644 --- a/docs/spice_protocol.txt +++ b/docs/spice_protoco

[Spice-devel] [PATCH v2 4/4] More work on attribute protocol documentation

Signed-off-by: Frediano Ziglio --- docs/spice_protocol.txt | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt index 832ea73..13506f1 100644 --- a/docs/spice_protocol.txt +++ b/docs/spice_protocol.txt @@ -336

[Spice-devel] [PATCH v2 1/4] Start adding protocol file documentation

The protocol file is not documented and people have to read code to understand the specification. This can lead to unexpected or not optimal results so it's better to have it documented. The m4/spice_manual.m4 came from spice server and is meant to be reused. Signed-off-by: Frediano Ziglio --- M

[Spice-devel] [PATCH v2 2/4] Start writing some documentation on protocol

Signed-off-by: Frediano Ziglio --- docs/spice_protocol.txt | 48 1 file changed, 48 insertions(+) diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt index b62da25..3406cb9 100644 --- a/docs/spice_protocol.txt +++ b/docs/spice_protocol.

Re: [Spice-devel] spice performance tweaking

> Hi, > I tried a virtual rhel7.3beta (server with gui) on a rhel7.3beta host. > The host was a laptop to which I setup to use my old wifi router that only > has 54Mbit so the bandwith was poor and unstable. > Without the compression options the spice display was really bad. > You could see the

[Spice-devel] [PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

Signed-off-by: Hans de Goede --- src/spiceqxl_main_loop.c | 4 1 file changed, 4 insertions(+) diff --git a/src/spiceqxl_main_loop.c b/src/spiceqxl_main_loop.c index db89b6d..0ac1f3e 100644 --- a/src/spiceqxl_main_loop.c +++ b/src/spiceqxl_main_loop.c @@ -330,7 +330,11 @@ static int no_writ

[Spice-devel] [PATCH] Cache field to make code easier

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index d7ea7d5..32f8e67 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -1976,22 +

[Spice-devel] [PATCH RFC 10/14] Pass surface directly to dcc_create_surface

Signed-off-by: Frediano Ziglio --- server/dcc.c | 13 ++--- server/dcc.h | 3 +-- server/display-channel.c | 11 ++- 3 files changed, 13 insertions(+), 14 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index c4510b0..8a63caf 100644 --- a/server/dcc

[Spice-devel] [PATCH RFC 08/14] Pass surface directly calling display_channel_current_flush

Signed-off-by: Frediano Ziglio --- server/dcc.c | 6 +++--- server/display-channel.c | 8 server/display-channel.h | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 3e597b8..c4510b0 100644 --- a/server/dcc.c +++ b/server/

[Spice-devel] [PATCH RFC 14/14] Reuse more validate_surface

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index cf019fe..c4d07f7 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -9

[Spice-devel] [PATCH RFC 12/14] Use directly surface instead of id

Signed-off-by: Frediano Ziglio --- server/dcc.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index a800aaa..eeb2867 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -243,28 +243,28 @@ static void add_drawable_surface_im

[Spice-devel] [PATCH RFC 07/14] Pass surface directly calling dcc_clear_surface_drawables_from_pipe

Signed-off-by: Frediano Ziglio --- server/dcc.c | 11 +++ server/dcc.h | 3 ++- server/display-channel.c | 8 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index be95e1b..3e597b8 100644 --- a/server/dcc.c +++

[Spice-devel] [PATCH RFC 11/14] Pass surface directly to dcc_push_surface_image

Signed-off-by: Frediano Ziglio --- server/dcc.c | 13 + server/dcc.h | 3 +-- server/display-channel.c | 5 +++-- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 8a63caf..a800aaa 100644 --- a/server/dcc.c +++

[Spice-devel] [PATCH RFC 09/14] New function to pass surface directly to display_channel_draw

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 7627df9..e0a91a3 100644 --- a/server/display-channel.c +++ b/server/display-chann

[Spice-devel] [PATCH RFC 13/14] Change validate_surface to return surface pointer

Signed-off-by: Frediano Ziglio --- server/dcc-send.c| 8 server/display-channel.c | 19 +++ server/display-channel.h | 2 +- 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/server/dcc-send.c b/server/dcc-send.c index 1e31584..d5ed97e 100644 ---

[Spice-devel] [PATCH RFC 04/14] Pass surface directly to display_channel_surface_unref

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 23 ++- server/display-channel.h | 2 +- server/red-worker.c | 2 +- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 5e9bc7d..5cdd0cb

[Spice-devel] [PATCH RFC 06/14] Pass surface directly calling draw_depend_on_me and display_channel_destroy_surface

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index dcbd250..87c801b 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @

[Spice-devel] [PATCH RFC 03/14] Pass surface directly to current_remove_all

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 18f31dc..5e9bc7d 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -382,9 +382

[Spice-devel] [PATCH RFC 00/14] Change the way RedSurface is stored and handled

This series of patches attempt to use direct pointers to surfaces. The current code rely on the fact that surface pointer for a specific surface_id does not change. For this reason for instance surfaces are allocated in a static array. On the other way surfaces have reference counting so why don't

[Spice-devel] [PATCH RFC 02/14] Pass surface directly for surface_read_bits

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 99082e6..18f31dc 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -847,11 +847,10 @

[Spice-devel] [PATCH RFC 05/14] Pass surface directly in is_primary_surface

Signed-off-by: Frediano Ziglio --- server/dcc.c | 4 ++-- server/display-channel.c | 14 +++--- server/display-channel.h | 7 ++- 3 files changed, 15 insertions(+), 10 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index af32de7..be95e1b 100644 --- a/server/dcc.c

[Spice-devel] [PATCH RFC 01/14] Use direct pointers for surface and surface dependencies from Drawable

As we use reference counting is more direct to use direct pointers. Also this will allow to have a surface in a "released state" reducing the complexity of code destroying a surface. Signed-off-by: Frediano Ziglio --- server/dcc-send.c| 21 ++- server/dcc.c | 21 +