Re: [Spice-devel] [PATCH spice-server v2 0/7] Update proposed refactory merges

2016-10-05 Thread Jonathon Jongsma
These patches (including the two extra fixups I sent) look fine to me, but I'll wait for somebody else to officially ACK them. Jonathon On Fri, 2016-09-30 at 14:21 +0100, Frediano Ziglio wrote: > This patchset contains my split of the patches and some > proposed changes to the second big patch.

[Spice-devel] [PATCH 1/2] fixup! Convert RedChannelClient hierarchy to GObject

2016-10-05 Thread Jonathon Jongsma
Allocate DisplayChannelClientPrivate manually to avoid changing all arrays to dynamically allocated. --- server/dcc-private.h | 6 +++--- server/dcc.c | 17 + 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/server/dcc-private.h b/server/dcc-private.h index

[Spice-devel] [PATCH 0/2] A couple more fixups

2016-10-05 Thread Jonathon Jongsma
These should apply to the end of your fixup series Jonathon Jongsma (2): fixup! Convert RedChannelClient hierarchy to GObject fixup! Convert RedChannelClient hierarchy to GObject server/cursor-channel-client.c | 9 - server/dcc-private.h | 6 +++--- server/dcc.c

[Spice-devel] [PATCH 2/2] fixup! Convert RedChannelClient hierarchy to GObject

2016-10-05 Thread Jonathon Jongsma
Remove a couple unimplemented gobject vfuncs --- server/cursor-channel-client.c | 9 - server/main-channel-client.c | 12 2 files changed, 21 deletions(-) diff --git a/server/cursor-channel-client.c b/server/cursor-channel-client.c index 51fef19..19ac8e7 100644 --- a/serve

Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

2016-10-05 Thread Christophe Fergeau
On Wed, Oct 05, 2016 at 03:08:58PM +0200, Victor Toso wrote: > Hi, > > On Tue, Oct 04, 2016 at 04:58:29AM -0400, Frediano Ziglio wrote: > > > > > > On Fri, Sep 30, 2016 at 01:13:04PM +0200, Victor Toso wrote: > > > > On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote: > > > > > Just t

Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

2016-10-05 Thread Victor Toso
Hi, On Tue, Oct 04, 2016 at 04:58:29AM -0400, Frediano Ziglio wrote: > > > > On Fri, Sep 30, 2016 at 01:13:04PM +0200, Victor Toso wrote: > > > On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote: > > > > Just to make it clear... do you mean spice-server repository? > > > > > > Yes. We

Re: [Spice-devel] [spice-gtk v2] tests: fix -Wall -Wextra compiler warnings

2016-10-05 Thread Pavel Grunt
On Mon, 2016-10-03 at 15:23 +0200, Victor Toso wrote: > From: Victor Toso > > With -Wall a few -Wunused-variable and -Wunused-but-set-variable; > With -Wextra lots of -Wunused-parameter and a few -Wsign-compare. > > Signed-off-by: Victor Toso Acked-by: Pavel Grunt > --- >  tests/coroutine.c   

Re: [Spice-devel] [spice-gtk v1 0/2] tests: fix warnings and set name prefix

2016-10-05 Thread Victor Toso
Ops, This was blocked because I sent it with an email not registered in the ml. First patch was pushed, second patch I sent a v2. Feel free to ignore this series. On Fri, Sep 30, 2016 at 05:10:01PM +0200, Victor Toso wrote: > Hi, > > First patch fixes a few harmless compiler warnings. I put it

[Spice-devel] [spice-gtk v1 0/2] tests: fix warnings and set name prefix

2016-10-05 Thread Victor Toso
Hi, First patch fixes a few harmless compiler warnings. I put it in a single patch as I did not see a strong reason to split. Second patch sets the test binaries to have 'test-' as prefix. Make check result: PASS: test-util PASS: test-coroutine PASS: test-session PASS: test-spice-uri PASS: test-

[Spice-devel] [spice-gtk v1 2/2] tests: set binaries to have 'test' name prefix

2016-10-05 Thread Victor Toso
To follow test-spice-uri and test-file-transfer standard. --- tests/Makefile.am | 26 +- tests/usb-acl-helper.c | 2 +- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 6d9cfeb..3a0188d 100644 --- a/tests/Mak

[Spice-devel] [spice-gtk v1 1/2] tests: fix some compiler warnings

2016-10-05 Thread Victor Toso
file-transfer.c: In function ‘transfer_on_init_async_cb_agent_cancel’: file-transfer.c:316:19: warning: unused variable ‘cancellable’ [-Wunused-variable] GCancellable *cancellable; ^~~ pipe.c: In function ‘test_pipe_readblock’: pipe.c:91:12: warning: variable ‘size’ s