In preparation for converting RedChannel to GObject, switch to using
RED_CHANNEL()-type macros for casting. For now they just do a regular
cast, but it helps reduce the size of the GObject patch to make it
easier to review.
---
server/common-graphics-channel.c | 2 +-
server/cursor-channel.c
Encapsulate MainChannel a bit better in preparation for proting to
GObject.
---
server/main-channel-client.c | 24 +++-
server/main-channel.c| 43 +--
server/main-channel.h| 11 ---
3 files changed, 48 insertions(+
When MainChannelClient was split to a separate file, the responsibility
for incrementing this field was supposed to belong to the MainChannel
function (main_channel_connect_semi_seamless()), but by mistake it was
incremented both there and in the client function
(main_channel_client_connect_semi_se
Prepare for GObject port
---
server/inputs-channel.c | 68 ++---
1 file changed, 36 insertions(+), 32 deletions(-)
diff --git a/server/inputs-channel.c b/server/inputs-channel.c
index 85ca155..dfb7ba6 100644
--- a/server/inputs-channel.c
+++ b/server/in
Encapsulate private data for CommonGraphicsChannel and prepare for
GObject conversion.
---
server/common-graphics-channel.c | 33 +++--
server/common-graphics-channel.h | 14 ++
server/cursor-channel-client.c | 2 +-
server/cursor-channel.c | 8
Move out of red-worker.c. This requires a little bit of minor
refactoring to avoid accessing some RedWorker internals in the
constructor function, etc.
---
server/Makefile.am | 2 +
server/common-graphics-channel.c | 129 +++
server/common-graphi
Here's a new version of the patch series that results in the RedChannel
hierarchy being converted to GObejct. In addition to fixes for issues that were
pointed out in the review, I also extracted a couple other private structs out
into separate patches. I also added a patch to fix a bug that I disc
On Tue, 2016-10-11 at 09:55 -0400, Frediano Ziglio wrote:
> >
> > > > diff --git a/server/cursor-channel.h b/server/cursor-channel.h
> > > > index a3ddaa3..8b3bc17 100644
> > > > --- a/server/cursor-channel.h
> > > > +++ b/server/cursor-channel.h
> > > > @@ -19,6 +19,17 @@
> > > > # define CURSOR
On Tue, 2016-10-11 at 16:13 +0200, Pavel Grunt wrote:
> Hi Frediano,
>
> On Tue, 2016-10-11 at 09:55 -0400, Frediano Ziglio wrote:
> >
> > >
> > >
> > > On Mon, 2016-10-10 at 12:48 -0400, Frediano Ziglio wrote:
> > > >
> > > > >
> > > > >
> > > > > Subject: [Spice-devel] [PATCH spice-server
On Tue, 2016-10-11 at 10:00 -0400, Frediano Ziglio wrote:
> >
> >
> Beside that... how to better handle all these fixup patches?
> I tend to prefer fixup patches for patch to big patches so
> it's easier to review and people don't have to do weird diff
> commands to understand what's changed from
On Tue, 2016-10-11 at 10:36 -0400, Marc-André Lureau wrote:
>
> - Original Message -
> > Hi,
> >
> > On Mon, 2016-10-10 at 08:37 -0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > - Original Message -
> > > > When the guest receives the monitor configuration message, it
> > > >
- Original Message -
> Hi,
>
> On Mon, 2016-10-10 at 08:37 -0400, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> > > When the guest receives the monitor configuration message, it
> > > replies
> > > (through spice-server) by destroying the primary surface, which
Hi Frediano,
On Tue, 2016-10-11 at 09:55 -0400, Frediano Ziglio wrote:
> >
> > On Mon, 2016-10-10 at 12:48 -0400, Frediano Ziglio wrote:
> > > >
> > > > Subject: [Spice-devel] [PATCH spice-server v2 7/8] Convert
> > > > RedChannel heirarchy to GObject
> > > >
> > >
> > > Small spell, it's
>
> Convert a couple of additional casts
> ---
> One additional fixup on top of Frediano's with some additional cases
> mentioned
> by Pavel
>
> server/inputs-channel.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/server/inputs-channel.c b/server/inp
>
> On Mon, 2016-10-10 at 12:48 -0400, Frediano Ziglio wrote:
> > >
> > > Subject: [Spice-devel] [PATCH spice-server v2 7/8] Convert
> > > RedChannelheirarchy to GObject
> > >
> >
> > Small spell, it's "hierarchy".
> >
> > >
> > > From: Jonathon Jongsma
> > >
> > > FIXME: this commi
Hi,
On Mon, 2016-10-10 at 08:37 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > When the guest receives the monitor configuration message, it
> > replies
> > (through spice-server) by destroying the primary surface, which
> > makes
> > the SpiceDisplay disabled if its "r
Hi,
I've just spent some time tuning an Ubuntu 16.04 (I know Fedora is
preferred around here, but a lot of clients seem to prefer Ubuntu and
its derivatives) desktop for VDI usage, and I had a hard time finding a
X Display Manager which plays nice with spice-vdagent (in the sense of
adapting prope
>
> On Mon, 2016-10-10 at 12:20 -0400, Frediano Ziglio wrote:
> > >
> > >
> > > From: Jonathon Jongsma
> > >
> > > Encapsulate private data for CommonGraphicsChannel and prepare for
> > > GObject conversion.
> >
> > This object has all the fields with accessors... not a really private
> > I w
>
> Hi,
>
> I am adding tests for agent message filtering because I plan to touch
> this area soon [1].
>
> I split the test into two parts to make it easier for review, I am ok
> to squash them.
>
> [1]
> https://lists.freedesktop.org/archives/spice-devel/2016-September/032083.html
>
> Thanks
>
> Signed-off-by: Pavel Grunt
Acked-by: Frediano Ziglio
> ---
> server/agent-msg-filter.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c
> index 7921fe7..17f8e88 100644
> --- a/server/agent-msg-filter.c
> +++ b/server/agent-ms
---
server/tests/test-agent-msg-filter.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/server/tests/test-agent-msg-filter.c
b/server/tests/test-agent-msg-filter.c
index 6582e68..5255ec4 100644
--- a/server/tests/test-agent-msg-filter.c
+++ b/server/tests/test-agent-msg-filter.c
@@ -21,1
Hi,
I am adding tests for agent message filtering because I plan to touch
this area soon [1].
I split the test into two parts to make it easier for review, I am ok
to squash them.
[1]
https://lists.freedesktop.org/archives/spice-devel/2016-September/032083.html
Thanks,
Pavel Grunt (3):
agen
Signed-off-by: Pavel Grunt
---
server/agent-msg-filter.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c
index 7921fe7..17f8e88 100644
--- a/server/agent-msg-filter.c
+++ b/server/agent-msg-filter.c
@@ -25,8 +25,6 @@
#include
#include
Test filter initialization and configuration
Signed-off-by: Pavel Grunt
---
server/tests/Makefile.am | 1 +
server/tests/test-agent-msg-filter.c | 66
2 files changed, 67 insertions(+)
create mode 100644 server/tests/test-agent-msg-filter.c
dif
Signed-off-by: Pavel Grunt
---
server/tests/test-agent-msg-filter.c | 78
1 file changed, 78 insertions(+)
diff --git a/server/tests/test-agent-msg-filter.c
b/server/tests/test-agent-msg-filter.c
index 6582e68..e1ff8e6 100644
--- a/server/tests/test-agent-ms
On Mon, Oct 10, 2016 at 04:41:02PM -0500, Jonathon Jongsma wrote:
> >
> > In spice-gtk we use both style, I don't mind, but I have a slight
> > preference for the first.
> >
> > declarations are however almost always
> >
> > static void function_name(type name);
> >
> > in short, I like glib/gt
26 matches
Mail list logo
