[Spice-devel] [PATCH v2 0/5] Convert RedChannel to GObject

2016-10-13 Thread Jonathon Jongsma
Changes sinced last series - pushed ACKED bugfix patch to master and dropped from this series - dropped InputsChannelPrivate patch - Removed MainChannelPrivate struct and reduced that patch to simply encapsulate the data better - moved "final" gobject structs (cursor, inputs, main channels)

[Spice-devel] [PATCH v2 3/5] Add CommonGraphicsChannelPrivate struct

2016-10-13 Thread Jonathon Jongsma
Encapsulate private data for CommonGraphicsChannel and prepare for GObject conversion. --- server/common-graphics-channel.c | 33 +++-- server/common-graphics-channel.h | 14 ++ server/cursor-channel-client.c | 2 +- server/cursor-channel.c | 8

[Spice-devel] [PATCH v2 4/5] Improve MainChannel encapsulation

2016-10-13 Thread Jonathon Jongsma
Encapsulate MainChannel a bit better in preparation for proting to GObject. --- server/main-channel-client.c | 24 +++- server/main-channel.c| 15 +++ server/main-channel.h| 2 ++ 3 files changed, 28 insertions(+), 13 deletions(-) diff --git a/serv

[Spice-devel] [PATCH v2 1/5] Move CommonGraphicsChannel to a new file

2016-10-13 Thread Jonathon Jongsma
Move out of red-worker.c. This requires a little bit of minor refactoring to avoid accessing some RedWorker internals in the constructor function, etc. --- server/Makefile.am | 2 + server/common-graphics-channel.c | 129 +++ server/common-graphi

[Spice-devel] [PATCH v2 2/5] Use macros for casting Channel types

2016-10-13 Thread Jonathon Jongsma
In preparation for converting RedChannel to GObject, switch to using RED_CHANNEL()-type macros for casting. For now they just do a regular cast, but it helps reduce the size of the GObject patch to make it easier to review. --- server/common-graphics-channel.c | 2 +- server/cursor-channel.c

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-13 Thread Christophe Fergeau
On Mon, Oct 10, 2016 at 08:37:04AM -0400, Marc-André Lureau wrote: > Imho, it should be fine for the client to send the same monitor > config, the server should however not notify of changes if none > happened. Yup, after quite a lot of digging, this seems to be what is happening, nothing in the s

Re: [Spice-devel] Very poor video performance using Virt Viewer compared to RDP

2016-10-13 Thread Frediano Ziglio
> I have a Windows 7 VM running via Qemu on Gentoo Linux using a product called > Foss-Cloud. > I have spice tools and the QXL video driver installed > Using Virt-Viewer The Vm shows a little lag when typing (always takes a > second to catch up when typing my password to log in and such). In genera

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-13 Thread Christophe Fergeau
On Tue, Oct 11, 2016 at 04:56:42PM +0200, Pavel Grunt wrote: > On Tue, 2016-10-11 at 10:36 -0400, Marc-André Lureau wrote: > > > > > > Flickering is PRIMARY_DESTROY & PRIMARY_CREATE > > > > Is there a way to prevent DESTROY & CREATE of same size on > > server/guest side? why not? > > The problem

[Spice-devel] Very poor video performance using Virt Viewer compared to RDP

2016-10-13 Thread Brad Wilson
I have a Windows 7 VM running via Qemu on Gentoo Linux usinga product called Foss-Cloud.    I have spice tools and the QXL video driver installed   Using Virt-Viewer The Vm shows a little lag when typing(always takes a second to catch up when typing my password to log in and such).  In gener

[Spice-devel] [PATCH qxl-wddm-dod v2 2/2] Call "DxgkCbAcquirePostDisplayOwnership" when changing Power State to D0

2016-10-13 Thread Sameeh Jubran
Starting with Windows Display Driver Model (WDDM) 1.2, if the DevicePowerState parameter is set to PowerDeviceD0, the display miniport driver should call DxgkCbAcquirePostDisplayOwnership to query the information about the display mode. This patch fixies this bug: https://bugzilla.redhat.com/show_

[Spice-devel] [PATCH qxl-wddm-dod v2 0/2] Fixing guest change to black-white

2016-10-13 Thread Sameeh Jubran
difference from v1: * Minor typos in commit message fixed * Log Message function name * Minor cosmetic change Sameeh Jubran (2): Fixing black-white screen in installation when qxl revision = 3 Call "DxgkCbAcquirePostDisplayOwnership" when changing Power State to D0 qxldod/QxlDod.cpp | 73

[Spice-devel] [PATCH qxl-wddm-dod v2 1/2] Fixing black-white screen in installation when qxl revision = 3

2016-10-13 Thread Sameeh Jubran
When qxl revision is 3, the vga driver is the one that is running. When installing the driver the function VgaDevice::HWInit with displayInfo structure that is zeroed out. The displayInfo should be initialized using DxgkCbAcquirePostDisplayOwnership and thus it should be called before calling HWIni

Re: [Spice-devel] [PATCH spice-gtk v2 0/4]Add more tests for the session's uri

2016-10-13 Thread Marc-André Lureau
Hi - Original Message - > Hi, > > On Wed, 2016-10-12 at 11:38 -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Hi, > > > > > > I plan to merge both uri parsers (one is in spice-session, one in > > > spice-uri). > > > These patches add more to tests to av

Re: [Spice-devel] [PATCH spice-gtk v2 0/4]Add more tests for the session's uri

2016-10-13 Thread Pavel Grunt
Hi, On Wed, 2016-10-12 at 11:38 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi, > > > > I plan to merge both uri parsers (one is in spice-session, one in > > spice-uri). > > These patches add more to tests to avoid regressions. > > > > v2 per Victor review splits I

Re: [Spice-devel] [PATCH qxl-wddm-dod 1/2] Fixing black-white screen in installation when qxl revision = 3

2016-10-13 Thread Sameeh Jubran
On Thu, Oct 13, 2016 at 3:43 PM, Frediano Ziglio wrote: > > > > When qxl revision is 3, the vga driver is the one that is running. When > > installing the driver the function VgaDevice::HWInit with displayInfo > > structure that is zeroed out. The displayInfo should be intialized using > > DxgkCb

Re: [Spice-devel] [PATCH 4/7] Add InputsChannelPrivate struct

2016-10-13 Thread Frediano Ziglio
> > On Wed, 2016-10-12 at 06:55 -0400, Frediano Ziglio wrote: > > > > > > > > > Prepare for GObject port > > > > Nacked > > > > > > > > --- > > >  server/inputs-channel.c | 68 > > >  ++--- > > >  1 file changed, 36 insertions(+), 32 deletions(-) > >

Re: [Spice-devel] [PATCH qxl-wddm-dod 1/2] Fixing black-white screen in installation when qxl revision = 3

2016-10-13 Thread Frediano Ziglio
> > When qxl revision is 3, the vga driver is the one that is running. When > installing the driver the function VgaDevice::HWInit with displayInfo > structure that is zeroed out. The displayInfo should be intialized using > DxgkCbAcquirePostDisplayOwnership and thus it should be called before > c

[Spice-devel] [PATCH qxl-wddm-dod 2/2] Call "DxgkCbAcquirePostDisplayOwnership" when changing Power State to D0

2016-10-13 Thread Sameeh Jubran
Starting with Windows Display Driver Model (WDDM) 1.2, if the DevicePowerState parameter is set to PowerDeviceD0, the display miniport driver should call DxgkCbAcquirePostDisplayOwnership to query the information about the display mode. This patch fixies this bug: https://bugzilla.redhat.com/show_

[Spice-devel] [PATCH qxl-wddm-dod 1/2] Fixing black-white screen in installation when qxl revision = 3

2016-10-13 Thread Sameeh Jubran
When qxl revision is 3, the vga driver is the one that is running. When installing the driver the function VgaDevice::HWInit with displayInfo structure that is zeroed out. The displayInfo should be intialized using DxgkCbAcquirePostDisplayOwnership and thus it should be called before calling HWInit

[Spice-devel] [PATCH qxl-wddm-dod 0/2] Fixing guest change to black-white

2016-10-13 Thread Sameeh Jubran
This patch series fixies this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1202267. Sameeh Jubran (2): Fixing black-white screen in installation when qxl revision = 3 Call "DxgkCbAcquirePostDisplayOwnership" when changing Power State to D0 qxldod/QxlDod.cpp | 73 +

Re: [Spice-devel] [PATCH 5/7] Don't increment num_clients_mig_wait twice

2016-10-13 Thread Uri Lublin
On 10/12/2016 05:19 PM, Pavel Grunt wrote: On Wed, 2016-10-12 at 10:13 -0400, Frediano Ziglio wrote: On Wed, 2016-10-12 at 06:57 -0400, Frediano Ziglio wrote: When MainChannelClient was split to a separate file, the responsibility for incrementing this field was supposed to belong to the Mai