Re: [Spice-devel] [client v3 06/10] build-sys: Remove SPICE_NO_DEPRECATED

On Thu, 27 Oct 2016, Jonathon Jongsma wrote: > On Thu, 2016-10-27 at 18:41 +0200, Francois Gouget wrote: > > Deprecation warnings no longer cause compilation errors. > > Since when?  Right. That change comes from the last patch in the series. In fact if this patch is applied alone there are

Re: [Spice-devel] [client v3 06/10] build-sys: Remove SPICE_NO_DEPRECATED

On Thu, 2016-10-27 at 18:41 +0200, Francois Gouget wrote: > Deprecation warnings no longer cause compilation errors. Since when?  > Also they should either be fixed or ignored with > G_GNUC_{BEGIN,END}_IGNORE_DEPRECATIONS. So this patch is re-enabling the deprecated functions so that we will

Re: [Spice-devel] [client v3 05/10] audio: Remove spice_audio_new() from the public header

Seems OK to me. Looks like it was deprecated in Feb 2012.  Anybody else have objections?  On Thu, 2016-10-27 at 18:41 +0200, Francois Gouget wrote: > It has been deprecated for long enough. > > Signed-off-by: Francois Gouget > --- >  src/spice-audio-priv.h | 2 ++ >  

Re: [Spice-devel] [client v3 04/10] gdk: Ignore clipboard_get()'s deprecation warnings

Acked-by: Jonathon Jongsma On Thu, 2016-10-27 at 18:41 +0200, Francois Gouget wrote: > Its implementation is modeled after gtk_dialog_run() which still uses > these deprecated thread functions. > > Signed-off-by: Francois Gouget > --- >  

Re: [Spice-devel] [client v3 03/10] gtk: Ignore GLib's too-new warnings where we explicitly check its version

Acked-by: Jonathon Jongsma On Thu, 2016-10-27 at 18:41 +0200, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- >  src/spice-gtk-session.c | 3 +++ >  src/spice-widget-egl.c  | 3 +++ >  src/spice-widget.c  | 6 ++ >  3 files

Re: [Spice-devel] [client v3 02/10] vncdisplaykeymap: Remove obsolete GTK+ 2 compatibility macros

Acked-by: Jonathon Jongsma On Thu, 2016-10-27 at 18:41 +0200, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- >  src/vncdisplaykeymap.c | 27 +-- >  1 file changed, 1 insertion(+), 26 deletions(-) > > diff --git

Re: [Spice-devel] [client v3 01/10] gtk: Remove an obsolete comment

Acked-by: Jonathon Jongsma On Thu, 2016-10-27 at 18:41 +0200, Francois Gouget wrote: > The GTK+ compatibility code has been gathered in a single file long > ago  > and support for GTK+ 2 has been dropped anyway. > > Signed-off-by: Francois Gouget >

Re: [Spice-devel] [spice] streaming: Limit the h264 image compression level

On Thu, 27 Oct 2016, Francois Gouget wrote: > When uncapped x264enc can compress the frames beyond recognition in low > bitrate situation. Beyond the set limit the gains are modest and it is > better to drop frames to reduce the bit rate further. In case anyone is interested, here is a

Re: [Spice-devel] [spice v2] streaming: Always delegate bit rate control to the video encoder

Here are some pointers on ways to test this patch. 1. Tweaking the available bandwith at will --- The point of the bit rate control algorithm is to adapt the video stream's bitrate to the available network bandwidth. So you could test how it reacts in

[Spice-devel] [PATCH] Limit maximum "n-surfaces" via param spec

In commit beec1b41, we manually limited this property value in _set_property(). But there's a simpler way to do it: via the param spec for the property. This also means that we can remove the warning log in red_worker_new() since GObject will automatically warn if a property is assigned a value

[Spice-devel] [spice] streaming: Clarify GStreamer's virtual buffer size documentation

Signed-off-by: Francois Gouget --- server/gstreamer-encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c index 6afc7e4..f9cd3ca 100644 --- a/server/gstreamer-encoder.c +++

[Spice-devel] [spice] streaming: Limit the h264 image compression level

When uncapped x264enc can compress the frames beyond recognition in low bitrate situation. Beyond the set limit the gains are modest and it is better to drop frames to reduce the bit rate further. Signed-off-by: Francois Gouget --- server/gstreamer-encoder.c | 5 -

[Spice-devel] [spice v2] streaming: Always delegate bit rate control to the video encoder

The video encoders already have sophisticated bit rate control code that can react to both stream reports sent by the client, and server frame drop notifications. Furthermore they can adjust both the frame rate and the image quality to best match the network conditions. But if the client cannot

[Spice-devel] [client v3 10/10] build-sys: Enable deprecation warnings instead of ignoring them entirely

For Spice-gtk most deprecation issues come from changes outside Spice (GLib) and thus should not be treated as errors to not break compilation for users who have newer third-party libraries. However they must be visible otherwise Spice developers will not be aware of them and thus will not fix

[Spice-devel] [client v3 07/10] build-sys: Use spice-protocol's deprecation macros

Signed-off-by: Francois Gouget --- src/spice-channel.h | 5 +++-- src/spice-util.h | 2 -- src/usb-device-manager.h | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/spice-channel.h b/src/spice-channel.h index 3b0bffb..aa0d9cb 100644

[Spice-devel] [client v3 08/10] gtk: Temporarily ignore the keyboard/mouse grabbing deprecation warnings

Signed-off-by: Francois Gouget --- src/spice-widget.c | 24 1 file changed, 24 insertions(+) diff --git a/src/spice-widget.c b/src/spice-widget.c index 82adacf..f0681d6 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -812,6 +812,9 @@

[Spice-devel] [client v3 09/10] spicy: Temporarily ignore deprecation warnings

GtkAction and lots of GtkUI APIs are deprecated. Signed-off-by: Francois Gouget --- src/spicy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/spicy.c b/src/spicy.c index c502428..c4a6c7d 100644 --- a/src/spicy.c +++ b/src/spicy.c @@ -38,6 +38,9 @@

[Spice-devel] [client v3 06/10] build-sys: Remove SPICE_NO_DEPRECATED

Deprecation warnings no longer cause compilation errors. Also they should either be fixed or ignored with G_GNUC_{BEGIN,END}_IGNORE_DEPRECATIONS. Signed-off-by: Francois Gouget --- src/Makefile.am | 1 - src/spice-util.h | 12 +++- 2 files changed, 3

[Spice-devel] [client v3 00/10] Deprecation warning cleanup

This is v3 of the following patchset: https://lists.freedesktop.org/archives/spice-devel/2016-October/032797.html Changes since v2: * Jonathon Jongsma pointed out that the 'too-new warnings' patch had an unrelated hunk. It is now the clipboard_get() patch. * And I updated the

[Spice-devel] [client v3 05/10] audio: Remove spice_audio_new() from the public header

It has been deprecated for long enough. Signed-off-by: Francois Gouget --- src/spice-audio-priv.h | 2 ++ src/spice-audio.h | 5 - src/spice-session.c| 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/spice-audio-priv.h

[Spice-devel] [client v3 02/10] vncdisplaykeymap: Remove obsolete GTK+ 2 compatibility macros

Signed-off-by: Francois Gouget --- src/vncdisplaykeymap.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/src/vncdisplaykeymap.c b/src/vncdisplaykeymap.c index c50f9f7..d0c9739 100644 --- a/src/vncdisplaykeymap.c +++

[Spice-devel] [client v3 04/10] gdk: Ignore clipboard_get()'s deprecation warnings

Its implementation is modeled after gtk_dialog_run() which still uses these deprecated thread functions. Signed-off-by: Francois Gouget --- src/spice-gtk-session.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/spice-gtk-session.c

[Spice-devel] [client v3 01/10] gtk: Remove an obsolete comment

The GTK+ compatibility code has been gathered in a single file long ago and support for GTK+ 2 has been dropped anyway. Signed-off-by: Francois Gouget --- src/spice-widget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c

Re: [Spice-devel] [PATCH spice-server v2] Remove red_pipe_add_verb family function

> > Hey, > > On Wed, Oct 26, 2016 at 09:45:15AM +0100, Frediano Ziglio wrote: > > These functions were implementing the same stuff as empty > > messages functions provided by RedChannel so reuse them. > > > > The implementation seems a bit different but the result > > is the same. Specifically:

[Spice-devel] [client v3 03/10] gtk: Ignore GLib's too-new warnings where we explicitly check its version

Signed-off-by: Francois Gouget --- src/spice-gtk-session.c | 3 +++ src/spice-widget-egl.c | 3 +++ src/spice-widget.c | 6 ++ 3 files changed, 12 insertions(+) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c index 3e0ec74..7bed005 100644 ---

Re: [Spice-devel] [PATCH spice-server v2] Remove red_pipe_add_verb family function

> > Hey, > > On Wed, Oct 26, 2016 at 09:45:15AM +0100, Frediano Ziglio wrote: > > These functions were implementing the same stuff as empty > > messages functions provided by RedChannel so reuse them. > > > > The implementation seems a bit different but the result > > is the same. Specifically:

Re: [Spice-devel] [PATCH spice-server v2] Remove red_pipe_add_verb family function

Hey, On Wed, Oct 26, 2016 at 09:45:15AM +0100, Frediano Ziglio wrote: > These functions were implementing the same stuff as empty > messages functions provided by RedChannel so reuse them. > > The implementation seems a bit different but the result > is the same. Specifically: > -

Re: [Spice-devel] [PATCH spice-server] Fix typo in comment

On Thu, Oct 27, 2016 at 03:50:36PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/red-channel.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red-channel.h b/server/red-channel.h > index 89aab8d..c136355 100644

Re: [Spice-devel] [spice-server 9/9] syntax-check: Add missing license headers

> > --- > server/tests/stream-test.c | 17 + > server/tests/test-qxl-parsing.c | 18 ++ > 2 files changed, 35 insertions(+) > > diff --git a/server/tests/stream-test.c b/server/tests/stream-test.c > index 9c43d74..8a34a0d 100644 > ---

[Spice-devel] [PATCH spice-server] Fix typo in comment

Signed-off-by: Frediano Ziglio --- server/red-channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-channel.h b/server/red-channel.h index 89aab8d..c136355 100644 --- a/server/red-channel.h +++ b/server/red-channel.h @@ -359,7 +359,7 @@

Re: [Spice-devel] [spice-server 8/9] syntax-check: Remove unused header includes

> > --- > server/tests/test-loop.c| 1 - > server/tests/test-qxl-parsing.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/server/tests/test-loop.c b/server/tests/test-loop.c > index 0bcc953..c8d3fb1 100644 > --- a/server/tests/test-loop.c > +++ b/server/tests/test-loop.c > @@

Re: [Spice-devel] [spice-server 7/9] syntax-check: Add missing includes

> > --- > server/event-loop.c | 3 +++ > server/tests/stream-test.c | 4 > server/tests/test-qxl-parsing.c | 3 +++ > 3 files changed, 10 insertions(+) > > diff --git a/server/event-loop.c b/server/event-loop.c > index 1b57460..80add0b 100644 > --- a/server/event-loop.c >

Re: [Spice-devel] [spice-server 6/9] syntax-check: Remove trailing whitespace from EOL and EOF

> > --- > server/common-graphics-channel.c | 1 - > server/cursor-channel.h | 2 +- > server/inputs-channel.c | 2 +- > server/red-channel.c | 2 +- > server/smartcard-channel-client.c | 1 - > 5 files changed, 3 insertions(+), 5 deletions(-) > > diff --git

Re: [Spice-devel] [spice-server 3/9] syntax-check: Add missing contributors names to AUTHORS

> --- > AUTHORS | 4 > 1 file changed, 4 insertions(+) > > diff --git a/AUTHORS b/AUTHORS > index e1a1a87..2b0fe24 100644 > --- a/AUTHORS > +++ b/AUTHORS > @@ -35,6 +35,7 @@ Patches also contributed by > David Gibson > David Jaša >

Re: [Spice-devel] [spice-server 1/9] syntax-check: Add missing license

> > --- > server/dummy-channel.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/server/dummy-channel.c b/server/dummy-channel.c > index c43221b..be1982b 100644 > --- a/server/dummy-channel.c > +++ b/server/dummy-channel.c > @@ -1,4 +1,19 @@ > -/*

Re: [Spice-devel] QXL-WDDM-DOD v0.4-1 released

Il 27/10/2016 12:03, Christophe Fergeau ha scritto: > On Thu, Oct 27, 2016 at 10:40:47AM +0200, Fabio Fantoni wrote: >> Is there any vdagent testing build with all newer patches available >> somewhere? > https://copr.fedorainfracloud.org/coprs/teuf/spice-mingw/build/470179/ > has a totally

Re: [Spice-devel] [spice-server 4/9] syntax-check: Remove unneeded cast of free() argument

On Thu, Oct 27, 2016 at 04:20:11PM +0200, Pavel Grunt wrote: > mjpeg-encoder.c: In function 'mjpeg_encoder_encode_frame': > mjpeg-encoder.c:972:27: error: passing argument 1 of 'buffer- > >base.free' from incompatible pointer type [-Werror=incompatible- > pointer-types] >  

Re: [Spice-devel] [spice-common v1] Fix gitignore with new docs folder

Hi, On Tue, Oct 25, 2016 at 07:09:10PM +0200, Christophe Fergeau wrote: > On Thu, Oct 20, 2016 at 04:08:27PM +0200, Victor Toso wrote: > > From: Victor Toso > > > > The generated spice_protocol.html file and the Makefile were not > > included in gitignore. This patch fixes

Re: [Spice-devel] [spice-common v1] Fix gitignore with new docs folder

On Thu, Oct 27, 2016 at 04:26:28PM +0200, Victor Toso wrote: > > > > and the patch below seems to fix it too: > > > > diff --git a/docs/Makefile.am b/docs/Makefile.am > > index 0b09b82..3f98680 100644 > > --- a/docs/Makefile.am > > +++ b/docs/Makefile.am > > @@ -13,5 +13,6 @@ spice_protocol.html:

Re: [Spice-devel] [PATCH spice-server] Make reds_stat utility work with both 32 and 64 bit architectures.

On Wed, 2016-10-26 at 16:06 +0100, Frediano Ziglio wrote: > Due to alignment problems the structure of statistics file is > different between 32 and 64 bit. This as on 32 bit uint64_t is > aligned to 4 bytes instead of 8 so sizeof(SpiceStat) can be either > 20 (32 bit) or 24 (64 bit). > This cause

Re: [Spice-devel] [spice-server 2/9] syntax-check: Change tabs to spaces

On Thu, Oct 27, 2016 at 10:18:19AM -0400, Frediano Ziglio wrote: > > > > --- > > server/glib-compat.h | 18 +- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/server/glib-compat.h b/server/glib-compat.h > > index a20a434..4d4ca43 100644 > > ---

Re: [Spice-devel] [spice-server 4/9] syntax-check: Remove unneeded cast of free() argument

mjpeg-encoder.c: In function 'mjpeg_encoder_encode_frame': mjpeg-encoder.c:972:27: error: passing argument 1 of 'buffer- >base.free' from incompatible pointer type [-Werror=incompatible- pointer-types]  buffer->base.free(buffer); Declaration of the free function is: static void

Re: [Spice-devel] [spice-server 2/9] syntax-check: Change tabs to spaces

> > --- > server/glib-compat.h | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/server/glib-compat.h b/server/glib-compat.h > index a20a434..4d4ca43 100644 > --- a/server/glib-compat.h > +++ b/server/glib-compat.h > @@ -24,9 +24,9 @@ > static inline

[Spice-devel] [spice-server 1/9] syntax-check: Add missing license

--- server/dummy-channel.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/server/dummy-channel.c b/server/dummy-channel.c index c43221b..be1982b 100644 --- a/server/dummy-channel.c +++ b/server/dummy-channel.c @@ -1,4 +1,19 @@ -/* dummy-channel.c */ +/* +

[Spice-devel] [spice-server 8/9] syntax-check: Remove unused header includes

--- server/tests/test-loop.c| 1 - server/tests/test-qxl-parsing.c | 1 - 2 files changed, 2 deletions(-) diff --git a/server/tests/test-loop.c b/server/tests/test-loop.c index 0bcc953..c8d3fb1 100644 --- a/server/tests/test-loop.c +++ b/server/tests/test-loop.c @@ -24,7 +24,6 @@

[Spice-devel] [spice-server 5/9] syntax-check: Add exception for server/stat.h

Due to the use of static inline functions, the headers uses G_GNUC_UNUSED, which the sc_avoid_attribute_unused_in_header test complains about. --- cfg.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cfg.mk b/cfg.mk index 8809df0..3e5d345 100644 --- a/cfg.mk +++ b/cfg.mk @@ -145,3 +145,5

[Spice-devel] [spice-server 2/9] syntax-check: Change tabs to spaces

--- server/glib-compat.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/server/glib-compat.h b/server/glib-compat.h index a20a434..4d4ca43 100644 --- a/server/glib-compat.h +++ b/server/glib-compat.h @@ -24,9 +24,9 @@ static inline void

[Spice-devel] [spice-server 9/9] syntax-check: Add missing license headers

--- server/tests/stream-test.c | 17 + server/tests/test-qxl-parsing.c | 18 ++ 2 files changed, 35 insertions(+) diff --git a/server/tests/stream-test.c b/server/tests/stream-test.c index 9c43d74..8a34a0d 100644 --- a/server/tests/stream-test.c +++

[Spice-devel] [spice-server 4/9] syntax-check: Remove unneeded cast of free() argument

--- server/mjpeg-encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c index d95c645..2e22edf 100644 --- a/server/mjpeg-encoder.c +++ b/server/mjpeg-encoder.c @@ -969,7 +969,7 @@ static int

[Spice-devel] [spice-server 0/9] syntax-check: Fix various make syntax-check issues

Hey, I noticed a few trailing white spaces in master, so decided to try to run make syntax-check and then fixed the issues it reported. There is still one issue remaining with server/Makefile.am which uses @ @ variables, but I did not look closer if this could be fixed. Christophe

[Spice-devel] [spice-server 7/9] syntax-check: Add missing includes

--- server/event-loop.c | 3 +++ server/tests/stream-test.c | 4 server/tests/test-qxl-parsing.c | 3 +++ 3 files changed, 10 insertions(+) diff --git a/server/event-loop.c b/server/event-loop.c index 1b57460..80add0b 100644 --- a/server/event-loop.c +++

[Spice-devel] [spice-server 6/9] syntax-check: Remove trailing whitespace from EOL and EOF

--- server/common-graphics-channel.c | 1 - server/cursor-channel.h | 2 +- server/inputs-channel.c | 2 +- server/red-channel.c | 2 +- server/smartcard-channel-client.c | 1 - 5 files changed, 3 insertions(+), 5 deletions(-) diff --git

[Spice-devel] [spice-server 3/9] syntax-check: Add missing contributors names to AUTHORS

--- AUTHORS | 4 1 file changed, 4 insertions(+) diff --git a/AUTHORS b/AUTHORS index e1a1a87..2b0fe24 100644 --- a/AUTHORS +++ b/AUTHORS @@ -35,6 +35,7 @@ Patches also contributed by David Gibson David Jaša Dunrong Huang

Re: [Spice-devel] [PATCH spice 2/2] Do not enable statistic by default

Hi, On Thu, Oct 27, 2016 at 08:58:04AM +0200, Pavel Grunt wrote: > On Wed, 2016-10-26 at 10:56 -0400, Frediano Ziglio wrote: > > > > > > --- > > >  server/Makefile.am | 1 - > > >  1 file changed, 1 deletion(-) > > > > > > diff --git a/server/Makefile.am b/server/Makefile.am > > > index

Re: [Spice-devel] [PATCH 1/4] Re-arrange channel client creation to avoid exposing client lock

> **FIXME: introduces crash when session vdagent connects > > Instead of requiring the channel client to lock the client's lock, > re-arrange things so that all of the locking can be internal to > RedClient methods. So instead of having a pre-create validate function, > we simply move the check

Re: [Spice-devel] [PATCH spice 2/2] Do not enable statistic by default

On Thu, 2016-10-27 at 05:56 -0400, Frediano Ziglio wrote: > > > > On Wed, 2016-10-26 at 10:56 -0400, Frediano Ziglio wrote: > > > > > > > > --- > > > >  server/Makefile.am | 1 - > > > >  1 file changed, 1 deletion(-) > > > > > > > > diff --git a/server/Makefile.am b/server/Makefile.am > > > >

Re: [Spice-devel] [PATCH spice 1/2] Allow to compile without RED_STATISTICS

> > On Wed, 2016-10-26 at 10:54 -0400, Frediano Ziglio wrote: > > Looks like we are working on similar stuff! > > > > > > > > > > --- > > >  server/dcc-send.c| 2 +- > > >  server/main-channel-client.c | 2 +- > > >  server/red-channel.c | 6 ++ > > >  3 files changed, 4

Re: [Spice-devel] QXL-WDDM-DOD v0.4-1 released

On Thu, Oct 27, 2016 at 10:40:47AM +0200, Fabio Fantoni wrote: > Is there any vdagent testing build with all newer patches available > somewhere? https://copr.fedorainfracloud.org/coprs/teuf/spice-mingw/build/470179/ has a totally untested build of a snapshot of

Re: [Spice-devel] [PATCH spice-server] Fix handle-acks regression

> > Good catch! Wondering if this could be done in > common_graphics_channel_init() maybe, but probably more explicit the way > you did it. > > Christophe > I think is more flexible this way and more similar to the way is set on the other objects. Frediano > On Wed, Oct 26, 2016 at

Re: [Spice-devel] [PATCH spice 2/2] Do not enable statistic by default

> > On Wed, 2016-10-26 at 10:56 -0400, Frediano Ziglio wrote: > > > > > > --- > > >  server/Makefile.am | 1 - > > >  1 file changed, 1 deletion(-) > > > > > > diff --git a/server/Makefile.am b/server/Makefile.am > > > index 2a6010b..0514a2c 100644 > > > --- a/server/Makefile.am > > > +++

Re: [Spice-devel] [PATCH spice-server] Fix core-interface type regression

> > On Wed, Oct 26, 2016 at 10:08:09AM +0100, Frediano Ziglio wrote: > > This was introduced with 96e94c6f32d4345ea25ef7a474fbd92de03b38ad > > (Convert RedChannel hierarchy to GObject). > > The type for "core-interface" property should be > > SpiceCoreInterfaceInternal, not SpiceCoreInterface. >

Re: [Spice-devel] [PATCH spice-server] Remove g_smartcard_channel global

> > On Thu, Oct 27, 2016 at 05:21:03AM -0400, Frediano Ziglio wrote: > > > > > > I think I would have just switched this to a static variable, possibly a > > > GOnce if you are worried about thread-safety. > > > > > > Acked-by: Christophe Fergeau > > > > > > Christophe >

Re: [Spice-devel] [PATCH spice-server] Remove g_smartcard_channel global

On Thu, Oct 27, 2016 at 05:21:03AM -0400, Frediano Ziglio wrote: > > > > I think I would have just switched this to a static variable, possibly a > > GOnce if you are worried about thread-safety. > > > > Acked-by: Christophe Fergeau > > > > Christophe > > > > This won't

Re: [Spice-devel] [PATCH spice-server] Remove g_smartcard_channel global

> > I think I would have just switched this to a static variable, possibly a > GOnce if you are worried about thread-safety. > > Acked-by: Christophe Fergeau > > Christophe > This won't solve having 2 spice server instances on the same executable. Frediano > On Wed,

Re: [Spice-devel] [PATCH spice-server] Fix core-interface type regression

On Wed, Oct 26, 2016 at 10:08:09AM +0100, Frediano Ziglio wrote: > This was introduced with 96e94c6f32d4345ea25ef7a474fbd92de03b38ad > (Convert RedChannel hierarchy to GObject). > The type for "core-interface" property should be > SpiceCoreInterfaceInternal, not SpiceCoreInterface. > >

Re: [Spice-devel] [PATCH spice-server] Remove g_smartcard_channel global

I think I would have just switched this to a static variable, possibly a GOnce if you are worried about thread-safety. Acked-by: Christophe Fergeau Christophe On Wed, Oct 26, 2016 at 10:29:42AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH spice-server] Fix handle-acks regression

Good catch! Wondering if this could be done in common_graphics_channel_init() maybe, but probably more explicit the way you did it. Christophe On Wed, Oct 26, 2016 at 08:46:41AM +0100, Frediano Ziglio wrote: > This was introduced with 96e94c6f32d4345ea25ef7a474fbd92de03b38ad > (Convert

Re: [Spice-devel] QXL-WDDM-DOD v0.4-1 released

On Thu, Oct 27, 2016 at 09:55:23AM +0300, Dmitry Fleytman wrote: > According to earlier discussions on the list the best way is to indicate > mouse mode to driver via device interface. If this is the patches I have in mind, my latest question why was this needed at all for the wddm driver while

Re: [Spice-devel] [PATCH spice-server v2] Move capability initialisation into channel creation

On Wed, Oct 26, 2016 at 08:38:26AM +0100, Frediano Ziglio wrote: > No reason why RedWorker should know the capabilities of > DisplayChannel. > > Signed-off-by: Frediano Ziglio > --- > server/display-channel.c | 6 +- > server/red-worker.c | 3 --- > 2 files changed,

[Spice-devel] [PATCH spice-server v8 09/12] fixup! Convert RedChannel hierarchy to GObject

Reuse new macro to scan GLists (not available when this patch was originally written). Signed-off-by: Frediano Ziglio --- server/reds.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/server/reds.c b/server/reds.c index 186c2e1..de0d356

Re: [Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

Aside from the comment about potentially splitting patch 11/12, all of the fixups look good to me. However, I seem to be missing patches 5/12, 9/12, and 12/12. Did they get sent? Jonathon On Mon, 2016-10-24 at 09:40 +0100, Frediano Ziglio wrote: > Some different fixup with updates and small

[Spice-devel] [PATCH spice-server v8 05/12] fixup! Convert RedChannel hierarchy to GObject

Removed unused RedSmartcardChannelPrivate structure. Signed-off-by: Frediano Ziglio --- server/smartcard.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index 6974cb1..655eaf7 100644 --- a/server/smartcard.c +++

[Spice-devel] [PATCH spice-server v8 12/12] fixup! Convert RedChannel hierarchy to GObject

Removed unused functions. All these function where introduced by the patch without being used. Signed-off-by: Frediano Ziglio --- server/red-channel.c | 24 server/red-channel.h | 5 - 2 files changed, 29 deletions(-) diff --git

Re: [Spice-devel] [spice-protocol v1 3/4] enums: Move auto generated SpiceDataCompressionType

> > From: Victor Toso > > This header is auto generated from spice_codegen.py tool in > spice-common repository and thus, it changes what was included > manually. > > Move SpiceDataCompressionType struct to comply with spice_codegen.py. > This header was generated with: >

Re: [Spice-devel] [PATCH spice-server] Avoid client to set too much surfaces

wording suggestion: "display channel: don't let client set too many surfaces Limit the n_surfaces argument to avoid overflowing the surfaces array" I suppose it could also be an assert instead, but this works as well. I notice that red_worker_new() does have the following line:    

Re: [Spice-devel] QXL-WDDM-DOD v0.4-1 released

Il 26/10/2016 17:31, Frediano Ziglio ha scritto: >> Il 25/10/2016 16:16, Dmitry Fleytman ha scritto: >>> Hi All, >>> >>> We are glad to notify you that the first official version of QXL-WDDM-DOD >>> driver with Windows 10 support has been released. >>> >>> This version was built from tag v0.4-1

Re: [Spice-devel] [PATCH spice 2/2] Do not enable statistic by default

On Wed, 2016-10-26 at 10:56 -0400, Frediano Ziglio wrote: > > > > --- > >  server/Makefile.am | 1 - > >  1 file changed, 1 deletion(-) > > > > diff --git a/server/Makefile.am b/server/Makefile.am > > index 2a6010b..0514a2c 100644 > > --- a/server/Makefile.am > > +++ b/server/Makefile.am > > @@

Re: [Spice-devel] QXL-WDDM-DOD v0.4-1 released

Hi Christophe, > On 26 Oct 2016, at 19:17 PM, Christophe Fergeau wrote: > > Hey Sameeh, > > On Wed, Oct 26, 2016 at 06:37:12PM +0300, Sameeh Jubran wrote: >> And as Frediano mentioned this could be an issue with the mouse as there >> was set of patches that weren't

Re: [Spice-devel] [PATCH spice 1/2] Allow to compile without RED_STATISTICS

On Wed, 2016-10-26 at 10:54 -0400, Frediano Ziglio wrote: > Looks like we are working on similar stuff! > > > > > --- > >  server/dcc-send.c| 2 +- > >  server/main-channel-client.c | 2 +- > >  server/red-channel.c | 6 ++ > >  3 files changed, 4 insertions(+), 6