>> Looks like you still have the original patch in Fedora ;)
>
> Yes, because it fixes the build. Xspice is not widely used,
> so no-one has noticed it is broken yet...
I've noticed, but I don't have an urgent need for server 1.19 just yet.
Cheers,
Jeremy
___
On Wed, 16 Nov 2016, Frediano Ziglio wrote:
[...]
> Took me some time to test but the patch works as expected and
> video is smoother. Strangely seems that MJPEG works better than
> other encoders (beside taking more bandwidth).
Being curious I have to ask: how so?
(but I'll acknowledge that it ca
On Wed, 16 Nov 2016, Frediano Ziglio wrote:
[...]
> I don't know how much information can give the upper bound.
When the available bandwidth drops suddenly (e.g. degraded wifi / 3G
connection or multiple competing network streams starting) it can take
quite a few iterations before the video stre
>
> >
> > Windows disables hw pointer acceleration and draws the cursor
> > in frame buffer if the driver does not report pointer capabilities
> > in QueryAdapterInfo. In this mode OS usually does not send pointer
> > commands to the driver or does it with pointer set to invisible
> > state. This
From: Javier Celaya
This avoid having possibly 2 pointers (client and server) if Windows
decide to render the mouse by itself.
This happens for instance moving windows.
---
qxldod/QxlDod.cpp | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
Javier, as we changed license since you cre
Hey Christophe,
> I don't know what others think, so just let me know how you feel about
> that.
I'm a huge fan!
I've just run an Xspice smoke test on Debian and make check and a basic
Xspice test looked clean.
I hit one tiny hitch; the lz4-dev library on Debian is r122, too old to
support the
Hey,
On Fri, Nov 18, 2016 at 11:49:11AM +0300, Ilya wrote:
> For example: I have one host with qemu-kvm hypervisor installation
> under Openstack (test environment) project. I have installed that
> packages: virt-viwer, spice-xpi, spice-protocol, spice-server and I
> could't realise have I loaded
>
> Windows disables hw pointer acceleration and draws the cursor
> in frame buffer if the driver does not report pointer capabilities
> in QueryAdapterInfo. In this mode OS usually does not send pointer
> commands to the driver or does it with pointer set to invisible
> state. This mode of operat
Windows disables hw pointer acceleration and draws the cursor
in frame buffer if the driver does not report pointer capabilities
in QueryAdapterInfo. In this mode OS usually does not send pointer
commands to the driver or does it with pointer set to invisible
state. This mode of operation consumes
Hi,
On 18-11-16 14:04, Timo Aaltonen wrote:
On 04.10.2016 14:41, Hans de Goede wrote:
Hi,
On 03-10-16 12:04, Christophe Fergeau wrote:
On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote:
Signed-off-by: Hans de Goede
---
src/spiceqxl_main_loop.c | 4
1 file changed, 4 inse
On Fri, Nov 18, 2016 at 9:49 AM, Ilya wrote:
>
> For example: I have one host with qemu-kvm hypervisor installation under
> Openstack (test environment) project. I have installed that packages:
> virt-viwer, spice-xpi, spice-protocol, spice-server and I could't realise
> have I loaded and functio
>
> strncpy is considered unsafe
> ---
> cfg.mk| 1 -
> server/reds.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/cfg.mk b/cfg.mk
> index 66235ee..3e5d345 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -42,7 +42,6 @@ local-checks-to-skip = \
>
> strncpy used in reds_init_socket() has destination NUL terminated
> ---
> An alternative would be to use g_strlcpy
> ---
> cfg.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/cfg.mk b/cfg.mk
> index 3e5d345..66235ee 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -42,6 +42,7 @@ local-c
strncpy is considered unsafe
---
cfg.mk| 1 -
server/reds.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index 66235ee..3e5d345 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -42,7 +42,6 @@ local-checks-to-skip =\
sc_prohibit_stat_st
Yes, of course I have several times read this page:
https://www.spice-space.org/spice-user-manual.html and in my opinion this page
content have very huge amount of unusual information that don't needed in
installation process and nothing about troubleshooting.
For example: I have one host wit
>
> On Fri, 2016-11-18 at 13:11 +0100, Christophe Fergeau wrote:
> > On Fri, Nov 18, 2016 at 07:03:52AM -0500, Frediano Ziglio wrote:
> > > Acked-by: Frediano Ziglio
> > >
> > > I don't think this should cause test problem but I'll wait
> > > Christophe
> > > before merging it.
> >
> > Yep, sur
On Fri, 2016-11-18 at 13:11 +0100, Christophe Fergeau wrote:
> On Fri, Nov 18, 2016 at 07:03:52AM -0500, Frediano Ziglio wrote:
> > Acked-by: Frediano Ziglio
> >
> > I don't think this should cause test problem but I'll wait
> > Christophe
> > before merging it.
>
> Yep, sure, I only objected to
On Fri, Nov 18, 2016 at 07:03:52AM -0500, Frediano Ziglio wrote:
> Acked-by: Frediano Ziglio
>
> I don't think this should cause test problem but I'll wait Christophe
> before merging it.
Yep, sure, I only objected to the one which seemed more problematic.
Christophe
signature.asc
Description
>
> Fix make check, otherwise it fails on
>GEN public-submodule-commit
> Stopping at 'spice-common'; script returned non-zero status.
> maint.mk: found non-public submodule commit
> ---
> GNUmakefile | 25 ++-
> maint.mk| 555
> ++--
>
> ---
> server/red-qxl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/red-qxl.h b/server/red-qxl.h
> index 00c5486..0ff2475 100644
> --- a/server/red-qxl.h
> +++ b/server/red-qxl.h
> @@ -47,7 +47,7 @@ int red_qxl_check_qxl_version(QXLInstance *qxl, int major,
On Fri, 2016-11-18 at 11:58 +0100, Christophe Fergeau wrote:
> On Fri, Nov 18, 2016 at 11:45:40AM +0100, Pavel Grunt wrote:
> > strncpy used in reds_init_socket() has destination NUL terminated
> > ---
> > An alternative would be to use g_strlcpy
>
> I'd prefer to switch to g_strlcpy and that we p
On Fri, Nov 18, 2016 at 11:45:40AM +0100, Pavel Grunt wrote:
> strncpy used in reds_init_socket() has destination NUL terminated
> ---
> An alternative would be to use g_strlcpy
I'd prefer to switch to g_strlcpy and that we prohibit strncpy. But I'd
prefer not to do that before a release :)
Chris
strncpy used in reds_init_socket() has destination NUL terminated
---
An alternative would be to use g_strlcpy
---
cfg.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/cfg.mk b/cfg.mk
index 3e5d345..66235ee 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -42,6 +42,7 @@ local-checks-to-skip =
---
server/red-qxl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-qxl.h b/server/red-qxl.h
index 00c5486..0ff2475 100644
--- a/server/red-qxl.h
+++ b/server/red-qxl.h
@@ -47,7 +47,7 @@ int red_qxl_check_qxl_version(QXLInstance *qxl, int major,
int minor);
SpiceS
Fix make check, otherwise it fails on
GEN public-submodule-commit
Stopping at 'spice-common'; script returned non-zero status.
maint.mk: found non-public submodule commit
---
GNUmakefile | 25 ++-
maint.mk| 555 ++--
2 files ch
Looks good to me
On Fri, 2016-11-18 at 09:38 +, Frediano Ziglio wrote:
> This leaks happen for every connection. Potentially the timer can
> be called after the client is closed causing an use after free.
> Recently RED_STATISTICS was switched off by default but previous
> version have this is
On Fri, 2016-11-18 at 09:38 +, Frediano Ziglio wrote:
> self->priv was deleted and then used
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/display-channel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/display-channel.c b/server/
This leaks happen for every connection. Potentially the timer can
be called after the client is closed causing an use after free.
Recently RED_STATISTICS was switched off by default but previous
version have this issue.
Signed-off-by: Frediano Ziglio
---
server/main-channel-client.c | 15 +++
self->priv was deleted and then used
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 46191b0..52f0a3d 100644
--- a/server/display-channel.c
+++ b/server/displ
29 matches
Mail list logo
