Re: [Spice-devel] [spice] server: Disable deprecation warnings only where needed

2016-11-22 Thread Christophe Fergeau
On Wed, Nov 23, 2016 at 06:48:22AM +0100, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > server/red-qxl.c| 2 ++ > server/red-replay-qxl.c | 10 ++ > server/reds-stream.c| 2 ++ > server/spice-core.h | 4 > 4 files changed, 14 insertions(+), 4 dele

[Spice-devel] [client v2 3/3] build-sys: Enable deprecation warnings instead of ignoring them entirely

2016-11-22 Thread Francois Gouget
For Spice-gtk most deprecation issues come from changes outside Spice (GLib) and thus should not be treated as errors to not break compilation for users who have newer third-party libraries. However they must be visible otherwise Spice developers will not be aware of them and thus will not fix them

[Spice-devel] [client v2 2/3] spicy: Temporarily ignore deprecation warnings

2016-11-22 Thread Francois Gouget
GtkAction and lots of GtkUI APIs are deprecated. Signed-off-by: Francois Gouget --- src/spicy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/spicy.c b/src/spicy.c index c502428..c4a6c7d 100644 --- a/src/spicy.c +++ b/src/spicy.c @@ -38,6 +38,9 @@ #include "spicy-connect.h" +/*

[Spice-devel] [client v2 1/3] gtk: Temporarily ignore the keyboard/mouse grabbing deprecation warnings

2016-11-22 Thread Francois Gouget
Signed-off-by: Francois Gouget --- src/spice-widget.c | 24 1 file changed, 24 insertions(+) diff --git a/src/spice-widget.c b/src/spice-widget.c index 82adacf..f0681d6 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -812,6 +812,9 @@ SpiceGrabSequence *spice_

[Spice-devel] [client v2 0/3] Deprecation warning cleanup

2016-11-22 Thread Francois Gouget
I know the first two patches are really just sweeping issues under the rug but I really thing they should still get in: * As long as the policy is that spice-gtk must compile without warnings then they are needed for the third patch which reenables deprecation warnings. * So really th

[Spice-devel] [spice] server: Disable deprecation warnings only where needed

2016-11-22 Thread Francois Gouget
Signed-off-by: Francois Gouget --- server/red-qxl.c| 2 ++ server/red-replay-qxl.c | 10 ++ server/reds-stream.c| 2 ++ server/spice-core.h | 4 4 files changed, 14 insertions(+), 4 deletions(-) diff --git a/server/red-qxl.c b/server/red-qxl.c index 19cff95..2ca25

Re: [Spice-devel] [PATCH spice-server 10/30] Move RedsWebSocket to header

2016-11-22 Thread Jeremy White
Hi Frediano, Thanks for the review, and all the hard work to tighten the code. I've reviewed all 30 patches, and have done a quick dry run test, and it still seems to work for my use case - thanks! I have to confess I didn't have the time for as detailed a review as perhaps it calls for; the PIN

[Spice-devel] [spice v6 3/3] streaming: Stop streaming if the client reports a streaming error

2016-11-22 Thread Francois Gouget
By removing the stream's video encoder we force the stream to send future frames using the fallback code, that is as regular screen updates. However note that we keep the stream object: we have to. Otherwise future frames would trigger the creation of a new stream object with a new video encoder wh

[Spice-devel] [client v6 1/3] streaming: Report invalid streams to the server

2016-11-22 Thread Francois Gouget
The error is sent using the existing client stream report message where the dropped frame count is maxed out while the received frame count is zero. Servers that recognize it can then switch to sending regular screen updates for that area so the client is not stuck with a frozen area on the screen.

[Spice-devel] [client v6 2/3] streaming: Stop streaming if frames cannot be decoded

2016-11-22 Thread Francois Gouget
Report the stream as invalid if the frames cannot be decoded. This will force the server to send regular screen updates instead. Signed-off-by: Francois Gouget --- Uses report_invalid_stream() now. src/channel-display-gst.c | 41 - src/channel-display-

[Spice-devel] [PATCH qxl-wddm-dod 2/2] Fix default mode pitch

2016-11-22 Thread Frediano Ziglio
From: Javier Celaya Signed-off-by: Javier Celaya --- qxldod/QxlDod.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 7bd2ead..68e3383 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -4792,7 +4792,7 @@ NTSTATUS HwDevice

[Spice-devel] [PATCH qxl-wddm-dod 1/2] Remove unused code

2016-11-22 Thread Frediano Ziglio
From: Javier Celaya Signed-off-by: Javier Celaya --- qxldod/QxlDod.cpp | 51 --- qxldod/QxlDod.h | 3 --- 2 files changed, 54 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 8f31714..7bd2ead 100755 --- a/qxldod/QxlDod.cpp

[Spice-devel] [PATCH qxl-wddm-dod v2] Send HIDE command when pointer is not visible

2016-11-22 Thread Frediano Ziglio
From: Javier Celaya This avoids having 2 pointers (client and server) if Windows decides to render the mouse by itself. This happens, for instance, when moving windows around. Signed-off-by: Javier Celaya Acked-by: Frediano Ziglio --- qxldod/QxlDod.cpp | 7 +-- 1 file changed, 1 insertion

Re: [Spice-devel] Question about SPICE-server

2016-11-22 Thread Ilya
Hello everyone! Thanks for answer, now I understand about these ports. But I have an additional question about them: are these ports fixed for every VM or they are all floating and do not relate to VM? For example: if I have two VMs on my hypervisor and I want to start one of VM which port wil