[Spice-devel] spice-gtk 0.33 issue

2016-12-08 Thread InQ-AllenKao
Hi, I was connected to remote desktop from client to guest with dual-screen mode by spice-gtk 0.33, but there are two strange issue: 1. Cannot change between full-screen-mode and window-mode by hot-key(shift-F11), which means that it can turns full-screen-mode from window-mode, but cannot

Re: [Spice-devel] I am a China java development engineer, i had achinese keyboard qusetion need to be solved

2016-12-08 Thread 史建超
yes, i am trying to connect to a virtual machine using Spice with an Android pad client(like apple pad,but it is Android system,not ios). when i input in chinese with Android pad,i must used Android system original keyboard,but spice and qemu-kvm can't handle chinese characters ,so the system

[Spice-devel] [spice v1 1/3] reds: don't replace video_codecs on failure

2016-12-08 Thread Victor Toso
From: Victor Toso We should replace the video_codecs GArray only after the parsing of input is done, otherwise we might lose previous configuration. Tests were updated to match this situation. Input that fails to replace video_codecs are considerer bad. Signed-off-by: Victor Toso --- server/r

[Spice-devel] [spice v1 3/3] reds: drop sscanf() in favour of g_strsplit()

2016-12-08 Thread Victor Toso
From: Victor Toso In case of errors in sscanf(), we were returning (codecs + n) being n an initialized integer. While working on extending the codecs string, this seems a bit risky although I did not find any real example that could trigger that path. Signed-off-by: Victor Toso --- server/red

[Spice-devel] [spice v1 2/3] reds: set the video_codecs in a separated function

2016-12-08 Thread Victor Toso
From: Victor Toso Small refactor. As reds_get_video_codecs() returns the video codecs as GArray, we should match reds_set_video_codecs() to have a GArray as parameter instead of string. reds_set_video_codecs_from_string() seems more appropriate for the previous function. Signed-off-by: Victor T

Re: [Spice-devel] [RFC spice-common] ci: Automatically test integration with spice-common users

2016-12-08 Thread Frediano Ziglio
> > Add .gitlab-ci.yml to check if the latest spice-gtk and spice server > are compatible with latest spice-common changes. > --- > Hi, > > recent changes in spice-common made me come up with this patch for checking > integration of spice-common submodule with its users (spice-gtk, spice > server

[Spice-devel] [PATCH spice-server] Sort include order in source files

2016-12-08 Thread Frediano Ziglio
Sort based on coding style. Signed-off-by: Frediano Ziglio --- server/inputs-channel.c | 2 +- server/jpeg-encoder.c | 4 +++- server/mjpeg-encoder.c | 8 +--- server/reds-stream.c| 13 +++-- server/spicevmc.c | 6 +++--- server/tree.c | 2 +- server/zlib-

Re: [Spice-devel] [PATCH spice-gtk] Adjust to spice_marshaller_add_ref rename

2016-12-08 Thread Victor Toso
Hi, On Thu, Dec 08, 2016 at 05:45:05PM +0100, Pavel Grunt wrote: > It was renamed in the spice-common submodule > > Submodule update contains following changes: > > Francois Gouget (1): > codegen: Fix compatibility with Python 2.6 > > Frediano Ziglio (9): > Start adding protocol file d

[Spice-devel] QXL-WDDM-DOD 0.15 has been released

2016-12-08 Thread Yuri Benditovich
Hi All, QXL-WDDM-DOD 0.15 has been released. Please read Changelog for details. The latest QXL-WDDM-DOD source code available at: https://gitlab.com/spice/qxl-wddm-dod Source tarball for this version: https://www.spice-space.org/download/windows/qxl-wddm-dod/qxl-wddm-dod-0.15/qxlwddm-0.15-0-sou

[Spice-devel] [PATCH spice-gtk] Adjust to spice_marshaller_add_ref rename

2016-12-08 Thread Pavel Grunt
It was renamed in the spice-common submodule Submodule update contains following changes: Francois Gouget (1): codegen: Fix compatibility with Python 2.6 Frediano Ziglio (9): Start adding protocol file documentation Start writing some documentation on protocol Extended pr

[Spice-devel] [RFC spice-common] ci: Automatically test integration with spice-common users

2016-12-08 Thread Pavel Grunt
Add .gitlab-ci.yml to check if the latest spice-gtk and spice server are compatible with latest spice-common changes. --- Hi, recent changes in spice-common made me come up with this patch for checking integration of spice-common submodule with its users (spice-gtk, spice server). This commit add

[Spice-devel] [PATCH v2 0/2] RHEL7 improvements

2016-12-08 Thread Frediano Ziglio
These 2 patches attempt to join images split by RHEL7 graphic stack (Mesa) decreasing commands handled by spice-server. You can see the difference between the 2 video: - https://www.youtube.com/watch?v=OarV6zUmUdg (before) - https://www.youtube.com/watch?v=5fTdCCbFeCg (after) These video are reali

[Spice-devel] [PATCH v2 2/2] display-channel: Handle timeout for joining drawables

2016-12-08 Thread Frediano Ziglio
The previous patch join correctly the commands however if there are no more commands the command joined is delayed till new commands arrive. This patch introduce a timeout (currently 10 ms) after the command is executed. Signed-off-by: Frediano Ziglio --- server/display-channel-private.h | 4 ++

[Spice-devel] [PATCH v2 1/2] display-channel: Join drawables to improve rhel7 behaviour

2016-12-08 Thread Frediano Ziglio
Due to the way RHEL7 works the images came out from guest using multiple commands. This increase the commands to the client and cause the video code to create and handle multiple streams creating some visual glitches. This patch attempt to detect and join the multiple commands to avoid these issues

Re: [Spice-devel] [PATCH spice-server 1/2] Refactory Glz RedDrawable retention code

2016-12-08 Thread Frediano Ziglio
ping this patch is about 6 months old Frediano - Original Message - > From: "Frediano Ziglio" > To: spice-devel@lists.freedesktop.org > Cc: "Frediano Ziglio" > Sent: Tuesday, October 18, 2016 10:28:25 AM > Subject: [PATCH spice-server 1/2] Refactory Glz RedDrawable retention code > >

[Spice-devel] [PATCH v8 00/11] Remove DummyChannel* objects

2016-12-08 Thread Frediano Ziglio
These objects were used by the sound channel as this channel read/write to/from client directly. This make the code of this channel quite different from the other ones. Also this reduce code duplication from RedChannelClient and increase encapsulation. Also there are multiple cleanup following this

[Spice-devel] [PATCH v8 08/11] sound: Reuse code to set volume and mute

2016-12-08 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/sound.c | 51 +-- 1 file changed, 21 insertions(+), 30 deletions(-) diff --git a/server/sound.c b/server/sound.c index d6896d5..df5094c 100644 --- a/server/sound.c +++ b/server/sound.c @@ -825,12 +825,11 @@

[Spice-devel] [PATCH v8 06/11] sound: Reuse code for snd_set_{playback, record}_peer

2016-12-08 Thread Frediano Ziglio
Almost identical beside the type. Signed-off-by: Frediano Ziglio --- server/sound.c | 53 +++ 1 file changed, 16 insertions(+), 37 deletions(-) diff --git a/server/sound.c b/server/sound.c index 745cac7..88171cc 100644 --- a/server/sound.c +++ b/s

[Spice-devel] [PATCH v8 02/11] Remove DummyChannel* objects

2016-12-08 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/Makefile.am| 4 +- server/dummy-channel-client.c | 138 +--- server/dummy-channel-client.h | 64 + server/dummy-channel.c| 94 + server/dummy-channel.h

[Spice-devel] [PATCH v8 01/11] sound: Convert SndChannelClient to GObject

2016-12-08 Thread Frediano Ziglio
This patch is quite huge but have some benefits: - reduce dependency (DummyChannel* and some RedChannelClient internals); - reuse RedChannelClient instead of reading from the RedsStream directly. You can see that SndChannelClient has much less field as the code to read/write from/to client is re

[Spice-devel] [PATCH v8 03/11] Make RedChannelClient::incoming private

2016-12-08 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/red-channel-client-private.h | 11 +++ server/red-channel-client.c | 12 ++-- server/red-channel-client.h | 13 - 3 files changed, 17 insertions(+), 19 deletions(-) diff --git a/server/red-channel-client-privat

[Spice-devel] [PATCH v8 11/11] sound: Use memcpy instead of manually copy volume array

2016-12-08 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/sound.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/server/sound.c b/server/sound.c index d26e922..055a94b 100644 --- a/server/sound.c +++ b/server/sound.c @@ -386,7 +386,6 @@ static int snd_playback_send_migrate(PlaybackChan

[Spice-devel] [PATCH v8 09/11] sound: Use default message handler if possible

2016-12-08 Thread Frediano Ziglio
red_channel_client_handle_message can handle base messages so reuse it. Signed-off-by: Frediano Ziglio --- server/sound.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/server/sound.c b/server/sound.c index df5094c..78a65f6 100644 --- a/server/sound.c +++ b/

[Spice-devel] [PATCH v8 10/11] sound: Make clear active and client_active are boolean

2016-12-08 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/sound.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/server/sound.c b/server/sound.c index 78a65f6..d26e922 100644 --- a/server/sound.c +++ b/server/sound.c @@ -93,8 +93,8 @@ GType snd_channel_client_get_type(void) G_

[Spice-devel] [PATCH v8 07/11] sound: Reuse code for migrating client channels

2016-12-08 Thread Frediano Ziglio
We support only a single client so don't waste code just to check this. The worst stuff can happen is that we'll migrate multiple connections. Signed-off-by: Frediano Ziglio --- server/sound.c | 35 +-- 1 file changed, 5 insertions(+), 30 deletions(-) diff --git

[Spice-devel] [PATCH v8 05/11] sound: Use default disconnect for client channels

2016-12-08 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/sound.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/server/sound.c b/server/sound.c index 20c4337..745cac7 100644 --- a/server/sound.c +++ b/server/sound.c @@ -817,23 +817,6 @@ snd_channel_client_release_recv_buf(RedChannelClie

[Spice-devel] [PATCH v8 04/11] sound: Free more on SndChannel finalize

2016-12-08 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/sound.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/server/sound.c b/server/sound.c index 6c6d65d..20c4337 100644 --- a/server/sound.c +++ b/server/sound.c @@ -1434,10 +1434,26 @@ snd_channel_init(SndChannel *s

Re: [Spice-devel] [spice v1] Fix gitignore

2016-12-08 Thread Victor Toso
Hi, Sorry, I pushed already. On Thu, Dec 08, 2016 at 09:15:57AM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Signed-off-by: Victor Toso > > --- > > .gitignore | 4 > > server/tests/.gitignore | 37 ++--- > > tools/.gitigno

Re: [Spice-devel] [spice v1] Fix gitignore

2016-12-08 Thread Victor Toso
Hi, On Thu, Dec 08, 2016 at 03:10:44PM +0100, Pavel Grunt wrote: > Ack > > Would be good to generate it (git.mk) Agreed. I don't understand much about it.. we already use some cfg.mk in spice while we have included this git.mk in spice-gtk I'll push this for now. toso > > Pavel > > On Thu,

Re: [Spice-devel] [spice v1] Fix gitignore

2016-12-08 Thread Frediano Ziglio
> > From: Victor Toso > > Signed-off-by: Victor Toso > --- > .gitignore | 4 > server/tests/.gitignore | 37 ++--- > tools/.gitignore| 1 + > 3 files changed, 27 insertions(+), 15 deletions(-) > create mode 100644 tools/.gitignore >

Re: [Spice-devel] [spice v1] Fix gitignore

2016-12-08 Thread Pavel Grunt
Ack Would be good to generate it (git.mk) Pavel On Thu, 2016-12-08 at 14:30 +0100, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso > --- >  .gitignore  |  4 >  server/tests/.gitignore | 37 ++--- >  tools/.gitignore

Re: [Spice-devel] [PATCH spice-server v4] marshaller: rename _add_ref() to _add_by_ref()

2016-12-08 Thread Pavel Grunt
Ack Pavel On Thu, 2016-12-08 at 13:53 +, Frediano Ziglio wrote: > The spice_marshaller_add_ref() family of functions is confusing > since it > sounds like you're incrementing a reference on the marshaller. What > it > is actually doing is adding a data buffer to the marshaller by > reference

[Spice-devel] [PATCH spice-server v4] marshaller: rename _add_ref() to _add_by_ref()

2016-12-08 Thread Frediano Ziglio
The spice_marshaller_add_ref() family of functions is confusing since it sounds like you're incrementing a reference on the marshaller. What it is actually doing is adding a data buffer to the marshaller by reference rather than by value. Changing the function names to _add_by_ref() makes this clea

Re: [Spice-devel] [PATCH spice-common] marshaller: Remove deprecated replacement functions

2016-12-08 Thread Pavel Grunt
Ack from me Pavel On Thu, 2016-12-08 at 13:37 +, Frediano Ziglio wrote: > spice-common has no stable ABI/API. > Also these function caused linking problems as these functions > were defined multiple times. > > Signed-off-by: Frediano Ziglio > --- >  common/marshaller.h | 13 - >

[Spice-devel] [PATCH spice-common] marshaller: Remove deprecated replacement functions

2016-12-08 Thread Frediano Ziglio
spice-common has no stable ABI/API. Also these function caused linking problems as these functions were defined multiple times. Signed-off-by: Frediano Ziglio --- common/marshaller.h | 13 - 1 file changed, 13 deletions(-) diff --git a/common/marshaller.h b/common/marshaller.h index

[Spice-devel] [spice v1] Fix gitignore

2016-12-08 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso --- .gitignore | 4 server/tests/.gitignore | 37 ++--- tools/.gitignore| 1 + 3 files changed, 27 insertions(+), 15 deletions(-) create mode 100644 tools/.gitignore diff --git a/.gitignor

Re: [Spice-devel] [PATCH spice-common] marshaller: Use static inline for deprecated functions

2016-12-08 Thread Pavel Grunt
Hey, rather remove the deprecated function. spice-common is not api/abi stable library Pavel On Thu, 2016-12-08 at 13:12 +, Frediano Ziglio wrote: > Compiler threats static inline functions in a different way avoiding > emitting code if functions are not used. > This avoid unused function to

[Spice-devel] [PATCH spice-common] marshaller: Use static inline for deprecated functions

2016-12-08 Thread Frediano Ziglio
Compiler threats static inline functions in a different way avoiding emitting code if functions are not used. This avoid unused function to generate code and duplicate symbols. Signed-off-by: Frediano Ziglio --- common/marshaller.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-

[Spice-devel] [PATCH spice-server v3] marshaller: rename _add_ref() to _add_by_ref()

2016-12-08 Thread Frediano Ziglio
The spice_marshaller_add_ref() family of functions is confusing since it sounds like you're incrementing a reference on the marshaller. What it is actually doing is adding a data buffer to the marshaller by reference rather than by value. Changing the function names to _add_by_ref() makes this clea

Re: [Spice-devel] [PATCH spice-server] marshaller: rename _add_ref() to _add_by_ref()

2016-12-08 Thread Pavel Grunt
On Thu, 2016-12-08 at 07:36 -0500, Frediano Ziglio wrote: > > > > I did git clean && ./autogen.sh && mak > > > > and > > It does not compile: > > make[4]: Entering directory '/home/pgrunt/src/spice/server/tests' > >   CCLD test-display-no-ssl > > ../../server/.libs/libserver.a(smartcard-chann

Re: [Spice-devel] [PATCH spice-server] marshaller: rename _add_ref() to _add_by_ref()

2016-12-08 Thread Frediano Ziglio
> > I did git clean && ./autogen.sh && mak > > and > It does not compile: > make[4]: Entering directory '/home/pgrunt/src/spice/server/tests' >   CCLD test-display-no-ssl > ../../server/.libs/libserver.a(smartcard-channel-client.o): In > function `smartcard_channel_client_send_data': > /home/

[Spice-devel] [PATCH spice-server v2] marshaller: rename _add_ref() to _add_by_ref()

2016-12-08 Thread Frediano Ziglio
The spice_marshaller_add_ref() family of functions is confusing since it sounds like you're incrementing a reference on the marshaller. What it is actually doing is adding a data buffer to the marshaller by reference rather than by value. Changing the function names to _add_by_ref() makes this clea

Re: [Spice-devel] [PATCH spice-server] marshaller: rename _add_ref() to _add_by_ref()

2016-12-08 Thread Pavel Grunt
I did git clean && ./autogen.sh && mak and It does not compile: make[4]: Entering directory '/home/pgrunt/src/spice/server/tests'   CCLD test-display-no-ssl ../../server/.libs/libserver.a(smartcard-channel-client.o): In function `smartcard_channel_client_send_data': /home/pgrunt/src/spice/serv

Re: [Spice-devel] I am a China java development engineer, i had a chinese keyboard qusetion need to be solved

2016-12-08 Thread Frediano Ziglio
Which SDK are you referring to? Android? Officially we don't provide Android application/library, which website are you referring to? What's the problem with Android keyboard input you are having? I can guess you are trying to connect to a virtual machine using Spice and an Android client but

[Spice-devel] [PATCH spice-server] marshaller: rename _add_ref() to _add_by_ref()

2016-12-08 Thread Frediano Ziglio
The spice_marshaller_add_ref() family of functions is confusing since it sounds like you're incrementing a reference on the marshaller. What it is actually doing is adding a data buffer to the marshaller by reference rather than by value. Changing the function names to _add_by_ref() makes this clea

Re: [Spice-devel] [PATCH] qxl-wddm-dod: Add Changelog file

2016-12-08 Thread Frediano Ziglio
> > Signed-off-by: Yuri Benditovich > --- > Changelog | 9 + > 1 file changed, 9 insertions(+) > create mode 100644 Changelog > > diff --git a/Changelog b/Changelog > new file mode 100644 > index 000..af28f4c > --- /dev/null > +++ b/Changelog > @@ -0,0 +1,9 @@ > +Version 0.15 > +

[Spice-devel] [PATCH] qxl-wddm-dod: Add Changelog file

2016-12-08 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- Changelog | 9 + 1 file changed, 9 insertions(+) create mode 100644 Changelog diff --git a/Changelog b/Changelog new file mode 100644 index 000..af28f4c --- /dev/null +++ b/Changelog @@ -0,0 +1,9 @@ +Version 0.15 +Implement screen to screen mo

Re: [Spice-devel] [client v2 3/3] build-sys: Enable deprecation warnings instead of ignoring them entirely

2016-12-08 Thread Christophe Fergeau
On Thu, Dec 08, 2016 at 07:29:18AM +0100, Francois Gouget wrote: > On Thu, 1 Dec 2016, Christophe Fergeau wrote: > > > On Thu, Dec 01, 2016 at 04:27:36AM +0100, Francois Gouget wrote: > > > On Wed, 23 Nov 2016, Christophe Fergeau wrote: > > > > > > > On Wed, Nov 23, 2016 at 07:09:28AM +0100, Fran

[Spice-devel] I am a China java development engineer, i had a chinese keyboard qusetion need to be solved

2016-12-08 Thread 史建超
Hello. I am a China java development engineer, My Android mobile project has used spice, but according to the website to download the relevant steps SDK has 4 unexpected error resources on the web link is not available, now I need to solve Chinese by Android keyboard input, transmission interf

[Spice-devel] [qxl v2] spiceqxl: Improve the Xspice and Xorg configuration option descriptions

2016-12-08 Thread Francois Gouget
Group the options more logically and improve their descriptions. Add the missing help strings for Xspice --help and standardize the messages to start with a lowercase and not end with a period. In the Xorg configuration, always show the default in the commented-out sample. Signed-off-by: Francois

Re: [Spice-devel] [qxl] spiceqxl: Improve the Xspice and Xorg configuration option descriptions

2016-12-08 Thread Francois Gouget
On Mon, 7 Nov 2016, Frediano Ziglio wrote: [...] > > > -parser.add_argument('--audio-fifo-dir', help="set fifo directory for > > > playback audio. designed to work with PulseAudio's module-pipe-sink") > > > +parser.add_argument('--audio-fifo-dir', help="If a directory is given, > > > any > > > fil

Re: [Spice-devel] [qxl] spiceqxl: Improve the Xspice and Xorg configuration option descriptions

2016-12-08 Thread Francois Gouget
On Mon, 7 Nov 2016, Christophe Fergeau wrote: [...] > > +parser.add_argument('--dh-file', help="Set the server DH file location for > > TLS.") > > +parser.add_argument('--tls-ciphers', help="Set the TLS ciphers preference > > order.") > > +add_boolean('--ipv4-only') > > +add_boolean('--ipv6-only'