[Spice-devel] Blurry spice-widget

2016-12-21 Thread Jason A. Donenfeld
Hi folks, Since spicy is gtk3, it supports HiDPI scaling of widgets, which is great. The menus and icons are all in beautiful proportion, scaled up 2x, since I'm on a 192-dpi screen. Yay. However, the spice-widget.c view of the Windows 10 VM, which is showing what's essentially a bitmap stream, i

Re: [Spice-devel] [PATCH spice-gtk v2 1/5] gtk: Use gdk_cursor_new_for_display

2016-12-21 Thread Christophe Fergeau
On Mon, Dec 19, 2016 at 05:26:32PM +0100, Pavel Grunt wrote: > Create the cursor when the widget is realized > --- > src/spice-widget.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/spice-widget.c b/src/spice-widget.c > index 72fbbc8..a27f5a2 100644 >

Re: [Spice-devel] [PATCH spice-gtk v2 5/5] gtk: Avoid deprecated gdk_pointer_grab

2016-12-21 Thread Christophe Fergeau
For the record, without this patch, the client mouse cursor is not hidden as expected when running on wayland and the guest is in mouse server mode, not sure why... So in addition to switching away from deprecated API, this fixes/works around a bug. Christophe On Mon, Dec 19, 2016 at 05:26:36PM +

Re: [Spice-devel] Blurry spice-widget

2016-12-21 Thread David Jaša
On St, 2016-12-21 at 02:57 +0100, Jason A. Donenfeld wrote: > Hi folks, > > Since spicy is gtk3, it supports HiDPI scaling of widgets, which is > great. The menus and icons are all in beautiful proportion, scaled up > 2x, since I'm on a 192-dpi screen. Yay. > > However, the spice-widget.c view of

Re: [Spice-devel] virt-viewer for windows with usbdk support

2016-12-21 Thread Victor Toso
Hi, On Tue, Dec 20, 2016 at 07:01:48PM +0100, Pavel Grunt wrote: > Alternatively download msi of virt-viewer 5.0 which has everything > https://virt-manager.org/download/ This is our first release using usbdk as back end, let us know of any problems :) Cheers, toso signature.asc Description:

[Spice-devel] question about 3D acceleration within spice

2016-12-21 Thread Chen Fan
Hi all, there was a question in my mind confusing me for some days. the 3D acceleration currently support local rending with virgl, right? I want to know why the spice don't support remote display? seems I also can run 3D game with spice to do remote display. Thanks, Chen -- Sinc

Re: [Spice-devel] question about 3D acceleration within spice

2016-12-21 Thread Victor Toso
Hi, On Wed, Dec 21, 2016 at 08:42:37PM +0800, Chen Fan wrote: > Hi all, > >there was a question in my mind confusing me for some days. the 3D > acceleration > > currently support local rending with virgl, right? Correct > I want to know why the spice don't support remote display? seems I > a

[Spice-devel] R: virt-viewer for windows with usbdk support

2016-12-21 Thread sella gianpietro
Hi, Many many thanks, the binary virt-viewer 5.0 for x64 is very good, all work, sound and usb redirection. I have not used before this binary because the old version (2.0 and 3.0 that I tested 1 year ago) are not compiled with usb redirection. Best regards, Gianpietro. -Messaggio originale--

Re: [Spice-devel] [PATCH spice 1/2] Filter agent capabilites messages

2016-12-21 Thread Victor Toso
Hi, I did not tested it as I see the discussion on IRC that you will also report an error in server in case file-xfer is disabled when we receive a file-xfer messages. Just a small comment bellow On Tue, Dec 20, 2016 at 08:39:31PM +0100, Pavel Grunt wrote: > It will be used to announce disabled

Re: [Spice-devel] [PATCH spice-protocol, spice-gtk, spice] Inform client about disabled features on server

2016-12-21 Thread Victor Toso
Hi, On Tue, Dec 20, 2016 at 08:39:28PM +0100, Pavel Grunt wrote: > Hello, > > this is another attempt to fix the bug about disabled file transfer on > the server but client allowing to start the file transfer (by drag'n'drop) > and creating a transfer dialog which cannot be closed: > https://bugz

Re: [Spice-devel] [PATCH spice-gtk v2 5/5] gtk: Avoid deprecated gdk_pointer_grab

2016-12-21 Thread Victor Toso
Hi, On Wed, Dec 21, 2016 at 11:51:06AM +0100, Christophe Fergeau wrote: > For the record, without this patch, the client mouse cursor is not > hidden as expected when running on wayland and the guest is in mouse > server mode, not sure why... > So in addition to switching away from deprecated API,

[Spice-devel] [PATCH spice] reds: Cancel unexpected xfer messages

2016-12-21 Thread Pavel Grunt
Inform client that transfer will not work, instead of only dropping the agent messages. The file transfer messages can be disabled using qemu cli option: "disable-agent-file-xfer" Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1373725 Signed-off-by: Pavel Grunt --- server/reds.c | 34 +

Re: [Spice-devel] Blurry spice-widget

2016-12-21 Thread Jason A. Donenfeld
Hi David, On Wed, Dec 21, 2016 at 1:37 PM, David Jaša wrote: > You're actually on 294 dpi screen :) Yea, sure, but in terms of standard DPIs, this screen is "2x", so 96*2=192. Not really important for this discussion though. > This is actually good RFE that can work for different cases both by

Re: [Spice-devel] Blurry spice-widget

2016-12-21 Thread Marc-André Lureau
Hi - Original Message - > Hi David, > > On Wed, Dec 21, 2016 at 1:37 PM, David Jaša wrote: > > You're actually on 294 dpi screen :) > > Yea, sure, but in terms of standard DPIs, this screen is "2x", so > 96*2=192. Not really important for this discussion though. > > > This is actually

Re: [Spice-devel] Blurry spice-widget

2016-12-21 Thread Jason A. Donenfeld
On Wed, Dec 21, 2016 at 5:08 PM, Marc-André Lureau wrote: > > Can we avoid tweaking? > > I would simply send the client dpi or scale factor as part of monitor config. That sounds even better to me. ___ Spice-devel mailing list Spice-devel@lists.freedesk

[Spice-devel] [PATCH] Sound: Fix confusing channel/client terminology

2016-12-21 Thread Jonathon Jongsma
Previously, the object we now call SndChannel was named SndWorker, and the object we now call SndChannelClient was called SndChannel. When these names were changed, the functions on_new_(record|playback)_channel() were not updated, so the function names and the arguments are both a bit confusing no

[Spice-devel] [spice-gtk v1] file-xfer: differentiate error from host/guest and client

2016-12-21 Thread Victor Toso
From: Victor Toso During file transfer, we can have error and cancellation in client, host or guest side. If error happens in the client side, we must send a message to the guest, VD_AGENT_FILE_XFER_STATUS, with either _STATUS_CANCELLED or _STATUS_ERROR. But the current code is also sending a m

Re: [Spice-devel] [PATCH v9 01/11] sound: Convert SndChannelClient to GObject

2016-12-21 Thread Jonathon Jongsma
I've been trying to review this for quite a while now. It's rather dense and difficult to make sure I understand all of the potential minor changes, etc. In general, it looks good, but I have a couple of questions/comments below. On Tue, 2016-12-20 at 17:44 +, Frediano Ziglio wrote: > This pa