Re: [Spice-devel] [PATCH spice-gtk v5 4/9] channel-display: implement preferred video codec msgc

2017-01-18 Thread Victor Toso
Hi, On Wed, Jan 18, 2017 at 11:27:40AM +0100, Pavel Grunt wrote: > Hi Victor, > > On Fri, 2017-01-06 at 09:18 +0100, Victor Toso wrote: > > From: Victor Toso > > > > * SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE > > > > This message was introduced in protocol 0.12.13 to

Re: [Spice-devel] [PATCH spice-html5 3/3] Detect video underrun and advance the current time.

2017-01-18 Thread Pavel Grunt
On Mon, 2016-12-19 at 15:20 -0600, Jeremy White wrote: > This helps us avoid stalled video streams. > > Signed-off-by: Jeremy White Acked-by: Pavel Grunt > --- >  display.js | 8 >  1 file changed, 8 insertions(+) > > diff --git a/display.js

Re: [Spice-devel] [PATCH spice-gtk v5 5/9] spicy: implement preferred video codec type

2017-01-18 Thread Victor Toso
Hi, On Wed, Jan 18, 2017 at 11:29:45AM +0100, Pavel Grunt wrote: > On Fri, 2017-01-06 at 09:18 +0100, Victor Toso wrote: > > From: Victor Toso > > > > Similar to preferred video compression, a radio button showing > > mjpeg, > > vp8 and h264 in case server has the proper

Re: [Spice-devel] [PATCH spice-html5 2/3] Add more stream information in high debug situations at an updateend event.

2017-01-18 Thread Pavel Grunt
On Mon, 2016-12-19 at 15:20 -0600, Jeremy White wrote: > Signed-off-by: Jeremy White Acked-by: Pavel Grunt > --- >  display.js | 4 >  1 file changed, 4 insertions(+) > > diff --git a/display.js b/display.js > index c124483..d4baef7 100644 > ---

Re: [Spice-devel] [PATCH spice-html5 1/3] Catch and note updateend messages after video destruction.

2017-01-18 Thread Pavel Grunt
On Mon, 2016-12-19 at 15:20 -0600, Jeremy White wrote: > Signed-off-by: Jeremy White Acked-by: Pavel Grunt > --- >  display.js | 6 ++ >  1 file changed, 6 insertions(+) > > diff --git a/display.js b/display.js > index 40a809e..c124483 100644 > ---

Re: [Spice-devel] [PATCH v2 1/2] autotools: Add automake conditional for gstreamer

2017-01-18 Thread Christophe Fergeau
On Wed, Jan 18, 2017 at 03:29:45PM +0200, Snir Sheriber wrote: > Adding conditional for having gstreamer_0_10 or gstreamer_1_0 > (and also a preprocessor symbol), removing the previous conditionals > and update relevant ifdefs with the newly defined changes > --- > configure.ac

[Spice-devel] [PATCH v2 2/2] autotools: compile gst-test only if gstreamer is available

2017-01-18 Thread Snir Sheriber
Needed in order to avoid compilation error when gstreamer is unavailable --- server/tests/Makefile.am | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index f696f9f..af0bd20 100644 --- a/server/tests/Makefile.am +++

[Spice-devel] [PATCH v2 1/2] autotools: Add automake conditional for gstreamer

2017-01-18 Thread Snir Sheriber
Adding conditional for having gstreamer_0_10 or gstreamer_1_0 (and also a preprocessor symbol), removing the previous conditionals and update relevant ifdefs with the newly defined changes --- configure.ac | 7 +-- server/Makefile.am | 8 +---

Re: [Spice-devel] [PATCH spice-gtk v5 5/9] spicy: implement preferred video codec type

2017-01-18 Thread Pavel Grunt
On Fri, 2017-01-06 at 09:18 +0100, Victor Toso wrote: > From: Victor Toso > > Similar to preferred video compression, a radio button showing > mjpeg, > vp8 and h264 in case server has the proper [0] capability > > [0] SPICE_DISPLAY_CAP_PREF_VIDEO_CODEC_TYPE > >

Re: [Spice-devel] [PATCH spice-gtk v5 4/9] channel-display: implement preferred video codec msgc

2017-01-18 Thread Pavel Grunt
Hi Victor, On Fri, 2017-01-06 at 09:18 +0100, Victor Toso wrote: > From: Victor Toso > > * SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE > > This message was introduced in protocol 0.12.13 to establish client > side preference on video codec to be used in streams. > > At

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

2017-01-18 Thread Frediano Ziglio
> > Hey, > > On Fri, Jan 13, 2017 at 05:47:13AM -0500, Frediano Ziglio wrote: > > You are right. Surprisingly if the network queue was full the old code > > just ignored the request not sending/setting any command. > > After your code you don't schedule a send any volume/mute changes. > > Maybe