Re: [Spice-devel] [spice-gtk v2] Move spicy tools to its own folder

On Thu, 2017-01-19 at 16:34 +0100, Victor Toso wrote: > Hi, > > On Thu, Jan 19, 2017 at 03:27:21PM +0100, Christophe Fergeau wrote: > > You need > > > > diff --git a/tools/Makefile.am b/tools/Makefile.am > > index 204dc50..0bdb3c5 100644 > > --- a/tools/Makefile.am > > +++ b/tools/Makefile.am >

[Spice-devel] [PATCH] RFC: Document display channel drawable trees, etc

--- I started looking into a bug related to surfaces and drawing, but after a little initial investigation, I realized that I didn't really understand any of the code in this part of spice server. I discussed it a little bit with several others who also didn't have a good understanding of this

Re: [Spice-devel] [PATCH v5 4/5] gstreamer: Avoid memory copy if strides are different

On Tue, Jan 10, 2017 at 02:20:40PM +, Frediano Ziglio wrote: > If bitmap stride and stream stride are different copy was used. > Using GStreamer 1.0 you can avoid the copy setting correctly > image offset and stride. Oh that's nice! > > Signed-off-by: Frediano Ziglio >

Re: [Spice-devel] [PATCH v5 3/5] gstreamer: Add gst_format to the table of supported formats

On Tue, Jan 10, 2017 at 02:20:39PM +, Frediano Ziglio wrote: > This format is required to add metadata. > These metadata can be used to pass different strides or additional > information to pass dma buffers. I don't really understand what you want to do with that additional info from the

Re: [Spice-devel] [PATCH v5 2/5] tests: Make possible to have a report of the video encoding

On Tue, Jan 10, 2017 at 02:20:38PM +, Frediano Ziglio wrote: > This allows to do some possible statistics or graph. > Currently the report contain encoded sizes. 'contains' If you have a use for it, why not, though the output format can change at any time we decide, right? Acked-by:

[Spice-devel] [vdagent-linux v5 3/3] Move mouse-specific handling out of virtio_port_read_complete

From: Michal Suchanek Move some mouse-specific code from the start of virtio_port_read_complete to a separate helper as is the case with other message types. Signed-off-by: Michal Suchanek --- src/vdagentd/vdagentd.c | 43

[Spice-devel] [vdagent-linux v5 1/3] vdagentd: early return on bad message size

From: Victor Toso The payload size for each message should be the size of the expected struct or bigger when it contain arrays of no fixed size. This patch creates the vdagent_message_min_size[] static array with the expected size for each message so we can check on

[Spice-devel] [vdagent-linux v5 0/3] Endian swapping

From: Victor Toso Hi, version 4 at: https://lists.freedesktop.org/archives/spice-devel/2017-January/034980.html I did some tests on LE only machines, it seems fine. v5: - 0001 is an extra patch to remove extra checks (for message size) and the goto; - 0002 does split

[Spice-devel] [vdagent-linux v5 2/3] Do endian swapping.

From: Michal Suchanek This allows running big endian and little endian guest side by side using cut & paste between them. There is a general design idea that swapping should come as close to virtio_read/virtio_write as possible. In particular, the protocol between vdagent and

[Spice-devel] [PATCH spice-gtk v3 3/6] gtk: Use gdk_device_warp

gdk_display_warp_pointer has been deprecated since Gtk 3.0 --- src/spice-widget.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index c8ee4bb..94d7f9a 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -119,6

[Spice-devel] [PATCH spice-gtk v3 1/6] gtk: Use gdk_cursor_new_from_name

Create the cursor when the widget is realized Also make the cursor work under Wayland --- src/spice-widget.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 72fbbc8..7678c12 100644 ---

[Spice-devel] [PATCH spice-gtk v3 2/6] gtk: Use gdk_window_get_device_position

gdk_window_get_pointer has been deprecated since Gtk 3.0 --- src/spice-widget.c | 54 -- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 7678c12..c8ee4bb 100644 ---

[Spice-devel] [PATCH spice-gtk v3 5/6] gtk: Avoid deprecated gdk_pointer_grab

--- src/spice-widget.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index aa03556..9d5ac3d 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -1023,6 +1023,17 @@ static gboolean

[Spice-devel] [PATCH spice-gtk v3 4/6] gtk: Avoid deprecated gdk_keyboard_grab

--- src/spice-widget.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/spice-widget.c b/src/spice-widget.c index 94d7f9a..aa03556 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -120,6 +120,9 @@ static void size_allocate(GtkWidget *widget, GtkAllocation

[Spice-devel] [PATCH spice-gtk v3 6/6] usb-device-widget: Do not use GtkVBox

--- src/usb-device-widget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c index b394499..747887c 100644 --- a/src/usb-device-widget.c +++ b/src/usb-device-widget.c @@ -40,14 +40,14 @@ struct _SpiceUsbDeviceWidget { -

Re: [Spice-devel] [PATCH spice-gtk v2] keymap: Add missing keys for XF86 and X11

On Mon, Jan 16, 2017 at 06:29:07PM +0100, Pavel Grunt wrote: > It was missing the "shift" variants of many keys, like: > !,@,#,$,%,^,&,*,(,),... > making BRODWAY backend usage very limited. This change allow us > to use it at least with the en_us keyboard layout in the guest. > > Keys were taken

[Spice-devel] [PATCH spice-gtk v3 0/6] Avoid usage of deprecated functions

Hi, this is a follow up to Francois's patches which avoided some deprecated warnings in the SpiceDisplay widget. The main difference is the usage of GdkSeat api that was introduced in Gtk 3.20. Getting rid of deprecated symbols is neccessary to be able to compile with the gtk master. v3: -

[Spice-devel] [spice-server] stat: Silence gcc warning

Initializing 'node' to NULL silences this warning: stat-file.c: In function 'stat_file_add_node': stat-file.c:180:15: error: 'node' may be used uninitialized in this function [-Werror=maybe-uninitialized] g_strlcpy(node->name, name, sizeof(node->name)); ^~~~ cc1: all warnings

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

On Wed, Jan 18, 2017 at 03:25:09AM -0500, Frediano Ziglio wrote: > > > > Hey, > > > > On Fri, Jan 13, 2017 at 05:47:13AM -0500, Frediano Ziglio wrote: > > > You are right. Surprisingly if the network queue was full the old code > > > just ignored the request not sending/setting any command. > >

Re: [Spice-devel] [PATCH v4] Do endian swapping.

Hello, On Thu, 19 Jan 2017 16:18:27 +0100 Victor Toso wrote: > Hi, > > On Fri, Jan 13, 2017 at 07:32:12PM +0100, Michal Suchanek wrote: > > /* vdagentd <-> spice-client communication handling */ > > static void send_capabilities(struct vdagent_virtio_port *vport, > >

Re: [Spice-devel] [PATCH spice-server 1/3] red-worker: Reuse code to process cursor command

Acked-by: Christophe Fergeau On Tue, Jan 10, 2017 at 03:59:36PM +, Frediano Ziglio wrote: > Code to read and process cursor commands were the same > so use a common function for better reuse. > > Signed-off-by: Frediano Ziglio > --- >