[Spice-devel] [PATCH spice-gtk 5/5] widget: switch 'display' type to DisplayChannel*

2017-06-07 Thread marcandre . lureau
From: Marc-André Lureau This avoids the long casts. The Channel* type is less commonly used. Signed-off-by: Marc-André Lureau --- src/spice-widget-egl.c | 2 +- src/spice-widget-priv.h | 2 +- src/spice-widget.c | 19 ++- 3 files changed, 12 insertions(+), 11 deletions(

[Spice-devel] [PATCH spice-gtk 3/5] widget: skip spice_egl_resize_display() if context is not ready

2017-06-07 Thread marcandre . lureau
From: Marc-André Lureau And call spice_egl_resize_display() when initializing the context. This fixes the "Couldn't find current GL or GLX context" error for me on X11. I thought first it was somehow related to commit a395ac59447de "spice-widget: init egl only after first gl_scanout", but revert

[Spice-devel] [PATCH spice-gtk 4/5] widget: call gl-draw when skipping draw

2017-06-07 Thread marcandre . lureau
From: Marc-André Lureau It's a bad idea to hold the GL scanout for a long time, especially in error cases. (fwiw, qemu has 1s tolerance before complaining, and the guest is most likely going to hang meanwhile, stuck on the GPU) Signed-off-by: Marc-André Lureau --- src/spice-widget.c | 6 +-

[Spice-devel] [PATCH spice-gtk 0/5] "Couldn't find current GLX or EGL context" on X11

2017-06-07 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following patches fixes the "Couldn't find current GLX or EGL context" error on X11. I don't know when and why the regression happened, but there is some GL context create races left in spice-gtk. I added a few cleanup patches too, hope you don't mind it sent tog

[Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

2017-06-07 Thread marcandre . lureau
From: Marc-André Lureau Use shorter line, use the common "d" variable for private data access, add brackets to ease reading the inner block vs the condition, remove needless != NULL. Signed-off-by: Marc-André Lureau --- src/spice-widget.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-

[Spice-devel] [PATCH spice-gtk 1/5] egl: add a precondition on gl_make_current()

2017-06-07 Thread marcandre . lureau
From: Marc-André Lureau To ease with debugging GL issues. Signed-off-by: Marc-André Lureau --- src/spice-widget-egl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c index 130710e..f9c024c 100644 --- a/src/spice-widget-egl.c +++ b/src/spice

Re: [Spice-devel] RFC: Lightweight tracing mechanism

2017-06-07 Thread Marc-André Lureau
Hi - Original Message - > > > On 7 Jun 2017, at 13:51, Marc-André Lureau > > wrote: > > > > Hi > > > > - Original Message - > >> > >>> On 6 Jun 2017, at 20:45, Marc-André Lureau > >>> wrote: > >>> > >>> I don't think any of these measurements couldn't be reported accurately

Re: [Spice-devel] RFC: Lightweight tracing mechanism

2017-06-07 Thread Christophe de Dinechin
> On 7 Jun 2017, at 13:51, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> >>> On 6 Jun 2017, at 20:45, Marc-André Lureau >>> wrote: >>> >>> I don't think any of these measurements couldn't be reported accurately >>> with a regular log or structured log. Thus I don't u

Re: [Spice-devel] RFC: Lightweight tracing mechanism

2017-06-07 Thread Marc-André Lureau
Hi - Original Message - > > > On 6 Jun 2017, at 20:45, Marc-André Lureau > > wrote: > > > > I don't think any of these measurements couldn't be reported accurately > > with a regular log or structured log. Thus I don't understand what problem > > you try to solve. > > > > Sorry, but I

[Spice-devel] [PATCH spice-common] log: Use GLib logging levels directly

2017-06-07 Thread Frediano Ziglio
As we moved toward GLib logging instead of having to convert every time the log level from the old system to GLib use directly GLib constants. Signed-off-by: Frediano Ziglio --- common/log.c | 35 +-- common/log.h | 26 +- 2 files changed,

Re: [Spice-devel] shared folders in Windows with QEMU/KVM ?

2017-06-07 Thread Han Pilmeyer
I've been using Samba for years to share files between my Windows guest and KVM host. I though this would make a much nicer solution. Currently my guest is Windows 10 and my host is Fedora 25. First step for me was to install spice-webdavd.exe as everything else seems to be in place already. The