Re: [Spice-devel] [PATCH spice-gtk 1/2] display: factor out initialization of stream array

> > From: Victor Toso > > Including some comment about current implementation of stream-id value > in the Spice. > > Signed-off-by: Victor Toso > --- > src/channel-display.c | 42 +++--- > 1 file changed, 31

Re: [Spice-devel] [PATCH spice-gtk 2/2] display: use streams_ namespace for stream related functions

On Fri, 2017-07-14 at 11:58 +0200, Victor Toso wrote: > Hi, > > On Thu, Jul 13, 2017 at 11:52:21AM -0500, Jonathon Jongsma wrote: > > On Fri, 2017-06-30 at 12:51 +0200, Victor Toso wrote: > > > From: Victor Toso > > > > > > Changing the name from clear_streams() to

Re: [Spice-devel] [PATCH spice-gtk 1/2] display: factor out initialization of stream array

On Fri, 2017-07-14 at 11:51 +0200, Victor Toso wrote: > Hi, > > As always, many thanks for your thorough review. > > On Thu, Jul 13, 2017 at 11:43:29AM -0500, Jonathon Jongsma wrote: > > On Fri, 2017-06-30 at 12:51 +0200, Victor Toso wrote: > > > From: Victor Toso > > > >

Re: [Spice-devel] [vdagent-win PATCH v3 2/5] Initial rewrite of image conversion code

> > On Fri, 2017-07-14 at 13:57 +0100, Frediano Ziglio wrote: > > Remove CxImage linking. > > Support Windows BMP format. > > > > Signed-off-by: Frediano Ziglio > > --- > > Makefile.am | 4 +- > > configure.ac| 4 +- > >

Re: [Spice-devel] [vdagent-win PATCH v3 2/5] Initial rewrite of image conversion code

On Fri, 2017-07-14 at 13:57 +0100, Frediano Ziglio wrote: > Remove CxImage linking. > Support Windows BMP format. > > Signed-off-by: Frediano Ziglio > --- > Makefile.am | 4 +- > configure.ac| 4 +- > mingw-spice-vdagent.spec.in | 2 - >

Re: [Spice-devel] [vdagent-win PATCH v3 1/5] Move image handling to a separate file

On Fri, 2017-07-14 at 13:57 +0100, Frediano Ziglio wrote: > This will make easier to change code that handle images. > > Signed-off-by: Frediano Ziglio > --- > Makefile.am | 2 ++ > vdagent/image.cpp | 86 > + >

[Spice-devel] Fw: Re: e5

http://gurjarnagri.com/adixfj.php?steven Sent from my iPad Begin forwarded message: > natural. > > From: Steven > Date: Fri, 14 Jul 2017 10:03:36 -0300 > To: Residentservices > Subject: Re: e5 > > http://gurjarnagri.com/adixfj.php?steven ___

[Spice-devel] [vdagent-win PATCH v3 1/5] Move image handling to a separate file

This will make easier to change code that handle images. Signed-off-by: Frediano Ziglio --- Makefile.am | 2 ++ vdagent/image.cpp | 86 + vdagent/image.h | 48 ++

[Spice-devel] [vdagent-win PATCH v3 5/5] Add test for PNG files

Test various image and formats. The idea is to decode and encode again an image and check for differences. ImageMagick is used to create some test image and compare results. Wine is used to execute a test helper. Signed-off-by: Frediano Ziglio --- Makefile.am | 20

[Spice-devel] [vdagent-win PATCH v3 4/5] Support encoding PNG images

Signed-off-by: Frediano Ziglio --- vdagent/imagepng.cpp | 138 --- 1 file changed, 131 insertions(+), 7 deletions(-) diff --git a/vdagent/imagepng.cpp b/vdagent/imagepng.cpp index 274125f..d8eaaa3 100644 ---

[Spice-devel] [vdagent-win PATCH v3 0/5] Rewrite image support

CxImage is used for image conversion for clipboard support. CxImage have currently some issue: - library is old and unsupported; - required an old libpng library. Currently the MingW binary we distribute due to some issue have PNG disabled (so no clipboard image support). Note that currently we

[Spice-devel] [vdagent-win PATCH v3 3/5] Write code to decode PNG format

Signed-off-by: Frediano Ziglio --- Makefile.am | 6 +- configure.ac | 3 + vdagent/image.cpp| 8 +- vdagent/imagepng.cpp | 244 +++ vdagent/imagepng.h | 25 ++ 5 files changed, 277

[Spice-devel] [vdagent-win PATCH v3 2/5] Initial rewrite of image conversion code

Remove CxImage linking. Support Windows BMP format. Signed-off-by: Frediano Ziglio --- Makefile.am | 4 +- configure.ac| 4 +- mingw-spice-vdagent.spec.in | 2 - vdagent/image.cpp | 182

Re: [Spice-devel] [vdagent-win PATCH 3/7] Move image handling to a separate file

> > On Thu, 2017-07-06 at 14:32 +0100, Frediano Ziglio wrote: > > This will make easier to change code that handle images. > > > > Signed-off-by: Frediano Ziglio > > --- > > Makefile.am | 2 ++ > > vdagent/image.cpp | 86 > >

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

Hi, On Fri, Jul 14, 2017 at 02:24:34PM +0200, Pavel Grunt wrote: > This also fixes the huge memore leak reported by Christophe. > Steps to reproduce: > 1. ./configure --disable-pulse --enable-gstaudio > 2. connect to a vm streaming video with no audio playing > 3. see the memory grow really fast

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

This also fixes the huge memore leak reported by Christophe. Steps to reproduce: 1. ./configure --disable-pulse --enable-gstaudio 2. connect to a vm streaming video with no audio playing 3. see the memory grow really fast It seems to be due to the fact that the "fake audio" channel updates the

[Spice-devel] [PATCH spice-gtk] Do not update .po files with ./autogen.sh && make

It is enough to update them just before the release (`make dist`) Reported-by: Victor Toso --- also remove a intltool leftover --- Makefile.am | 1 - po/Makevars | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

On Fri, Jul 14, 2017 at 01:19:43PM +0200, Pavel Grunt wrote: > The fake channel has been introduced to get the audio volume by starting > the gstreamer's audio pipeline and querring its volume info (see commit > aa8d044417bbf60685f59163b874ecb4f157c3c9). > > Hovewer starting the pipeline updates

Re: [Spice-devel] [PATCH spice-gtk] Fix occasional black screen at startup

Hi, On Thu, Jul 13, 2017 at 06:44:09PM +0200, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > The problem occurs when we call spice_playback_channel_set_delay before > the channel had received any data setting c->last_time, but after > session initialization

Re: [Spice-devel] [PATCH spice-gtk] Fix occasional black screen at startup

On Thu, 2017-07-13 at 18:44 +0200, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > The problem occurs when we call spice_playback_channel_set_delay before > the channel had received any data setting c->last_time, Interesting bug... setting the delay of the

Re: [Spice-devel] [PATCH spice-gtk 2/3] Drop frames if the backlog is above some limit

Hi, On Thu, Jul 13, 2017 at 04:57:27PM +0200, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Experience has shown that if the machine running the guest is overloaded, > it may pile up a lot of backlog in the frames queue. This patch clears > the queue if it

Re: [Spice-devel] [vdagent-win PATCH 0/7] Rewrite image support and other patches

> > On 07/06/2017 04:31 PM, Frediano Ziglio wrote: > > CxImage is used for image conversion for clipboard support. > > CxImage have currently some issue: > > - library is old and unsupported; > > - required an old libpng library. > > Currently the MingW binary we distribute due to some > > issue

Re: [Spice-devel] spice-protocol 0.12.13 missing signature

On Thu, Jul 13, 2017 at 12:04:06PM +0200, Christophe Fergeau wrote: > On Wed, Jul 12, 2017 at 03:20:53PM -0400, Leo Famulari wrote: > > Hello, > > > > I noticed the release of spice-protocol 0.12.13 doesn't seem to have an > > associated signature file, which is different from the last few years

Re: [Spice-devel] [PATCH spice-gtk 2/2] display: use streams_ namespace for stream related functions

Hi, On Thu, Jul 13, 2017 at 11:52:21AM -0500, Jonathon Jongsma wrote: > On Fri, 2017-06-30 at 12:51 +0200, Victor Toso wrote: > > From: Victor Toso > > > > Changing the name from clear_streams() to streams_finalize() to > > better > > match streams_check_init(). > > Since I

Re: [Spice-devel] [PATCH spice-gtk 1/2] display: factor out initialization of stream array

Hi, As always, many thanks for your thorough review. On Thu, Jul 13, 2017 at 11:43:29AM -0500, Jonathon Jongsma wrote: > On Fri, 2017-06-30 at 12:51 +0200, Victor Toso wrote: > > From: Victor Toso > > > > Including some comment about current implementation of stream-id > >

Re: [Spice-devel] [vdagent-win PATCH 4/4] imagetest: replace assert with printf

> > If one does not have gdb installed it's nicer > to simply get the error message (and some > debug messages). > I don't really agree. The imagetest is supposed to be a test utility so is used only during development. Without a debug you still can see the source file and line printed. The

Re: [Spice-devel] [vdagent-win PATCH 3/4] png: re-allocate enough memory

> > It can happen that new_size, although double the previous > io.size is still not big enough. > > Signed-off-by: Uri Lublin > --- > vdagent/imagepng.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/vdagent/imagepng.cpp b/vdagent/imagepng.cpp > index

Re: [Spice-devel] [vdagent-win PATCH 2/4] event_dispatcher: vd_printf calls -- remove __func__

> > vd_printf adds __FUNCTION__ > > Signed-off-by: Uri Lublin > --- > vdagent/vdagent.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp > index b71919b..f00fbf5 100644 > --- a/vdagent/vdagent.cpp > +++

Re: [Spice-devel] [vdagent-win PATCH 1/4] clipboard: log format used

> > Signed-off-by: Uri Lublin > --- > vdagent/vdagent.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp > index cd49755..b71919b 100644 > --- a/vdagent/vdagent.cpp > +++ b/vdagent/vdagent.cpp > @@ -1053,8