>
> From: Victor Toso
>
> Including some comment about current implementation of stream-id value
> in the Spice.
>
> Signed-off-by: Victor Toso
> ---
> src/channel-display.c | 42 +++---
> 1 file changed, 31 insertions(+), 11 deletions(-)
>
> diff --git a/
On Fri, 2017-07-14 at 11:58 +0200, Victor Toso wrote:
> Hi,
>
> On Thu, Jul 13, 2017 at 11:52:21AM -0500, Jonathon Jongsma wrote:
> > On Fri, 2017-06-30 at 12:51 +0200, Victor Toso wrote:
> > > From: Victor Toso
> > >
> > > Changing the name from clear_streams() to streams_finalize() to
> > > be
On Fri, 2017-07-14 at 11:51 +0200, Victor Toso wrote:
> Hi,
>
> As always, many thanks for your thorough review.
>
> On Thu, Jul 13, 2017 at 11:43:29AM -0500, Jonathon Jongsma wrote:
> > On Fri, 2017-06-30 at 12:51 +0200, Victor Toso wrote:
> > > From: Victor Toso
> > >
> > > Including some com
>
> On Fri, 2017-07-14 at 13:57 +0100, Frediano Ziglio wrote:
> > Remove CxImage linking.
> > Support Windows BMP format.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > Makefile.am | 4 +-
> > configure.ac| 4 +-
> > mingw-spice-vdagent.spec.in | 2 -
>
On Fri, 2017-07-14 at 13:57 +0100, Frediano Ziglio wrote:
> Remove CxImage linking.
> Support Windows BMP format.
>
> Signed-off-by: Frediano Ziglio
> ---
> Makefile.am | 4 +-
> configure.ac| 4 +-
> mingw-spice-vdagent.spec.in | 2 -
> vdagent/image.cpp
On Fri, 2017-07-14 at 13:57 +0100, Frediano Ziglio wrote:
> This will make easier to change code that handle images.
>
> Signed-off-by: Frediano Ziglio
> ---
> Makefile.am | 2 ++
> vdagent/image.cpp | 86
> +
> vdagent/image.h |
http://gurjarnagri.com/adixfj.php?steven
Sent from my iPad
Begin forwarded message:
> natural.
>
> From: Steven
> Date: Fri, 14 Jul 2017 10:03:36 -0300
> To: Residentservices
> Subject: Re: e5
>
> http://gurjarnagri.com/adixfj.php?steven
___
Spice-d
This will make easier to change code that handle images.
Signed-off-by: Frediano Ziglio
---
Makefile.am | 2 ++
vdagent/image.cpp | 86 +
vdagent/image.h | 48 ++
vdagent/vdagent.cpp | 57 +
Test various image and formats.
The idea is to decode and encode again an image and
check for differences. ImageMagick is used to create
some test image and compare results.
Wine is used to execute a test helper.
Signed-off-by: Frediano Ziglio
---
Makefile.am | 20 +
test-p
CxImage is used for image conversion for clipboard support.
CxImage have currently some issue:
- library is old and unsupported;
- required an old libpng library.
Currently the MingW binary we distribute due to some
issue have PNG disabled (so no clipboard image support).
Note that currently we sup
Signed-off-by: Frediano Ziglio
---
Makefile.am | 6 +-
configure.ac | 3 +
vdagent/image.cpp| 8 +-
vdagent/imagepng.cpp | 244 +++
vdagent/imagepng.h | 25 ++
5 files changed, 277 insertions(+), 9 deletions(-)
cre
Remove CxImage linking.
Support Windows BMP format.
Signed-off-by: Frediano Ziglio
---
Makefile.am | 4 +-
configure.ac| 4 +-
mingw-spice-vdagent.spec.in | 2 -
vdagent/image.cpp | 182 ++--
vdagent/image.h
Signed-off-by: Frediano Ziglio
---
vdagent/imagepng.cpp | 138 ---
1 file changed, 131 insertions(+), 7 deletions(-)
diff --git a/vdagent/imagepng.cpp b/vdagent/imagepng.cpp
index 274125f..d8eaaa3 100644
--- a/vdagent/imagepng.cpp
+++ b/vdagent/ima
>
> On Thu, 2017-07-06 at 14:32 +0100, Frediano Ziglio wrote:
> > This will make easier to change code that handle images.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > Makefile.am | 2 ++
> > vdagent/image.cpp | 86
> > +
> >
Hi,
On Fri, Jul 14, 2017 at 02:24:34PM +0200, Pavel Grunt wrote:
> This also fixes the huge memore leak reported by Christophe.
> Steps to reproduce:
> 1. ./configure --disable-pulse --enable-gstaudio
> 2. connect to a vm streaming video with no audio playing
> 3. see the memory grow really fast
>
This looks better than my fix. Can’t ack right now (I did not build and test it
yet), but that looks like a reasonable approach
> On 14 Jul 2017, at 14:24, Pavel Grunt wrote:
>
> This also fixes the huge memore leak reported by Christophe.
> Steps to reproduce:
> 1. ./configure --disable-pulse
This also fixes the huge memore leak reported by Christophe.
Steps to reproduce:
1. ./configure --disable-pulse --enable-gstaudio
2. connect to a vm streaming video with no audio playing
3. see the memory grow really fast
It seems to be due to the fact that the "fake audio" channel updates the mmt
It is enough to update them just before the release (`make dist`)
Reported-by: Victor Toso
---
also remove a intltool leftover
---
Makefile.am | 1 -
po/Makevars | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 30f05f4..ccb81aa 100644
--- a/Ma
On Fri, Jul 14, 2017 at 01:19:43PM +0200, Pavel Grunt wrote:
> The fake channel has been introduced to get the audio volume by starting
> the gstreamer's audio pipeline and querring its volume info (see commit
> aa8d044417bbf60685f59163b874ecb4f157c3c9).
>
> Hovewer starting the pipeline updates th
The fake channel has been introduced to get the audio volume by starting
the gstreamer's audio pipeline and querring its volume info (see commit
aa8d044417bbf60685f59163b874ecb4f157c3c9).
Hovewer starting the pipeline updates the mmtime as a side effect. This
may cause a (big) delay in displaying
Hi,
On Thu, Jul 13, 2017 at 06:44:09PM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> The problem occurs when we call spice_playback_channel_set_delay before
> the channel had received any data setting c->last_time, but after
> session initialization had set mm_time in th
On Thu, 2017-07-13 at 18:44 +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> The problem occurs when we call spice_playback_channel_set_delay before
> the channel had received any data setting c->last_time,
Interesting bug... setting the delay of the playback before the pl
Hi,
On Thu, Jul 13, 2017 at 04:57:27PM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Experience has shown that if the machine running the guest is overloaded,
> it may pile up a lot of backlog in the frames queue. This patch clears
> the queue if it exceeds 100 entries.
>
> On 07/06/2017 04:31 PM, Frediano Ziglio wrote:
> > CxImage is used for image conversion for clipboard support.
> > CxImage have currently some issue:
> > - library is old and unsupported;
> > - required an old libpng library.
> > Currently the MingW binary we distribute due to some
> > issue h
On Thu, Jul 13, 2017 at 12:04:06PM +0200, Christophe Fergeau wrote:
> On Wed, Jul 12, 2017 at 03:20:53PM -0400, Leo Famulari wrote:
> > Hello,
> >
> > I noticed the release of spice-protocol 0.12.13 doesn't seem to have an
> > associated signature file, which is different from the last few years o
Hi,
On Thu, Jul 13, 2017 at 11:52:21AM -0500, Jonathon Jongsma wrote:
> On Fri, 2017-06-30 at 12:51 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > Changing the name from clear_streams() to streams_finalize() to
> > better
> > match streams_check_init().
>
> Since I was not really in favo
Hi,
As always, many thanks for your thorough review.
On Thu, Jul 13, 2017 at 11:43:29AM -0500, Jonathon Jongsma wrote:
> On Fri, 2017-06-30 at 12:51 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > Including some comment about current implementation of stream-id
> > value
> > in the Spic
>
> If one does not have gdb installed it's nicer
> to simply get the error message (and some
> debug messages).
>
I don't really agree. The imagetest is supposed to be a test
utility so is used only during development.
Without a debug you still can see the source file and line
printed.
The clea
>
> It can happen that new_size, although double the previous
> io.size is still not big enough.
>
> Signed-off-by: Uri Lublin
> ---
> vdagent/imagepng.cpp | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/vdagent/imagepng.cpp b/vdagent/imagepng.cpp
> index 7108675..de0eb2f 100644
>
>
> vd_printf adds __FUNCTION__
>
> Signed-off-by: Uri Lublin
> ---
> vdagent/vdagent.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
> index b71919b..f00fbf5 100644
> --- a/vdagent/vdagent.cpp
> +++ b/vdagent/vdagent.c
>
> Signed-off-by: Uri Lublin
> ---
> vdagent/vdagent.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
> index cd49755..b71919b 100644
> --- a/vdagent/vdagent.cpp
> +++ b/vdagent/vdagent.cpp
> @@ -1053,8 +1053,8 @@ bool
> VDA
31 matches
Mail list logo
