> On 8 Nov 2017, at 16:35, Frediano Ziglio wrote:
>
>>>
>>> On 8 Nov 2017, at 16:02, Frediano Ziglio wrote:
>>>
>>> This better integrate with exceptions.
>>> Also don't leak resources using a return in the middle of the
>>> code.
>>>
>>> Signed-off-by: Frediano Ziglio
>>> ---
>>> src/Makef
This prevent future problems supporting new channels.
Signed-off-by: Frediano Ziglio
---
server/utils.c | 10 ++
1 file changed, 10 insertions(+)
Christophe, is this addressing the problem you were thinking?
diff --git a/server/utils.c b/server/utils.c
index ff1fc2d1..746132e5 100644
-
>
> > On 8 Nov 2017, at 16:02, Frediano Ziglio wrote:
> >
> > This better integrate with exceptions.
> > Also don't leak resources using a return in the middle of the
> > code.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > src/Makefile.am | 1 +
> > src/defer.hpp
> On 8 Nov 2017, at 16:02, Frediano Ziglio wrote:
>
> This better integrate with exceptions.
> Also don't leak resources using a return in the middle of the
> code.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/Makefile.am | 1 +
> src/defer.hpp | 16
for the series,
Acked-by: Christophe Fergeau
On Wed, Nov 08, 2017 at 02:18:52PM +, Frediano Ziglio wrote:
> Frediano Ziglio (6):
> Make the compiler work out better way to write unaligned memory
> test-marshallers: Use unaligned structure
> test-marshallers: Test demarshalli
>
> On Wed, Nov 08, 2017 at 12:51:01PM +0100, Christophe Fergeau wrote:
> > It needs the corresponding library to be installed, as well as
> > pkg-config since it installs a .pc file.
> > ---
> > Since the plugins are going to be dlopened, and since the main package
> > does not ship a .so we need
On Wed, Nov 08, 2017 at 12:51:01PM +0100, Christophe Fergeau wrote:
> It needs the corresponding library to be installed, as well as
> pkg-config since it installs a .pc file.
> ---
> Since the plugins are going to be dlopened, and since the main package
> does not ship a .so we need to link to, I'
This allows for instance old clients to work correctly.
Signed-off-by: Frediano Ziglio
---
src/concrete-agent.cpp| 5 -
src/concrete-agent.hpp| 2 +-
src/spice-streaming-agent.cpp | 6 +-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/concrete-agent.c
This saves some resources if no client are connected.
Also will allow to get a better capture engine taking into account
client supported codecs.
Signed-off-by: Frediano Ziglio
---
src/spice-streaming-agent.cpp | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sr
This better integrate with exceptions.
Also don't leak resources using a return in the middle of the
code.
Signed-off-by: Frediano Ziglio
---
src/Makefile.am | 1 +
src/defer.hpp | 16
src/spice-streaming-agent.cpp | 16
3 files ch
On 11/08/2017 01:51 PM, Christophe Fergeau wrote:
It needs the corresponding library to be installed, as well as
pkg-config since it installs a .pc file.
---
Since the plugins are going to be dlopened, and since the main package
does not ship a .so we need to link to, I'm unsure about the first
R
Merged the entire series
>
> Acked-by: Frediano Ziglio
> ---
> README | 19 +--
> 1 file changed, 5 insertions(+), 14 deletions(-)
>
> diff --git a/README b/README
> index d07c014..7e9a3c7 100644
> --- a/README
> +++ b/README
> @@ -2,9 +2,11 @@ Introduction
>
>
This reduce the attack surface moving some data into read-only
sections.
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 2 +-
server/image-cache.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index e
Frediano Ziglio (6):
Make the compiler work out better way to write unaligned memory
test-marshallers: Use unaligned structure
test-marshallers: Test demarshalling
ring: Remove __ring_remove function
ring: Remove short living temporary variable
canvas_base: Allow
Acked-by: Frediano Ziglio
---
configure.ac | 2 +-
spice-streaming-agent.spec.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index a21832b..1d86200 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7,7 +7,7 @@ AM_CONFIG_HEADER
For once, the default automake behaviour is better than the one this
macro adds... See
https://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/
for details:
« what this macro means is that changes to your Makefile.am will not
automatically result in the Makefile being regenerated un
Acked-by: Frediano Ziglio
---
README | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/README b/README
index d07c014..7e9a3c7 100644
--- a/README
+++ b/README
@@ -2,9 +2,11 @@ Introduction
The SPICE Streaming Agent is a guest-side daemon whi
This is more consistent with how other RPM macros are used (%{release},
%{version}, ...)
---
Changes since v1:
- more details in the commit log
spice-streaming-agent.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming
The .pc file defines a plugin installation location, which will be arch
dependent, so the .pc file belongs in this arch ${libdir}, not in the
'noarch' ${sharedir}
Acked-by: Frediano Ziglio
---
Makefile.am | 2 +-
spice-streaming-agent.spec.in | 2 +-
2 files changed, 2 insertio
It needs pkg-config to be installed since it installs a .pc file.
---
Changes since v1:
- only add pkgconfig Requires
spice-streaming-agent.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
index e8c6d54..99b1f52 100644
-
On Wed, Nov 08, 2017 at 07:25:21AM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Nov 08, 2017 at 10:31:38AM +0100, Christophe Fergeau wrote:
> > > Hey,
> > >
> > > On Wed, Nov 08, 2017 at 08:20:12AM +, Frediano Ziglio wrote:
> > > > Missing some names cause some debugging messages to be
> > >
On Wed, Nov 08, 2017 at 07:44:38AM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Nov 08, 2017 at 07:15:21AM -0500, Frediano Ziglio wrote:
> > > >
> > > > This makes patch applying easier, no need to duplicate the information
> > > > in 2 places, a PatchN entry is enough.
> > > > ---
> > > > spic
On Wed, Nov 08, 2017 at 07:07:59AM -0500, Frediano Ziglio wrote:
> Why this is better ?
I'll add this to the commit log, but I find it more obvious this way
that this is an RPM variable, as opposed to something set by the shell.
>
> >
> > ---
> > spice-streaming-agent.spec.in | 6 +++---
> >
On Wed, Nov 08, 2017 at 07:09:11AM -0500, Frediano Ziglio wrote:
> >
> > The .pc file defines a plugin installation location, which will be arch
> > dependent, so the .pc file belongs in this arch ${libdir}, not in the
> > 'noarch' ${sharedir}
> > ---
> > Makefile.am | 2 +-
> >
>
> On Wed, Nov 08, 2017 at 07:15:21AM -0500, Frediano Ziglio wrote:
> > >
> > > This makes patch applying easier, no need to duplicate the information
> > > in 2 places, a PatchN entry is enough.
> > > ---
> > > spice-streaming-agent.spec.in | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 del
On Wed, Nov 08, 2017 at 07:15:21AM -0500, Frediano Ziglio wrote:
> >
> > This makes patch applying easier, no need to duplicate the information
> > in 2 places, a PatchN entry is enough.
> > ---
> > spice-streaming-agent.spec.in | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >
This flag will allow the client to perform some optimisations
on output and buffering processing.
Old clients will ignore this additional flag.
Signed-off-by: Frediano Ziglio
---
spice.proto | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
Changes since v2:
- more comments o
>
> On Wed, Nov 08, 2017 at 10:31:38AM +0100, Christophe Fergeau wrote:
> > Hey,
> >
> > On Wed, Nov 08, 2017 at 08:20:12AM +, Frediano Ziglio wrote:
> > > Missing some names cause some debugging messages to be
> > > generated and some of our tests to fail.
> >
> > Something I wanted to chec
>
> This makes patch applying easier, no need to duplicate the information
> in 2 places, a PatchN entry is enough.
> ---
> spice-streaming-agent.spec.in | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
> ind
Why this is better ?
>
> ---
> spice-streaming-agent.spec.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
> index e384951..8c4f26e 100644
> --- a/spice-streaming-agent.spec.in
> +++ b/spice-streaming
>
> It needs the corresponding library to be installed, as well as
> pkg-config since it installs a .pc file.
> ---
> Since the plugins are going to be dlopened, and since the main package
> does not ship a .so we need to link to, I'm unsure about the first
> Requires this patch adds.
>
> Christo
>
> ---
> configure.ac | 2 +-
> spice-streaming-agent.spec.in | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index a21832b..1d86200 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -7,7 +7,7 @@ AM_CONFIG_HEADER([co
>
> The .pc file defines a plugin installation location, which will be arch
> dependent, so the .pc file belongs in this arch ${libdir}, not in the
> 'noarch' ${sharedir}
> ---
> Makefile.am | 2 +-
> spice-streaming-agent.spec.in | 2 +-
> 2 files changed, 2 insertions(+), 2 de
>
> ---
> README | 19 +--
> 1 file changed, 5 insertions(+), 14 deletions(-)
>
> diff --git a/README b/README
> index d07c014..7e9a3c7 100644
> --- a/README
> +++ b/README
> @@ -2,9 +2,11 @@ Introduction
>
>
> The SPICE Streaming Agent is a guest-side daemon wh
This makes patch applying easier, no need to duplicate the information
in 2 places, a PatchN entry is enough.
---
spice-streaming-agent.spec.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
index 91e6b88..e384951
---
spice-streaming-agent.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
index e384951..8c4f26e 100644
--- a/spice-streaming-agent.spec.in
+++ b/spice-streaming-agent.spec.in
@@ -34,9 +34,9 @@ agent pl
---
README | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/README b/README
index d07c014..7e9a3c7 100644
--- a/README
+++ b/README
@@ -2,9 +2,11 @@ Introduction
The SPICE Streaming Agent is a guest-side daemon which captures the
-guest X.Or
For once, the default automake behaviour is better than the one this
macro adds... See
https://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/
for details:
« what this macro means is that changes to your Makefile.am will not
automatically result in the Makefile being regenerated un
It needs the corresponding library to be installed, as well as
pkg-config since it installs a .pc file.
---
Since the plugins are going to be dlopened, and since the main package
does not ship a .so we need to link to, I'm unsure about the first
Requires this patch adds.
Christophe
spice-stream
---
configure.ac | 2 +-
spice-streaming-agent.spec.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index a21832b..1d86200 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7,7 +7,7 @@ AM_CONFIG_HEADER([config.h])
AC_CONFIG_MAC
The .pc file defines a plugin installation location, which will be arch
dependent, so the .pc file belongs in this arch ${libdir}, not in the
'noarch' ${sharedir}
---
Makefile.am | 2 +-
spice-streaming-agent.spec.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
On Wed, Nov 08, 2017 at 10:31:38AM +0100, Christophe Fergeau wrote:
> Hey,
>
> On Wed, Nov 08, 2017 at 08:20:12AM +, Frediano Ziglio wrote:
> > Missing some names cause some debugging messages to be
> > generated and some of our tests to fail.
>
> Something I wanted to check before sending th
Acked-by: Christophe Fergeau
On Wed, Nov 08, 2017 at 06:04:53AM -0500, Frediano Ziglio wrote:
> ping
>
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > COPYING | 203
> > +-
> > LICENSE | 9 --
> > spice
ping
>
> Signed-off-by: Frediano Ziglio
> ---
> COPYING | 203
> +-
> LICENSE | 9 --
> spice-streaming-agent.spec.in | 4 +-
> 3 files changed, 204 insertions(+), 12 deletions(-)
> delete mode 100644 LICE
Hey,
On Wed, Nov 08, 2017 at 08:20:12AM +, Frediano Ziglio wrote:
> Missing some names cause some debugging messages to be
> generated and some of our tests to fail.
Something I wanted to check before sending this patch is if
the commit adding human-readable channel did not cause a small
regr
Missing some names cause some debugging messages to be
generated and some of our tests to fail.
This patch was written by Christophe Fergeau.
Signed-off-by: Frediano Ziglio
---
server/utils.c | 2 ++
1 file changed, 2 insertions(+)
Tested with Gitlab, see https://gitlab.com/freddy77/spice/-/jo
46 matches
Mail list logo
