Seems I got behind on email and ACKed the previous version already.
Oops.
Acked-by: Jonathon Jongsma
On Thu, 2017-11-30 at 16:42 +, Frediano Ziglio wrote:
> verify guarantee that the condition is always a compile
> time constant.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/glib-co
Acked-by: Jonathon Jongsma
On Thu, 2017-11-30 at 12:07 +, Frediano Ziglio wrote:
> Potentially a channel can run with a different core interface
> than the global one attached to RedsState so instead of calling
> reds_core_* functions use the code interface attached to the
> channel.
>
> S
I don't like this. It feels like it's being too clever and actually
makes things more confusing. The small benefit we get from not
allocating a small struct or two is definitely outweighed by the
disadvantages in my mind.
Jonathon
On Thu, 2017-11-30 at 12:03 +, Frediano Ziglio wrote:
> Signe
Acked-by: Jonathon Jongsma
On Thu, 2017-11-30 at 12:03 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/inputs-channel.c | 16 +++-
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/server/inputs-channel.c b/server/inputs-channel.c
>
sure, why not?
Acked-by: Jonathon Jongsma
On Thu, 2017-11-30 at 12:00 +, Frediano Ziglio wrote:
> verify guarantee that the condition is always a compile
> time constant.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/glib-compat.h| 2 +-
> server/red-parse-qxl.c | 4 +
Acked-by: Jonathon Jongsma
On Thu, 2017-11-30 at 11:15 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/test-display-base.c | 42
>
> server/tests/test-display-streaming.c| 2 +-
> server/tests/test-display-widt
Looks reasonable to me
Acked-by: Jonathon Jongsma
On Wed, 2017-11-29 at 17:14 +, Frediano Ziglio wrote:
> The name is more consistent with the value of the flag and
> the function red_channel_client_wait_pipe_item_sent where
> the MarkerPipeItem structure is used.
>
> Signed-off-by: Fredi
Acked-by: Jonathon Jongsma
On Wed, 2017-11-22 at 11:05 +, Frediano Ziglio wrote:
> This header is mainly exporting functions to handle public
> interface for the QXL devices.
> Avoid spreading its inclusion including this header in other
> headers.
>
> Signed-off-by: Frediano Ziglio
> ---
>
> On Thu, 2017-11-30 at 13:40 -0500, Frediano Ziglio wrote:
> > >
> > > This allows us to unref the stream directly rather than needing to
> > > pass
> > > the associated DisplayChannel to stream_unref(). The same is also
> > > true
> > > for stream_agent_unref, since the only reason that
> > >
>
> On Tue, 2017-11-21 at 09:49 +, Frediano Ziglio wrote:
> > This allows for instance old clients to work correctly.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > src/concrete-agent.cpp| 5 -
> > src/concrete-agent.hpp| 3 ++-
> > src/spice-streaming-agent.cpp | 6
>
> On Tue, 2017-11-21 at 09:49 +, Frediano Ziglio wrote:
> > This saves some resources if no client are connected.
> > Also will allow to get a better capture engine taking into account
> > client supported codecs.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > src/spice-streaming-agen
On Tue, 2017-11-21 at 09:49 +, Frediano Ziglio wrote:
> This allows for instance old clients to work correctly.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/concrete-agent.cpp| 5 -
> src/concrete-agent.hpp| 3 ++-
> src/spice-streaming-agent.cpp | 6 +-
> 3 files c
On Fri, 2017-12-01 at 17:11 +0100, Victor Toso wrote:
> Hi,
>
> On Fri, Dec 01, 2017 at 04:29:32PM +0100, Jakub Janků wrote:
> > Hi,
> >
> > On Fri, 2017-12-01 at 15:11 +0100, Victor Toso wrote:
> > > Hi,
> > >
> > > On Mon, Nov 13, 2017 at 06:50:06PM +0100, Jakub Janků wrote:
> > > > Get _NET_W
Hi,
On Fri, Dec 01, 2017 at 04:29:32PM +0100, Jakub Janků wrote:
> Hi,
>
> On Fri, 2017-12-01 at 15:11 +0100, Victor Toso wrote:
> > Hi,
> >
> > On Mon, Nov 13, 2017 at 06:50:06PM +0100, Jakub Janků wrote:
> > > Get _NET_WM_NAME using gdk_x11_screen_get_window_manager_name().
> > > vdagent_x11_g
On Tue, 2017-11-21 at 09:49 +, Frediano Ziglio wrote:
> This saves some resources if no client are connected.
> Also will allow to get a better capture engine taking into account
> client supported codecs.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/spice-streaming-agent.cpp | 14 +++-
Hi,
On Fri, 2017-12-01 at 15:11 +0100, Victor Toso wrote:
> Hi,
>
> On Mon, Nov 13, 2017 at 06:50:06PM +0100, Jakub Janků wrote:
> > Get _NET_WM_NAME using gdk_x11_screen_get_window_manager_name().
> > vdagent_x11_get_wm_name(): return the name instead of setting it.
> > Return string specifics:
Hi,
On Wed, Nov 29, 2017 at 11:48:52AM -0600, Jonathon Jongsma wrote:
> Ask udev (via pkg-config) for the appropriate directory to install udev
> rules. This is useful for recent distributions (e.g. RHEL7, fedora) that
> no longer have a root /lib directory and instead use /usr/lib
>
> Signed-off
Hi,
On Wed, Nov 29, 2017 at 11:48:43AM -0600, Jonathon Jongsma wrote:
> Reported by Frediano Ziglio. if udscs_create_server_for_fd() fails, it
> will return NULL and the file descriptor will be leaked. Since the
> calling function is the one that created the fd, it should free the fd
> if the serv
Hi,
On Mon, Nov 13, 2017 at 01:16:33PM +, Frediano Ziglio wrote:
> This flag will allow the client to perform some optimisations
> on output and buffering processing.
> Old clients will ignore this additional flag.
>
> Signed-off-by: Frediano Ziglio
> ---
> Changes since v2:
> - removed RFC
Hi,
On Thu, Nov 16, 2017 at 01:24:01PM +0100, Christophe Fergeau wrote:
> On Thu, Nov 16, 2017 at 07:12:17AM -0500, Frediano Ziglio wrote:
> > >
> > > Hey,
> > >
> > > Some concrete examples of what you are going to do with it would be
> > > useful ;)
> > >
> > > Christophe
> > >
> > > On Mon,
Hi,
On Fri, Dec 01, 2017 at 02:33:19PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Seems that was never used
Acked-by: Victor Toso
> ---
> server/video-stream.c | 12 +---
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/server/video-stream.c b/se
Hi,
On Mon, Nov 13, 2017 at 06:50:07PM +0100, Jakub Janků wrote:
> Don't cache _NET_WM_NAME, instead refetch it with each
> vdagent_x11_has_icons_on_desktop() call so that correct result is returned
> even if the window manager changes during the lifetime of vdagent_x11 struct.
> Remove char *net_
Signed-off-by: Frediano Ziglio
---
server/video-stream.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/server/video-stream.c b/server/video-stream.c
index 65da3f8a..619e5ed3 100644
--- a/server/video-stream.c
+++ b/server/video-stream.c
@@ -218,8 +218,7 @@ stati
Hi,
On Mon, Nov 13, 2017 at 06:50:06PM +0100, Jakub Janků wrote:
> Get _NET_WM_NAME using gdk_x11_screen_get_window_manager_name().
> vdagent_x11_get_wm_name(): return the name instead of setting it.
> Return string specifics:
> - "unsupported", when not running on X11
> - "unknown", when the name
Can we have a bit more details?
Which OS and version is running the VM? Which resolution and color depth?
Which OS and version (Windows x64 SP1 is not a version) is running the client?
Which resolution and color depth?
Do you know the server version? Qemu and spice-server versions would be help
How could this happened and how can i solve this problem?Plz return me soon.
labtop based on Windows x64 SP1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
How could this happened and how can i solve this problem?Plz return me soon.<>
<>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Thu, Nov 30, 2017 at 01:06:37PM -0500, Frediano Ziglio wrote:
> Yes, the 2 suggestions seem to conflict. I'm not sure about the page
> I pointed out. For instance I just checked RHEL 7.4 and there's gtk 3.22
> so is fine, maybe the page is referring at the first release, not sure
> if we should
28 matches
Mail list logo
