[Spice-devel] [nsis 1/2] Properly quote path to service binaries

2017-12-15 Thread Christophe Fergeau
If these paths are unquoted, and the path contains spaces (C:\Program Files (x86)\...), this could be exploited by putting a binary with a crafted name (C:\Program.exe), leading to privilege escalation as this is a service that is being started. https://www.commonexploits.com/unquoted-service-path

[Spice-devel] [nsis 2/2] build: Don't add .pdb debug files to the installer

2017-12-15 Thread Christophe Fergeau
The .pdb files contain the debug information for the drivers. They increase significantly the size of the installer, so it's better not to ship them. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index df8f7bc..841f01a 100644 --- a/Makefile ++

[Spice-devel] [PATCH spice-server] display-channel: Limit number of surfaces to 1024

2017-12-15 Thread Frediano Ziglio
Qemu never used more than this number and today surfaces are not much used so there's no reason to keep this limit so high. This reduces quite a lot some internal structure (DisplayChannelPrivate and DisplayChannelClientPrivate). Signed-off-by: Frediano Ziglio --- server/display-channel.c | 2 +-

Re: [Spice-devel] [PATCH spice-server 03/11] reds: Remove possible leak during SASL authentication

2017-12-15 Thread Frediano Ziglio
> > On 12/11/2017 12:28 PM, Frediano Ziglio wrote: > > We need to free the connection if the mechanism name is wrong > > > > Signed-off-by: Frediano Ziglio > > Acked-by: Uri Lublin > > Looking at reds_handle_auth_mechname() and reds_handle_auth_mechlen(), > one is calling reds_link_free the o

Re: [Spice-devel] [RFC PATCH 0/3] Flush interface and TCP_CORK

2017-12-15 Thread Frediano Ziglio
ping > > These patches try to add interface to support flush interface. > This interface could help improving bandwidth usage reducing bytes > sent through network. > The TCP_CORK is one possible usage of the library which actually > decrease packet numbers (not using SSL) by a 5% (unfortunately