Currently red_stream_async_read cannot handle read of 0 bytes.
This would cause a wrong assert in async_read_handler.
Fixing the assert would just make the code wrongly detect a
disconnection (usually a return of 0 from read is handled that
way but happens also if you try to read 0 bytes).
Current
On Thu, Jan 11, 2018 at 1:45 PM, Frediano Ziglio wrote:
> > On Tue, Jan 9, 2018 at 10:09 PM, Frediano Ziglio < fzig...@redhat.com >
> > wrote:
>
> > > > Hello!
> >
>
> > > > I would really like to see XSpice and xf86-video-qxl on FreeBSD.
> >
>
> > > > The correction for the FreeBSD build libspic
hey,
On Wed, Jan 17, 2018 at 12:15:03PM +0300, Oleg Ginzburg wrote:
> Confirm - these changes work successfully, tested on: FreeBSD 11.1-RELEASE
> and FreeBSD 12-CURRENT (aka HEAD).
>
> Will these changes be included in the next release?
>
> There is another small issue of build libspice-server
>
> hey,
>
> On Wed, Jan 17, 2018 at 12:15:03PM +0300, Oleg Ginzburg wrote:
> > Confirm - these changes work successfully, tested on: FreeBSD 11.1-RELEASE
> > and FreeBSD 12-CURRENT (aka HEAD).
> >
> > Will these changes be included in the next release?
> >
> > There is another small issue of b
El vie, 12-01-2018 a las 08:05 -0500, Marc-André Lureau escribió:
> Hi
>
> - Original Message -
> > On Thu, Jan 11, 2018 at 12:35:36PM -0500, Marc-André Lureau wrote:
> > > > I agree with you that some help from the windowing/toolkit
> > > > would be good
> > > > to have, but in this case,
Remove obsolete stuff required for old GDI canvas.
Actually these stuff were not used.
Frediano Ziglio (8):
canvas: Move PixmanData to C file
canvas: Remove mutex field from PixmanData
canvas: Remove Windows bitmap allocation
canvas: Remove unused dc parameter from surface_create
canvas:
The field is only assigned but never used.
Signed-off-by: Frediano Ziglio
---
common/canvas_utils.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/common/canvas_utils.c b/common/canvas_utils.c
index 626f17d..a6527e7 100644
--- a/common/canvas_utils.c
+++ b/common/canvas_utils.c
They are now just the same function with same parameters,
just one calls the other.
Signed-off-by: Frediano Ziglio
---
common/canvas_utils.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/common/canvas_utils.c b/common/canvas_utils.c
index 3e143de..a95501f 10064
Signed-off-by: Frediano Ziglio
---
common/canvas_base.h | 3 ---
common/canvas_utils.h | 4
2 files changed, 7 deletions(-)
diff --git a/common/canvas_base.h b/common/canvas_base.h
index b746bcb..27e2751 100644
--- a/common/canvas_base.h
+++ b/common/canvas_base.h
@@ -25,9 +25,6 @@
#inclu
Not used anymore.
Signed-off-by: Frediano Ziglio
---
common/canvas_base.h | 3 ---
common/sw_canvas.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/common/canvas_base.h b/common/canvas_base.h
index 2d3c35b..b746bcb 100644
--- a/common/canvas_base.h
+++ b/common/canvas_base.h
@@ -141,9
This structure is used only in canvas_utils.c
Signed-off-by: Frediano Ziglio
---
common/canvas_utils.c | 9 +
common/canvas_utils.h | 9 -
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/common/canvas_utils.c b/common/canvas_utils.c
index 0be761a..626f17d 100644
--
There's no reason to use a DIB section if we are going to use just the
memory in it assigned to a pixman surface, use normal path and memory.
Signed-off-by: Frediano Ziglio
---
common/canvas_utils.c | 105 --
1 file changed, 105 deletions(-)
diff
Signed-off-by: Frediano Ziglio
---
common/canvas_base.c | 36 ++--
common/canvas_utils.c | 7 +--
common/canvas_utils.h | 5 -
3 files changed, 7 insertions(+), 41 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 39439ed..d295
Now always NULL.
Signed-off-by: Frediano Ziglio
---
common/canvas_base.c | 17 -
common/canvas_utils.c | 19 +--
common/canvas_utils.h | 8
3 files changed, 1 insertion(+), 43 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index
On Wed, Jan 17, 2018 at 2:02 PM, Christophe Fergeau
wrote:
> hey,
>
> On Wed, Jan 17, 2018 at 12:15:03PM +0300, Oleg Ginzburg wrote:
> > Confirm - these changes work successfully, tested on: FreeBSD
> 11.1-RELEASE
> > and FreeBSD 12-CURRENT (aka HEAD).
> >
> > Will these changes be included in th
On Wed, Jan 17, 2018 at 2:18 PM, Oleg Ginzburg wrote:
>
>
> On Wed, Jan 17, 2018 at 2:02 PM, Christophe Fergeau
> wrote:
>
>> hey,
>>
>> On Wed, Jan 17, 2018 at 12:15:03PM +0300, Oleg Ginzburg wrote:
>> > Confirm - these changes work successfully, tested on: FreeBSD
>> 11.1-RELEASE
>> > and Free
Use a break to exit the loop instead of using a variable.
Signed-off-by: Frediano Ziglio
---
common/lz_decompress_tmpl.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/common/lz_decompress_tmpl.c b/common/lz_decompress_tmpl.c
index 04a5121..0189f86 100644
--- a/
Signed-off-by: Frediano Ziglio
---
common/lz.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/common/lz.c b/common/lz.c
index 28f450b..b7e7d48 100644
--- a/common/lz.c
+++ b/common/lz.c
@@ -90,7 +90,6 @@ typedef struct Encoder {
// (2) a pointer to the first byte in the segment th
Remove some conditional code always defining CAST_PLT_DISTANCE
macro.
Signed-off-by: Frediano Ziglio
---
common/lz_decompress_tmpl.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/common/lz_decompress_tmpl.c b/common/lz_decompress_tmpl.c
index 0189f86..d445c70
longjmp can happen in different places, even after the palette
is allocated so we need to free it if it got allocated.
Signed-off-by: Frediano Ziglio
---
common/canvas_base.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
ind
Instead of using spice_malloc+memcpy use spice_memdup which is
doing the same.
Signed-off-by: Frediano Ziglio
---
common/canvas_base.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 39439ed..f4f301c 100644
--- a/common/ca
Hi Frediano,
Some of those changes are a matter of style (e.g. remove variable).
Ack Series.
Thanks,
Uri.
On 01/17/2018 05:55 PM, Frediano Ziglio wrote:
Instead of using spice_malloc+memcpy use spice_memdup which is
doing the same.
Signed-off-by: Frediano Ziglio
---
common/canvas_base
22 matches
Mail list logo
