Re: [Spice-devel] [PATCH vdagent 2/2] vdagent: handle clipboard using GTK+

> On 7 Feb 2018, at 19:39, Jakub Janků wrote: > > Hi Christophe, > > On Wed, Feb 7, 2018 at 5:12 PM, Christophe de Dinechin > wrote: >> Hi Jakub, >> >> >> I have not looked at everything, but here are a few quick notes just from

Re: [Spice-devel] [PATCH vdagent 2/2] vdagent: handle clipboard using GTK+

Hi Christophe, On Wed, Feb 7, 2018 at 5:12 PM, Christophe de Dinechin wrote: > Hi Jakub, > > > I have not looked at everything, but here are a few quick notes just from > glancing… > >> On 21 Jan 2018, at 21:03, Jakub Janků wrote: >>

Re: [Spice-devel] [PATCH v2 09/13] Add mention of fall-through comments

> > > On 7 Feb 2018, at 14:58, Frediano Ziglio wrote: > > > >> > >> From: Christophe de Dinechin > >> > >> Signed-off-by: Christophe de Dinechin > >> --- > >> docs/spice_style.txt | 2 ++ > >> 1 file changed, 2 insertions(+) > >>

Re: [Spice-devel] RFC [spice-gtk] session: Allow to delay sending clipboard to the guest

> On 17 Jan 2018, at 11:16, Javier Celaya wrote: > > El vie, 12-01-2018 a las 08:05 -0500, Marc-André Lureau escribió: >> Hi >> >> - Original Message - >>> On Thu, Jan 11, 2018 at 12:35:36PM -0500, Marc-André Lureau wrote: > I agree with you that some

Re: [Spice-devel] [PATCH spice-common 0/8] Windows stuff cleanup

> On 7 Feb 2018, at 17:22, Christophe de Dinechin wrote: > > I may be wrong, but I don’t see this series in patchwork (I search based on > date). If that’s the case, any reason for this? Answering my own stupidity. The “Done” filter is not preserved when you go back in

Re: [Spice-devel] [PATCH spice-common 7/8] canvas: Unify __surface_create_stride and surface_create_stride

> On 17 Jan 2018, at 12:31, Frediano Ziglio wrote: > > They are now just the same function with same parameters, > just one calls the other. > > Signed-off-by: Frediano Ziglio > --- > common/canvas_utils.c | 12 +++- > 1 file changed, 3

Re: [Spice-devel] [PATCH spice-common 0/8] Windows stuff cleanup

I may be wrong, but I don’t see this series in patchwork (I search based on date). If that’s the case, any reason for this? Christophe > On 17 Jan 2018, at 12:31, Frediano Ziglio wrote: > > Remove obsolete stuff required for old GDI canvas. > Actually these stuff were not

Re: [Spice-devel] [PATCH vdagent 2/2] vdagent: handle clipboard using GTK+

Hi Jakub, I have not looked at everything, but here are a few quick notes just from glancing… > On 21 Jan 2018, at 21:03, Jakub Janků wrote: > > From: Jakub Janků > > Place the code that handles clipboard > into a separate file - clipboard.c >

Re: [Spice-devel] [PATCH] Proposed changes to the style guide

> On 7 Feb 2018, at 14:58, Lukáš Hrázký wrote: > > On Wed, 2018-02-07 at 14:44 +0100, Christophe de Dinechin wrote: >>> On 7 Feb 2018, at 12:12, Lukáš Hrázký wrote: >>> >>> On Wed, 2018-02-07 at 11:35 +0100, Christophe de Dinechin wrote: > On 7 Feb

Re: [Spice-devel] [PATCH v2 09/13] Add mention of fall-through comments

> On 7 Feb 2018, at 14:58, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> docs/spice_style.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git

Re: [Spice-devel] [PATCH] Proposed changes to the style guide

On Wed, 2018-02-07 at 14:44 +0100, Christophe de Dinechin wrote: > > On 7 Feb 2018, at 12:12, Lukáš Hrázký wrote: > > > > On Wed, 2018-02-07 at 11:35 +0100, Christophe de Dinechin wrote: > > > > On 7 Feb 2018, at 11:01, Frediano Ziglio wrote: > > > > > >

Re: [Spice-devel] [PATCH v2 09/13] Add mention of fall-through comments

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > docs/spice_style.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/spice_style.txt b/docs/spice_style.txt > index ccc60bb3..e35272ec 100644 > ---

Re: [Spice-devel] [PATCH] Proposed changes to the style guide

> On 7 Feb 2018, at 12:12, Lukáš Hrázký wrote: > > On Wed, 2018-02-07 at 11:35 +0100, Christophe de Dinechin wrote: >>> On 7 Feb 2018, at 11:01, Frediano Ziglio wrote: >>> From: Christophe de Dinechin

Re: [Spice-devel] [PATCH v2 07/13] Fix grammatical error

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > docs/spice_style.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/spice_style.txt b/docs/spice_style.txt > index 74f4e29d..a9d77afa

Re: [Spice-devel] [PATCH v2 10/13] Fix indentation in macro example

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > docs/spice_style.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/spice_style.txt b/docs/spice_style.txt > index e35272ec..780f0615

Re: [Spice-devel] [PATCH] Proposed changes to the style guide

On Wed, 2018-02-07 at 11:35 +0100, Christophe de Dinechin wrote: > > On 7 Feb 2018, at 11:01, Frediano Ziglio wrote: > > > > > > > > From: Christophe de Dinechin > > > > > > Signed-off-by: Christophe de Dinechin > > > --- > > >

[Spice-devel] [PATCH v2 03/13] Specify file extensions for C++ and Obj-C

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- docs/spice_style.txt | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index c127f026..72ed2ef7 100644 ---

[Spice-devel] [PATCH v2 02/13] Update copyright date

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- docs/spice_style.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index eb0e30ef..c127f026 100644 ---

[Spice-devel] [PATCH v2 09/13] Add mention of fall-through comments

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- docs/spice_style.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index ccc60bb3..e35272ec 100644 --- a/docs/spice_style.txt +++

[Spice-devel] [PATCH v2 05/13] Rephrase section about constants

From: Christophe de Dinechin The indent of the rephrasing is that: - If you have a single constant, use const, e.g. (visible in debugger) const unsigned max_stuff = 42; - If you have multiple constants, prefer enums over #define, as already suggested later in the

[Spice-devel] [PATCH v2 12/13] Add guidelines about warnings and whitespaces

From: Christophe de Dinechin The objective of these guidelines is that: - We avoid introducing new warnings - We know how to fix old ones - We don't have to isolate whitespace changes when submitting patches, i.e. someone who use tools that automatically strip whitespaces

[Spice-devel] [PATCH v2 01/13] Add .clang-format with defaults matching what's specified in the style guide

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- .clang-format | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 .clang-format diff --git a/.clang-format b/.clang-format new file mode 100644 index

[Spice-devel] [PATCH v2 10/13] Fix indentation in macro example

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- docs/spice_style.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index e35272ec..780f0615 100644 ---

[Spice-devel] [PATCH v2 11/13] Add mention of header guards

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- docs/spice_style.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index 780f0615..e2465aa9 100644 ---

[Spice-devel] [PATCH v2 06/13] Rephrase section on short functions for readability

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- docs/spice_style.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index 3e463d2f..74f4e29d 100644 ---

[Spice-devel] [PATCH v2 08/13] Remove confusing example

From: Christophe de Dinechin The sentence explaining that example makes no real sense, and the coding style suggestion is horrendous (not to mention flies in the face of all automatic indentation tools) Signed-off-by: Christophe de Dinechin ---

[Spice-devel] [PATCH v2 07/13] Fix grammatical error

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- docs/spice_style.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index 74f4e29d..a9d77afa 100644 ---

Re: [Spice-devel] [PATCH] Proposed changes to the style guide

> On 7 Feb 2018, at 11:01, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> docs/spice_style.txt | 113 >> --- >> 1

[Spice-devel] [PATCH spice-server v2] style: Update style to include some C++ element

These style are used by other SPICE projects like spice-streaming-agent. See discussion "Coding style and naming conventions for C++" at https://lists.freedesktop.org/archives/spice-devel/2018-January/041562.html. Signed-off-by: Frediano Ziglio --- docs/spice_style.txt | 54

Re: [Spice-devel] [PATCH] Proposed changes to the style guide

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > docs/spice_style.txt | 113 > --- > 1 file changed, 81 insertions(+), 32 deletions(-) > > diff --git

[Spice-devel] [PATCH] Proposed changes to the style guide

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- docs/spice_style.txt | 113 --- 1 file changed, 81 insertions(+), 32 deletions(-) diff --git a/docs/spice_style.txt

Re: [Spice-devel] [PATCH spice-server] style: Update style to include some C++ element

On Wed, 2018-02-07 at 10:10 +0100, Christophe de Dinechin wrote: > Frediano Ziglio writes: > > > These style are used by other SPICE projects like spice-streaming-agent. > > See discussion "Coding style and naming conventions for C++" at > >

Re: [Spice-devel] [PATCH spice-server] style: Update style to include some C++ element

> > Frediano Ziglio writes: > > > These style are used by other SPICE projects like spice-streaming-agent. > > See discussion "Coding style and naming conventions for C++" at > > https://lists.freedesktop.org/archives/spice-devel/2018-January/041562.html. > > > > Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH spice-server] style: Update style to include some C++ element

On Wed, 2018-02-07 at 10:10 +0100, Christophe de Dinechin wrote: > Frediano Ziglio writes: > > > These style are used by other SPICE projects like spice-streaming-agent. > > See discussion "Coding style and naming conventions for C++" at > >

Re: [Spice-devel] [PATCH spice-server] style: Update style to include some C++ element

Frediano Ziglio writes: > These style are used by other SPICE projects like spice-streaming-agent. > See discussion "Coding style and naming conventions for C++" at > https://lists.freedesktop.org/archives/spice-devel/2018-January/041562.html. > > Signed-off-by: Frediano Ziglio