Re: [Spice-devel] [PATCH v3 04/11] Rephrase assertion section

2018-02-12 Thread Frediano Ziglio
> > > On 12 Feb 2018, at 13:34, Frediano Ziglio wrote: > > > >>> > >>> On 12 Feb 2018, at 11:22, Frediano Ziglio wrote: > >>> > > > > On 12 Feb 2018, at 09:21, Frediano Ziglio wrote: > > > >> > >> From:

Re: [Spice-devel] [PATCH v3 04/11] Rephrase assertion section

2018-02-12 Thread Christophe de Dinechin
> On 12 Feb 2018, at 13:34, Frediano Ziglio wrote: > >>> >>> On 12 Feb 2018, at 11:22, Frediano Ziglio wrote: >>> > > On 12 Feb 2018, at 09:21, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin

Re: [Spice-devel] [PATCH spice-server v2] reds: Disable TLS 1.0

2018-02-12 Thread Victor Toso
Hey, - Original Message - > TLS 1.0 is considered now insecure. > TLS 1.1 was introduced in 2006. > Our SPICE clients uses OpenSSL to use TLS and the support for TLS 1.1 > in OpenSSL was introduced in 2006 too so even in systems like > Windows XP which are not officially supporting TLS

[Spice-devel] [PATCH spice-server v2] reds: Disable TLS 1.0

2018-02-12 Thread Frediano Ziglio
TLS 1.0 is considered now insecure. TLS 1.1 was introduced in 2006. Our SPICE clients uses OpenSSL to use TLS and the support for TLS 1.1 in OpenSSL was introduced in 2006 too so even in systems like Windows XP which are not officially supporting TLS 1.0 will work with SPICE and TLS 1.1. This

Re: [Spice-devel] [PATCH vdagent 2/2] vdagent: handle clipboard using GTK+

2018-02-12 Thread Victor Toso
Hi, On Sun, Jan 21, 2018 at 09:03:14PM +0100, Jakub Janků wrote: > From: Jakub Janků > > Place the code that handles clipboard > into a separate file - clipboard.c > --- > Makefile.am | 2 + > src/vdagent/clipboard.c | 401 >

Re: [Spice-devel] [PATCH spice-server v4 0/4] Better handling reset for streaming device

2018-02-12 Thread Lukáš Hrázký
On Sun, 2018-02-11 at 17:19 +0200, Uri Lublin wrote: > On 01/30/2018 04:33 PM, Christophe de Dinechin wrote: > > > > Christophe de Dinechin writes: > > > > > > On 30 Jan 2018, at 12:56, Frediano Ziglio wrote: > > > > > > > > > > > > > > Hi Frediano, > > > > > > > > > > >

Re: [Spice-devel] [RFC PATCH spice-streaming-agent v2] separate and encapsulate the agent business code

2018-02-12 Thread Lukáš Hrázký
On Mon, 2018-02-12 at 03:53 -0500, Frediano Ziglio wrote: > > > > Create an AgentRunner (TODO: needs a better name) class to encapsulate > > the streaming and communication with the server. The basic setup (cmd > > Also encapsulate command line interface (quite odd, does it make still > much

Re: [Spice-devel] [PATCH v3 04/11] Rephrase assertion section

2018-02-12 Thread Frediano Ziglio
> > > On 12 Feb 2018, at 11:22, Frediano Ziglio wrote: > > > >>> > >>> On 12 Feb 2018, at 09:21, Frediano Ziglio wrote: > >>> > > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin

[Spice-devel] [PATCH spice-server] reds: Disable TLS 1.0

2018-02-12 Thread Frediano Ziglio
TLS 1.0 is considered now insecure. TLS 1.1 was introduced in 2006. Our SPICE clients uses OpenSSL to use TLS and the support for TLS 1.1 in OpenSSL was introduced in 2006 too so even in systems like Windows XP which are not officially supporting TLS 1.0 will work with SPICE and TLS 1.1. This

Re: [Spice-devel] [PATCH v3 04/11] Rephrase assertion section

2018-02-12 Thread Christophe de Dinechin
> On 12 Feb 2018, at 11:22, Frediano Ziglio wrote: > >>> >>> On 12 Feb 2018, at 09:21, Frediano Ziglio wrote: >>> From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin

Re: [Spice-devel] [PATCH spice-server v4 0/4] Better handling reset for streaming device

2018-02-12 Thread Frediano Ziglio
> > > On 12 Feb 2018, at 09:04, Frediano Ziglio wrote: > > > >> > >> On 01/30/2018 04:33 PM, Christophe de Dinechin wrote: > >>> > >>> Christophe de Dinechin writes: > >>> > > On 30 Jan 2018, at 12:56, Frediano Ziglio wrote: > > > >> >

Re: [Spice-devel] [PATCH spice-server v4 0/4] Better handling reset for streaming device

2018-02-12 Thread Christophe de Dinechin
> On 12 Feb 2018, at 09:04, Frediano Ziglio wrote: > >> >> On 01/30/2018 04:33 PM, Christophe de Dinechin wrote: >>> >>> Christophe de Dinechin writes: >>> > On 30 Jan 2018, at 12:56, Frediano Ziglio wrote: > >> >> Hi Frediano,

Re: [Spice-devel] [PATCH vdagent 1/2] vdagent-x11: remove clipboard handling

2018-02-12 Thread Victor Toso
Hi, Follow up after the comment in the cover letter. On Sun, Jan 21, 2018 at 09:03:13PM +0100, Jakub Janků wrote: > From: Jakub Janků > > The code will be replaced by GTK+ in the following patch. > --- > src/vdagent/vdagent.c |7 - > src/vdagent/x11-priv.h | 91

Re: [Spice-devel] [PATCH v3 03/11] Specify file extensions for C++ and Obj-C

2018-02-12 Thread Frediano Ziglio
See https://lists.freedesktop.org/archives/spice-devel/2018-February/041724.html > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > docs/spice_style.txt | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-)

Re: [Spice-devel] [PATCH v3 07/11] Remove confusing example

2018-02-12 Thread Frediano Ziglio
See https://lists.freedesktop.org/archives/spice-devel/2018-February/041727.html > From: Christophe de Dinechin > > The sentence explaining that example makes no real sense, and > the coding style suggestion is horrendous (not to mention flies in the > face of all automatic

Re: [Spice-devel] [PATCH v3 04/11] Rephrase assertion section

2018-02-12 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > docs/spice_style.txt | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/docs/spice_style.txt b/docs/spice_style.txt > index

Re: [Spice-devel] [PATCH spice-server v4 0/4] Better handling reset for streaming device

2018-02-12 Thread Frediano Ziglio
> > On 01/30/2018 04:33 PM, Christophe de Dinechin wrote: > > > > Christophe de Dinechin writes: > > > >>> On 30 Jan 2018, at 12:56, Frediano Ziglio wrote: > >>> > > Hi Frediano, > > > > > On 30 Jan 2018, at 11:50, Frediano Ziglio