On 03/19/2018 06:46 PM, Frediano Ziglio wrote:
Handle capabilities from guest device.
Send capability to the guest when device is opened.
Currently there's no capabilities set on the message sent.
On the tests we need to discard the capability message before
reading the error.
Signed-off-by: Fre
On 03/20/2018 01:28 PM, Frediano Ziglio wrote:
Looks good, with minor nits.
On 19 Mar 2018, at 17:46, Frediano Ziglio wrote:
Handle capabilities from guest device.
Send capability to the guest when device is opened.
Currently there's no capabilities set on the message sent.
On the tests we n
This was true for virtual graphic cards, but not true for
device-assigned graphic cards.
For example NVIDIA M2000 has 8.
Still we currently pick only a single crtc for each output
(but looping over them to find an active one)
Signed-off-by: Uri Lublin
---
src/vdagent/x11-randr.c | 15 ++
>
> Looks good, with minor nits.
>
> > On 19 Mar 2018, at 17:46, Frediano Ziglio wrote:
> >
> > Handle capabilities from guest device.
> > Send capability to the guest when device is opened.
> > Currently there's no capabilities set on the message sent.
> > On the tests we need to discard the c
> > On 19 Mar 2018, at 11:39, Frediano Ziglio wrote:
> >
> >>
> >> On 03/13/2018 08:21 AM, Frediano Ziglio wrote:
> >>> Although not necessary for a single monitor DisplayChannel implementation
> >>> this make the DiisplayChannels more coherent from the client
> >>> point of view.
> >>>
> >>> S
> > On 19 Mar 2018, at 14:46, Frediano Ziglio wrote:
> >
> > Allow to enable code to do additional or expensive checks.
>
> “Allow to enable…” -> “Add configuration option enabling expensive checks”
>
We decided extra after researching on different projects.
I think extra is better, not only e
>
> If you have declared right types from the previous patch, is this really
> necessary?
>
Previous patch affects other code paths.
> > On 19 Mar 2018, at 11:06, Frediano Ziglio wrote:
> >
> > Use always 64, sizes can be 32x32.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > python_modu
>
> > On 19 Mar 2018, at 11:06, Frediano Ziglio wrote:
> >
> > Make code safe using both 32 and 64 bit machine.
> > Consider that this code can be compiled for machines with 32 bit.
> > There are some arrays length which are 32 bit.
> >
> > If size_t this can cause easily an overflow. For insta
If you have declared right types from the previous patch, is this really
necessary?
> On 19 Mar 2018, at 11:06, Frediano Ziglio wrote:
>
> Use always 64, sizes can be 32x32.
>
> Signed-off-by: Frediano Ziglio
> ---
> python_modules/demarshal.py | 14 ++
> python_modules/marshal.py
> On 19 Mar 2018, at 11:06, Frediano Ziglio wrote:
>
> Make code safe using both 32 and 64 bit machine.
> Consider that this code can be compiled for machines with 32 bit.
> There are some arrays length which are 32 bit.
>
> If size_t this can cause easily an overflow. For instance message_len
> On 19 Mar 2018, at 11:39, Frediano Ziglio wrote:
>
>>
>> On 03/13/2018 08:21 AM, Frediano Ziglio wrote:
>>> Although not necessary for a single monitor DisplayChannel implementation
>>> this make the DiisplayChannels more coherent from the client
>>> point of view.
>>>
>>> Signed-off-by: Fr
See my comments on the spice-common patch.
> On 19 Mar 2018, at 14:46, Frediano Ziglio wrote:
>
> Reuse option from common code.
> Also reuse spice_extra_checks constant instead of using the preprocessor
> macro directly.
>
> Signed-off-by: Frediano Ziglio
> ---
> configure.ac |
> On 19 Mar 2018, at 14:46, Frediano Ziglio wrote:
>
> Allow to enable code to do additional or expensive checks.
“Allow to enable…” -> “Add configuration option enabling expensive checks”
> The option should be used by higher level libraries.
> By default the option is disabled.
>
> Signed-
Looks good, with minor nits.
> On 19 Mar 2018, at 17:46, Frediano Ziglio wrote:
>
> Handle capabilities from guest device.
> Send capability to the guest when device is opened.
> Currently there's no capabilities set on the message sent.
> On the tests we need to discard the capability message
14 matches
Mail list logo
