[Spice-devel] [PATCH spice-streaming-agent] build: Use same options to compile unit tests

2018-04-23 Thread Frediano Ziglio
Unit test where not compiling with same options. In this case warnings are different producing different results. Signed-off-by: Frediano Ziglio --- src/unittests/Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/src/unittests/Makefile.am b/src/unittests/Makefile.am index 0fc6d

[Spice-devel] [PATCH spice-streaming-agent 3/4] Always log statistics

2018-04-23 Thread Frediano Ziglio
Allow to see frame size even if frame data is disabled. Useful to compute frame statistics not spending huge amount of space for frame data. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/spice-streami

[Spice-devel] [PATCH spice-streaming-agent 2/4] Enable line buffering instead of full buffering for the log

2018-04-23 Thread Frediano Ziglio
Allows to kill the process without losing log lines Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 56c1582..419ff3b 100644 --- a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH spice-streaming-agent 4/4] Add option to disable logging full frames

2018-04-23 Thread Frediano Ziglio
In some cases we want to avoid saving huge amount of data on the log. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 503c3b5..ab663cb 1

[Spice-devel] [PATCH spice-streaming-agent 1/4] Add some information to the log

2018-04-23 Thread Frediano Ziglio
Allows to track different frame timing. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 8b3f833..56c1582 100644 --- a/src/spice-streaming-agen

[Spice-devel] [PATCH spice-streaming-agent v2] Eliminate signed/unsigned warning

2018-04-23 Thread Frediano Ziglio
From: Christophe de Dinechin Currently -Wsign-compare is disabled by default in the default settings (m4/spice-compile-warnings.m4). However is good and not that expensive to remove this warning. Signed-off-by: Christophe de Dinechin Signed-off-by: Frediano Ziglio --- src/mjpeg-fallback.cpp |

Re: [Spice-devel] How to check if the spice-streaming-agent workscorrectly

2018-04-23 Thread Christophe Fergeau
On Mon, Apr 23, 2018 at 02:08:45PM +0200, Lukáš Hrázký wrote: > On Mon, 2018-04-23 at 19:22 +0800, 孙得霖 wrote: > > hi, > > @lhrazky > > host: > > qemu-kvm: 1.5.3 > > spice-server: 0.13.3 > > This is an old version of spice server. You need to build the current > git master of the server on

Re: [Spice-devel] How to check if the spice-streaming-agent workscorrectly

2018-04-23 Thread Lukáš Hrázký
On Mon, 2018-04-23 at 19:22 +0800, 孙得霖 wrote: > hi, > @lhrazky > host: > qemu-kvm: 1.5.3 > spice-server: 0.13.3 This is an old version of spice server. You need to build the current git master of the server on the host (note as Uri correctly commented the name of the virtio port was recen

Re: [Spice-devel] How to check if the spice-streaming-agent workscorrectly

2018-04-23 Thread 孙得霖
hi, @lhrazky host: qemu-kvm: 1.5.3 spice-server: 0.13.3 spcie-protocol: 0.12.12 client: remote-view: Virtual Machine Viewer 5.0-256(run in win7) ./src/spice-streaming-agent.ccp:static int have_something_to_read(int timeout) { struct pollfd pollfd = {streamfd, POLLIN, 0}; if (

Re: [Spice-devel] [PATCH spice-streaming-agent] Eliminate signed/unsigned warning

2018-04-23 Thread Christophe Fergeau
Hey, I believe my comment from https://lists.freedesktop.org/archives/spice-devel/2018-February/042062.html still apply, by default -Wno-sign-compare is in the CFLAGS/CXXFLAGS, so I'd mention in the log that you need to use non-default CXXFLAGS to hit this. Apart from this, looks good to me. Chri

Re: [Spice-devel] bad id bug in glz decoder

2018-04-23 Thread Usepr Xf
I found this code in glz_encoder.c in spice-server: static inline void encode_64(Encoder *encoder, uint64_t word) { encode_32(encoder, (uint32_t)(word >> 32)); encode_32(encoder, (uint32_t)(word & 0xff)); // <- is it wrong? 0xff should be deleted } On Fri, Apr 13, 2018 at

Re: [Spice-devel] How to check if the spice-streaming-agent works correctly

2018-04-23 Thread Uri Lublin
On 04/23/2018 10:48 AM, 孙得霖 wrote: Hello, I have some difficulties with spice-streaming-agent, can you help me. > when I run spice-streaming-agent, it can not read_command(have_something_to_read always return 0). ./src/spice-streaming-agent.ccp:static int have_something_to_read(int timeout)

[Spice-devel] [PATCH spice-server] glz-encoder: Do not discard top bits of lower part sending 64 bit ints

2018-04-23 Thread Frediano Ziglio
When GLZ code attempts to send a 64 bit integer the 8 top bit of the lower (32 bits) part of the number are stripped due to a bug. This was discovered by Zhongqiang Huang Reported-by: Zhongqiang Huang Signed-off-by: Frediano Ziglio --- server/glz-encoder.c | 2 +- 1 file changed, 1 insertion(

Re: [Spice-devel] How to check if the spice-streaming-agent works correctly

2018-04-23 Thread Lukáš Hrázký
On Mon, 2018-04-23 at 15:48 +0800, 孙得霖 wrote: > Hello, I have some difficulties with spice-streaming-agent, can you help me. > > > when I run spice-streaming-agent, it can not > read_command(have_something_to_read always return 0). > ./src/spice-streaming-agent.ccp:static int have_something_to_r

Re: [Spice-devel] [spice-gtk v1] spice-widget: remove old warning

2018-04-23 Thread Frediano Ziglio
> > > > > Hi, > > > > > > On 04/04/2018 06:31 PM, Victor Toso wrote: > > > From: Victor Toso > > > > > > This log was introduced in 13f5ebbf07a3 to track the situation where > > > the GdkCursor pointer would be invalid/NULL. That was possible if the > > > caller passed a NULL for rgba pointer

[Spice-devel] How to check if the spice-streaming-agent works correctly

2018-04-23 Thread 孙得霖
Hello, I have some difficulties with spice-streaming-agent, can you help me. when I run spice-streaming-agent, it can not read_command(have_something_to_read always return 0). ./src/spice-streaming-agent.ccp:static int have_something_to_read(int timeout) { struct pollfd pollfd = {streamfd, P

Re: [Spice-devel] [PATCH] build: fix template filenames in EXTRA_DIST

2018-04-23 Thread Frediano Ziglio
> > This seems to have been forgotten in > > dafc941 build: Rename spice-server-enums.tmpl.[ch] to > spice-server-enums.[ch].tmpl No, the Makefile.am was changed according in the right way. "make dist" is working file, cfr https://gitlab.com/spice/spice/commit/dafc941c761eeb9f6db607899a087f6bf

[Spice-devel] [PATCH] build: fix template filenames in EXTRA_DIST

2018-04-23 Thread Elvis Stansvik
This seems to have been forgotten in dafc941 build: Rename spice-server-enums.tmpl.[ch] to spice-server-enums.[ch].tmpl --- server/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/Makefile.am b/server/Makefile.am index 2fee378..f8765da 100644 --- a/serv