Re: [Spice-devel] [spice-gtk 1/3] build-sys: Disable -Wcast-function-type

On Thu, May 03, 2018 at 07:37:44AM -0400, Frediano Ziglio wrote: > > > > With gcc 8.0.1 from Fedora 28, I'm getting warnings related to > > -Wcast-function-type in a few places. Most of these could be solved > > by adding an intermediate wrapper with the right number of args, but the > >

Re: [Spice-devel] [spice-gtk 3/3] win32: Convert locale dir from UTF-8 to local encoding

On Thu, May 03, 2018 at 07:28:27AM -0400, Frediano Ziglio wrote: > > > > As indicated in gtk+ win32 gtk_get_localedir [1], bindtextdomain() is not > > UTF-8 aware on win32, so it needs a filename in locale encoding > > > > Stupid questions: what happens if the directory name has like

Re: [Spice-devel] [PATCH spice-gtk 1/3] Add support for building with meson

Hey, So I've experimented with this today, couple of comments/suggested improvements/fixes/missing things/... It might be worth to have some short document somewhere describing the meson/ninja equivalent for (at least) make CFLAGS="-Wno-error" ./configure (eg meson configure --prefix "/home/foo")

Re: [Spice-devel] [PATCH spice-streaming-agent 8/9] Encapsulate the stream port fd and locking

On Thu, 2018-05-03 at 07:35 -0400, Frediano Ziglio wrote: > > Wrap the streaming virtio port along with the mutex to lock it in a > > class. Pass the class temporarily around to functions that need it until > > the functions too are consolidated into the class. > > > > Signed-off-by: Lukáš Hrázký

Re: [Spice-devel] [spice-gtk 1/3] build-sys: Disable -Wcast-function-type

> > With gcc 8.0.1 from Fedora 28, I'm getting warnings related to > -Wcast-function-type in a few places. Most of these could be solved > by adding an intermediate wrapper with the right number of args, but the > g_source_set_callback() warning cannot be solved this way as the > callback

Re: [Spice-devel] [PATCH spice-streaming-agent 8/9] Encapsulate the stream port fd and locking

> Wrap the streaming virtio port along with the mutex to lock it in a > class. Pass the class temporarily around to functions that need it until > the functions too are consolidated into the class. > > Signed-off-by: Lukáš Hrázký The mutex is supposed to avoid situations

Re: [Spice-devel] [spice-gtk 3/3] win32: Convert locale dir from UTF-8 to local encoding

> > As indicated in gtk+ win32 gtk_get_localedir [1], bindtextdomain() is not > UTF-8 aware on win32, so it needs a filename in locale encoding > Stupid questions: what happens if the directory name has like Chines/Japanese characters and current locale is latin 1 kind of (like western

[Spice-devel] [spice-gtk 2/3] usb: Remove unused spice_marshaller_add_by_ref_full() user data

g_free() only expects a single argument, so it won't make use of the extra 'channel' arg which will be passed as user data. --- src/channel-usbredir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index f509e49d..0cc56306

[Spice-devel] [spice-gtk 3/3] win32: Convert locale dir from UTF-8 to local encoding

As indicated in gtk+ win32 gtk_get_localedir [1], bindtextdomain() is not UTF-8 aware on win32, so it needs a filename in locale encoding [1] https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/gtkwin32.c#L187 --- src/spice-glib-main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[Spice-devel] [spice-gtk 1/3] build-sys: Disable -Wcast-function-type

With gcc 8.0.1 from Fedora 28, I'm getting warnings related to -Wcast-function-type in a few places. Most of these could be solved by adding an intermediate wrapper with the right number of args, but the g_source_set_callback() warning cannot be solved this way as the callback signature will vary