On Wed, May 16, 2018 at 3:54 PM, Frediano Ziglio wrote:
>>
>> On Wed, May 16, 2018 at 10:46:35AM +0200, Christophe Fergeau wrote:
>> > On Wed, May 16, 2018 at 10:43:20AM +0200, Christophe Fergeau wrote:
>> > > On Wed, May 16, 2018 at 10:23:01AM +0300, Snir Sheriber wrote:
>> > > Yes, indeed, this
Thanks for pointing out the prefix thing with libvirt, and pointing me
to the correct mailing-list.
On 05/16/2018 05:01 AM, Daniel P. Berrangé wrote:
On Tue, May 15, 2018 at 10:27:32PM -0400, Adrian Lucrèce Céleste wrote:
I've hit a bit of a snag with virt-viewer. I've got it compiled, runnin
The Smartcard channel definition has been always broken.
Multiple client messages with the same ID are defined in the channel.
This cause on server demarshaller to only have last message defined,
while on the client marshaller code all message marshallers are
defined but client uses only header mes
On Wed, May 16, 2018 at 12:24:06PM -0400, Frediano Ziglio wrote:
> >
> > On Wed, May 16, 2018 at 11:04:17AM -0400, Frediano Ziglio wrote:
> > > >
> > > > On Mon, May 14, 2018 at 11:18:53PM +0100, Frediano Ziglio wrote:
> > > > > Make sure there are not 2 messages with the same name in the
> > > >
>
> Signed-off-by: Lukáš Hrázký
> ---
> src/unittests/.gitignore | 1 +
> src/unittests/Makefile.am | 9 -
> src/unittests/test-stream-port.cpp | 69
> ++
> 3 files changed, 78 insertions(+), 1 deletion(-)
> create mode 100644 src/un
>
> Introduces an exception hierarchy up to a ReadError class, which is
> thrown from read_all().
>
> Signed-off-by: Lukáš Hrázký
> ---
> src/Makefile.am | 2 ++
> src/error.cpp | 22 ++
> src/error.hpp | 37
Both versions are fine, unify for consistency. Use the optically less
verbose version.
Signed-off-by: Lukáš Hrázký
---
src/stream-port.cpp | 20 +++-
src/stream-port.hpp | 4 ++--
2 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/src/stream-port.cpp b/src/stream-p
Update the interface to not return the size written, as it is not needed
anymore.
Signed-off-by: Lukáš Hrázký
---
src/error.cpp | 1 -
src/error.hpp | 14 +
src/spice-streaming-agent.cpp | 48 +++
src/stream-por
Signed-off-by: Lukáš Hrázký
---
src/unittests/.gitignore | 1 +
src/unittests/Makefile.am | 9 -
src/unittests/test-stream-port.cpp | 69 ++
3 files changed, 78 insertions(+), 1 deletion(-)
create mode 100644 src/unittests/test-stream-
Changes since v1:
- Improved some commit log messages.
- Renamed errno_ to sys_errno.
- Used inheriting constructors for errors.
- Used std::runtime_error as predecessor of the Error class to handle
the message string.
- Cleaned up the terminators in the unit test :)
- Fixed a typo in the WriteEr
Introduces an exception hierarchy up to a ReadError class, which is
thrown from read_all().
Signed-off-by: Lukáš Hrázký
---
src/Makefile.am | 2 ++
src/error.cpp | 22 ++
src/error.hpp | 37 +
Use exceptions for errors, remove the inner loop in read_command, which
should practically never do more than one iteration. Handle EINTR from
poll and report nothing to read, relying on the enclosing loop to poll
for the command on the next iteration.
Signed-off-by: Lukáš Hrázký
---
src/spice-s
Unifies the reading from the virtio port, read_all() supports signals
and partial reads.
Signed-off-by: Lukáš Hrázký
---
src/spice-streaming-agent.cpp | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index
Wrap the streaming virtio port along with the mutex to lock it in a
class. Pass the class temporarily around to functions that need it until
the functions too are consolidated into the class.
The locking needs to be outside the class for now to prevent situations
like:
1 - data header
2 - cursor h
In blocking mode, the IO operations block indefinitely if the server
closes the virtio port on it's side. Change to non-blocking mode, so
that we can quit the streaming agent in case the port gets closed.
Signed-off-by: Lukáš Hrázký
---
src/error.hpp | 2 ++
src/spice-strea
This starts at the bottom and prepares for gradually moving more stuff
out of the main file.
Signed-off-by: Lukáš Hrázký
---
src/Makefile.am | 2 ++
src/spice-streaming-agent.cpp | 48 -
src/stream-port.cpp | 55 +++
>
> On Wed, May 16, 2018 at 11:04:17AM -0400, Frediano Ziglio wrote:
> > >
> > > On Mon, May 14, 2018 at 11:18:53PM +0100, Frediano Ziglio wrote:
> > > > Make sure there are not 2 messages with the same name in the
> > > > same channel.
> > > >
> > > > Signed-off-by: Frediano Ziglio
> > > > ---
On Wed, May 16, 2018 at 11:04:17AM -0400, Frediano Ziglio wrote:
> >
> > On Mon, May 14, 2018 at 11:18:53PM +0100, Frediano Ziglio wrote:
> > > Make sure there are not 2 messages with the same name in the
> > > same channel.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > python_modu
Code that handled client and server messages check was the same, just
changed some variable names.
Instead use a class to store same information and reuse the code.
This allows easier extension of the 2 path of code.
Signed-off-by: Frediano Ziglio
---
python_modules/ptypes.py | 68 ++
>
> On Mon, May 14, 2018 at 11:18:52PM +0100, Frediano Ziglio wrote:
> > Code that handled client and server messages check was the same, just
> > changed some variable names.
> > Instead use a class to store same information and reuse the code.
> > This allows easier extension of the 2 path of co
>
> On Mon, May 14, 2018 at 11:18:51PM +0100, Frediano Ziglio wrote:
> > The Smartcard channel definition has been always broken.
> > Multiple client messages with the same ID are defined in the channel.
> > This cause on server demarshaller to only have last message defined,
> > while on the clie
>
> On Mon, May 14, 2018 at 11:18:53PM +0100, Frediano Ziglio wrote:
> > Make sure there are not 2 messages with the same name in the
> > same channel.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > python_modules/ptypes.py | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/
Acked-by: Christophe Fergeau
On Mon, May 14, 2018 at 11:18:54PM +0100, Frediano Ziglio wrote:
> Make sure there are not 2 messages with the same value in the
> same channel.
>
> Signed-off-by: Frediano Ziglio
> ---
> python_modules/ptypes.py | 8
> 1 file changed, 8 insertions(+)
>
>
On Mon, May 14, 2018 at 11:18:53PM +0100, Frediano Ziglio wrote:
> Make sure there are not 2 messages with the same name in the
> same channel.
>
> Signed-off-by: Frediano Ziglio
> ---
> python_modules/ptypes.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/python_modules/ptypes.p
On Mon, May 14, 2018 at 11:18:52PM +0100, Frediano Ziglio wrote:
> Code that handled client and server messages check was the same, just
> changed some variable names.
> Instead use a class to store same information and reuse the code.
> This allows easier extension of the 2 path of code.
>
> Sign
On Mon, May 14, 2018 at 11:18:51PM +0100, Frediano Ziglio wrote:
> The Smartcard channel definition has been always broken.
> Multiple client messages with the same ID are defined in the channel.
> This cause on server demarshaller to only have last message defined,
> while on the client marshaller
Hi,
On 05/16/2018 05:16 PM, Frediano Ziglio wrote:
In case glimagesink is used (up to playbin) window system events
do not propagate to the widget. This patch tells the overlay not
to try handle window system events.
Which event? Did you had any issue? Kind of moving mouse/pressing keyboard
I
>
> In case glimagesink is used (up to playbin) window system events
> do not propagate to the widget. This patch tells the overlay not
> to try handle window system events.
>
Which event? Did you had any issue? Kind of moving mouse/pressing keyboard
I suppose
> Signed-off-by: Snir Sheriber
>
In case glimagesink is used (up to playbin) window system events
do not propagate to the widget. This patch tells the overlay not
to try handle window system events.
Signed-off-by: Snir Sheriber
---
src/channel-display-gst.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/channel-display
>
> On Wed, May 16, 2018 at 10:46:35AM +0200, Christophe Fergeau wrote:
> > On Wed, May 16, 2018 at 10:43:20AM +0200, Christophe Fergeau wrote:
> > > On Wed, May 16, 2018 at 10:23:01AM +0300, Snir Sheriber wrote:
> > > Yes, indeed, this is similar to what you were doing in earlier
> > > iterations
>
> On Wed, 2018-05-16 at 05:31 -0400, Frediano Ziglio wrote:
> > >
> > > On Tue, 2018-05-15 at 16:44 -0400, Frediano Ziglio wrote:
> > > > A bit more comment would be good. For instance why not unifying the
> > > > other
> > > > way
> > > > around?
> > >
> > > Well, the reason is this one seems
On Wed, 2018-05-16 at 05:43 -0400, Frediano Ziglio wrote:
> > On Tue, 2018-05-15 at 16:52 -0400, Frediano Ziglio wrote:
> > > A bit more comments.
> > >
> > > >
> > > > Signed-off-by: Lukáš Hrázký
> > > > ---
> > > > src/unittests/.gitignore | 1 +
> > > > src/unittests/Makefile.am
Hi
On Wed, May 16, 2018 at 12:16 PM, Marc-André Lureau
wrote:
> Hi
>
> On Wed, May 16, 2018 at 12:09 PM, Christophe Fergeau
> wrote:
>> On Wed, May 16, 2018 at 10:46:35AM +0200, Christophe Fergeau wrote:
>>> On Wed, May 16, 2018 at 10:43:20AM +0200, Christophe Fergeau wrote:
>>> > On Wed, May 16
From: Joel Purra
- It seems `SpiceDisplayConn` does not always have the array
`this.o.sc.streams` set.
- It also seems (stream?) images can be loaded before `streams` is set.
- Without `streams`, or the specific stream matching `this.o.id`,
`this.o.sc.streams[this.o.id].frames_loading` cannot b
Hi
On Wed, May 16, 2018 at 12:09 PM, Christophe Fergeau
wrote:
> On Wed, May 16, 2018 at 10:46:35AM +0200, Christophe Fergeau wrote:
>> On Wed, May 16, 2018 at 10:43:20AM +0200, Christophe Fergeau wrote:
>> > On Wed, May 16, 2018 at 10:23:01AM +0300, Snir Sheriber wrote:
>> > Yes, indeed, this is
On Wed, May 16, 2018 at 10:46:35AM +0200, Christophe Fergeau wrote:
> On Wed, May 16, 2018 at 10:43:20AM +0200, Christophe Fergeau wrote:
> > On Wed, May 16, 2018 at 10:23:01AM +0300, Snir Sheriber wrote:
> > Yes, indeed, this is similar to what you were doing in earlier
> > iterations.
> >
> > >
On Wed, 2018-05-16 at 05:31 -0400, Frediano Ziglio wrote:
> >
> > On Tue, 2018-05-15 at 16:44 -0400, Frediano Ziglio wrote:
> > > A bit more comment would be good. For instance why not unifying the other
> > > way
> > > around?
> >
> > Well, the reason is this one seems a bit cleaner and easier t
On Wed, 2018-05-16 at 05:46 -0400, Frediano Ziglio wrote:
> >
> > On Tue, 2018-05-15 at 16:42 -0400, Frediano Ziglio wrote:
> > > >
> > > > Update the interface to not return the size written, as it is not needed
> > > > anymore.
> > > >
> > > > Signed-off-by: Lukáš Hrázký
> > > > ---
> > > >
> On 16 May 2018, at 11:13, Lukáš Hrázký wrote:
>
> On Tue, 2018-05-15 at 16:42 -0400, Frediano Ziglio wrote:
>>>
>>> Update the interface to not return the size written, as it is not needed
>>> anymore.
>>>
>>> Signed-off-by: Lukáš Hrázký
>>> ---
>>> src/error.cpp | 3 ++-
>
On Wed, 2018-05-16 at 05:25 -0400, Frediano Ziglio wrote:
> >
> > On Tue, 2018-05-15 at 16:37 -0400, Frediano Ziglio wrote:
> > > >
> > > > Introduces an exception hierarchy up to a ReadError class, which is
> > > > thrown from read_all().
> > > >
> > > > Signed-off-by: Lukáš Hrázký
> > > > ---
> On 16 May 2018, at 11:25, Frediano Ziglio wrote:
>
>>
>> On Tue, 2018-05-15 at 16:37 -0400, Frediano Ziglio wrote:
Introduces an exception hierarchy up to a ReadError class, which is
thrown from read_all().
Signed-off-by: Lukáš Hrázký
---
src/Makefile.am
>
> On Tue, 2018-05-15 at 16:42 -0400, Frediano Ziglio wrote:
> > >
> > > Update the interface to not return the size written, as it is not needed
> > > anymore.
> > >
> > > Signed-off-by: Lukáš Hrázký
> > > ---
> > > src/error.cpp | 3 ++-
> > > src/error.hpp
> On Tue, 2018-05-15 at 16:52 -0400, Frediano Ziglio wrote:
> > A bit more comments.
> >
> > >
> > > Signed-off-by: Lukáš Hrázký
> > > ---
> > > src/unittests/.gitignore | 1 +
> > > src/unittests/Makefile.am | 9 -
> > > src/unittests/test-stream-port.cpp | 69
> > >
Hi,
On Wed, May 16, 2018 at 05:35:56PM +0800, dongzhen_...@nfschina.com wrote:
> hi，
> yes i use windows client and rebuild on fedora 28.
> if i rebuild spice-gtk on centos or redhat is this problem exit?
> do you mean this problem is caused by fedora gtk?
Likely. I'll start to bisect to see.
hi，
yes i use windows client and rebuild on fedora 28.
if i rebuild spice-gtk on centos or redhat is this problem exit?
do you mean this problem is caused by fedora gtk?
thank you very much!
dongzhen_...@nfschina.com
From: Victor Toso
Date: 2018-05-16 17:00
To: dongzhen_...@nfschina.com
CC: s
hi!
spice display unresponsive after host and VM sleep: GSpice-WARNING **: keyboard
grab failed 1
please can you help me?
dongzhen_...@nfschina.com
From: dongzhen_...@nfs-china.com
Date: 2018-04-19 15:58
To: Victor Toso
CC: spice-devel
Subject: [Spice-devel] spice-gtk redirection of USB
hi！
s
On Tue, 2018-05-15 at 16:52 -0400, Frediano Ziglio wrote:
> A bit more comments.
>
> >
> > Signed-off-by: Lukáš Hrázký
> > ---
> > src/unittests/.gitignore | 1 +
> > src/unittests/Makefile.am | 9 -
> > src/unittests/test-stream-port.cpp | 69
> > +
>
> On Tue, 2018-05-15 at 16:44 -0400, Frediano Ziglio wrote:
> > A bit more comment would be good. For instance why not unifying the other
> > way
> > around?
>
> Well, the reason is this one seems a bit cleaner and easier to read.
> Want me to put that in the commit message? :) Anything else? I
>
> On Tue, 2018-05-15 at 16:37 -0400, Frediano Ziglio wrote:
> > >
> > > Introduces an exception hierarchy up to a ReadError class, which is
> > > thrown from read_all().
> > >
> > > Signed-off-by: Lukáš Hrázký
> > > ---
> > > src/Makefile.am | 2 ++
> > > src/error.cpp
On Tue, 2018-05-15 at 16:44 -0400, Frediano Ziglio wrote:
> A bit more comment would be good. For instance why not unifying the other way
> around?
Well, the reason is this one seems a bit cleaner and easier to read.
Want me to put that in the commit message? :) Anything else? I don't
feel this ne
On Wed, 2018-05-16 at 11:08 +0200, Christophe de Dinechin wrote:
> > On 16 May 2018, at 10:59, Lukáš Hrázký wrote:
> >
> > On Tue, 2018-05-15 at 16:37 -0400, Frediano Ziglio wrote:
> > > >
> > > > Introduces an exception hierarchy up to a ReadError class, which is
> > > > thrown from read_all().
On Tue, 2018-05-15 at 16:42 -0400, Frediano Ziglio wrote:
> >
> > Update the interface to not return the size written, as it is not needed
> > anymore.
> >
> > Signed-off-by: Lukáš Hrázký
> > ---
> > src/error.cpp | 3 ++-
> > src/error.hpp | 14 +
>
> On 16 May 2018, at 10:59, Lukáš Hrázký wrote:
>
> On Tue, 2018-05-15 at 16:37 -0400, Frediano Ziglio wrote:
>>>
>>> Introduces an exception hierarchy up to a ReadError class, which is
>>> thrown from read_all().
>>>
>>> Signed-off-by: Lukáš Hrázký
>>> ---
>>> src/Makefile.am
On Tue, May 15, 2018 at 10:27:32PM -0400, Adrian Lucrèce Céleste wrote:
> I've hit a bit of a snag with virt-viewer. I've got it compiled, running,
> but whenever I try to connect to a remote instance, I always get this:
>
>
> [alc@xps org.virt_manager.virt-viewer]$ flatpak run
> org.virt_manager
Hi,
On Wed, May 16, 2018 at 09:24:23AM +0800, dongzhen_...@nfschina.com wrote:
> hi!
> spice display unresponsive after host and VM sleep: GSpice-WARNING **:
> keyboard grab failed 1
> please can you help me?
Hmmm, is that with windows client?
We have a bug for fedora where we are missing enter
On Tue, 2018-05-15 at 16:37 -0400, Frediano Ziglio wrote:
> >
> > Introduces an exception hierarchy up to a ReadError class, which is
> > thrown from read_all().
> >
> > Signed-off-by: Lukáš Hrázký
> > ---
> > src/Makefile.am | 2 ++
> > src/error.cpp | 29 +++
On Wed, May 16, 2018 at 10:43:20AM +0200, Christophe Fergeau wrote:
> On Wed, May 16, 2018 at 10:23:01AM +0300, Snir Sheriber wrote:
> > > > diff --git a/src/spice-widget.c b/src/spice-widget.c
> > > > index 73db593..251b29c 100644
> > > > --- a/src/spice-widget.c
> > > > +++ b/src/spice-widget.c
>
On Wed, May 16, 2018 at 10:23:01AM +0300, Snir Sheriber wrote:
> > > diff --git a/src/spice-widget.c b/src/spice-widget.c
> > > index 73db593..251b29c 100644
> > > --- a/src/spice-widget.c
> > > +++ b/src/spice-widget.c
> > > +static void* prepare_streaming_mode(SpiceChannel *channel, bool
> > > s
Hi,
On 04/19/2018 03:28 PM, Frediano Ziglio wrote:
display_queue is queued with decoded frames ready to be displayed.
However current code can insert a timeout before displaying and
removing the queued frames. As the frames are not compressed the
usage of memory by this queue can became in some
Hi,
On 05/15/2018 06:09 PM, Christophe Fergeau wrote:
On Wed, Apr 25, 2018 at 03:43:14PM +0300, Snir Sheriber wrote:
Currently when gstreamer is used to decode a full-screen
stream sent from the server, the decoding frames are being
forced to RBGA format and pushed using appsink to be scaled
a
60 matches
Mail list logo
