[Spice-devel] Question

2018-05-23 Thread Kihoon David Choi
Hello staffs and developers. I am completely new to the spice project. I am planning to use a thin client. If I am to use the solutions provided by your project, would I require a thin client that support spice protocol? Thank you. ___ Spice-devel maili

Re: [Spice-devel] [PATCH spice-common v3] codegen: Remove duplicate client and server code from ChannelType::resolve

2018-05-23 Thread Frediano Ziglio
ping > > Code that handled client and server messages check was the same, just > changed some variable names. > Instead use a class to store same information and reuse the code. > This allows easier extension of the 2 path of code. > > Signed-off-by: Frediano Ziglio > --- > python_modules/ptyp

[Spice-devel] [PATCH spice-streaming-agent v3 4/4] Add option to set logging categories

2018-05-23 Thread Frediano Ziglio
Allows to enable/disable different categories of logging. Currently disabling by default logging of full frame data which can take huge amount of log and allow to enable it if needed. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 15 ++- 1 file changed, 14 insert

[Spice-devel] [PATCH spice-streaming-agent v3 0/4] Add some logging support

2018-05-23 Thread Frediano Ziglio
Changes since v2: - consider --log-binary as a different format, do not mix with other informations; - do not enable line buffering for binary format. Frediano Ziglio (4): Add some information to the log Enable line buffering instead of full buffering for the log Always log statistics Ad

[Spice-devel] [PATCH spice-streaming-agent v3 3/4] Always log statistics

2018-05-23 Thread Frediano Ziglio
Allow to see frame size even if frame data is disabled. Useful to compute frame statistics not spending huge amount of space for frame data. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/spice-streaming-

[Spice-devel] [PATCH spice-streaming-agent v3 2/4] Enable line buffering instead of full buffering for the log

2018-05-23 Thread Frediano Ziglio
Allows to kill the process without losing log lines Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index b30e968..d4c4707 100644 --- a/src/spice-streaming-agent.

[Spice-devel] [PATCH spice-streaming-agent v3 1/4] Add some information to the log

2018-05-23 Thread Frediano Ziglio
Allows to track different frame timing. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 434489f..b30e968 100644 --- a/src/spice-streaming-agen

[Spice-devel] [PATCH spice-streaming-agent v3 1/5] Install udev rule

2018-05-23 Thread Frediano Ziglio
The udev rule is used to do some action when the device is added to the system. Current rule change the permission of the special file to allow to open it by any user. Some systems use /lib/udev while others use /usr/lib/udev. Allow to specify the full path to support both type of systems. Signed-

Re: [Spice-devel] [PATCH spice-common v3] codegen: Remove duplicate client and server code from ChannelType::resolve

2018-05-23 Thread Lukáš Hrázký
On Thu, 2018-05-17 at 13:49 +0100, Frediano Ziglio wrote: > Code that handled client and server messages check was the same, just > changed some variable names. > Instead use a class to store same information and reuse the code. > This allows easier extension of the 2 path of code. > > Signed-off-

[Spice-devel] [PATCH spice-gtk] channel-display: Avoid ABI incompatibility for streaming-mode signal

2018-05-23 Thread Frediano Ziglio
Changing SpiceDisplayChannelClass structure causes ABI incompatibility. Having a field for streaming-mode signal is not planned to be used so remove it. Signed-off-by: Frediano Ziglio --- src/channel-display.c | 4 +--- src/channel-display.h | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-

[Spice-devel] [spice-server] sound: Don't mute recording when client reconnects

2018-05-23 Thread Christophe Fergeau
When a new record channel is added, the code relies on a snd_send() call in record_channel_client_constructed() to send RECORD_START to the client. However, at this point, snd_send() is non-functional because the red_channel_client_pipe_add() call it makes is a no-op because prepare_pipe_add() make

Re: [Spice-devel] [spice-server] sound: Don't mute recording when client reconnects

2018-05-23 Thread Frediano Ziglio
> > When a new record channel is added, the code relies on a snd_send() call > in record_channel_client_constructed() to send RECORD_START to the > client. However, at this point, snd_send() is non-functional because > the red_channel_client_pipe_add() call it makes is a no-op because > prepare_pi

Re: [Spice-devel] [PATCH spice-common v2] Add support for building with meson/ninja

2018-05-23 Thread Frediano Ziglio
> > On Fri, 2018-05-18 at 11:57 -0300, Eduardo Lima (Etrunko) wrote: > > In a comparison with current autotools build system, meson/ninja > > provides a huge improvement in build speed, while keeping the same > > functionalities currently available and being considered more user > > friendly. > >

[Spice-devel] how to build win32/vd_agent?

2018-05-23 Thread pengyixiang
Hello, everyone ! I'm a new bird in windows/spice. I want to build vd_agent for win64, and I clone it from [1], then I run ./autogen.sh && make, but it failed, see [2], what should I do to build it? is there any document? [1] https://gitlab.freedesktop.org/spice/win32/vd_agent [2] $ m

Re: [Spice-devel] how to build win32/vd_agent?

2018-05-23 Thread Frediano Ziglio
> Hello, everyone ! > I'm a new bird in windows/spice. I want to build vd_agent for win64, and I > clone it from [1], > then I run ./autogen.sh && make, but it failed, see [2], what should I do to > build it? is there any document? > [1] > https://gitlab.freedesktop.org/spice/win32/vd_agent > [2]

Re: [Spice-devel] [PATCH spice-common v2] Add support for building with meson/ninja

2018-05-23 Thread Eduardo Lima (Etrunko)
On 23/05/18 09:05, Frediano Ziglio wrote: >> >> On Fri, 2018-05-18 at 11:57 -0300, Eduardo Lima (Etrunko) wrote: >>> In a comparison with current autotools build system, meson/ninja >>> provides a huge improvement in build speed, while keeping the same >>> functionalities currently available and be

[Spice-devel] [PATCH spice-common] fixup! meson build

2018-05-23 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 14 ++ meson_options.txt | 5 + 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 9d44604..cd75c51 100644 --- a/meson.build +++ b/meson.build @@ -90,11 +90,14 @@ endforeach

Re: [Spice-devel] [PATCH spice-common] fixup! meson build

2018-05-23 Thread Frediano Ziglio
> > Signed-off-by: Eduardo Lima (Etrunko) > --- > meson.build | 14 ++ > meson_options.txt | 5 + > 2 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/meson.build b/meson.build > index 9d44604..cd75c51 100644 > --- a/meson.build > +++ b/meson.build > @@ -9

Re: [Spice-devel] [PATCH spice-common v2] Add support for building with meson/ninja

2018-05-23 Thread Jonathon Jongsma
On Wed, 2018-05-23 at 11:24 -0300, Eduardo Lima (Etrunko) wrote: > > > > > > At the moment spice-common appears to require 2.22. Is there > > > something > > > we need from 2.46? If we do need to bump the version, it could > > > probably > > > be done in a separate commit from the meson patches? >

Re: [Spice-devel] [spice-server] sound: Don't mute recording when client reconnects

2018-05-23 Thread Frediano Ziglio
> > > > > When a new record channel is added, the code relies on a snd_send() call > > in record_channel_client_constructed() to send RECORD_START to the > > client. However, at this point, snd_send() is non-functional because > > the red_channel_client_pipe_add() call it makes is a no-op because

[Spice-devel] [PATCH spice-common] Bump glib requirements to 2.38

2018-05-23 Thread Eduardo Lima (Etrunko)
test-logging makes use of functions only available from this version ../tests/test-logging.c: In function ‘test_spice_abort_level’: ../tests/test-logging.c:50:5: error: ‘g_test_subprocess’ is deprecated: Not available before 2.38 [-Werror=deprecated-declarations] if (g_test_subprocess()) {

Re: [Spice-devel] [PATCH spice-common] fixup! meson build

2018-05-23 Thread Eduardo Lima (Etrunko)
On 23/05/18 11:43, Frediano Ziglio wrote: >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> meson.build | 14 ++ >> meson_options.txt | 5 + >> 2 files changed, 15 insertions(+), 4 deletions(-) >> >> diff --git a/meson.build b/meson.build >> index 9d44604..cd75c51 10064

Re: [Spice-devel] [PATCH spice-common] Bump glib requirements to 2.38

2018-05-23 Thread Frediano Ziglio
> > test-logging makes use of functions only available from this version > > ../tests/test-logging.c: In function ‘test_spice_abort_level’: > ../tests/test-logging.c:50:5: error: ‘g_test_subprocess’ is deprecated: Not > available before 2.38 [-Werror=deprecated-declarations] > if (g_test_sub

Re: [Spice-devel] [PATCH spice-common] fixup! meson build

2018-05-23 Thread Frediano Ziglio
> > Signed-off-by: Eduardo Lima (Etrunko) > --- > meson.build | 14 ++ > meson_options.txt | 5 + > 2 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/meson.build b/meson.build > index 9d44604..cd75c51 100644 > --- a/meson.build > +++ b/meson.build > @@ -9

Re: [Spice-devel] [spice-gtk] widget: avoid gdk_seat_grab/ungrab() API temporarily

2018-05-23 Thread Victor Toso
Hi Pavel, Thanks for taking time to review this one. On Tue, May 22, 2018 at 08:44:16PM +0200, Pavel Grunt wrote: > The intention of those commits was to be ready for new things > (wayland, gtk4... wait, actually gtk3). That side effect was > not desired... I'm not sure whether is better to reve

Re: [Spice-devel] Question

2018-05-23 Thread Victor Toso
Hi, On Tue, May 22, 2018 at 04:44:31PM -0400, Kihoon David Choi wrote: > Hello staffs and developers. > > I am completely new to the spice project. I am planning to use a thin > client. If I am to use the solutions provided by your project, would I > require a thin client that support spice protoc

Re: [Spice-devel] [PATCH spice-gtk] channel-display: Avoid ABI incompatibility for streaming-mode signal

2018-05-23 Thread Snir Sheriber
Hi, On 05/23/2018 12:44 PM, Frediano Ziglio wrote: Changing SpiceDisplayChannelClass structure causes ABI incompatibility. Having a field for streaming-mode signal is not planned to be used so remove it. Signed-off-by: Frediano Ziglio --- src/channel-display.c | 4 +--- src/channel-display