Re: [Spice-devel] [RFC/POC PATCH spice-gtk 12/16] Use the new output_id as display ID for the mouse motion event

On Tue, 2018-06-05 at 17:30 +0200, Lukáš Hrázký wrote: > If the output_id is set, it is the true xrandr guest ID to use for > the > mouse motion event. If it's not present, keep relying on the wacky > sequence of IDs of channel_id + monitor_id. > --- > src/spice-widget.c | 30 +

Re: [Spice-devel] Spice console pixelated noise on display changes

Hi, On Wed, Jun 13, 2018 at 10:11:00AM +0200, Mitja Mihelič wrote: > Dear all, > > We are running the following setup: > ovirt-engine host: > - CentOS release 7.5.1804 > - ovirt-engine-4.1.9.1-1.el7.centos.noarch > - spice-html5-0.1.7-1.el7.noarch > > We have noticed problems with the Spice consol

Re: [Spice-devel] [PATCH spice-server v3 2/2] stream-channel: Send the full frame in a single message

On Wed, 2018-06-13 at 07:13 -0400, Frediano Ziglio wrote: > > > > On Tue, 2018-06-12 at 13:30 +0200, Christophe Fergeau wrote: > > > Hey, > > > > > > On Wed, May 09, 2018 at 01:20:19PM +0200, Lukáš Hrázký wrote: > > > > On Wed, 2018-05-09 at 05:18 -0400, Frediano Ziglio wrote: > > > > > The agent

[Spice-devel] [PATCH spice-streaming-agent 0/9] More refactor and separation

Hello, a second batch of the streaming agent refactor follows. It moves out the FrameLog and the CursorUpdater and does most of the preparation to move out the main loop and the sending and receiving of messages. It doesn't contain all of the small fixes discussed/proposed previously (in c3d's pat

[Spice-devel] [PATCH spice-streaming-agent 8/9] Clean up the global try-catch block

Unify the error handling to use exceptions, narrowing down the exit spots for success/error to one each. Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-

[Spice-devel] [PATCH spice-streaming-agent 4/9] Improve the invalid option argument (-c) error message

Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index ca10d3b..d5ed034 100644 --- a/src/spice-streaming-agent.cpp +++ b/src/spice-streaming-agent.cpp @@

[Spice-devel] [PATCH spice-streaming-agent 2/9] FrameLog: Use std::chrono instead of gettimeofday for time

Signed-off-by: Lukáš Hrázký --- src/frame-log.cpp | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/frame-log.cpp b/src/frame-log.cpp index b0bd09e..4418d09 100644 --- a/src/frame-log.cpp +++ b/src/frame-log.cpp @@ -9,9 +9,9 @@ #include "error.hpp" #include "hexdu

[Spice-devel] [PATCH spice-streaming-agent 1/9] Separate the code for logging frames/times into a class

The FrameLog class provides RAII for the FILE and encapsulates the logging functionality. Signed-off-by: Lukáš Hrázký --- While I retained all the behaviour of the original implementation, I don't like it as it is. 1. The class is doing two different things: a) logging the binary frames for l

[Spice-devel] [PATCH spice-streaming-agent 9/9] Move out the cursor-updating code into it's own class

Wraps the code in a functor which can then be used in std::thread. Keeps the call to std::thread::detach() for now, as the thread actually cannot be properly joined. It spends most of the time blocking on XNextEvent() and there is no way of interrupting it. It seems XNextEvent() is acutally using

[Spice-devel] [PATCH spice-streaming-agent 7/9] Make the try-catch block in main() a catch-all

Extends the try-catch block to encompass all the business code in main(), making it a catch-all for all errors. Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 46 +-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/src/spice-stream

[Spice-devel] [PATCH spice-streaming-agent 3/9] Remove the arg_error macro

It doesn't help anything. Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index aef49c7..ca10d3b 100644 --- a/src/spice-streaming-agent.cpp +++ b/src

[Spice-devel] [PATCH spice-streaming-agent 6/9] Remove the logmask variable

The variable is unnecessary, we can pass the value straight to setlogmask(). Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 392936a..2bdfc3

[Spice-devel] [PATCH spice-streaming-agent 5/9] Introduce a short class to have RAII on the syslog

Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index d5ed034..392936a 100644 --- a/src/spice-streaming-agent.cpp +++ b/src/spice-s

Re: [Spice-devel] [PATCH spice-server v3 2/2] stream-channel: Send the full frame in a single message

> > On Tue, 2018-06-12 at 13:30 +0200, Christophe Fergeau wrote: > > Hey, > > > > On Wed, May 09, 2018 at 01:20:19PM +0200, Lukáš Hrázký wrote: > > > On Wed, 2018-05-09 at 05:18 -0400, Frediano Ziglio wrote: > > > > The agent send a single message, but reads/writes to the device are > > > > not a

[Spice-devel] Spice console pixelated noise on display changes

Dear all, We are running the following setup: ovirt-engine host: - CentOS release 7.5.1804 - ovirt-engine-4.1.9.1-1.el7.centos.noarch - spice-html5-0.1.7-1.el7.noarch We have noticed problems with the Spice console. When it opens and displays the information presented by the VM's console it is