>
> ACK series
>
> On Fri, 2018-07-06 at 17:44 +0200, Christophe Fergeau wrote:
> > g_abort() was only added in glib 2.50, which causes meson build
> > failures
> > since this defines GLIB_VERSION_MIN_REQUIRED/GLIB_VERSION_MAX_ALLOWED
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> >
This brings in the following changes:
Christophe Fergeau (19):
build: Update git.mk to latest version
build: Remove docs/.gitignore
build: Add __pycache__/*.pyc to DISTCLEANFILES
log: Only install glib log handler if SPICE_DEBUG_LEVEL is set
test-logging: Improve
ACK series
On Fri, 2018-07-06 at 17:44 +0200, Christophe Fergeau wrote:
> g_abort() was only added in glib 2.50, which causes meson build
> failures
> since this defines GLIB_VERSION_MIN_REQUIRED/GLIB_VERSION_MAX_ALLOWED
>
> Signed-off-by: Christophe Fergeau
> ---
> common/pixman_utils.c | 6
g_abort() was only added in glib 2.50, which causes meson build failures
since this defines GLIB_VERSION_MIN_REQUIRED/GLIB_VERSION_MAX_ALLOWED
Signed-off-by: Christophe Fergeau
---
common/pixman_utils.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
This is defined for the meson build, but not the autotools build. This
commit makes them consistent.
Signed-off-by: Christophe Fergeau
---
m4/spice-deps.m4 | 1 +
1 file changed, 1 insertion(+)
diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
index 61290fe..1721d34 100644
---
On Fri, Jul 06, 2018 at 05:33:45PM +0200, Christophe Fergeau wrote:
> Ok, g_abort() is only available in 2.50, and only the meson build uses
> GLIB_VERSION_MAX_ALLOWED. However, since this can be useful, I'd prefer
> that we keep GLIB_VERSION_MAX_ALLOWED, and add it to the autotools
> build. This
Ok, g_abort() is only available in 2.50, and only the meson build uses
GLIB_VERSION_MAX_ALLOWED. However, since this can be useful, I'd prefer
that we keep GLIB_VERSION_MAX_ALLOWED, and add it to the autotools
build. This specific issue can be fixed by using g_error() instead of
g_abort(). I'll
This was causing errors compiling pixman_utils.c:
../common/pixman_utils.c: In function 'spice_surface_format_to_pixman':
../common/pixman_utils.c:939:9: error: implicit declaration of function
'g_abort'; did you mean 'abort'? [-Werror=implicit-function-declaration]
g_abort();
On 06/07/18 03:20, Frediano Ziglio wrote:
>>
>> ACK series
>>
>
> For some reasons Meson build is failing, see
> https://gitlab.freedesktop.org/spice/spice-common/-/jobs/8351.
>
> I checked common/.deps/pixman_utils.Plo (autotool file dependencies)
> and there are GLib headers (don't ask me
Acked-by: Eduardo Lima (Etrunko)
On 06/07/18 10:03, Christophe Fergeau wrote:
> G_PID_FORMAT was only added in glib 2.50.
>
> Signed-off-by: Christophe Fergeau
> ---
> server/tests/replay.c | 1 +
> server/tests/test-glib-compat.h | 9 +
> 2 files changed, 10 insertions(+)
>
G_PID_FORMAT was only added in glib 2.50.
Signed-off-by: Christophe Fergeau
---
server/tests/replay.c | 1 +
server/tests/test-glib-compat.h | 9 +
2 files changed, 10 insertions(+)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index 40fd10b69..bd9420b8c 100644
Acked the entire series.
note that this patch is much shorter without space changes.
>
> ---
> Hopfully it's clear to understand the separation i did here without
> re-numbering:/
> ---
> src/channel-display-gst.c | 35 +--
> 1 file changed, 21 insertions(+), 14
>
> ACK series
>
For some reasons Meson build is failing, see
https://gitlab.freedesktop.org/spice/spice-common/-/jobs/8351.
I checked common/.deps/pixman_utils.Plo (autotool file dependencies)
and there are GLib headers (don't ask me where they came from)
Frediano
> On Tue, 2018-07-03 at
> Sounds like you don't support that address at all?
> When first subscribing to the list, confirmation and welcome messages -along
> with basic usage instructions- came from that address!
> And in the basic instructions it's mentioned one can change settings *either*
> through web interface
>
> Acked-by: Jonathon Jongsma
>
As a follow up of these patches I think an update to spice-common
submodule hash in spice-server/spice-gtk would be helpful.
Frediano
>
> On Tue, 2018-07-03 at 12:42 +0200, Christophe Fergeau wrote:
> > Signed-off-by: Christophe Fergeau
> > ---
> >
15 matches
Mail list logo
