On Tue, Jul 10, 2018 at 9:55 PM, Jonathon Jongsma
wrote:
> On Tue, 2018-07-10 at 18:00 +0200, Victor Toso wrote:
> > Hi,
> >
> > Similarly to closing github spice mirror [0], I'd like to propose
> > closing the gitlab.com/spice one now that we have a gitlab
> > instance in gitlab.freedesktop.org
On Tue, 2018-07-10 at 18:00 +0200, Victor Toso wrote:
> Hi,
>
> Similarly to closing github spice mirror [0], I'd like to propose
> closing the gitlab.com/spice one now that we have a gitlab
> instance in gitlab.freedesktop.org
>
> [0] https://lists.freedesktop.org/archives/spice-devel/2018-June/
On Tue, 2018-07-10 at 17:10 +0200, Lukáš Hrázký wrote:
> On Tue, 2018-07-10 at 09:20 -0500, Jonathon Jongsma wrote:
> > On Tue, 2018-07-10 at 10:47 +0200, Lukáš Hrázký wrote:
> > > On Mon, 2018-07-09 at 16:53 -0500, Jonathon Jongsma wrote:
> > > > Apologies for the delay in replying to this email.
Hi,
Similarly to closing github spice mirror [0], I'd like to propose
closing the gitlab.com/spice one now that we have a gitlab
instance in gitlab.freedesktop.org
[0] https://lists.freedesktop.org/archives/spice-devel/2018-June/043884.html
The main reason is consistency...
The steps would be s
Still not working as of today.
Any news about it by any chance?
Thanks again.
2018-07-06 1:14 GMT-05:00 Frediano Ziglio :
>
> Sounds like you don't support that address at all?
>
> When first subscribing to the list, confirmation and welcome messages
> -along with basic usage instructions- came
Hi,
On Tue, Jul 10, 2018 at 08:25:50PM +0800, molo wrote:
> hi,
>I am sorry to trouble you！
Don't be!
>We encountered the problem of video picture jam in the
>process of using the spice protocol, and the audio and video
>out of sync problem also appeared in the drag and drop
>
On Tue, 2018-07-10 at 09:20 -0500, Jonathon Jongsma wrote:
> On Tue, 2018-07-10 at 10:47 +0200, Lukáš Hrázký wrote:
> > On Mon, 2018-07-09 at 16:53 -0500, Jonathon Jongsma wrote:
> > > Apologies for the delay in replying to this email. It's an
> > > excellent
> > > summary of the options.
> > >
>
Hi all,
the refactor continues, in this series I introduce the InboundMessage
and OutboundMessage classes for the StreamPort I/O.
2/3 is heavily based on a previously posted patch by Christophe de
Dinechin. It is a carbon copy for the important parts, though I changed a
lot of small details and s
Wraps the deserialization of the received messages in an InboundMessages
class. The class is created with the deserialized header and the raw
data of the message. A template function get_payload() returns the
struct of the concrete message. The function is specialized for each
incoming message.
Wh
Replaces the polling function with a generic class that allows to
register multiple file descriptors for polling, along with a callback to
call when an event occurs on the descriptor.
The patch also effectively replaces the while loop which was in
read_command. The loop only ever looped more than
Heavily based on code by Christophe de Dinechin.
Wraps the serialization code in the OutboundMessage class and its
descendants for each specific message. Uses Cruiously Recurring Template
Pattern (CRTP) to avoid runtime overhead of polymorphism.
The messages are placed along with the code that se
On Tue, 2018-07-10 at 10:47 +0200, Lukáš Hrázký wrote:
> On Mon, 2018-07-09 at 16:53 -0500, Jonathon Jongsma wrote:
> > Apologies for the delay in replying to this email. It's an
> > excellent
> > summary of the options.
> >
> > On Tue, 2018-06-26 at 15:34 +0200, Lukáš Hrázký wrote:
> > > Hi all,
On 10/07/18 07:31, Frediano Ziglio wrote:
>>
>> On Tue, Jul 10, 2018 at 04:51:35AM -0400, Frediano Ziglio wrote:
On Tue, Jul 10, 2018 at 07:21:50AM +0100, Frediano Ziglio wrote:
> test-overflow was doing a specific test on demarshalling code.
> Joining the 2 tests also allows to r
Check we have enough data before reading.
This could lead to read buffer overflows being undetected.
This is not a security issue, read happens only in the client not causing
any information leakage, maximum can generate a crash or some garbage on
the screen.
Signed-off-by: Frediano Ziglio
---
c
The 2 APIs are equivalent.
Some minor coherence changes:
- remove line terminator, already added;
- start message with lower case;
- LZ4, not Lz4.
Signed-off-by: Frediano Ziglio
---
common/canvas_base.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git
hi,
I am sorry to trouble you??
We encountered the problem of video picture jam in the process of using the
spice protocol, and the audio and video out of sync problem also appeared in
the drag and drop player window. When trying to solve the problem, we changed
the encoding method from mj
This avoids compilers detect misaligned access which can lead to
warnings.
In QEMU the structure is allocated at the beginning of a 4Kb page,
in Xspice is allocated with a calloc, so the structure will end up 4
bytes aligned as well with these users. We are not aware of other users
of QXLRam, but i
On Tue, Jul 10, 2018 at 06:28:34AM -0400, Frediano Ziglio wrote:
> >
> > On Mon, Jul 09, 2018 at 04:48:46AM -0400, Frediano Ziglio wrote:
> > > >
> > > > On Tue, Jul 03, 2018 at 11:38:56AM -0400, Frediano Ziglio wrote:
> > > > > >
> > > > > > On Thu, Jun 28, 2018 at 09:43:47PM +0100, Frediano Zi
On Tue, 2018-07-10 at 06:09 -0400, Frediano Ziglio wrote:
> >
> > On Mon, 2018-07-09 at 05:21 -0400, Frediano Ziglio wrote:
> > > >
> > > > Pass the pointer to X cursor struct directly instead of using a lambda
> > > > to fill in the pixels.
> > > >
> > > > Signed-off-by: Lukáš Hrázký
> > > > -
>
> On Tue, Jul 10, 2018 at 04:51:35AM -0400, Frediano Ziglio wrote:
> > >
> > > On Tue, Jul 10, 2018 at 07:21:50AM +0100, Frediano Ziglio wrote:
> > > > test-overflow was doing a specific test on demarshalling code.
> > > > Joining the 2 tests also allows to remove the dependency from the main
>
>
> On Mon, Jul 09, 2018 at 04:48:46AM -0400, Frediano Ziglio wrote:
> > >
> > > On Tue, Jul 03, 2018 at 11:38:56AM -0400, Frediano Ziglio wrote:
> > > > >
> > > > > On Thu, Jun 28, 2018 at 09:43:47PM +0100, Frediano Ziglio wrote:
> > > > > > This avoids compilers detect misaligned access.
> > >
>
> On Mon, 2018-07-09 at 05:21 -0400, Frediano Ziglio wrote:
> > >
> > > Pass the pointer to X cursor struct directly instead of using a lambda
> > > to fill in the pixels.
> > >
> > > Signed-off-by: Lukáš Hrázký
> > > ---
> > > src/cursor-updater.cpp | 28 ++--
> > >
On Mon, Jul 09, 2018 at 04:48:46AM -0400, Frediano Ziglio wrote:
> >
> > On Tue, Jul 03, 2018 at 11:38:56AM -0400, Frediano Ziglio wrote:
> > > >
> > > > On Thu, Jun 28, 2018 at 09:43:47PM +0100, Frediano Ziglio wrote:
> > > > > This avoids compilers detect misaligned access.
> > > >
> > > > May
On Tue, Jul 10, 2018 at 04:51:35AM -0400, Frediano Ziglio wrote:
> >
> > On Tue, Jul 10, 2018 at 07:21:50AM +0100, Frediano Ziglio wrote:
> > > test-overflow was doing a specific test on demarshalling code.
> > > Joining the 2 tests also allows to remove the dependency from the main
> > > protocol
>
> Hey,
>
> This is the v2 of the patches sent by Frediano, split/reordered with
> better commit logs. The only new patch is 09/15 "quic: Wrap
> declaration/call of quic method in" which replaces the CHANNEL_
> CHANNEL_ARGS_ macros which were in the initial series.
>
> Christophe
>
Tested and
From: Frediano Ziglio
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic_rgb_tmpl.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/common/quic_rgb_tmpl.c b/common/quic_rgb_tmpl.c
index e0a05ca..2e76645 100644
--- a/common/quic_rg
From: Frediano Ziglio
This makes them identical to their counterparts in quic_rgb_tmpl.c
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic_tmpl.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/common/quic_tmpl.c b/common/quic_tm
From: Frediano Ziglio
Use a APPLY_ALL_COMP macro to unify single/multiple channel processing.
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic_rgb_tmpl.c | 58 +-
common/quic_tmpl.c | 30 --
2 file
From: Frediano Ziglio
Define COMPRESS_xx/UNCOMPRESS_xx macros in a more similar way between
quic_tmpl.c and quic_rgb_tmpl.c using channel suffixes. Instead of
having #define COMPRESS(channel) do_something(channel), we'll now have
#define COMPRESS(channel) do_something(channel_##channel), and cal
From: Frediano Ziglio
This helps making the code in quic_tmpl.c and quic_rgb_tmpl.c more
similar.
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic_tmpl.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/common/quic_tmpl.c b/common/
From: Frediano Ziglio
This will help to unify quic_tmpl.c and quic_rgb_tmpl.c
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic_tmpl.c | 44 +---
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/common/quic_
From: Frediano Ziglio
Define and reuse a COPY_PIXEL macro to copy a pixel.
This will help in making quic_tmpl.c and quic_rgb_tmpl.c identical.
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic_rgb_tmpl.c | 9 ++---
common/quic_tmpl.c | 5 -
2 files c
This allows to pass an additional 'channel' argument when needed, and
should eventually let us unify quic_tmpl.c and quic_rgb_tmpl.c
Signed-off-by: Christophe Fergeau
---
common/quic_rgb_tmpl.c | 122 ---
common/quic_tmpl.c | 126 +-
From: Frediano Ziglio
This commit reorders the macro declarations at the beginning of
quic_tmpl.c and quic_rgb_tmpl.c so that they follow a similar order.
This does the same for the #undef at the end of both file.
This commit is only code movement, and should not add/remove anything
which was not
From: Frediano Ziglio
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic.c | 21 -
common/quic_rgb_tmpl.c | 6 +++---
common/quic_tmpl.c | 6 +++---
3 files changed, 6 insertions(+), 27 deletions(-)
diff --git a/common/quic.c b/
From: Frediano Ziglio
Now that the 2 template files are the same (except for whitespace differences),
we can use a single file.
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/Makefile.am | 1 -
common/quic.c | 8 +-
common/quic_rgb_tmpl.c | 669 --
From: Frediano Ziglio
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic_rgb_tmpl.c | 42 +-
common/quic_tmpl.c | 17 ++---
2 files changed, 27 insertions(+), 32 deletions(-)
diff --git a/common/quic_rgb_tmp
From: Frediano Ziglio
They will help unify quic_rgb_tmpl.c and quic_tmpl.c
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic_rgb_tmpl.c | 59 --
common/quic_tmpl.c | 34 ++--
2 files changed, 44 ins
From: Frediano Ziglio
This commit adds a common block of macro declarations at the top of
quic_tmpl.c and quic_rgb_tmpl.c. This block is identical between the 2
files, and is one big step towards making the 2 files identical.
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
Hey,
This is the v2 of the patches sent by Frediano, split/reordered with
better commit logs. The only new patch is 09/15 "quic: Wrap
declaration/call of quic method in" which replaces the CHANNEL_
CHANNEL_ARGS_ macros which were in the initial series.
Christophe
___
From: Frediano Ziglio
These macros were added to quic_tmpl.c in 815223861 but without the
corresponding #undef. This commit adds them for consistency.
Signed-off-by: Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
common/quic_tmpl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/
>
> On Tue, Jul 10, 2018 at 07:21:50AM +0100, Frediano Ziglio wrote:
> > test-overflow was doing a specific test on demarshalling code.
> > Joining the 2 tests also allows to remove the dependency from the main
> > protocol allowing to run the test independently from generation setting.
>
>
>
>
On Mon, Jul 09, 2018 at 11:41:55AM +0100, Frediano Ziglio wrote:
> This flag disable some compiler feature which is used by some system header
> potentially introducing some limitations.
> Autotools won't add any flag to limit compiler features to C99, instead it
> currently only add flags to suppo
On Tue, Jul 10, 2018 at 07:21:50AM +0100, Frediano Ziglio wrote:
> test-overflow was doing a specific test on demarshalling code.
> Joining the 2 tests also allows to remove the dependency from the main
> protocol allowing to run the test independently from generation setting.
> This is useful w
On Mon, 2018-07-09 at 16:53 -0500, Jonathon Jongsma wrote:
> Apologies for the delay in replying to this email. It's an excellent
> summary of the options.
>
> On Tue, 2018-06-26 at 15:34 +0200, Lukáš Hrázký wrote:
> > Hi all,
> >
> > after posting the PoC patch series for the monitors_config rew
45 matches
Mail list logo
