[Spice-devel] [spice-html5] display: Dump bitmap metadata in log_draw()

2018-07-12 Thread Christophe Fergeau
log_draw() is used to debug drawing commands by dumping drawing information to the JS console. This commit adds dumping of missing data for uncompressed bitmaps. The 'stride' parameter is important, as spice-html5 currently does not deal properly with such bitmaps. Signed-off-by: Christophe Fergea

Re: [Spice-devel] Spice console pixelated noise on display changes

2018-07-12 Thread Christophe Fergeau
Hey, On Wed, Jul 11, 2018 at 10:45:08AM +0200, Mitja Mihelič wrote: > Answering the question for posterity. > We found a temporary solution to the described problem. > We had an oVirt development cluster with a working SPICE console. By > comparing packages we have established the differences betw

Re: [Spice-devel] Ongoing migration: gitlab.com/spice -> gitlab.freedesktop.org/spice

2018-07-12 Thread Victor Toso
Hi, JFYI, CC'ing: * qemu-devel * virt-tools-list * de...@ovirt.org If nobody complains, I'll finish whatever is pending next Monday morning (GMT+2). Cheers, toso On Thu, Jul 12, 2018 at 02:12:43PM +0200, Victor Toso wrote: > Hi, > > The official repository for Spice components should

Re: [Spice-devel] [PATCH spice-server] reds: Free device chain in spice_server_destroy to avoid leaks

2018-07-12 Thread Eduardo Lima (Etrunko)
On 11/07/18 13:30, Frediano Ziglio wrote: > Leak detectors did not manage to find leaks, possibly as double list > have all elements likely with a pointer to them. > The reference from the agent is necessary for inserting it into > the list. > > Signed-off-by: Frediano Ziglio > --- > server/reds

[Spice-devel] Windows vdagent false-positive detection of trojan by McAffee

2018-07-12 Thread Alm, Robert 2
Hi, Just to inform you - My corporate McAffee virus protection seem to identify vdagent for windows as a Trojan named "Artemis".. and If I try installing a newer version of vdagent it identifies as another Trojan "RDN/Generic.RP"... This makes me believe that some part of the binary has a resem

[Spice-devel] Ongoing migration: gitlab.com/spice -> gitlab.freedesktop.org/spice

2018-07-12 Thread Victor Toso
Hi, The official repository for Spice components should stay in gitlab.freedesktop.org/spice - As suggested in the previous thread [0], instead of closing gitlab.com/spice we can keep it read-only mirror from Freedesktop's gitlab instance. [0] https://lists.freedesktop.org/archives/spice-devel/20

Re: [Spice-devel] [PATCH spice-server] red-stream-device: Fix leaks in dispose and finalize chaining parent

2018-07-12 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Wed, Jul 11, 2018 at 04:37:14PM +0100, Frediano Ziglio wrote: > dispose and finalize methods have to call parent relative > cleanup method to avoid leaking resources. > > Signed-off-by: Frediano Ziglio > --- > server/red-stream-device.c | 4 > 1 file change

[Spice-devel] [spice-gtk] If replace me, should nod do refcount plus one

2018-07-12 Thread Victor Toso
From: 乐义华 https://gitlab.freedesktop.org/spice/spice-gtk/issues/72 --- src/channel-display.c | 5 - src/spice-channel-cache.h | 8 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/channel-display.c b/src/channel-display.c index 44ba043..138cd8c 100644 --- a/src