> >
> > >
> > > From: 乐义华
> > >
> > > https://gitlab.freedesktop.org/spice/spice-gtk/issues/72
> > > ---
> > > src/channel-display.c | 5 -
> > > src/spice-channel-cache.h | 8
> > > 2 files changed, 12 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/src/channel-display
On 12/07/2018 18:01, Christophe Fergeau wrote:
Hey,
On Wed, Jul 11, 2018 at 10:45:08AM +0200, Mitja Mihelič wrote:
Answering the question for posterity.
We found a temporary solution to the described problem.
We had an oVirt development cluster with a working SPICE console. By
comparing packa
From: 乐义华
When an image with SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME is received the
reference counter should stay the same to avoid the cache to grow
continously.
This fixes https://gitlab.freedesktop.org/spice/spice-gtk/issues/72
Signed-off-by: 乐义华
Signed-off-by: Frediano Ziglio
---
src/channel
>
> The main channel reference d->main of SpiceWidget is initialized on
> construction. However, it is used a couple of times before that moment
> while setting the default values of some properties, like resize-guest.
> This results in some annoying critical log messages. This commit makes
> sure
spice-html5 does not support multiple display channels, and will only
use the first one offered by spice-server, and ignore the others. This
can cause issues when using a VM with a configured but unused
org.spice-space.stream.0 spice port as this will create a 'fake' display
channel which is offere
On Mon, Jul 16, 2018 at 10:03:23AM -0500, Jeremy White wrote:
> Hey Christophe,
>
> On 07/12/2018 11:07 AM, Christophe Fergeau wrote:
> > log_draw() is used to debug drawing commands by dumping drawing
> > information to the JS console. This commit adds dumping of missing data
> > for uncompressed
On Tue, Jul 17, 2018 at 08:17:53AM +0100, Frediano Ziglio wrote:
> From: 乐义华
>
> When an image with SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME is received the
> reference counter should stay the same to avoid the cache to grow
> continously.
>
> This fixes https://gitlab.freedesktop.org/spice/spice-gtk/
On Tue, Jul 17, 2018 at 07:57:54AM +0100, Frediano Ziglio wrote:
> No need to pass a generic pointer.
>
This is also used as a callback:
spice_g_signal_connect_object(d->session, "channel-new",
G_CALLBACK(channel_new), display, 0);
and the 'expected' type for
From: Christophe de Dinechin
Clang complains about:
1. [[noreturn]] used on implementation instead of header
2. errno used without
Details:
clang complains about [[noreturn]] not being on the first declaration.
cursor-updater.cpp:77:3: error: function declared '[[noreturn]]' after its
first
On Tue, 2018-07-17 at 14:10 +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Clang complains about:
> 1. [[noreturn]] used on implementation instead of header
> 2. errno used without
>
> Details:
>
> clang complains about [[noreturn]] not being on the first declaration.
OK, I have modified it.
From 87be8732bf36038c9ba9faabb1aae58f7b830d05 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=B9=90=E4=B9=89=E5=8D=8E?=
Date: Thu, 12 Jul 2018 13:16:53 +0800
Subject: [PATCH] Fix image cache memory usage
When image flag is SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME, and if found it
Hello list
I have a special scenario where I cannot get the VDAgent to run
correctly. We are migrating a physical setup to virtual, with Ubuntu
booting by PXE from a SLES server. Then, an X session is started with
XDMCP, so that the X server runs in the virtual Ubuntu guest and the X
clients run i
>
> spice-html5 does not support multiple display channels, and will only
> use the first one offered by spice-server, and ignore the others. This
> can cause issues when using a VM with a configured but unused
> org.spice-space.stream.0 spice port as this will create a 'fake' display
> channel wh
diff --git a/display.js b/display.js
index 7719b23..c55b686 100644
--- a/display.js
+++ b/display.js
@@ -769,6 +769,12 @@ SpiceDisplayConn.prototype.log_draw = function(prefix,
draw)
str += "; src_bitmap type " + draw.data.src_bitmap.descriptor.type +
", flags " + draw.data.src_bi
No need to pass a generic pointer.
Avoid SpiceDisplay* -> gpointer* -> gpointer -> SpiceDisplay* cast
chain.
Signed-off-by: Frediano Ziglio
---
src/spice-widget.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
Changes since v1:
- merge 2 small patches changing pointer argu
On Tue, Jul 17, 2018 at 09:00:33AM -0500, Jeremy White wrote:
> > > > diff --git a/display.js b/display.js
> > > > index 7719b23..c55b686 100644
> > > > --- a/display.js
> > > > +++ b/display.js
> > > > @@ -769,6 +769,12 @@ SpiceDisplayConn.prototype.log_draw =
> > > > function(prefix, draw)
> > >
spice-html5 does not support multiple display channels, and will only
use the first one offered by spice-server, and ignore the others. This
can cause issues when using a VM with a configured but unused
org.spice-space.stream.0 spice port as this will create a 'fake' display
channel which is offere
On Tue, Jul 17, 2018 at 09:51:28AM -0400, Frediano Ziglio wrote:
> >
> > spice-html5 does not support multiple display channels, and will only
> > use the first one offered by spice-server, and ignore the others. This
> > can cause issues when using a VM with a configured but unused
> > org.spice-
log_draw() is used to debug drawing commands by dumping drawing
information to the JS console. This commit adds dumping of missing data
for uncompressed bitmaps. The 'stride' parameter is important, as
spice-html5 currently does not deal properly with such bitmaps.
Signed-off-by: Christophe Fergea
Signed-off-by: Lukáš Hrázký
---
server/dcc-send.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index 79c3d48b..e19ee19c 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -2294,7 +2294,7 @@ static void marshall_monitors_config(Re
Signed-off-by: Lukáš Hrázký
---
src/channel-display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/channel-display.c b/src/channel-display.c
index 993d9b7..54f40ba 100644
--- a/src/channel-display.c
+++ b/src/channel-display.c
@@ -1896,9 +1896,9 @@ static void displ
As an independent step in the monitors_config series, the SpiceHead::id
can be renamed to monitor_id.
Note the spice-server and spice-gtk patches should contain an update to
the spice-common submodule referencing the commit that does the rename,
so that the repository is in a consistent state. I'm
The id is called 'monitor_id' throughout the rest of the code, rename
for clarity and consistency.
Signed-off-by: Lukáš Hrázký
---
common/messages.h | 2 +-
spice.proto | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/messages.h b/common/messages.h
index 4fc03d
The pointer is not updated to the last byte used so using it
to compute the bytes written into the buffer we ignore some bytes
causing some image corruptions.
Note that also free_in_buffer is not updated to last written byte.
When buf_empty_output_buffer is called the buffer is full so use the
size
>
> The id is called 'monitor_id' throughout the rest of the code, rename
> for clarity and consistency.
>
> Signed-off-by: Lukáš Hrázký
> ---
> common/messages.h | 2 +-
> spice.proto | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/messages.h b/common/
>
> As an independent step in the monitors_config series, the SpiceHead::id
> can be renamed to monitor_id.
>
> Note the spice-server and spice-gtk patches should contain an update to
> the spice-common submodule referencing the commit that does the rename,
> so that the repository is in a consis
From: Christophe de Dinechin
The [[noreturn]] attribute must be visible from call sites.
This is a hard error in clang:
cursor-updater.cpp:77:3: error: function declared '[[noreturn]]' after its
first declaration
[[noreturn]] void CursorUpdater::operator()()
^
./cursor-updater.hpp:24:10: note:
From: Christophe de Dinechin
Using errno requires . Some platforms/compilers
are stricter than others in this respect.
frame-log.cpp:27:96: error: use of undeclared identifier 'errno'
throw Error(std::string("Failed to open log file '") + log_name +
"': " + strerror(errno));
Signed-
From: Christophe de Dinechin
Christophe de Dinechin (2):
Fix clang build error on [[noreturn]]
Fix clang build error on missing
src/cursor-updater.cpp | 2 +-
src/cursor-updater.hpp | 2 +-
src/frame-log.cpp | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
--
2.13.5 (Apple Git
This brings in the following changes:
Christophe Fergeau (20):
build: Update git.mk to latest version
build: Remove docs/.gitignore
build: Add __pycache__/*.pyc to DISTCLEANFILES
log: Only install glib log handler if SPICE_DEBUG_LEVEL is set
test-logging: Improve debu
Acked-by: Jeremy White
On 07/17/2018 10:18 AM, Christophe Fergeau wrote:
log_draw() is used to debug drawing commands by dumping drawing
information to the JS console. This commit adds dumping of missing data
for uncompressed bitmaps. The 'stride' parameter is important, as
spice-html5 currentl
On Tue, 2018-07-17 at 17:10 +0100, Frediano Ziglio wrote:
> This brings in the following changes:
>
> Christophe Fergeau (20):
> build: Update git.mk to latest version
> build: Remove docs/.gitignore
> build: Add __pycache__/*.pyc to DISTCLEANFILES
> log: Only install glib
32 matches
Mail list logo
