Re: [Spice-devel] [PATCH spice-common] ci: Fix typo: celt501 -> celt051

2018-07-19 Thread Uri Lublin
On 07/19/2018 08:17 PM, Eduardo Lima (Etrunko) wrote: Fixes the following warning message while running meson: WARNING: Unknown command line options: "celt501" This will become a hard error in a future Meson release. Signed-off-by: Eduardo Lima (Etrunko) Ack. Uri --- .gitlab-ci.yml | 2

[Spice-devel] [PATCH spice-common] ci: Fix typo: celt501 -> celt051

2018-07-19 Thread Eduardo Lima (Etrunko)
Fixes the following warning message while running meson: WARNING: Unknown command line options: "celt501" This will become a hard error in a future Meson release. Signed-off-by: Eduardo Lima (Etrunko) --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab

Re: [Spice-devel] [spice-server 3/3] dcc: Fix QUIC fallback in get_compression_for_bitmap()

2018-07-19 Thread Christophe Fergeau
On Thu, Jul 19, 2018 at 11:35:54AM -0400, Frediano Ziglio wrote: > Would be great to have a test case for this. > As the image was uncompressed this possibly affected also > network usage :-( Yes, tried to measure network bandwidth before/after this patch, and when this bug triggers, it seemed net

Re: [Spice-devel] VDAgent and XDMCP

2018-07-19 Thread Uri Lublin
On 07/17/2018 04:05 PM, Javier Celaya wrote: Hello list I have a special scenario where I cannot get the VDAgent to run correctly. We are migrating a physical setup to virtual, with Ubuntu booting by PXE from a SLES server. Then, an X session is started with XDMCP, so that the X server runs i

Re: [Spice-devel] [spice-server 3/3] dcc: Fix QUIC fallback in get_compression_for_bitmap()

2018-07-19 Thread Frediano Ziglio
> > There was a small regression introduced in get_compression_for_bitmap() > by f401eb07f dcc: Rewrite dcc_image_compress. > If SPICE_IMAGE_COMPRESSION_AUTO_GLZ is specified, and the bitmap has a > stride which is bigger than its width (ie it has padding), then > get_compression_for_bitmap() will

Re: [Spice-devel] [spice-server 2/3] dcc: Rework COMPRESS_DEBUG macro

2018-07-19 Thread Frediano Ziglio
> > On 07/19/2018 03:54 PM, Christophe Fergeau wrote: > > Rather than using > > #ifdef COMPRESS_DEBUG > > spice_info(...); > > #endif > > > > we can #define COMPRESS_DEBUG to spice_info() or nothing for a slight > > readability improvement. This opportunity is used to replace these > > sp

Re: [Spice-devel] [spice-server 2/3] dcc: Rework COMPRESS_DEBUG macro

2018-07-19 Thread Uri Lublin
On 07/19/2018 03:54 PM, Christophe Fergeau wrote: Rather than using #ifdef COMPRESS_DEBUG spice_info(...); #endif we can #define COMPRESS_DEBUG to spice_info() or nothing for a slight readability improvement. This opportunity is used to replace these spice_info() calls with g_message().

Re: [Spice-devel] [spice-server] reds: Call sasl_server_done() when destroying SpiceServer instance

2018-07-19 Thread Christophe Fergeau
On Thu, Jul 19, 2018 at 10:18:47AM -0400, Frediano Ziglio wrote: > > > > > > > > This call will free most of the memory allocated by sasl_server_init(). > > > It's refcounted so should be safe to call from a library. > > > --- > > > server/reds.c | 1 + > > > 1 file changed, 1 insertion(+) > > >

Re: [Spice-devel] [spice-server] reds: Call sasl_server_done() when destroying SpiceServer instance

2018-07-19 Thread Frediano Ziglio
> > > > > This call will free most of the memory allocated by sasl_server_init(). > > It's refcounted so should be safe to call from a library. > > --- > > server/reds.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/server/reds.c b/server/reds.c > > index 85043a88d..e195ce611 1

Re: [Spice-devel] [spice-server] reds: Call sasl_server_done() when destroying SpiceServer instance

2018-07-19 Thread Frediano Ziglio
> > This call will free most of the memory allocated by sasl_server_init(). > It's refcounted so should be safe to call from a library. > --- > server/reds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/server/reds.c b/server/reds.c > index 85043a88d..e195ce611 100644 > --- a/server/

Re: [Spice-devel] [spice-server 1/3] dcc: Improve can_lz_compress() comment

2018-07-19 Thread Frediano Ziglio
> > Both glz_encode and lz_encode error out if the bitmap stride does not > match the bitmap width. > --- > server/dcc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/dcc.c b/server/dcc.c > index a5d2b344a..44d8fdd75 100644 > --- a/server/dcc.c > +++ b/server/dc

Re: [Spice-devel] [spice-server] worker: Fix 'seemless' typo in comment

2018-07-19 Thread Frediano Ziglio
> > --- > server/red-worker.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red-worker.c b/server/red-worker.c > index 721b1c843..ccab9d960 100644 > --- a/server/red-worker.c > +++ b/server/red-worker.c > @@ -1339,7 +1339,7 @@ RedWorker* red_worker_new(QXLInstan

Re: [Spice-devel] [spice-server 2/3] dcc: Rework COMPRESS_DEBUG macro

2018-07-19 Thread Frediano Ziglio
> > Rather than using > #ifdef COMPRESS_DEBUG >spice_info(...); > #endif > > we can #define COMPRESS_DEBUG to spice_info() or nothing for a slight > readability improvement. This opportunity is used to replace these > spice_info() calls with g_message(). Why not compress_debug at this poin

[Spice-devel] [spice-server 2/3] dcc: Rework COMPRESS_DEBUG macro

2018-07-19 Thread Christophe Fergeau
Rather than using #ifdef COMPRESS_DEBUG spice_info(...); #endif we can #define COMPRESS_DEBUG to spice_info() or nothing for a slight readability improvement. This opportunity is used to replace these spice_info() calls with g_message(). --- server/image-encoders.c | 27 -

[Spice-devel] [spice-server] worker: Fix 'seemless' typo in comment

2018-07-19 Thread Christophe Fergeau
--- server/red-worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-worker.c b/server/red-worker.c index 721b1c843..ccab9d960 100644 --- a/server/red-worker.c +++ b/server/red-worker.c @@ -1339,7 +1339,7 @@ RedWorker* red_worker_new(QXLInstance *qxl, g_objec

[Spice-devel] [spice-server 1/3] dcc: Improve can_lz_compress() comment

2018-07-19 Thread Christophe Fergeau
Both glz_encode and lz_encode error out if the bitmap stride does not match the bitmap width. --- server/dcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/dcc.c b/server/dcc.c index a5d2b344a..44d8fdd75 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -759,7 +759,7 @@

[Spice-devel] [spice-server 3/3] dcc: Fix QUIC fallback in get_compression_for_bitmap()

2018-07-19 Thread Christophe Fergeau
There was a small regression introduced in get_compression_for_bitmap() by f401eb07f dcc: Rewrite dcc_image_compress. If SPICE_IMAGE_COMPRESSION_AUTO_GLZ is specified, and the bitmap has a stride which is bigger than its width (ie it has padding), then get_compression_for_bitmap() will return SPICE

[Spice-devel] [spice-server] reds: Call sasl_server_done() when destroying SpiceServer instance

2018-07-19 Thread Christophe Fergeau
This call will free most of the memory allocated by sasl_server_init(). It's refcounted so should be safe to call from a library. --- server/reds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/reds.c b/server/reds.c index 85043a88d..e195ce611 100644 --- a/server/reds.c +++ b/server/r

Re: [Spice-devel] how to set usb read-only transfer mode

2018-07-19 Thread Christophe Fergeau
Hey, On Thu, Jul 19, 2018 at 01:54:18PM +0900, 김갑용 wrote: > hi > > i'm downloading version spice-gtk 0.34 and it is under development. > If you redirect usb, you want to set it to read-only mode. > But libusb, usbdk seems to have no way. Is there a way to set this up? If your goal is to force t

Re: [Spice-devel] [PATCH spice-server 0/5] Improve stream device test

2018-07-19 Thread Christophe Fergeau
For the series, Acked-by: Christophe Fergeau On Fri, Jul 13, 2018 at 08:33:13PM +0100, Frediano Ziglio wrote: > Multiple test and improvement to test, also minor fix to the device itself. > > Frediano Ziglio (5): > red-stream-device: Fix and check empty data messages > test-stream-device: Ch

Re: [Spice-devel] Spice console pixelated noise on display changes

2018-07-19 Thread Christophe Fergeau
On Tue, Jul 17, 2018 at 09:15:05AM +0200, Mitja Mihelič wrote: > > > On 12/07/2018 18:01, Christophe Fergeau wrote: > > Hey, > > > > On Wed, Jul 11, 2018 at 10:45:08AM +0200, Mitja Mihelič wrote: > > > Answering the question for posterity. > > > We found a temporary solution to the described pro

Re: [Spice-devel] VDAgent and XDMCP

2018-07-19 Thread Christophe Fergeau
Dey, On Tue, Jul 17, 2018 at 03:05:30PM +0200, Javier Celaya wrote: > Hello list > > I have a special scenario where I cannot get the VDAgent to run > correctly. We are migrating a physical setup to virtual, with Ubuntu > booting by PXE from a SLES server. Then, an X session is started with > XDM

Re: [Spice-devel] [vdagent-win PATCH v6] Use GetModuleHandle to get some functions from user32 library

2018-07-19 Thread Christophe Fergeau
Still unconvinced about that one ;) But Acked-by: Christophe Fergeau if you feel this is the way to go. Christophe On Wed, Jul 18, 2018 at 11:52:45AM +0100, Frediano Ziglio wrote: > The library is surely already loaded as providing clipboard and > other utilities we need. > user32 is one of the

Re: [Spice-devel] [vdagent-win PATCH v6] vdagent: Add a comment around WinSta0_DesktopSwitch event usage

2018-07-19 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Wed, Jul 18, 2018 at 11:52:46AM +0100, Frediano Ziglio wrote: > Multiple times while I was reading this code was not clear why the > synchronization of this event was not done in the main event loop. > Also document why we want to use it not relying just on > WTSR

Re: [Spice-devel] [PATCH spice-common v2] spice*.proto: Replace tabs with the appropriate number of spaces

2018-07-19 Thread Christophe Fergeau
Fine with me, Acked-by: Christophe Fergeau (I checked with git diff -w that it's only whitespace changes) On Thu, Jul 19, 2018 at 10:47:11AM +0200, Lukáš Hrázký wrote: > Plus a few other indentation fixes. > > Signed-off-by: Lukáš Hrázký > --- > Changes since v1: > - Fixed a few other indentati

[Spice-devel] how to set usb read-only transfer mode

2018-07-19 Thread 김갑용
hi i'm downloading version spice-gtk 0.34 and it is under development. If you redirect usb, you want to set it to read-only mode. But libusb, usbdk seems to have no way. Is there a way to set this up? thanks ___ Spice-devel mailing list Spice-devel@lis

Re: [Spice-devel] [PATCH spice-streaming-agent] jpeg: Do not use next_output_byte buf_empty_output_buffer

2018-07-19 Thread Victor Toso
Hi, On Wed, Jul 18, 2018 at 12:02:16PM +0300, Uri Lublin wrote: > On 07/17/2018 06:28 PM, Frediano Ziglio wrote: > > Hi Frediano, > > > The pointer is not updated to the last byte used so using it > > to compute the bytes written into the buffer we ignore some bytes > > causing some image corrup

Re: [Spice-devel] How to make USB auto redirec

2018-07-19 Thread Snir Sheriber
Hi, On 07/19/2018 11:07 AM, 王杰东 wrote: /Recently i try the remote-viewer6.0 on Windows with parameter : --spice-usbredir-auto-redirect-filter="///0x03,-1,-1,-1,0|-1,-1,-1,-1,1/", i want my usb auto redirect to VM except Mouse and keyboard, but it never works. / /then i run remote-viewer.exe

[Spice-devel] [PATCH spice-common v2] spice*.proto: Replace tabs with the appropriate number of spaces

2018-07-19 Thread Lukáš Hrázký
Plus a few other indentation fixes. Signed-off-by: Lukáš Hrázký --- Changes since v1: - Fixed a few other indentation errors spice.proto | 622 +-- spice1.proto | 432 +-- 2 files changed, 527 insertions(+), 527 de

[Spice-devel] How to make USB auto redirec

2018-07-19 Thread 王杰东
Recently i try the remote-viewer6.0 on Windows with parameter : --spice-usbredir-auto-redirect-filter="0x03,-1,-1,-1,0|-1,-1,-1,-1,1", i want my usb auto redirect to VM except Mouse and keyboard, but it never works. then i run remote-viewer.exe with paremeter: --spice-usbredir-redirect-on-conn