Re: [Spice-devel] Regarding next Spice drivers release

2018-09-17 Thread Victor Toso
Hi Carlos, On Mon, Sep 17, 2018 at 07:45:43PM -0500, Carlos González wrote: > With all due apologies beforehand, but after re-reading this thread > https://lists.freedesktop.org/archives/spice-devel/2018-August/045216.html > and checking the Spice Space downloads site, I'm not sure how to

Re: [Spice-devel] [spice-gtk] widget: Send all smooth-scroll events to the guest

2018-09-17 Thread Victor Toso
Hi, On Mon, Sep 17, 2018 at 06:37:08PM +0200, Christophe Fergeau wrote: > On Fri, Sep 14, 2018 at 02:25:39PM +0200, Victor Toso wrote: > > From: Victor Toso > > > > Introduced in 2212f05145c5f1d5, smooth-scroll events were taking > > inconsideration that the delta_y value received by

Re: [Spice-devel] Regarding next Spice drivers release

2018-09-17 Thread Carlos González
With all due apologies beforehand, but after re-reading this thread https://lists.freedesktop.org/archives/spice-devel/2018-August/045216.html and checking the Spice Space downloads site, I'm not sure how to understand it, whether spice-server 0.14.1 has already been released, and if it has,

Re: [Spice-devel] [spice-gtk v4 03/13] cd-sharing: implement cd-device for Windows

2018-09-17 Thread Yuri Benditovich
On Mon, Sep 17, 2018 at 10:03 PM, Frediano Ziglio wrote: > > > > Added implementation of system-dependent operations > > defined in cd-device.h for Windows > > > > Signed-off-by: Yuri Benditovich > > --- > > src/cd-device-win.c | 193 > > >

Re: [Spice-devel] [spice-gtk v4 02/13] cd-sharing: implement cd-device for Linux

2018-09-17 Thread Yuri Benditovich
On Mon, Sep 17, 2018 at 9:47 PM, Frediano Ziglio wrote: > > > > Added implementation of system-dependent operations > > defined in cd-device.h for Linux > > > > Signed-off-by: Yuri Benditovich > > --- > > src/cd-device-linux.c | 137 > > ++ > >

Re: [Spice-devel] [spice-gtk v4 01/13] cd-sharing: add cd-device header file

2018-09-17 Thread Yuri Benditovich
On Mon, Sep 17, 2018 at 9:37 PM, Frediano Ziglio wrote: > > > > Contains definitions for system-dependent operations > > related to local cd devices and files > > > > Signed-off-by: Yuri Benditovich > > --- > > src/cd-device.h | 40 > > 1 file changed,

Re: [Spice-devel] [spice-gtk v4 03/13] cd-sharing: implement cd-device for Windows

2018-09-17 Thread Frediano Ziglio
> > Added implementation of system-dependent operations > defined in cd-device.h for Windows > > Signed-off-by: Yuri Benditovich > --- > src/cd-device-win.c | 193 > > 1 file changed, 193 insertions(+) > create mode 100644

Re: [Spice-devel] [spice-gtk v4 02/13] cd-sharing: implement cd-device for Linux

2018-09-17 Thread Frediano Ziglio
> > Added implementation of system-dependent operations > defined in cd-device.h for Linux > > Signed-off-by: Yuri Benditovich > --- > src/cd-device-linux.c | 137 > ++ > 1 file changed, 137 insertions(+) > create mode 100644

Re: [Spice-devel] [spice-gtk v4 01/13] cd-sharing: add cd-device header file

2018-09-17 Thread Frediano Ziglio
> > Contains definitions for system-dependent operations > related to local cd devices and files > > Signed-off-by: Yuri Benditovich > --- > src/cd-device.h | 40 > 1 file changed, 40 insertions(+) > create mode 100644 src/cd-device.h > > diff --git

Re: [Spice-devel] [spice-gtk] display: Trigger wheel scrolling after one 'click'

2018-09-17 Thread Marc-André Lureau
On Mon, Sep 17, 2018 at 8:41 PM Christophe Fergeau wrote: > > The scroll wheel on the mouse will trigger a smooth scroll event with a > delta of +/-1.0. The code added in 2212f05 triggers a scroll when the > delta is strictly greater than 1.0. This means that right after > connecting a client, we

[Spice-devel] [spice-gtk] display: Trigger wheel scrolling after one 'click'

2018-09-17 Thread Christophe Fergeau
The scroll wheel on the mouse will trigger a smooth scroll event with a delta of +/-1.0. The code added in 2212f05 triggers a scroll when the delta is strictly greater than 1.0. This means that right after connecting a client, we won't be triggering a scroll with the first mouse wheel 'click'.

Re: [Spice-devel] [spice-gtk] widget: Send all smooth-scroll events to the guest

2018-09-17 Thread Christophe Fergeau
On Fri, Sep 14, 2018 at 02:25:39PM +0200, Victor Toso wrote: > From: Victor Toso > > Introduced in 2212f05145c5f1d5, smooth-scroll events were taking > inconsideration that the delta_y value received by GdkEventScroll was > 1.0 but that can be different for other input devices. > > That can

[Spice-devel] [spice-gtk v4 03/13] cd-sharing: implement cd-device for Windows

2018-09-17 Thread Yuri Benditovich
Added implementation of system-dependent operations defined in cd-device.h for Windows Signed-off-by: Yuri Benditovich --- src/cd-device-win.c | 193 1 file changed, 193 insertions(+) create mode 100644 src/cd-device-win.c diff --git

[Spice-devel] [spice-gtk v4 07/13] cd-sharing: add implementation of SCSI device

2018-09-17 Thread Yuri Benditovich
Signed-off-by: Alexander Nezhinsky --- src/cd-scsi.c | 2765 + 1 file changed, 2765 insertions(+) create mode 100644 src/cd-scsi.c diff --git a/src/cd-scsi.c b/src/cd-scsi.c new file mode 100644 index 000..86baf97 --- /dev/null +++

[Spice-devel] [spice-gtk v4 13/13] cd-sharing: Implementation of CD sharing feature

2018-09-17 Thread Yuri Benditovich
This commit contains modified files related to CD sharing feature. The feature adds ability to share one or more CD images (or local CD-DVD devices) with the guest by emulating USB CD devices connected to guest system. Prerequisites: Guest system shall have USB2 or USB3 controller and one or

[Spice-devel] [spice-gtk v4 11/13] cd-sharing: added implementation of USB backend

2018-09-17 Thread Yuri Benditovich
Implementation of USB backend interface. For platform-specific operations (like operations with local CD devices) see cd-device-* files. Signed-off-by: Yuri Benditovich --- src/usb-backend-common.c | 2015 ++ 1 file changed, 2015 insertions(+) create

[Spice-devel] [spice-gtk v4 10/13] cd-charing: added interface definition for USB backend device

2018-09-17 Thread Yuri Benditovich
This interface isolates LIBUSB and USBREDIRHOST interfaces from all other modules of spice-gtk. It keeps all the functionality of these interfaces and adds ability to create and manage emulated CD devices Signed-off-by: Yuri Benditovich --- src/usb-backend.h | 112

[Spice-devel] [spice-gtk v4 12/13] cd-sharing: implementation of new USB widget

2018-09-17 Thread Yuri Benditovich
New USB widget supports all the functionality related to redirection of local USB device (as previous usb widget did). Additionally it allows creation, management and redirection of emulated USB CD devices for CD sharing. Signed-off-by: Alexander Nezhinsky Signed-off-by: Yuri Benditovich ---

[Spice-devel] [spice-gtk v4 02/13] cd-sharing: implement cd-device for Linux

2018-09-17 Thread Yuri Benditovich
Added implementation of system-dependent operations defined in cd-device.h for Linux Signed-off-by: Yuri Benditovich --- src/cd-device-linux.c | 137 ++ 1 file changed, 137 insertions(+) create mode 100644 src/cd-device-linux.c diff --git

[Spice-devel] [spice-gtk v4 09/13] cd-sharing: added implementation of USB mass storage device

2018-09-17 Thread Yuri Benditovich
Implementation of interface defined in cd-usb-bulk-msd.h Signed-off-by: Alexander Nezhinsky --- src/cd-usb-bulk-msd.c | 555 ++ 1 file changed, 555 insertions(+) create mode 100644 src/cd-usb-bulk-msd.c diff --git a/src/cd-usb-bulk-msd.c

[Spice-devel] [spice-gtk v4 01/13] cd-sharing: add cd-device header file

2018-09-17 Thread Yuri Benditovich
Contains definitions for system-dependent operations related to local cd devices and files Signed-off-by: Yuri Benditovich --- src/cd-device.h | 40 1 file changed, 40 insertions(+) create mode 100644 src/cd-device.h diff --git a/src/cd-device.h

[Spice-devel] [spice-gtk v4 06/13] cd-sharing: add interface definition for SCSI device

2018-09-17 Thread Yuri Benditovich
Interface for external code that manages CD SCSI device Signed-off-by: Yuri Benditovich --- src/cd-scsi.h | 122 ++ 1 file changed, 122 insertions(+) create mode 100644 src/cd-scsi.h diff --git a/src/cd-scsi.h b/src/cd-scsi.h new file

[Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-17 Thread Yuri Benditovich
This series of patches adds ability to share ISO files or local CD devices with guest system using USB redirection by emulation of USB CD device. For more information see commit comment of patch 13. Currently both new usb device widget and old one present in the code and the old one can be

[Spice-devel] [spice-gtk v4 05/13] cd-sharing: introduce header file for SCSI device parameters

2018-09-17 Thread Yuri Benditovich
The file defines data structures needed for SCSI device creation and management Signed-off-by: Alexander Nezhinsky --- src/cd-scsi-dev-params.h | 52 1 file changed, 52 insertions(+) create mode 100644 src/cd-scsi-dev-params.h diff --git

[Spice-devel] [spice-gtk v4 04/13] cd-sharing: add header file with SCSI definitions

2018-09-17 Thread Yuri Benditovich
The file includes defines needed for implementation of SCSI part of USB CD emulation Signed-off-by: Alexander Nezhinsky --- src/scsi-constants.h | 324 +++ 1 file changed, 324 insertions(+) create mode 100644 src/scsi-constants.h diff --git

[Spice-devel] [spice-gtk v4 08/13] cd-sharing: added interface file for USB mass storage device

2018-09-17 Thread Yuri Benditovich
The file defines interface for external software that manages bulk USB mass storage device Signed-off-by: Alexander Nezhinsky --- src/cd-usb-bulk-msd.h | 134 ++ 1 file changed, 134 insertions(+) create mode 100644 src/cd-usb-bulk-msd.h diff