[Spice-devel] Drag-n-drop for directories

2018-09-19 Thread Carlos González
Drag and dropping files from host to guest as copying method already works. But, by chance, are there any plans to support the same for folders/directories? Thanks. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] [PATCH spice-gtk v2] glib: add SpiceQmpPort helper

2018-09-19 Thread marcandre . lureau
From: Marc-André Lureau Add a few helper functions to deal with a QMP port channel, in order to ease json handling, and wrapping a few commands. (by convention, the port should have the name "org.qemu.monitor.qmp.0", but it's not strictly required) This helper is put into use in the

Re: [Spice-devel] [RFC PATCH v2 00/20] Monitor ID rework

2018-09-19 Thread Frediano Ziglio
> > > > Another lousely related thing: While debugging another issue I've > > > noticed that QXLMonitorsConfig has a surface_id field. What this is > > > intended for? Map non-primary surface to a head? > > > > I just did a brief investigation, I am not sure. It seems the field is > > not

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-09-19 Thread Marc-André Lureau
Hi On Wed, Sep 19, 2018 at 7:06 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 19, 2018 at 05:51:13PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Sep 19, 2018 at 3:26 PM Victor Toso wrote: > > > > > > Hi, > > > > > > Tested the qmp part, so far, so good. Some comments/suggestions > >

Re: [Spice-devel] [PATCH spice-server] syntax-check: Add missing contributors names to AUTHORS

2018-09-19 Thread Eduardo Lima (Etrunko)
On 9/19/18 12:54 PM, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > AUTHORS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/AUTHORS b/AUTHORS > index 8874a9d4..12158e60 100644 > --- a/AUTHORS > +++ b/AUTHORS > @@ -27,6 +27,7 @@ Patches also contributed by > Axel

[Spice-devel] [PATCH spice-server] syntax-check: Add missing contributors names to AUTHORS

2018-09-19 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 8874a9d4..12158e60 100644 --- a/AUTHORS +++ b/AUTHORS @@ -27,6 +27,7 @@ Patches also contributed by Axel Lin 소병철 Cédric Bosdonnat +Changqing Li

Re: [Spice-devel] [spice-gtk v4 12/13] cd-sharing: implementation of new USB widget

2018-09-19 Thread Marc-André Lureau
Hi On Tue, Sep 18, 2018 at 8:05 PM Yuri Benditovich wrote: > > > > On Tue, Sep 18, 2018 at 12:15 PM, Marc-André Lureau > wrote: >> >> Hi >> >> On Tue, Sep 18, 2018 at 12:04 PM Yuri Benditovich >> wrote: >> > >> > >> > >> > On Tue, Sep 18, 2018 at 9:10 AM, Victor Toso wrote: >> >> >> >> On

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-09-19 Thread Victor Toso
Hi, On Wed, Sep 19, 2018 at 05:51:13PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Sep 19, 2018 at 3:26 PM Victor Toso wrote: > > > > Hi, > > > > Tested the qmp part, so far, so good. Some comments/suggestions > > bellow. > > > > On Fri, Aug 10, 2018 at 03:44:19PM +0200,

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-09-19 Thread Marc-André Lureau
Hi On Wed, Sep 19, 2018 at 3:26 PM Victor Toso wrote: > > Hi, > > Tested the qmp part, so far, so good. Some comments/suggestions > bellow. > > On Fri, Aug 10, 2018 at 03:44:19PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Add a few helper functions to deal

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-19 Thread Yuri Benditovich
On Wed, Sep 19, 2018 at 3:49 PM, Gerd Hoffmann wrote: > Hi, > > > > Can you summarize the reasons to discard the approach? > > > > > > > I will try. > > > > The POC of nbd-based cd sharing was on the table. It needed some > > unclear rework to avoid breaking ABI with mainstream spice-server. >

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

2018-09-19 Thread Victor Toso
Hi, On Mon, Aug 13, 2018 at 01:44:37PM +0200, Javier Celaya wrote: > Hi, sorry for the late response, I was on holidays > El mar, 24-07-2018 a las 17:58 +0200, Marc-André Lureau escribió: > > On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya > com> wrote:The main channel reference d->main of

Re: [Spice-devel] [RFC PATCH v2 00/20] Monitor ID rework

2018-09-19 Thread Gerd Hoffmann
Hi, > - We're going to try to implement you suggestion of identifying the > monitors in the guest basically according to your outline in > https://lists.freedesktop.org/archives/spice-devel/2018-August/045465.html Ok. I'll stay tuned. Cc'ing me on patches you send out would be great. > >

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-19 Thread Gerd Hoffmann
Hi, > > Can you summarize the reasons to discard the approach? > > > > I will try. > > The POC of nbd-based cd sharing was on the table. It needed some > unclear rework to avoid breaking ABI with mainstream spice-server. --verbose please. > The solution requires updates in qemu and spice on

Re: [Spice-devel] [spice-gtk v4 12/13] cd-sharing: implementation of new USB widget

2018-09-19 Thread Christophe Fergeau
On Tue, Sep 18, 2018 at 11:03:56AM +0300, Yuri Benditovich wrote: > Earlier the screenshot of the latest widget (current code) was sent to > internal list for review and no objections were received. For the record, I do have some objections, but I received the screenshot at about the same time

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-19 Thread Yuri Benditovich
On Wed, Sep 19, 2018 at 7:41 AM, Gerd Hoffmann wrote: > Hi, > > > > Hmm, so it isn't only usb emulation, but also scsi emulation duplicated > > > in spice-client. Why this route? Wouldn't it be simpler to run nbd > > > over spice-chardev, then hook up the iso as blockdev in qemu? Which > >

Re: [Spice-devel] [RFC PATCH v2 00/20] Monitor ID rework

2018-09-19 Thread Lukáš Hrázký
Hello, On Wed, 2018-09-19 at 11:24 +0200, Gerd Hoffmann wrote: > Hi, > > > this is the reworked second version of the Monitor ID series. > > Ping. What is the status here? v3 coming? Sorry about the radio silence. We discussed the possibilities and came up with roughly the following: -

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-09-19 Thread Victor Toso
Hi, Tested the qmp part, so far, so good. Some comments/suggestions bellow. On Fri, Aug 10, 2018 at 03:44:19PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a few helper functions to deal with a QMP port channel, in order > to ease json handling, and wrapping a

Re: [Spice-devel] [RFC PATCH v2 00/20] Monitor ID rework

2018-09-19 Thread Gerd Hoffmann
Hi, > this is the reworked second version of the Monitor ID series. Ping. What is the status here? v3 coming? Another lousely related thing: While debugging another issue I've noticed that QXLMonitorsConfig has a surface_id field. What this is intended for? Map non-primary surface to a

Re: [Spice-devel] [PATCH vdagent-linux] vdagentd: parse argv using GLib

2018-09-19 Thread Victor Toso
Hi, Sorry that I missed this v2 On Tue, Sep 04, 2018 at 03:49:18PM +0200, Jakub Janků wrote: > All command line options now have long names > as they are required by GLib. > > So the supported command line options now are: > > -h, --help > > -d, --debug > -s,

Re: [Spice-devel] [RFC spice-vdagent 09/18] udscs: simplify logging

2018-09-19 Thread Victor Toso
Hi, Forgot to reply to this one, small suggestions below. On Tue, Aug 14, 2018 at 08:53:43PM +0200, Jakub Janků wrote: > Remove type_to_string, no_types arguments from > udscs_connect() and udscs_server_new(). > udscs is used only in vdagent.c and vdagentd.c > and in both cases the args are the

Re: [Spice-devel] Regarding next Spice drivers release

2018-09-19 Thread Victor Toso
Hi again, On Wed, Sep 19, 2018 at 08:33:35AM +0200, Victor Toso wrote: > Hi Carlos, > > On Tue, Sep 18, 2018 at 09:57:55AM -0500, Carlos González wrote: > > Thanks very much mr Toso, yet again. > > > > ... maybe I still need to learn how to read stuff at gitlab? > > The 0.14.1 tag

Re: [Spice-devel] Regarding next Spice drivers release

2018-09-19 Thread Victor Toso
Hi Carlos, On Tue, Sep 18, 2018 at 09:57:55AM -0500, Carlos González wrote: > Thanks very much mr Toso, yet again. > > ... maybe I still need to learn how to read stuff at gitlab? > The 0.14.1 tag https://gitlab.freedesktop.org/spice/spice/tags/v0.14.1 says > "no release notes" nor has any