Re: [Spice-devel] [PATCH spice-streaming-agent] plugin: Do not use references to pass ownership

2018-09-20 Thread Lukáš Hrázký
Hi, On Thu, 2018-09-20 at 14:32 +0100, Frediano Ziglio wrote: > Usually when references are used ownership is not moved. > Avoid to use references to confuse code reader. > Pointers and references have same ABI so the change does not > break plugin ABI. I don't think passing raw pointers over

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-20 Thread Yuri Benditovich
On Thu, Sep 20, 2018 at 2:48 PM, Gerd Hoffmann wrote: > Hi, > > > If we consider the nbd PoC and the solution Daynix sent (spice-gtk and > > emulation) I personally prefer the Daynix solution and as Yuri said > already > > the glue code required for the nbd is bigger than the emulation code. >

[Spice-devel] [PATCH spice] Count display channels for tablet mode check

2018-09-20 Thread Lukáš Hrázký
Having a single QXL interface is not enough, there can be other (e.g. streaming) display channels that make the tablet unusable. Add a check for the number of display channels also being equal to 1. We still need the check for QXL interaces, because the tablet only works with QXL. Signed-off-by:

Re: [Spice-devel] [spice-gtk v4 12/13] cd-sharing: implementation of new USB widget

2018-09-20 Thread Christophe Fergeau
On Thu, Sep 20, 2018 at 04:09:56PM +0300, Yuri Benditovich wrote: > Use case: installing Windows 7/10 VM ( or Win 7 ) with virtio hard drive. > Need to share 2 ISOs (this is what users do, this allows install all the > drivers just > after OS installation). The user needs to distinguish between

[Spice-devel] [PATCH spice-streaming-agent] plugin: Do not use references to pass ownership

2018-09-20 Thread Frediano Ziglio
Usually when references are used ownership is not moved. Avoid to use references to confuse code reader. Pointers and references have same ABI so the change does not break plugin ABI. Signed-off-by: Frediano Ziglio --- include/spice-streaming-agent/plugin.hpp | 3 ++- src/concrete-agent.cpp

Re: [Spice-devel] [spice-gtk v4 12/13] cd-sharing: implementation of new USB widget

2018-09-20 Thread Marc-André Lureau
Hi On Thu, Sep 20, 2018 at 5:09 PM Yuri Benditovich wrote: > > Hi > > On Wed, Sep 19, 2018 at 6:43 PM, Marc-André Lureau > wrote: >> >> Hi >> >> On Tue, Sep 18, 2018 at 8:05 PM Yuri Benditovich >> wrote: >> > >> > >> > >> > On Tue, Sep 18, 2018 at 12:15 PM, Marc-André Lureau >> > wrote: >>

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-20 Thread Gerd Hoffmann
Hi, > If we consider the nbd PoC and the solution Daynix sent (spice-gtk and > emulation) I personally prefer the Daynix solution and as Yuri said already > the glue code required for the nbd is bigger than the emulation code. Oh. Fair enough. I certainly didn't expect that the nbd glue is

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-20 Thread Frediano Ziglio
> Hi, > > > During my talk at KVM forum, I mentionned that an interesting project > > idea/heack would be to try to reuse emulated USB devices in qemu, and > > abstract them so they could speech usbredir. I think that would be > > really neat, because not only we could share USB emulation code

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-20 Thread Gerd Hoffmann
Hi, > During my talk at KVM forum, I mentionned that an interesting project > idea/heack would be to try to reuse emulated USB devices in qemu, and > abstract them so they could speech usbredir. I think that would be > really neat, because not only we could share USB emulation code from > qemu

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-20 Thread Gerd Hoffmann
Hi, > > Probably the bare minimum needed to get things going. > > Which guests have you tested with this? > > Several Windows + several Linuxes. What you recommend to add to the check > list? I'd suggest adding at least FreeBSD (most popular from the *BSDs I think) to regular tests, maybe

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-20 Thread Marc-André Lureau
Hi On Thu, Sep 20, 2018 at 12:37 PM Yuri Benditovich wrote: > > Hi > > On Thu, Sep 20, 2018 at 8:59 AM, Gerd Hoffmann wrote: >> >> Hi, >> >> > spice-server changes were backward-incompatible and were not accepted >> >> Why they are not backward compatible? > > > Possible, Marc Andre can

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-20 Thread Yuri Benditovich
Hi On Thu, Sep 20, 2018 at 8:59 AM, Gerd Hoffmann wrote: > Hi, > > > spice-server changes were backward-incompatible and were not accepted > > Why they are not backward compatible? > Possible, Marc Andre can answer. He was involved at time of presentation of 2 solutions and did not raise any

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-20 Thread Vasiliy Tolstov
чт, 20 сент. 2018 г. в 8:59, Gerd Hoffmann : > > Hi, > > > spice-server changes were backward-incompatible and were not accepted > > Why they are not backward compatible? > > > usb-storage is just a header processing and holder of units > > Yes, bulk-only transport isn't that difficuilt to

Re: [Spice-devel] [spice-gtk v4 00/13] CD sharing feature

2018-09-20 Thread Gerd Hoffmann
Hi, > spice-server changes were backward-incompatible and were not accepted Why they are not backward compatible? > usb-storage is just a header processing and holder of units Yes, bulk-only transport isn't that difficuilt to handle. > scsi source is 2K lines, similar to nbd server