On Thu, Sep 27, 2018 at 12:12 PM Christophe Fergeau
wrote:
> On Thu, Sep 27, 2018 at 11:48:13AM +0300, Yuri Benditovich wrote:
> > > > -static int usbredir_read_callback(void *user_data, uint8_t *data,
> int
> > > count)
> > > > +static void usbredir_log(void *user_data, const char *msg,
On Tue, Sep 25, 2018 at 4:39 PM Christophe Fergeau
wrote:
> Hey,
>
> Thanks for doing some splitting work!
>
> I would personally squash these 2 patches, as there is some code
> movement between the new file introduced in this patch, and the files
> which are modified in the other one.
> You
Christophe,
Our primary goal, if you remember, was to deliver cd-sharing feature.
For that it was needed to isolate usb redirection modules from libusb and
usbredir to create some abstraction layer for USB devices whether they are
local or emulated in software.
SpiceUsbDevice is type of object
From: Christophe de Dinechin
This is a new repository that makes it easier to build all
of SPICE with a single 'make' command. It also optimizes
the build of 'common' and 'protocol', which are built only once
and then used by both spice-gtk and spice-server. This makes
it easier and safer to
From: Christophe de Dinechin
This is the 'streaming-agent' part of a make-only build system that
can normally coexist with the existing two build systems.
This RFC follows similar ones for protocol, common, spice-gtk and server.
Christophe de Dinechin (1):
streaming-agent: Make-It-Quick
From: Christophe de Dinechin
Make-it-Quick is a make-only build system that uses makefiles
for autoconfiguration. For SPICE, it provides a faster, easier to
maintain and more flexible build system.
A key feature made possible by this build system is top-level builds.
Top-level builds are made
On Fri, Sep 21, 2018 at 08:10:08PM +0200, Christophe Fergeau wrote:
>
> All your SPICE_DEBUG calls include a __FUNCTION__, but it seems
> SPICE_DEBUG already does that for you?
>
> #define SPICE_DEBUG(fmt, ...) \
> do {
From: Christophe de Dinechin
Make-it-Quick is a make-only build system that uses makefiles
for autoconfiguration. For SPICE, it provides a faster, easier to
maintain and more flexible build system.
A key feature made possible by this build system is top-level builds.
Top-level builds are made
From: Christophe de Dinechin
This is a placeholder patch to remind you that you need to apply
the corresponding RFC version of spice-common for this to work.
Signed-off-by: Christophe de Dinechin
---
subprojects/spice-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Christophe de Dinechin
This is the 'spice-gtk' part of a make-only build system that
can normally coexist with the existing two build systems.
This RFC follows a similar one for protocol and a patch for common,
and will be followed by similar RFCs for server and streaming-agent
Github
From: Christophe de Dinechin
Make-it-Quick is a make-only build system that uses makefiles
for autoconfiguration. For SPICE, it provides a faster, easier to
maintain and more flexible build system.
A key feature made possible by this build system is top-level builds.
Top-level builds are made
Can I just update distro's spice-server package in order to test?
Or do I need to also somewhat fix/reinstall the Win10 VM?
El mié., 19 sept. 2018 a las 1:39, Victor Toso ()
escribió:
> Hi again,
>
> On Wed, Sep 19, 2018 at 08:33:35AM +0200, Victor Toso wrote:
> > Hi Carlos,
> >
> > On Tue, Sep
From: Christophe de Dinechin
Make-it-Quick is a make-only build system that uses makefiles
for autoconfiguration. For SPICE, it provides a faster, easier to
maintain and more flexible build system.
A key feature made possible by this build system is top-level builds.
Top-level builds are made
From: Christophe de Dinechin
Github review link: https://github.com/c3d/spice-protocol/commits/c3d-build
This is the protocol part of a make-only build system that
can normally coexist with the existing two build systems.
The primary benefit of the proposed approach is top-level build,
i.e. a
From: Christophe de Dinechin
This is the protocol part of a make-only build system that
can normally coexist with the existing two build systems.
The primary benefit of the proposed approach is top-level build,
i.e. a way to make it easier to build all of SPICE with correct
dependency tracking
On Thu, Sep 27, 2018 at 6:27 PM Eduardo Lima (Etrunko)
wrote:
>
> Fixes the following warnings:
>
> ../tests/usb-acl-helper.c:29:10: warning: no previous prototype for
> ‘abort_test’ [-Wmissing-prototypes]
> gboolean abort_test(gpointer user_data)
> ^~
>
Signed-off-by: Eduardo Lima (Etrunko)
---
m4/spice-compile-warnings.m4 | 9 -
1 file changed, 9 deletions(-)
diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4
index 0ae3bd7..a7a6ff3 100644
--- a/m4/spice-compile-warnings.m4
+++ b/m4/spice-compile-warnings.m4
@@
Signed-off-by: Eduardo Lima (Etrunko)
---
meson.build | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/meson.build b/meson.build
index 48f5f74..4e4bee8 100644
--- a/meson.build
+++ b/meson.build
@@ -368,14 +368,12 @@ endif
#
# global C defines
#
-glib_major_minor =
Fixes the following warnings:
../tests/usb-acl-helper.c:29:10: warning: no previous prototype for
‘abort_test’ [-Wmissing-prototypes]
gboolean abort_test(gpointer user_data)
^~
../tests/usb-acl-helper.c:37:10: warning: no previous prototype for
‘cancel_test’
On Thu, Sep 27, 2018 at 09:50:59AM -0300, Eduardo Lima (Etrunko) wrote:
> On 9/26/18 5:26 AM, Frediano Ziglio wrote:
> > OT: Mumble... this make me wonder... maybe we could integrate the
> > Gitlab CI with a MingW (cross Windows) build?
> >
>
> Definitely something worth trying. I still have not
>
> Signed-off-by: Eduardo Lima (Etrunko)
Acked-by: Frediano Ziglio
Frediano
> ---
> meson.build | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index eba2c38..76fb0cd 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -30,7
Usually when references are used ownership is not moved.
Avoid to use references to confuse code reader.
Signed-off-by: Frediano Ziglio
---
include/spice-streaming-agent/plugin.hpp | 4 +++-
src/concrete-agent.cpp | 4 ++--
src/concrete-agent.hpp | 2 +-
On 9/26/18 5:26 AM, Frediano Ziglio wrote:
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> meson.build | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/meson.build b/meson.build
>> index 629f109..ebd42e1 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@
Signed-off-by: Eduardo Lima (Etrunko)
---
meson.build | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/meson.build b/meson.build
index eba2c38..76fb0cd 100644
--- a/meson.build
+++ b/meson.build
@@ -30,7 +30,6 @@ spice_gtk_global_cflags = ['-DHAVE_CONFIG_H',
# other
On 9/26/18 5:16 AM, Frediano Ziglio wrote:
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> meson.build | 7 +++
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/meson.build b/meson.build
>> index eba2c38..629f109 100644
>> --- a/meson.build
>> +++ b/meson.build
>>
Hi
On Thu, Sep 27, 2018 at 3:22 PM Victor Toso wrote:
>
> On Wed, Sep 26, 2018 at 06:56:23PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Do not leak the strong channel ref.
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > src/qmp-port.c | 2 ++
> > 1 file
Hey,
One additional high-level comment, after these patches, we have
in the public API an opaque SpiceUsbDevice, which is
// this is the structure behind SpiceUsbDevice
typedef struct _SpiceUsbDeviceInfo {
guint8 busnum;
guint8 devaddr;
guint16 vid;
guint16 pid;
gboolean
On Wed, Sep 26, 2018 at 06:56:20PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Hi,
>
> Here are a few follow-up patches for the QMP helper.
>
> Thanks
For the series,
Acked-by: Victor Toso
>
> Marc-André Lureau (4):
> channel-port: fix invalid arg comment
>
On Wed, Sep 26, 2018 at 06:56:23PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Do not leak the strong channel ref.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/qmp-port.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/qmp-port.c
Hi
On Thu, Sep 27, 2018 at 12:26 PM Javier Celaya
wrote:
> El vie, 21-09-2018 a las 14:34 +0400, marcandre.lur...@redhat.com
> escribió:
>
> From: Marc-André Lureau
>
>
> Add a few helper functions to deal with a QMP port channel, in order
>
> to ease json handling, and wrapping a few
On Wed, 2018-09-26 at 10:47 -0500, Jonathon Jongsma wrote:
> So, off list we had discussed potentially investigating whether we
> wanted to use something like Cap'n Proto for the StreamDevice
> communication protocol. With that in mind, is it worth reviewing this
> series, or should we wait?
I
On Thu, Sep 27, 2018 at 11:48:13AM +0300, Yuri Benditovich wrote:
> > > -static int usbredir_read_callback(void *user_data, uint8_t *data, int
> > count)
> > > +static void usbredir_log(void *user_data, const char *msg, gboolean
> > error)
> > > {
> > > SpiceUsbredirChannel *channel =
El vie, 21-09-2018 a las 14:34 +0400, marcandre.lur...@redhat.com
escribió:
> From: Marc-André Lureau
> Add a few helper functions to deal with a QMP port channel, in
> orderto ease json handling, and wrapping a few commands.
> (by convention, the port should have the
>
On Thu, Sep 27, 2018 at 10:14 AM Frediano Ziglio wrote:
>
> Signed-off-by: Frediano Ziglio
Unused since commit 85ed26847c, ack
> ---
> src/spice-session-priv.h | 2 --
> src/spice-session.c | 9 +
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git
On Thu, Sep 27, 2018 at 10:12 AM Frediano Ziglio wrote:
>
> Signed-off-by: Frediano Ziglio
ack
> ---
> src/spice-session-priv.h | 1 -
> src/spice-session.c | 10 --
> 2 files changed, 11 deletions(-)
>
> diff --git a/src/spice-session-priv.h b/src/spice-session-priv.h
> index
Signed-off-by: Frediano Ziglio
---
src/spice-session-priv.h | 2 --
src/spice-session.c | 9 +
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/spice-session-priv.h b/src/spice-session-priv.h
index d2a557b..0190c1f 100644
--- a/src/spice-session-priv.h
+++
Signed-off-by: Frediano Ziglio
---
src/spice-session-priv.h | 1 -
src/spice-session.c | 10 --
2 files changed, 11 deletions(-)
diff --git a/src/spice-session-priv.h b/src/spice-session-priv.h
index 03005aa..d2a557b 100644
--- a/src/spice-session-priv.h
+++
37 matches
Mail list logo
