Re: [Spice-devel] [spice-common] Remove config.h from header files

2018-10-04 Thread Eduardo Lima (Etrunko)
On 10/4/18 1:17 PM, Christophe Fergeau wrote: > This should only be included from c files. > > Signed-off-by: Christophe Fergeau > --- > common/client_marshallers.h | 4 > common/mem.h| 4 > common/messages.h | 4 > 3 files changed, 12 deletions(-) > >

Re: [Spice-devel] [spice-server 3/3] dcc: Add debug log when setting compression

2018-10-04 Thread Frediano Ziglio
> > Without this it's not obvious that a compression setting took effect. > --- > server/dcc.c | 3 +++ > server/utils.c | 42 ++ > server/utils.h | 3 +++ > 3 files changed, 48 insertions(+) > > diff --git a/server/dcc.c b/server/dcc.c > index

Re: [Spice-devel] [spice-server 1/3] utils: Remove get/set/clear_bit

2018-10-04 Thread Frediano Ziglio
> > These function are used once each by red-qxl.c, they don't need to be > exported in utils.h > --- > server/red-qxl.c | 17 + > server/utils.h | 16 > 2 files changed, 17 insertions(+), 16 deletions(-) > > diff --git a/server/red-qxl.c b/server/red-qxl.c >

[Spice-devel] [spice-common] Remove config.h from header files

2018-10-04 Thread Christophe Fergeau
This should only be included from c files. Signed-off-by: Christophe Fergeau --- common/client_marshallers.h | 4 common/mem.h| 4 common/messages.h | 4 3 files changed, 12 deletions(-) diff --git a/common/client_marshallers.h

Re: [Spice-devel] [spice-gtk v2 0/1] usb redirection: USB backend layer

2018-10-04 Thread Yuri Benditovich
Ping On Sun, Sep 30, 2018 at 6:13 PM Yuri Benditovich < yuri.benditov...@daynix.com> wrote: > USB backend communicates with libusb and libusbredir and > provides the API for USB redirection procedures. > All the modules communicate only with usb backend > instead of calling libusb and

[Spice-devel] [spice-server 1/3] utils: Remove get/set/clear_bit

2018-10-04 Thread Christophe Fergeau
These function are used once each by red-qxl.c, they don't need to be exported in utils.h --- server/red-qxl.c | 17 + server/utils.h | 16 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/server/red-qxl.c b/server/red-qxl.c index

[Spice-devel] [spice-server 2/3] utils: Remove spice_get_monotonic_time_ms

2018-10-04 Thread Christophe Fergeau
This is a thin wrapper over g_get_monotonic_time_ms, and is called only once, so we can call directly g_get_monotonic_time_ms instead. --- server/reds.c | 2 +- server/utils.h | 5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/server/reds.c b/server/reds.c index

[Spice-devel] [spice-server 3/3] dcc: Add debug log when setting compression

2018-10-04 Thread Christophe Fergeau
Without this it's not obvious that a compression setting took effect. --- server/dcc.c | 3 +++ server/utils.c | 42 ++ server/utils.h | 3 +++ 3 files changed, 48 insertions(+) diff --git a/server/dcc.c b/server/dcc.c index 826dd28fe..e27d3dcad 100644

Re: [Spice-devel] Using a SPICe guest from console

2018-10-04 Thread Jonathon Jongsma
On Mon, 2018-10-01 at 14:10 +0200, Enrico Mioso wrote: > Hello SPICE community! :) > > First of all, I would like to say thank to you for your work in > SPICE: I find it to be a great idea. > > I am writing to you to ask for help, since I am trying to use SPICE > in a little strange way. > I

Re: [Spice-devel] Spice and Windows License

2018-10-04 Thread Jonathon Jongsma
On Fri, 2018-09-28 at 09:45 -0300, Gilberto Nunes wrote: > Hi there > > I have some issues here, regard Windows License when using Spice as > VDI solution. > I need User Cal when connect to Windows useing Spice? > > Thanks a lot > > --- > Gilberto Nunes Ferreira > > (47) 3025-5907 > (47)

Re: [Spice-devel] Virt-viewer single connection

2018-10-04 Thread Jonathon Jongsma
On Thu, 2018-10-04 at 07:55 -0300, Ivo Cavalcante wrote: > Hi people, > > We're trying to implement a standard solution on our company, where > users who need Windows machines (some legacy software still uses it) > will have a VM on their workstations, using Libvirt/QEMU/KVM. The > biggest

[Spice-devel] Virt-viewer single connection

2018-10-04 Thread Ivo Cavalcante
Hi people, We're trying to implement a standard solution on our company, where users who need Windows machines (some legacy software still uses it) will have a VM on their workstations, using Libvirt/QEMU/KVM. The biggest problem we're seeing so far is that we can't find a way to prevent users

[Spice-devel] Spice and Windows License

2018-10-04 Thread Gilberto Nunes
Hi there I have some issues here, regard Windows License when using Spice as VDI solution. I need User Cal when connect to Windows useing Spice? Thanks a lot --- Gilberto Nunes Ferreira (47) 3025-5907 (47) 99676-7530 - Whatsapp / Telegram Skype: gilberto.nunes36

[Spice-devel] About Building Spice OSX Client

2018-10-04 Thread dengrongyu
Hello,spice developer I’m a developer from China,I want to build SPICE on Mac,and I followed the instructions on your official page: https://www.spice-space.org/osx-client.html. I just cant walk through. First About Prerequisite: I was told to install

[Spice-devel] Using a SPICe guest from console

2018-10-04 Thread Enrico Mioso
Hello SPICE community! :) First of all, I would like to say thank to you for your work in SPICE: I find it to be a great idea. I am writing to you to ask for help, since I am trying to use SPICE in a little strange way. I would like, for confort reasons, to be able to use SPICE-gtk to connect

Re: [Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-10-04 Thread Lukáš Hrázký
On Thu, 2018-10-04 at 07:25 -0400, Frediano Ziglio wrote: > > On Tue, 2018-10-02 at 11:21 -0400, Frediano Ziglio wrote: > > > > On Fri, 2018-09-28 at 03:41 -0400, Frediano Ziglio wrote: > > > > > ping > > > > > > > > Sorry, I was thinking how to handle this and eventually forgot about > > > > it.

Re: [Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-10-04 Thread Frediano Ziglio
> On Tue, 2018-10-02 at 11:21 -0400, Frediano Ziglio wrote: > > > On Fri, 2018-09-28 at 03:41 -0400, Frediano Ziglio wrote: > > > > ping > > > > > > Sorry, I was thinking how to handle this and eventually forgot about > > > it. Two notes: > > > > > > 1. Without really looking into the

Re: [Spice-devel] [spice-gtk] display-gst: debug instead of warning on lack of video codecs

2018-10-04 Thread Christophe Fergeau
On Tue, Oct 02, 2018 at 10:19:01AM +0200, Victor Toso wrote: > Hi, > > On Mon, Oct 01, 2018 at 06:03:07PM +0200, Christophe Fergeau wrote: > > On Mon, Oct 01, 2018 at 05:43:26PM +0200, Victor Toso wrote: > > > From: Victor Toso > > > > > > Just plain ugly to have all Spice clients to warn out

Re: [Spice-devel] [spice-gtk v3 2/2] mingw: Fix compilation breakage because of memmem use

2018-10-04 Thread Frediano Ziglio
> > On Thu, Oct 4, 2018 at 12:30 PM Christophe Fergeau > wrote: > > > > mingw does not provide memmem. Since the qmp data is JSON, it won't > > contain embedded nul characters, we can use strstr instead of > > memmem. > > > > Signed-off-by: Christophe Fergeau > > ack > CI thanks,

Re: [Spice-devel] [PATCH spice-gtk 3/3] m4: Remove duplicate warnings settings

2018-10-04 Thread Frediano Ziglio
> > Signed-off-by: Eduardo Lima (Etrunko) Acked-by: Frediano Ziglio Frediano > --- > m4/spice-compile-warnings.m4 | 9 - > 1 file changed, 9 deletions(-) > > diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4 > index 0ae3bd7..a7a6ff3 100644 > ---

Re: [Spice-devel] [spice-gtk v3 1/2] mingw: Use G_GUINT64_FORMAT with glib printing functions

2018-10-04 Thread Marc-André Lureau
On Thu, Oct 4, 2018 at 12:30 PM Christophe Fergeau wrote: > > mingw builds currently trigger a few warnings: > ../../src/channel-cursor.c: In function 'set_cursor': > ../../src/channel-cursor.c:392:210: warning: 'I' flag used with '%x' > gnu_printf format [-Wformat=] >

Re: [Spice-devel] [spice-gtk v3 2/2] mingw: Fix compilation breakage because of memmem use

2018-10-04 Thread Marc-André Lureau
On Thu, Oct 4, 2018 at 12:30 PM Christophe Fergeau wrote: > > mingw does not provide memmem. Since the qmp data is JSON, it won't > contain embedded nul characters, we can use strstr instead of > memmem. > > Signed-off-by: Christophe Fergeau ack > --- > - add explicit check for NULL to match

Re: [Spice-devel] [PATCH spice-gtk] NEWS: Update

2018-10-04 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 7:36 PM Victor Toso wrote: > > Hi, > > On Tue, Oct 02, 2018 at 04:23:56PM +0100, Frediano Ziglio wrote: > > Add a note for future release about dropper support for version 1 > > of the protocol. > > > > Signed-off-by: Frediano Ziglio > > Not really sure this is

[Spice-devel] [spice-gtk v3 2/2] mingw: Fix compilation breakage because of memmem use

2018-10-04 Thread Christophe Fergeau
mingw does not provide memmem. Since the qmp data is JSON, it won't contain embedded nul characters, we can use strstr instead of memmem. Signed-off-by: Christophe Fergeau --- - add explicit check for NULL to match coding style src/qmp-port.c | 2 +- 1 file changed, 1 insertion(+), 1

[Spice-devel] [spice-gtk v3 1/2] mingw: Use G_GUINT64_FORMAT with glib printing functions

2018-10-04 Thread Christophe Fergeau
mingw builds currently trigger a few warnings: ../../src/channel-cursor.c: In function 'set_cursor': ../../src/channel-cursor.c:392:210: warning: 'I' flag used with '%x' gnu_printf format [-Wformat=] CHANNEL_DEBUG(channel, "type %s(%d), %" PRIx64 ", %dx%d",