Re: [Spice-devel] [spice-common] utils: Add genum -> string helpers

2018-11-22 Thread Frediano Ziglio
> > This makes it easier to convert enums registered with glib type system > to string in order to print them at runtime. > > Signed-off-by: Christophe Fergeau > --- > common/Makefile.am | 2 ++ > common/meson.build | 2 ++ > common/utils.c | 64

Re: [Spice-devel] spice-vdagent.service not starting

2018-11-22 Thread Frediano Ziglio
Looks like there's a kind of "virus" that set /etc/sysconfig/spice-vdagentd file incorrectly. Try to dump the file like $ cat /etc/sysconfig/spice-vdagentd or even better $ hexdump -C /etc/sysconfig/spice-vdagentd We already has some report of this file with wrong syntax. Looks like some web

[Spice-devel] [spice-common] utils: Add genum -> string helpers

2018-11-22 Thread Christophe Fergeau
This makes it easier to convert enums registered with glib type system to string in order to print them at runtime. Signed-off-by: Christophe Fergeau --- common/Makefile.am | 2 ++ common/meson.build | 2 ++ common/utils.c | 64 ++

Re: [Spice-devel] [spice-server 3/3] dcc: Add debug log when setting compression

2018-11-22 Thread Christophe Fergeau
On Thu, Oct 18, 2018 at 10:17:45AM -0400, Frediano Ziglio wrote: > > + > > +/* These 2 functions come from > > + * libvirt-glib/libvirt-gconfig/libvirt-gconfig-helpers.c > > + * Copyright (C) 2010, 2011 Red Hat, Inc. > > + * LGPLv2.1+ licensed */ > > the license is the same, no reason to state

[Spice-devel] [RFC PATCH spice-gtk] Fix overlay for vaapisink

2018-11-22 Thread Frediano Ziglio
The vaapisink plugin to support overlay requires the application to provide the proper context. If you don't do so the plugin will cause a crash of the application. Note that overlay message should be handled synchronously and not asynchronously so gst_bus_set_sync_handler is used. To avoid

Re: [Spice-devel] [PATCH spice-gtk] spice-channel: Add some comment to spice_channel_read

2018-11-22 Thread Christophe Fergeau
On Wed, Nov 21, 2018 at 11:24:17AM +, Frediano Ziglio wrote: > Document return value. > > Signed-off-by: Frediano Ziglio > --- > src/spice-channel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/spice-channel.c b/src/spice-channel.c > index 1486137e..602869e1 100644 > ---

Re: [Spice-devel] [PATCH spice-gtk] spice-channel: Avoids spice_channel_read_wire returning success

2018-11-22 Thread Christophe Fergeau
Hey, I'm having a hard time reading the commit log. The shortlog could be spice-channel: Don't return 0 when spice_channel_read_wire failed On Thu, Nov 22, 2018 at 09:17:17AM +, Frediano Ziglio wrote: > Although is really unlikely that errno get <= 0 do not returns a > valid result for a

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-22 Thread Frediano Ziglio
> > Hey, > > On Mon, Nov 19, 2018 at 08:46:04PM +, Frediano Ziglio wrote: > > From: Christophe de Dinechin > > > > Allow to use recorder library. See https://github.com/c3d/recorder for > > details. > > The main usage will be to collect statistics while the programs will run. > > By

[Spice-devel] [PATCH spice-gtk] spice-channel: Avoids spice_channel_read_wire returning success

2018-11-22 Thread Frediano Ziglio
Although is really unlikely that errno get <= 0 do not returns a valid result for a failure from spice_channel_read_wire. Such results could end up in buffer overflows. errno is not always set (for instance GLib functions prefer to set a GError instead or Windows uses WSASetLastError to store

Re: [Spice-devel] Feature suggestion: Port tunneling between VM & client over spice-channel

2018-11-22 Thread Javier Celaya
Hi El mié, 21-11-2018 a las 23:38 +0100, Michal Suchánek escribió: > On Wed, 14 Nov 2018 16:16:27 +0100Javier Celaya < > javier.cel...@flexvdi.com> wrote: > > Hi > > FYI, in flexVDI we have already implemented this feature. We just > > hadnot the time to split it into meaningful patches and share