Re: [Spice-devel] [PATCH vdagent-linux 1/4] build: add GIO dependency

2018-11-30 Thread Frediano Ziglio
> > Hi, > > On Sun, Sep 30, 2018 at 08:05:20PM +0200, Jakub Janků wrote: > > Require UNIX-specific GIO package to build spice-vdagent. > > > > This package includes: > > > > - GDBus which is going to be used instead of libdbus in > > console-kit.c and systemd-login.c > > > > - I/O stream

Re: [Spice-devel] [PATCH vdagent-linux 2/4] vport: add @err to disconnect_callback

2018-11-30 Thread Victor Toso
Hi, On Sun, Sep 30, 2018 at 08:05:21PM +0200, Jakub Janků wrote: > This is necessary for the following GMainLoop integration: > > vdagentd currently uses a while-loop in which > vdagent_virtio_port_handle_fds() is repeatedly called. > If an IO error occurs, the function sets virtio_port to NULL.

Re: [Spice-devel] [PATCH vdagent-linux 1/4] build: add GIO dependency

2018-11-30 Thread Victor Toso
Hi, On Sun, Sep 30, 2018 at 08:05:20PM +0200, Jakub Janků wrote: > Require UNIX-specific GIO package to build spice-vdagent. > > This package includes: > > - GDBus which is going to be used instead of libdbus in > console-kit.c and systemd-login.c > > - I/O stream classes and networking APIs

Re: [Spice-devel] spice-vdagent.service not starting

2018-11-30 Thread Emmanual Vnebu
I checked almost all possible options along with some forums... Seems like the channel itself is not getting detected by the host. Like we enable nested VM, is there something that we should do to enable channel communication? I installed Debian on GCP & that too came without the file in /dev

Re: [Spice-devel] [PATCH spice-gtk] spice-widget: Remove useless return statement

2018-11-30 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, Nov 29, 2018 at 05:42:08PM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > src/spice-widget.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/spice-widget.c b/src/spice-widget.c > index 312c640a..9bb42211 100644 > ---

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-30 Thread Christophe Fergeau
Hey, On Thu, Nov 29, 2018 at 12:23:16PM -0500, Frediano Ziglio wrote: > > For example, when Marc-André added the json-glib dependency ( > > https://lists.freedesktop.org/archives/spice-devel/2018-August/045202.html > > ), we did not get first a patch adding the new dep and not doing > >

Re: [Spice-devel] spice-vdagent.service not starting

2018-11-30 Thread Frediano Ziglio
> I checked almost all possible options along with some forums... > Seems like the channel itself is not getting detected by the host. By the host? They are in the client as SPICE channels and in the guest. > Like we enable nested VM, is there something that we should do to enable > channel