Re: [Spice-devel] [PATCH spice-server] tests: Use g_assert_(non)null instead of g_assert

2018-12-03 Thread Uri Lublin
On 12/3/18 7:09 PM, Frediano Ziglio wrote: Just a style change, on more recent GLib would print a more friendly error report. Signed-off-by: Frediano Ziglio Ack. Documentation mentions these macros should only be used in tests and the patch indeed only touches tests. https://developer.gnome

Re: [Spice-devel] [PATCH spice-gtk] spice-widget: Remove useless return statement

2018-12-03 Thread Eduardo Lima (Etrunko)
On 11/29/18 3:42 PM, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > src/spice-widget.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/spice-widget.c b/src/spice-widget.c > index 312c640a..9bb42211 100644 > --- a/src/spice-widget.c > +++ b/src/spice-widget.c > @@ -

Re: [Spice-devel] [PATCH spice] smartcard: set char device state

2018-12-03 Thread Frediano Ziglio
> > Hi > On Mon, Aug 20, 2018 at 2:06 PM Frediano Ziglio wrote: > > > > Without proper testing I would say Nack. > > I though we agreed on this. > > I have done manual testing. We don't have any smartcard channel test > in spice, afaik. > > What you asked me about disabling the device from the

[Spice-devel] [PATCH spice-server] tests: Use g_assert_(non)null instead of g_assert

2018-12-03 Thread Frediano Ziglio
Just a style change, on more recent GLib would print a more friendly error report. Signed-off-by: Frediano Ziglio --- server/tests/test-display-base.c | 2 +- server/tests/test-listen.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/server/tests/test-display-bas

Re: [Spice-devel] Tested latest spice-server on Windows 10 KVM guest

2018-12-03 Thread Carlos González
Ok, finally tried a Windows 10 VM installed from scratch on Proxmox, taking advantage of the fact that 1809 was released. Also used latest Virtio drivers ISO instead of the one labelled "stable". I must say, even the aforementioned "fading" effects problem got better. VM is indeed mostly quite usa