Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-10 Thread Frediano Ziglio
> On Mon, Dec 10, 2018 at 07:42:35AM -0500, Frediano Ziglio wrote: > > > > > > From: Victor Toso > > > > > > Spice client should listen to SpiceMainChannel::agent-connected > > > notification and avoid calling any clipboard related functions such as > > > spice_gtk_session_paste_from_guest()

Re: [Spice-devel] [PATCH spice-gtk] Gstreamer: Control GstVideoOverlay from the widget

2018-12-10 Thread Frediano Ziglio
> > This patch is changing the way gstvideooverlay is being set. I would use the camelcase GstVideoOverlay, not strong about it. > Once pipeline is created a pointer is passed to the widget using > GObject signal, so we can set there the overlay interface and call > its functions from widget

Re: [Spice-devel] [PATCH 5/7] drm/qxl: Don't set the dpms hook

2018-12-10 Thread Gerd Hoffmann
On Mon, Dec 10, 2018 at 11:03:57AM +0100, Daniel Vetter wrote: > Doesn't do anything with atomic. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: virtualizat...@lists.linux-foundation.org > Cc: spice-devel@lists.freedesktop.org > --- >

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-10 Thread Victor Toso
On Mon, Dec 10, 2018 at 07:42:35AM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Spice client should listen to SpiceMainChannel::agent-connected > > notification and avoid calling any clipboard related functions such as > > spice_gtk_session_paste_from_guest() from client-gtk

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-10 Thread Frediano Ziglio
> > From: Victor Toso > > Spice client should listen to SpiceMainChannel::agent-connected > notification and avoid calling any clipboard related functions such as > spice_gtk_session_paste_from_guest() from client-gtk library. > > This patch removes the silent return of agent_clipboard_grab()

[Spice-devel] [spice-gtk v2 3/7] channel-main: clipboard grab: wakeup only when needed

2018-12-10 Thread Victor Toso
From: Victor Toso This patch makes agent_clipboard_grab() to return true only when the message request to the agent is successfully queued to be sent. By checking the return value, we can avoid wakup the channel unnecessarily at spice_main_channel_clipboard_selection_request() Signed-off-by:

[Spice-devel] [spice-gtk v2 4/7] channel-main: clipboard release: wakeup only when needed

2018-12-10 Thread Victor Toso
From: Victor Toso This patch makes agent_clipboard_release() to return true only when the message request to the agent is successfully queued to be sent. By checking the return value, we can avoid wakeup the channel unnecessarily at spice_main_channel_clipboard_selection_release()

[Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-10 Thread Victor Toso
From: Victor Toso Spice client should listen to SpiceMainChannel::agent-connected notification and avoid calling any clipboard related functions such as spice_gtk_session_paste_from_guest() from client-gtk library. This patch removes the silent return of agent_clipboard_grab() in order to

[Spice-devel] [spice-gtk v2 0/7] small code improvements on clipboard

2018-12-10 Thread Victor Toso
From: Victor Toso v1: https://lists.freedesktop.org/archives/spice-devel/2018-December/046337.html From v1, pushed two patches and the other two are the 01/07 and 07/07 in this series. The extra 5 changes, with channel-main prefix, they are related to the discussin with Frediano in the v1. The

[Spice-devel] [spice-gtk v2 2/7] channel-main: clipboard request: wakeup only when needed

2018-12-10 Thread Victor Toso
From: Victor Toso This patch makes agent_clipboard_request() to return true only when the message request to the agent is successfully queued to be sent. By checking the return value, we can avoid wakeup the channel unnecessarily at spice_main_channel_clipboard_selection_request()

[Spice-devel] [spice-gtk v2 5/7] channel-main: clipboard release: don't fail silently

2018-12-10 Thread Victor Toso
From: Victor Toso Spice client should listen to SpiceMainChannel::agent-connected notification and avoid calling any clipboard related functions such as spice_gtk_session_paste_from_guest() from client-gtk library. This patch removes the silent return of

[Spice-devel] [spice-gtk v2 7/7] gtk-session: remove extra clipboard selection check

2018-12-10 Thread Victor Toso
From: Victor Toso Commit 284c1f2d switched to spice_main_channel_clipboard_selection_release() which does check if agent is connected and does the right thing (expected) in regards to releasing the clipboard by calling agent_clipboard_release() which does check VD_AGENT_CAP_CLIPBOARD_SELECTION

[Spice-devel] [spice-gtk v2 1/7] gtk-session: prefer early check to agent connectivity

2018-12-10 Thread Victor Toso
From: Victor Toso In case the agent is disconnected, we we don't need to create the struct RunInfo, GMainLoop and add handlers to some signals. Before this patch, spice_main_channel_clipboard_selection_request() was always called even if agent was not connected, which would log a critical

Re: [Spice-devel] [PATCH spice-gtk] Gstreamer: Control GstVideoOverlay from the widget

2018-12-10 Thread Christophe Fergeau
Hey, On Sun, Dec 09, 2018 at 03:26:30PM +0200, Snir Sheriber wrote: > This patch is changing the way gstvideooverlay is being set. > Once pipeline is created a pointer is passed to the widget using > GObject signal, so we can set there the overlay interface and call > its functions from widget