[Spice-devel] [spice-gtk v2 1/2] Deprecate “color-depth” properties

2018-12-14 Thread Victor Toso
From: Victor Toso With commit 1a980f3712 we deprecated some command line options. The color-depth one is the only one which is not used for testing/debug purposes. The intention of this option is to set guest's video driver color configuration, currently only windows guest agent uses this featur

[Spice-devel] [spice-gtk v2 2/2] option: Hide --spice-color-depth and warn on usage

2018-12-14 Thread Victor Toso
From: Victor Toso As this is NOP from previous patch and has been deprecated since v0.34 Signed-off-by: Victor Toso --- src/spice-option.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/src/spice-option.c b/src/spice-option.c index 6b400bc..f6

Re: [Spice-devel] [spice-gtk v2 5/7] channel-main: clipboard release: don't fail silently

2018-12-14 Thread Victor Toso
Hi, On Thu, Dec 13, 2018 at 04:06:11PM +0200, Uri Lublin wrote: > On 12/10/18 1:02 PM, Victor Toso wrote: > > From: Victor Toso > > > > Spice client should listen to SpiceMainChannel::agent-connected > > notification and avoid calling any clipboard related functions such as > > spice_gtk_session

Re: [Spice-devel] [spice-gtk v1 1/2] Deprecate “color-depth” properties

2018-12-14 Thread Victor Toso
Hi, On Wed, Dec 12, 2018 at 05:46:57PM +0100, Christophe Fergeau wrote: > On Tue, Dec 11, 2018 at 01:48:14PM +0100, Victor Toso wrote: > > @@ -297,8 +296,8 @@ static void spice_main_get_property(GObject*object, > > case PROP_DISPLAY_DISABLE_ANIMATION: > > g_value_set_boolean(valu

Re: [Spice-devel] [spice-gtk v1 1/2] Deprecate “color-depth” properties

2018-12-14 Thread Victor Toso
Hi, On Thu, Dec 13, 2018 at 06:16:36PM +0200, Uri Lublin wrote: > On 12/11/18 2:48 PM, Victor Toso wrote: > > From: Victor Toso > > > > With commit 1a980f3712 we deprecated some command line options. The > > color-depth one is the only one which is not used for testing/debug > > purposes. > > >

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-14 Thread Frediano Ziglio
> Hi, > > On Wed, Dec 12, 2018 at 06:43:04AM -0500, Frediano Ziglio wrote: > > > Documentation saying that this feature rely on agent seems to be > > > lacking. e.g: grep for 'agent' on SpiceGtkSession > > > > > > > As spice-gtk is a public library with an API speaking of "Spice > > > > client" i

Re: [Spice-devel] How to use spice floder sharing

2018-12-14 Thread Victor Toso
Hi, On Fri, Dec 14, 2018 at 10:42:11AM +0800, wangjiedong wrote: > I followed the way to configure Floder sharing on > https://www.spice-space.org/spice-user-manual.html > > The configuration of vm XML is ok , but on Windows 7 vm the > spice-webdavd service's status is allways stopped after > inst