Re: [Spice-devel] Can libspice be moved into guest os(virtual machine)?

2018-12-17 Thread 陈炤
Hi Christophe, Thanks for your information, and that helps a lot. I will download this project to have a deeper look. BR Don At 2018-12-17 17:21:57, "Christophe Fergeau" wrote: >Hey, > >On Mon, Dec 17, 2018 at 10:37:02AM +0800, 陈炤 wrote: >> Below is how SPICE handles commands: >> >>

Re: [Spice-devel] Adding support for mouse buttons SIDE and EXTRA (often scroll wheel push left or right)

2018-12-17 Thread Frediano Ziglio
> > > > > I have a Logitech G600 mouse. The scroll wheel can be pushed left or > > right. > > > > On Arch Linux host, evtest shows these as event codes 275 (BTN_SIDE) > > and 276 (BTN_EXTRA.) On host, they work as expected, by default as > > back and forward in supported programs such as web

Re: [Spice-devel] [PATCH linux vdagent 06/10] Make clearer distinctions between output ids

2018-12-17 Thread Lukáš Hrázký
On Thu, 2018-12-13 at 16:46 -0600, Jonathon Jongsma wrote: > There are basically three ways to refer to an output within vdagent: > - The index of the array of MonitorConfig message. This is essentially > a "spice display id" > - the index of the array of xrandr outputs. This is the

Re: [Spice-devel] [PATCH linux vdagent 02/10] Fix confusion between output index and crtc index

2018-12-17 Thread Lukáš Hrázký
On Thu, 2018-12-13 at 16:46 -0600, Jonathon Jongsma wrote: > Get the CRTC ID from the output struct rather than using the > output_index as an index into the array of crtcs > --- > src/vdagent/x11-randr.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH linux vdagent 01/10] Add lookup_xrand_output_for_device_info()

2018-12-17 Thread Lukáš Hrázký
* Hello, On Thu, 2018-12-13 at 16:46 -0600, Jonathon Jongsma wrote: > Add a function to look up an xrandr output for a given device display > id. This uses sysfs and the drm subsystem to lookup information about a > graphics device output. It then compares the drm output name to xrandr > output

Re: [Spice-devel] Adding support for mouse buttons SIDE and EXTRA (often scroll wheel push left or right)

2018-12-17 Thread Frediano Ziglio
> > I have a Logitech G600 mouse. The scroll wheel can be pushed left or right. > > On Arch Linux host, evtest shows these as event codes 275 (BTN_SIDE) > and 276 (BTN_EXTRA.) On host, they work as expected, by default as > back and forward in supported programs such as web browsers. > >

[Spice-devel] [PATCH spice-gtk] More cleanup for old protocol support

2018-12-17 Thread Frediano Ziglio
Support for protocol version 1 was dropped in commit f77a1d50. Signed-off-by: Frediano Ziglio --- src/channel-base.c | 4 --- src/channel-main.c | 69 +++--- 2 files changed, 29 insertions(+), 44 deletions(-) Patch much smaller seen ignoring space

Re: [Spice-devel] [PATCH spice-gtk 2/3] fixup! Gstreamer: Control GstVideoOverlay from the widget

2018-12-17 Thread Frediano Ziglio
> > Hi, > > On 12/17/18 11:51 AM, Frediano Ziglio wrote: > > --- > > src/channel-display.c | 2 ++ > > src/spice-widget-priv.h | 3 +-- > > src/spice-widget.c | 51 - > > 3 files changed, 23 insertions(+), 33 deletions(-) > > > > diff --git

[Spice-devel] [PATCH spice-common v2 1/2] test-region: Add missing dependencies

2018-12-17 Thread Frediano Ziglio
The test uses both GLib and pixman libraries. This does not seem to affect Linux but make the test fails under Windows. Signed-off-by: Frediano Ziglio --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) Changes since v1: - use SPICE_COMMON_LIBS diff --git a/tests/Makefile.am

[Spice-devel] [RFC PATCH spice-common] marshaller: Provide spice_marshaller_fill_iovec for Windows

2018-12-17 Thread Frediano Ziglio
An array of WSABUF can be used with WSASend. Signed-off-by: Frediano Ziglio --- common/marshaller.c | 10 -- common/marshaller.h | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) This will allow to port spice-server to Windows, spice_marshaller_fill_iovec is used only by

[Spice-devel] [PATCH spice-gtk 2/3] fixup! Gstreamer: Control GstVideoOverlay from the widget

2018-12-17 Thread Frediano Ziglio
--- src/channel-display.c | 2 ++ src/spice-widget-priv.h | 3 +-- src/spice-widget.c | 51 - 3 files changed, 23 insertions(+), 33 deletions(-) diff --git a/src/channel-display.c b/src/channel-display.c index 6b6a172c..e63fb3bb 100644 ---

[Spice-devel] [PATCH spice-gtk 0/3] Overlay patches with follow ups

2018-12-17 Thread Frediano Ziglio
Mainly styles updates to previous one. Frediano Ziglio (1): fixup! Gstreamer: Control GstVideoOverlay from the widget Snir Sheriber (2): Gstreamer: Control GstVideoOverlay from the widget Gstreamer: fix window resize when using GstVideoOverlay src/channel-display-gst.c | 30 +++

[Spice-devel] [PATCH spice-gtk 1/3] Gstreamer: Control GstVideoOverlay from the widget

2018-12-17 Thread Frediano Ziglio
From: Snir Sheriber This patch is changing the way GstVideoOverlay is being set. Once pipeline is created a pointer is passed to the widget using GObject signal, so we can set there the overlay interface and call its functions from widget callbacks. This allows to solve issues like resizing the

[Spice-devel] [PATCH spice-gtk 3/3] Gstreamer: fix window resize when using GstVideoOverlay

2018-12-17 Thread Frediano Ziglio
From: Snir Sheriber With previous patch changes it's now possible to call GstVideoOverlay interface functions in response to matching gtk events. This patch fixes the window resize and possibly other rendering issues. Signed-off-by: Snir Sheriber --- src/spice-widget.c | 42

Re: [Spice-devel] [PATCH spice-common 1/3] test-marshaller: Make test_overflow static

2018-12-17 Thread Uri Lublin
On 12/16/18 2:39 PM, Frediano Ziglio wrote: Not used outside the test. Signed-off-by: Frediano Ziglio Acked-by: Uri Lublin Uri. --- tests/test-marshallers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-marshallers.c b/tests/test-marshallers.c index

Re: [Spice-devel] [PATCH spice-common 3/3] test-region: Add missing dependencies

2018-12-17 Thread Uri Lublin
On 12/16/18 2:39 PM, Frediano Ziglio wrote: The test uses both GLib and pixman libraries. This does not seem to affect Linux but make the test fails under Windows. Hi, Looks good, with a comment. Signed-off-by: Frediano Ziglio --- tests/Makefile.am | 4 1 file changed, 4

Re: [Spice-devel] [PATCH spice-common] ci: Run tests on Windows using wine

2018-12-17 Thread Frediano Ziglio
> > Hey, I'm assuming these tests are currently successful? > If yes, > > Acked-by: Christophe Fergeau > Requires patch 3/3 of previous series, CI results at https://gitlab.freedesktop.org/fziglio/spice-common/pipelines/12492 > On Sun, Dec 16, 2018 at 05:57:55PM +, Frediano Ziglio wrote:

Re: [Spice-devel] [PATCH spice-common] ci: Run tests on Windows using wine

2018-12-17 Thread Christophe Fergeau
Hey, I'm assuming these tests are currently successful? If yes, Acked-by: Christophe Fergeau On Sun, Dec 16, 2018 at 05:57:55PM +, Frediano Ziglio wrote: > As spice-common is used by spice-gtk which should run on Windows > even spice-common should compile and run on Windows so check it >

Re: [Spice-devel] Can libspice be moved into guest os(virtual machine)?

2018-12-17 Thread Snir Sheriber
Hi, On 12/17/18 4:37 AM, 陈炤 wrote: Hi, Below is how SPICE handles commands: For some reason I want to move the lipspice code into guest OS(rather than in qemu), and the structure would look like: Is that possible? Please look at x11spice, might be what you're looking for

Re: [Spice-devel] Can libspice be moved into guest os(virtual machine)?

2018-12-17 Thread Christophe Fergeau
Hey, On Mon, Dec 17, 2018 at 10:37:02AM +0800, 陈炤 wrote: > Below is how SPICE handles commands: > > > For some reason I want to move the lipspice code into guest OS(rather than in > qemu), and the structure would look like: Have you looked at Xspice/x11spice? they might be doing something

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] Gstreamer: Control GstVideoOverlay from the widget

2018-12-17 Thread Frediano Ziglio
> > This patch is changing the way GstVideoOverlay is being set. > Once pipeline is created a pointer is passed to the widget using > GObject signal, so we can set there the overlay interface and call > its functions from widget callbacks. This allows to solve issues > like resizing the window. >