Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2018-12-20 Thread james harvey
On Thu, Dec 20, 2018 at 12:36 PM Christophe Fergeau wrote: > Hey, > > With this patch applied, I cannot seem to be able to copy from client to > guest when using wayland. > > Christophe I admit I only have a vague understanding of what Wayland is. I'm using Xorg & Plasma on Arch Linux. Some

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2018-12-20 Thread Christophe Fergeau
Hey, With this patch applied, I cannot seem to be able to copy from client to guest when using wayland. Christophe On Wed, Dec 19, 2018 at 03:29:44PM +0100, Victor Toso wrote: > From: Victor Toso > > If SpiceGtkSession is holding the keyboard, that's huge indication > that we should not be

Re: [Spice-devel] [PATCH spice-gtk] Do not include unused common/ring.h header

2018-12-20 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, Dec 20, 2018 at 04:00:30PM +, Frediano Ziglio wrote: > Commit 4398554be49b removed last usage of Ring/RingItem structures, > there's no need to include the header anymore. > > Signed-off-by: Frediano Ziglio > --- > src/channel-display-priv.h | 1 - >

[Spice-devel] [PATCH spice-gtk] Do not include unused common/ring.h header

2018-12-20 Thread Frediano Ziglio
Commit 4398554be49b removed last usage of Ring/RingItem structures, there's no need to include the header anymore. Signed-off-by: Frediano Ziglio --- src/channel-display-priv.h | 1 - src/spice-channel-cache.h | 1 - src/spice-session.c| 1 - 3 files changed, 3 deletions(-) diff --git

Re: [Spice-devel] [PATCH spice] reds: don't unlink existing UNIX socket

2018-12-20 Thread Daniel P . Berrangé
On Thu, Dec 20, 2018 at 06:58:34PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Dec 20, 2018 at 5:44 PM Daniel P. Berrangé > wrote: > > > > On Thu, Dec 20, 2018 at 05:37:40PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Since "reds: add Unix socket

Re: [Spice-devel] [PATCH spice] reds: don't unlink existing UNIX socket

2018-12-20 Thread Marc-André Lureau
Hi On Thu, Dec 20, 2018 at 5:44 PM Daniel P. Berrangé wrote: > > On Thu, Dec 20, 2018 at 05:37:40PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Since "reds: add Unix socket support" (commit > > 5365caeaae537f564d160936e60f71b2dc964ad1), the Spice server will >

Re: [Spice-devel] [PATCH spice] reds: don't unlink existing UNIX socket

2018-12-20 Thread Daniel P . Berrangé
On Thu, Dec 20, 2018 at 05:37:40PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since "reds: add Unix socket support" (commit > 5365caeaae537f564d160936e60f71b2dc964ad1), the Spice server will > remove existing socket before binding. > > Although it may seem handy at

[Spice-devel] [PATCH spice] reds: don't unlink existing UNIX socket

2018-12-20 Thread marcandre . lureau
From: Marc-André Lureau Since "reds: add Unix socket support" (commit 5365caeaae537f564d160936e60f71b2dc964ad1), the Spice server will remove existing socket before binding. Although it may seem handy at first, this is a bad idea, as it may create confusion (or worse). Fortunately, passing the

Re: [Spice-devel] [PATCH vdagent-linux 3/4] introduce VDAgentConnection

2018-12-20 Thread Victor Toso
Hi, On Tue, Dec 11, 2018 at 06:39:39PM +0100, Jakub Janku wrote: > Hi, Victor! > > Many thanks for reviewing this series. > > On Thu, Dec 6, 2018 at 4:20 PM Victor Toso wrote: > > > > Hi, > > > > First of all, tested. Seems to work fine! > > Great! > > > > This one I think it can be improved

Re: [Spice-devel] [PATCH spice-gtk 4/4] spicy-screenshot: Make some variable static

2018-12-20 Thread Snir Sheriber
Hi, s/variable/variables Ack for the series Nice, i never used this tool, by now :p Snir. On 12/19/18 3:25 PM, Frediano Ziglio wrote: Not used outside this module. Also update indentation. Signed-off-by: Frediano Ziglio --- tools/spicy-screenshot.c | 6 +++--- 1 file changed, 3

Re: [Spice-devel] [vdagent-linux v2 1/2] systemd: Remove unneded virtio-port dependencies

2018-12-20 Thread Frediano Ziglio
> > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket > to the relevant virtio devices, which automatically adds Wants=${device} > to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket'). > Adding a Requisite/After for these ports is at best redundant, and most > likely

Re: [Spice-devel] [vdagent-linux v2] systemd: Remove unneded virtio-port dependencies

2018-12-20 Thread Frediano Ziglio
> On Wed, Dec 19, 2018 at 09:52:57AM -0500, Frediano Ziglio wrote: > > The "Requisite" still prevents the socket to be activated with a > > "systemctl enable spice-vdagentd.socket" launched manually. > > You can obviously complaint that users should not do that but > > I don't think that if the