This file was used by the old client to hold return error codes.
Signed-off-by: Frediano Ziglio
---
spice/Makefile.am | 1 -
spice/error_codes.h | 51 -
spice/meson.build | 1 -
3 files changed, 53 deletions(-)
delete mode 100644
Signed-off-by: Frediano Ziglio
---
README.Windows | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 README.Windows
diff --git a/README.Windows b/README.Windows
new file mode 100644
index ..2274eba4
--- /dev/null
+++ b/README.Windows
@@ -0,0 +1,18 @@
+SPICE
Allows the compiler to catch errors mixing int and sockets.
Make easier to keep Windows port working.
Signed-off-by: Frediano Ziglio
---
server/sys-socket.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/sys-socket.h b/server/sys-socket.h
index 9dca563b..361845e2
If input contains the binary record we can't have it modified
during read.
Signed-off-by: Frediano Ziglio
---
server/tests/replay.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index cbb1c195..c8e10d0a 100644
--- a/server/tests/replay.c
Set correctly errno to make callers handle correctly encrypted
traffic.
Signed-off-by: Frediano Ziglio
---
server/red-stream.c | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)
diff --git a/server/red-stream.c b/server/red-stream.c
index a6da8385..687d6ca2
Replace poll call with select.
As socket is set to non-blocking we must support it so if
we detect an EAGAIN error wait for data.
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 20
1 file changed, 20 insertions(+)
diff --git a/server/dispatcher.c
Use GLib function to launch and wait process exit.
Signed-off-by: Frediano Ziglio
---
server/tests/regression-test.py | 4 ++--
server/tests/test-display-base.c | 37 +++-
2 files changed, 19 insertions(+), 22 deletions(-)
diff --git
Signed-off-by: Frediano Ziglio
---
server/tests/Makefile.am | 2 +
server/tests/test-channel.c | 1 +
server/tests/test-loop.c | 1 +
server/tests/test-stream-device.c | 1 +
server/tests/win-alarm.c | 65 +++
Client process termination did not work for Windows, used Win32
APIs.
Signed-off-by: Frediano Ziglio
---
server/tests/replay.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index c8e10d0a..58630711 100644
---
usleep under Windows does not seem to have the required precision.
Use milliseconds and adjust check times according.
Signed-off-by: Frediano Ziglio
---
server/tests/stat-test.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/server/tests/stat-test.c
MingW does not include this header while including stdint.h so
on Windows you need to include it.
Signed-off-by: Frediano Ziglio
---
server/reds.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/reds.h b/server/reds.h
index 8481d7c6..f192b563 100644
--- a/server/reds.h
+++
Although this feature can be ported to Windows doing so would
require the usage of g_spawn_async_with_fds, which is only available
in GLib 2.58 or some specific Win32 code.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c| 8 ++--
server/tests/test-record.c | 7 +--
2
Use g_io_channel_win32_new_socket instead of g_io_channel_unix_new
Signed-off-by: Frediano Ziglio
---
server/event-loop.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/server/event-loop.c b/server/event-loop.c
index 56200ce5..72af9ab9 100644
--- a/server/event-loop.c
+++
Windows does not support Unix sockets.
Signed-off-by: Frediano Ziglio
---
server/tests/test-listen.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/server/tests/test-listen.c b/server/tests/test-listen.c
index 640e8f12..2fd4b5a3 100644
--- a/server/tests/test-listen.c
+++
Signed-off-by: Frediano Ziglio
---
server/tests/basic-event-loop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/tests/basic-event-loop.c b/server/tests/basic-event-loop.c
index 607a5a5e..76b0580e 100644
--- a/server/tests/basic-event-loop.c
+++
Signed-off-by: Frediano Ziglio
---
server/tests/test-stream.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/tests/test-stream.c b/server/tests/test-stream.c
index d56109d1..54fbf259 100644
--- a/server/tests/test-stream.c
+++ b/server/tests/test-stream.c
@@
- global signals;
- CLOEXEC flag;
- mmap and statistics;
- IPTOS_LOWDELAY flag;
- Unix sockets;
- sharing file descriptors through Unix sockets;
- TCP_CORK flag.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 2 ++
server/red-stream.c | 11 ++-
Signed-off-by: Frediano Ziglio
---
server/tests/test-leaks.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/server/tests/test-leaks.c b/server/tests/test-leaks.c
index 64130c22..98f9cb67 100644
--- a/server/tests/test-leaks.c
+++ b/server/tests/test-leaks.c
@@
Signed-off-by: Frediano Ziglio
---
server/tests/test-channel.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/server/tests/test-channel.c b/server/tests/test-channel.c
index 1c9148df..fef295a3 100644
--- a/server/tests/test-channel.c
+++
Signed-off-by: Frediano Ziglio
---
server/red-qxl.c | 1 +
server/reds.c| 3 +++
2 files changed, 4 insertions(+)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index cec3eefb..886bf9f5 100644
--- a/server/red-qxl.c
+++ b/server/red-qxl.c
@@ -39,6 +39,7 @@
#include "red-qxl.h"
Signed-off-by: Frediano Ziglio
---
server/red-common.h | 4 +-
server/reds-private.h | 4 +-
server/reds.c | 94 +++
server/reds.h | 2 +-
4 files changed, 56 insertions(+), 48 deletions(-)
diff --git a/server/red-common.h
Allows to easier port socketpair.
Windows does not have this function, we need to create a pair
using 2 internet sockets and connecting one to the other.
Signed-off-by: Frediano Ziglio
---
server/sys-socket.c | 75 +
server/sys-socket.h | 7 +
2
Mainly SPICE server uses lot of libraries to expose a TCP protocol.
As TCP is implemented with socket library which is quite portable was
not that hard to port.
Beside some minor feature (see REAME.Windows) all was ported.
During porting was choosen to keep Unix as the main platform, if a
change
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 26 +-
server/dispatcher.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index 3e27f2c2..4cd91f11 100644
--- a/server/dispatcher.c
+++
Signed-off-by: Frediano Ziglio
---
server/sound.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 44b27dec..00b473a8 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -775,14 +775,13 @@ static void
Signed-off-by: Frediano Ziglio
---
server/red-stream.c | 32 +---
server/red-stream.h | 4 ++--
2 files changed, 19 insertions(+), 17 deletions(-)
diff --git a/server/red-stream.c b/server/red-stream.c
index 57034a64..33086d99 100644
--- a/server/red-stream.c
+++
Windows needs some specific setting to use network.
Signed-off-by: Frediano Ziglio
---
configure.ac | 18 +-
server/Makefile.am | 1 +
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 96e4e66c..a2a81cef 100644
---
Between Unix and Windows socket are quite different:
- on Windows sockets have a different namespace from C file
descriptors so you can't use read/write/close or similar functions;
- errors are not stored in errno but you must be read/write the
errors with specific function;
- sometimes
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red-channel-client.c b/server/red-channel-client.c
index 375a60b3..07f1988d 100644
--- a/server/red-channel-client.c
+++ b/server/red-channel-client.c
@@
Signed-off-by: Frediano Ziglio
---
server/event-loop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/event-loop.c b/server/event-loop.c
index 413102e8..56200ce5 100644
--- a/server/event-loop.c
+++ b/server/event-loop.c
@@ -153,16 +153,16 @@ static void
This is a preparatory patch for next portability patches
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 2 ++
server/net-utils.c | 2 ++
server/red-channel-client.c | 6 --
server/red-qxl.c | 1 -
server/red-stream.c
These constants are meant to be used in format string for size_t
types. Use them for portability.
Signed-off-by: Frediano Ziglio
---
server/gstreamer-encoder.c | 2 +-
server/red-channel.c | 5 +++--
server/red-client.c| 4 ++--
server/red-replay-qxl.c| 4 ++--
server/reds.c
Not supported.
Signed-off-by: Frediano Ziglio
--
TODO find a better solution
---
server/reds.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index aa3f8ca7..2874bd4c 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3582,7 +3582,14 @@ static const
Signed-off-by: Frediano Ziglio
---
server/net-utils.c | 33 +
server/net-utils.h | 10 ++
2 files changed, 27 insertions(+), 16 deletions(-)
diff --git a/server/net-utils.c b/server/net-utils.c
index 802509a4..8a5b62cb 100644
--- a/server/net-utils.c
+++
On Thu, Dec 20, 2018 at 04:41:48PM -0500, james harvey wrote:
> On Thu, Dec 20, 2018 at 12:36 PM Christophe Fergeau
> wrote:
> > Hey,
> >
> > With this patch applied, I cannot seem to be able to copy from client to
> > guest when using wayland.
> >
> > Christophe
>
> I admit I only have a vague
Hi,
On Thu, Dec 20, 2018 at 06:36:02PM +0100, Christophe Fergeau wrote:
> Hey,
>
> With this patch applied, I cannot seem to be able to copy from client to
> guest when using wayland.
>
> Christophe
You are right... I thought I had tested it properly...
> On Wed, Dec 19, 2018 at 03:29:44PM
Signed-off-by: Frediano Ziglio
---
server/tests/test-playback.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/server/tests/test-playback.c b/server/tests/test-playback.c
index a62b8299..87469c8e 100644
--- a/server/tests/test-playback.c
+++ b/server/tests/test-playback.c
@@ -87,9 +87,6
We are waiting for a client connection, channel is already there
Signed-off-by: Frediano Ziglio
---
server/tests/test-playback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/tests/test-playback.c b/server/tests/test-playback.c
index 32f091ef..a62b8299 100644
Split level computation, make clear is a sine wave on both channels.
Signed-off-by: Frediano Ziglio
---
server/tests/test-playback.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/tests/test-playback.c b/server/tests/test-playback.c
index 87469c8e..290c8609 100644
We just fill it up, can't be NULL.
Signed-off-by: Frediano Ziglio
---
server/tests/test-playback.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/tests/test-playback.c b/server/tests/test-playback.c
index cbefb9b0..32f091ef 100644
---
40 matches
Mail list logo
