From: Marc-André Lureau
Add required dependency on gstreamer to fix unresolved GstPipeline
type warning:
:: Warning: SpiceClientGLib: (Signal)gst-video-overlay: argument
pipeline: Unresolved type: 'GstPipeline'
Signed-off-by: Marc-André Lureau
---
src/Makefile.am | 2 +-
From: Marc-André Lureau
GStreamer is being increasingly used by spice-gtk. Let's make it a
core requirement.
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml| 2 --
configure.ac | 32 ++--
meson.build | 18 --
meson_options.txt |
From: Marc-André Lureau
Deprecated for several releases now (v0.31).
Signed-off-by: Marc-André Lureau
---
configure.ac | 10 --
1 file changed, 10 deletions(-)
diff --git a/configure.ac b/configure.ac
index 69c03da..ff5114e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -195,16
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/spice-widget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 87c1560..a44a6f1 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2601,7 +2601,7 @@
From: Marc-André Lureau
Hi,
The series drops support for optional GStreamer dependency. Spice
increasingly require GStreamer for audio and video support. GStreamer
is widely available, including in embedded space.
Marc-André Lureau (5):
build-sys: remove autoconf --with-audio=..
build-sys:
From: Marc-André Lureau
GStreamer is being increasingly used by spice-gtk. Let's make it a
core requirement.
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml | 2 --
configure.ac | 41 ++
meson.build| 17
Signed-off-by: Frediano Ziglio
---
src/vdagent/vdagent.c | 16
src/vdagentd/vdagentd.c | 16
2 files changed, 24 insertions(+), 8 deletions(-)
Changes since v2:
- avoid long if chaining.
diff --git a/src/vdagent/vdagent.c b/src/vdagent/vdagent.c
index
Signed-off-by: Frediano Ziglio
---
src/udscs.c| 2 ++
src/vdagent/x11.c | 2 ++
src/vdagentd/virtio-port.c | 1 +
3 files changed, 5 insertions(+)
diff --git a/src/udscs.c b/src/udscs.c
index 05fe41b..32bd6e6 100644
--- a/src/udscs.c
+++ b/src/udscs.c
@@ -341,12 +341,14
>
> On Fri, Jan 04, 2019 at 08:37:02AM +, Frediano Ziglio wrote:
> > We need to pass original argument list, however argv is modified by
>
> "the original argument list.."
>
> > g_option_context_parse so save a copy of the array to make possible
> > to restart with the same arguments.
>
>
Acked-by: Christophe Fergeau
On Fri, Jan 04, 2019 at 08:37:04AM +, Frediano Ziglio wrote:
> Remove HAVE_CONFIG_H check, is always defined.
"it is always defined"
> Remove indentation of includes, now not in a condition and also
> some were indented some not.
"now the include is not in a
>
> On Fri, Jan 04, 2019 at 08:23:15AM +, Frediano Ziglio wrote:
> > The SpiceStat structure can be 20 or 24 bytes depending on alignment.
> > Being a memory mapped structure potentially used with lockless access,
> > it is not good to have it unaligned.
> > The current tool that reads this
Acked-by: Christophe Fergeau
I was looking for these in the previous patch ;)
On Fri, Jan 04, 2019 at 08:37:05AM +, Frediano Ziglio wrote:
> Make sure all module files include config.h
>
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagentd/console-kit.c| 1 +
>
On Fri, Jan 04, 2019 at 08:37:03AM +, Frediano Ziglio wrote:
> People can think that 32 means 32 bit while is always a long.
"it is always"
>
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/x11.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/vdagent/x11.c
On Fri, Jan 04, 2019 at 08:37:02AM +, Frediano Ziglio wrote:
> We need to pass original argument list, however argv is modified by
"the original argument list.."
> g_option_context_parse so save a copy of the array to make possible
> to restart with the same arguments.
"to make it possible"
On Fri, Jan 04, 2019 at 08:37:01AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/vdagent.c | 10 ++
> src/vdagentd/vdagentd.c | 10 ++
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/src/vdagent/vdagent.c
On Fri, Jan 04, 2019 at 08:36:59AM +, Frediano Ziglio wrote:
> Different tools (compilers or analysers) recognise missing break
> in switch as possible problems.
> Many recognise "fall through" comment to tell is wanted.
a "fall through" comment (I think), "to tell it is wanted"
Acked-by:
>
> Hi
>
> On Fri, Jan 4, 2019 at 1:27 PM Frediano Ziglio wrote:
> >
> > >
> > > Hi
> > >
> > > On Fri, Jan 4, 2019 at 1:04 PM Frediano Ziglio
> > > wrote:
> > > >
> > > > Actually was decided was an internal signal so we agreed to not keep
> > > > it...
> > >
> > > There is no such thing as
Hey,
On Thu, Jan 03, 2019 at 04:25:00PM -0600, Eric Blake wrote:
> On 12/27/18 8:51 AM, Niccolò Belli wrote:
> > On mercoledì 26 dicembre 2018 13:38:28 CET, Frediano Ziglio wrote:
> >> Yes, this looks like a format string error in the upper (not into
> >> spice) layer.
> >>
> >> This potentially
On Fri, Jan 04, 2019 at 08:23:15AM +, Frediano Ziglio wrote:
> The SpiceStat structure can be 20 or 24 bytes depending on alignment.
> Being a memory mapped structure potentially used with lockless access,
> it is not good to have it unaligned.
> The current tool that reads this memory mapped
Hi
On Fri, Jan 4, 2019 at 1:27 PM Frediano Ziglio wrote:
>
> >
> > Hi
> >
> > On Fri, Jan 4, 2019 at 1:04 PM Frediano Ziglio wrote:
> > >
> > > Actually was decided was an internal signal so we agreed to not keep it...
> >
> > There is no such thing as internal signal, and it wasn't documented
On Thu, Jan 03, 2019 at 12:15:02PM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Jan 02, 2019 at 02:58:45PM +, Frediano Ziglio wrote:
> > > Windows needs some specific setting to use network.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > configure.ac | 20 +++-
>
> Hi
>
> On Fri, Jan 4, 2019 at 1:04 PM Frediano Ziglio wrote:
> >
> > Actually was decided was an internal signal so we agreed to not keep it...
>
> There is no such thing as internal signal, and it wasn't documented as
> such either. It is available in 0.35.
>
Yes, there is, for some
Hi
On Fri, Jan 4, 2019 at 1:04 PM Frediano Ziglio wrote:
>
> Actually was decided was an internal signal so we agreed to not keep it...
There is no such thing as internal signal, and it wasn't documented as
such either. It is available in 0.35.
It needs to remains, or you may break users, at
Actually was decided was an internal signal so we agreed to not keep it...
- Original Message -
> From: "Victor Toso"
> To: "marcandre lureau"
> Cc: spice-devel@lists.freedesktop.org
> Sent: Friday, 4 January, 2019 9:03:07 AM
> Subject: Re: [Spice-devel] [PATCH spice-gtk] display: add
Hi,
On Fri, Jan 04, 2019 at 12:57:34PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The signal was added in 0.35, but removed in
> 8c5bf5dedab3cd5a9c7ac484c0d97d43aeb0056b. We should keep it for a
> while with updated documentation and a G_SIGNAL_DEPRECATED flag.
>
>
From: Marc-André Lureau
The signal was added in 0.35, but removed in
8c5bf5dedab3cd5a9c7ac484c0d97d43aeb0056b. We should keep it for a
while with updated documentation and a G_SIGNAL_DEPRECATED flag.
Signed-off-by: Marc-André Lureau
---
src/channel-display.c | 25 +
1
Signed-off-by: Frediano Ziglio
---
src/udscs.c| 2 ++
src/vdagent/x11.c | 2 ++
src/vdagentd/virtio-port.c | 1 +
3 files changed, 5 insertions(+)
diff --git a/src/udscs.c b/src/udscs.c
index 7fe74b9..fe2cf8c 100644
--- a/src/udscs.c
+++ b/src/udscs.c
@@ -343,12 +343,14
People can think that 32 means 32 bit while is always a long.
Signed-off-by: Frediano Ziglio
---
src/vdagent/x11.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vdagent/x11.c b/src/vdagent/x11.c
index c9c2e02..bc37a0e 100644
--- a/src/vdagent/x11.c
+++ b/src/vdagent/x11.c
@@ -727,6
Different tools (compilers or analysers) recognise missing break
in switch as possible problems.
Many recognise "fall through" comment to tell is wanted.
Signed-off-by: Frediano Ziglio
---
src/vdagentd/vdagentd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vdagentd/vdagentd.c
Remove HAVE_CONFIG_H check, is always defined.
Remove indentation of includes, now not in a condition and also
some were indented some not.
Signed-off-by: Frediano Ziglio
---
src/udscs.c | 2 --
src/vdagent/audio.c | 3 ---
src/vdagent/clipboard.c | 5 +
Signed-off-by: Frediano Ziglio
---
src/vdagent/vdagent.c | 10 ++
src/vdagentd/vdagentd.c | 10 ++
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/src/vdagent/vdagent.c b/src/vdagent/vdagent.c
index 87dfa7c..eb741bc 100644
--- a/src/vdagent/vdagent.c
+++
Make sure all module files include config.h
Signed-off-by: Frediano Ziglio
---
src/vdagentd/console-kit.c| 1 +
src/vdagentd/dummy-session-info.c | 1 +
src/vdagentd/systemd-login.c | 1 +
src/vdagentd/virtio-port.c| 1 +
4 files changed, 4 insertions(+)
diff --git
We need to pass original argument list, however argv is modified by
g_option_context_parse so save a copy of the array to make possible
to restart with the same arguments.
Signed-off-by: Frediano Ziglio
---
src/vdagent/vdagent.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
Most removing some warnings related to Coverity.
Other just cleanups.
Other style changes.
Changes since v1:
- removed merged patches;
- some style addition.
Frediano Ziglio (7):
vdagentd: Tell different tools that we are falling through
Ignore some Coverity reports
Check errors setting
The SpiceStat structure can be 20 or 24 bytes depending on alignment.
Being a memory mapped structure potentially used with lockless access,
it is not good to have it unaligned.
The current tool that reads this memory mapped file (reds_stats) is
able to detect if the structure is either 20 or 24
35 matches
Mail list logo
