From: Marc-André Lureau
GStreamer is being increasingly used by spice-gtk. Let's make it a
core requirement.
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml| 2 --
configure.ac | 32 ++--
meson.build | 18 --
meson_options.txt |
From: Marc-André Lureau
GStreamer is being increasingly used by spice-gtk. Let's make it a
core requirement.
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml | 2 --
configure.ac | 41 ++
meson.build| 17 +---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/spice-widget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 006dc5e..c71cc53 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2609,7 +2609,7 @@ stati
From: Marc-André Lureau
Hi,
Here is a series I would like to get merged for v0.36.
- make GStreamer a build requirement
- make gstreamer audio backend default
- unfortunately, there is a bug in the GStreamer pulsesrc element
Add a check for element version >= 1.15, and fallback to pulse b
From: Marc-André Lureau
Add required dependency on gstreamer to fix unresolved GstPipeline
type warning:
:: Warning: SpiceClientGLib: (Signal)gst-video-overlay: argument
pipeline: Unresolved type: 'GstPipeline'
Signed-off-by: Marc-André Lureau
---
src/Makefile.am | 2 +-
src/
From: Marc-André Lureau
Deprecated for several releases now (v0.31).
Signed-off-by: Marc-André Lureau
---
configure.ac | 10 --
1 file changed, 10 deletions(-)
diff --git a/configure.ac b/configure.ac
index 69c03da..ff5114e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -195,16 +195,
From: Marc-André Lureau
It was release the 2012-09-07, should be enough time.
According to repology, all tracked distros have 0.5:
https://repology.org/metapackage/usbredir/versions
Signed-off-by: Marc-André Lureau
---
configure.ac | 15 ---
meson.build | 9 ++---
2 files ch
From: Marc-André Lureau
libusb 1.0.16 was released on 11 Jul 2013, that should be long enough.
From the distro we care about, according to repology, CentOS 6 and
Ubuntu 12.04 have too old libusb (1.0.9rc).
Fwiw, libusb 1.0.23 should hopefully see Windows hotplug
support (https://github.com/libu
From: Marc-André Lureau
v2.5.1 was released the 2015-11-24.
According to repology, from the distro we care about, CentOS 6,
openSUSE Leap 42.3 have too old version (0.1.2).
I didn't bother updating SPICE_CHECK_SMARTCARD, since spice-gtk is
probably the only user, and we are slowly dropping auto
From: Marc-André Lureau
Gtk+ shouldn't be used by spice-client-glib. GIO is enough.
Signed-off-by: Marc-André Lureau
---
src/win-usb-dev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/win-usb-dev.h b/src/win-usb-dev.h
index b5c4fce..7f40197 100644
--- a/src/win-usb-d
From: Marc-André Lureau
[1/14] Compiling C object
'src/25a6634@@spice-client-glib-2.0@sha/win-usb-dev.c.obj'.
../src/win-usb-dev.c: In function 'get_usb_dev_info':
../src/win-usb-dev.c:376:5: warning: implicit declaration of function
'snprintf' [-Wimplicit-function-declaration]
snprintf(ud
From: Marc-André Lureau
spice-gtk requires glib 2.46.
Modernize a bit coroutine-gthread.
Signed-off-by: Marc-André Lureau
---
src/coroutine_gthread.c | 56 -
1 file changed, 22 insertions(+), 34 deletions(-)
diff --git a/src/coroutine_gthread.c b/src/c
From: Marc-André Lureau
Remove rt/x11/m dependencies from Windows build.
Signed-off-by: Marc-André Lureau
---
meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index 42c18f0..91d0742 100644
--- a/meson.build
+++ b/meson.build
@@ -103,
From: Marc-André Lureau
Let's turn explicit true/false option into features which can be
autodetected and turned all enabled/disabled at once.
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.y
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
meson.build | 6 --
meson_options.txt | 3 +--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/meson.build b/meson.build
index 91d0742..ebc846e 100644
--- a/meson.build
+++ b/meson.build
@@ -128,8 +128,10 @@ e
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml| 1 -
meson.build | 14 +-
meson_options.txt | 3 +--
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 5d4da85..e913da4 100644
--- a/.gitlab-c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml| 1 -
meson.build | 15 +--
meson_options.txt | 3 +--
3 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index fabe29e..125dbd7 100644
--- a/.gitlab-
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml| 1 -
meson.build | 8 +++-
meson_options.txt | 3 +--
3 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index e913da4..fabe29e 100644
--- a/.gitlab-ci.yml
+++
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
meson.build | 32 +++-
meson_options.txt | 3 +--
2 files changed, 16 insertions(+), 19 deletions(-)
diff --git a/meson.build b/meson.build
index 18e330f..07e8227 100644
--- a/meson.build
+++ b/meso
From: Marc-André Lureau
Contrary to spice server dependency, spice-gtk doesn't have a known
minimum version requirement.
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml| 1 -
meson.build | 10 +++---
meson_options.txt | 3 +--
3 files changed, 4 insertions(+), 10 deletions(
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml| 1 -
meson.build | 5 +++--
meson_options.txt | 3 +--
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 692374a..a3cb6ad 100644
--- a/.gitlab-ci.yml
+++ b/.
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml| 1 -
meson.build | 5 +++--
meson_options.txt | 3 +--
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a3cb6ad..750e801 100644
--- a/.gitlab-ci.yml
+++ b/.
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
meson.build | 5 +++--
meson_options.txt | 3 +--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/meson.build b/meson.build
index 07e8227..4c9c05c 100644
--- a/meson.build
+++ b/meson.build
@@ -263,8 +263,9 @@ end
From: Marc-André Lureau
The desktop-integration code works by attempting to connect to GNOME
Session Manager. If it is absent, it will print a "Warning no
automount-inhibiting implementation available" message.
Tested on win32 as well.
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml
From: Marc-André Lureau
../src/./spice-audio.h:22:2: warning: #warning "Only can be
included directly" [-Wcpp]
#warning "Only can be included directly"
^~~
...
Signed-off-by: Marc-André Lureau
---
doc/reference/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/refer
From: Marc-André Lureau
It makes it non-obvious what that variable actually is.
Signed-off-by: Marc-André Lureau
---
meson.build | 9 -
src/meson.build | 2 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/meson.build b/meson.build
index b596a0f..bbfd8d0 100644
---
From: Marc-André Lureau
This is based on similar meson code in GStreamer.
(one of the core meson developer, Nirbheek, is also doing the GStreamer
meson build support)
This allows me to install a meson-mingw64 build, with
-Dgtk_doc=disabled, as it fails to build currently for other reasons
which
From: Marc-André Lureau
Let's have a new 'auto' default value, and use winfibers on Windows.
Signed-off-by: Marc-André Lureau
---
meson.build | 23 ---
meson_options.txt | 3 ++-
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/meson.build b/meson.buil
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/spice-gstaudio.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/spice-gstaudio.c b/src/spice-gstaudio.c
index dcd0591..aff69d2 100644
--- a/src/spice-gstaudio.c
+++ b/src/spice-gstaudio.c
@@ -59,11 +59,6 @@ static vo
From: Marc-André Lureau
There is a racy bug in pulsesrc that we can't easily workaround:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/69
It will hopefully be fixed with 1.15.
In theory, pulseaudio may not be picked by autoaudiosink, but looking
up the actual sink or
From: Marc-André Lureau
Let's not track channels ourself, but rely on the disconnected signal
instead.
This solves spicy hanging, when gstaudio is recording and the main
loop is gone, so record channel is not finalized, and GStreamer
locks.
Signed-off-by: Marc-André Lureau
---
tools/spicy.c |
From: Marc-André Lureau
Removed unused vapigen/vapidir variables as well.
Signed-off-by: Marc-André Lureau
---
meson.build | 9 +
meson_options.txt | 3 +--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/meson.build b/meson.build
index 9896151..7e0c68d 100644
---
From: Marc-André Lureau
(lt-spicy:13097): GStreamer-CRITICAL **: 18:01:13.698:
Trying to dispose element pipeline1, but it is in READY instead of the NULL
state.
You need to explicitly set elements to the NULL state before
dropping the final reference, to allow them to clean up.
Signed-off-by:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
configure.ac | 3 +++
meson.build | 1 +
2 files changed, 4 insertions(+)
diff --git a/configure.ac b/configure.ac
index a23f861..fdfdd5a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -549,3 +549,6 @@ AC_MSG_NOTICE([
])
SPICE_
From: Marc-André Lureau
The pulse backend is getting deprecated.
Signed-off-by: Marc-André Lureau
---
src/spice-audio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/spice-audio.c b/src/spice-audio.c
index daf62df..a03c80b 100644
--- a/src/spice-audio.c
+++ b/sr
On 1/7/19 10:00 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/spice-widget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 006dc5e..c71cc53 100644
--- a/src/spice-w
Hi,
On 1/7/19 10:00 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
(lt-spicy:13097): GStreamer-CRITICAL **: 18:01:13.698:
Trying to dispose element pipeline1, but it is in READY instead of the NULL
state.
You need to explicitly set elements to the NULL state before
dropping th
Hi,
On 1/7/19 10:01 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
There is a racy bug in pulsesrc that we can't easily workaround:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/69
It will hopefully be fixed with 1.15.
In theory, pulseaudio may not
On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> >
> > > I'll work on a patch to remove pulse.
> > >
> >
> > It seems too soon.
>
> yes, we haven't done enough testing of the gstreamer backend on Linux.
> The recording path at least fails very often for me due to a race:
> http
Hi
On Mon, Jan 7, 2019 at 2:03 PM Christophe Fergeau wrote:
>
> On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> > >
> > > > I'll work on a patch to remove pulse.
> > > >
> > >
> > > It seems too soon.
> >
> > yes, we haven't done enough testing of the gstreamer backend on Lin
On Mon, Jan 07, 2019 at 02:12:34PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jan 7, 2019 at 2:03 PM Christophe Fergeau wrote:
> >
> > On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> > > >
> > > > > I'll work on a patch to remove pulse.
> > > > >
> > > >
> > > > It seem
Hi
On Mon, Jan 7, 2019 at 2:50 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 02:12:34PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Jan 7, 2019 at 2:03 PM Christophe Fergeau
> > wrote:
> > >
> > > On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> > > > >
Dear developers,
While I was looking in the packets using Wireshark I saw that the Major and
Minor version is 2 and not 1 anymore. And there are some discrepancies in
the Spice protocol v1.0 and the actual value of fields. Has the protocol
been updated in any way? If yes, where can I find the chan
> Hi
>
> On Sat, Jan 5, 2019 at 9:00 PM Frediano Ziglio wrote:
> >
> > >
> > > Hi
> > >
> > > On Sat, Jan 5, 2019 at 1:59 PM Victor Toso wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Fri, Jan 04, 2019 at 04:48:21PM +0400, marcandre.lur...@redhat.com
> > > > wrote:
> > > > > From: Marc-André Lure
Can be used with Qemu on Windows or to implement software like Xspice on
Windows.
Requires a really small path for Qemu (just remove a "#include "
line).
Frediano
>
> Can you explain the end goal here?
>
> On Fri, 2018-12-21 at 12:02 +, Frediano Ziglio wrote:
> > Mainly SPICE server uses lo
On Mon, Jan 07, 2019 at 03:12:45PM +0400, Marc-André Lureau wrote:
> g_warning or g_debug, not a big difference to me here.
>
> But g_debug() is likely to be missed, since it is silent by default.
Yes, and being silent for now is the goal since the vast majority of
systems will be hitting that fa
From: Victor Toso
If SpiceGtkSession is holding the keyboard, that's huge indication
that the client should not be requesting guest's clipboard data yet.
This patch adds a check in clipboard_get() callback, to avoid such
requests. In Linux, this only happens with X11 backend.
This patch helps t
Hi
On Mon, Jan 7, 2019 at 3:44 PM Frediano Ziglio wrote:
>
> > Hi
> >
> > On Sat, Jan 5, 2019 at 9:00 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > Hi
> > > >
> > > > On Sat, Jan 5, 2019 at 1:59 PM Victor Toso
> > > > wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > On Fri, Jan 04, 2019 at
On Mon, Jan 7, 2019 at 1:06 PM Snir Sheriber wrote:
>
> Hi,
>
> On 1/7/19 10:00 AM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > (lt-spicy:13097): GStreamer-CRITICAL **: 18:01:13.698:
> > Trying to dispose element pipeline1, but it is in READY instead of the NULL
> > st
Hi
On Mon, Jan 7, 2019 at 1:11 PM Snir Sheriber wrote:
>
> Hi,
>
>
> On 1/7/19 10:01 AM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > There is a racy bug in pulsesrc that we can't easily workaround:
> > https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_req
On Mon, Jan 07, 2019 at 12:00:30PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Deprecated for several releases now (v0.31).
Ok, though it does not hurt either as it's going to be dropped when
autotools is dropped.
Reviewed-by: Christophe Fergeau
>
> Signed-off-by:
Reviewed-by: Christophe Fergeau
though they depend on the patches making gstreamer a hard dep which are
still under discussion.
Christophe
On Mon, Jan 07, 2019 at 12:00:34PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Add required dependency on gstreamer to fix un
On Mon, Jan 07, 2019 at 12:00:35PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> It was release the 2012-09-07, should be enough time.
>
> According to repology, all tracked distros have 0.5:
> https://repology.org/metapackage/usbredir/versions
>
> Signed-off-by: Marc-
On Mon, Jan 07, 2019 at 12:00:37PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> v2.5.1 was released the 2015-11-24.
>
> According to repology, from the distro we care about, CentOS 6,
> openSUSE Leap 42.3 have too old version (0.1.2).
>
> I didn't bother updating SPIC
Hi,
On Thu, Jan 03, 2019 at 09:57:40AM +0100, Jakub Janku wrote: > Hi,
>
>
> On Wed, Jan 2, 2019, 5:31 PM Victor Toso
> > Hi,
> >
> > Thanks for taking a look!
> >
> > On Sun, Dec 30, 2018 at 10:23:02PM +0100, Jakub Janku wrote:
> > > Hi,
> > >
> > > On Wed, Dec 19, 2018 at 3:30 PM Victor Toso
On Mon, Jan 07, 2019 at 12:00:38PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Gtk+ shouldn't be used by spice-client-glib. GIO is enough.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/win-usb-dev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> dif
On Mon, Jan 07, 2019 at 12:00:39PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> [1/14] Compiling C object
> 'src/25a6634@@spice-client-glib-2.0@sha/win-usb-dev.c.obj'.
> ../src/win-usb-dev.c: In function 'get_usb_dev_info':
> ../src/win-usb-dev.c:376:5: warning: implic
On Mon, Jan 07, 2019 at 12:00:41PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Remove rt/x11/m dependencies from Windows build.
librt/libm dependencies are even removed from all builds as far as I can
tell? This does not seem to make a difference on the build though.
Hi
On Mon, Jan 7, 2019 at 5:22 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:37PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > v2.5.1 was released the 2015-11-24.
> >
> > According to repology, from the distro we care about, CentOS 6,
> > openSUS
> Hi
>
> On Mon, Jan 7, 2019 at 3:44 PM Frediano Ziglio wrote:
> >
> > > Hi
> > >
> > > On Sat, Jan 5, 2019 at 9:00 PM Frediano Ziglio
> > > wrote:
> > > >
> > > > >
> > > > > Hi
> > > > >
> > > > > On Sat, Jan 5, 2019 at 1:59 PM Victor Toso
> > > > > wrote:
> > > > > >
> > > > > > Hi,
> > > >
Hi
On Mon, Jan 7, 2019 at 5:37 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:39PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > [1/14] Compiling C object
> > 'src/25a6634@@spice-client-glib-2.0@sha/win-usb-dev.c.obj'.
> > ../src/win-usb-dev.c: In
On Mon, Jan 07, 2019 at 12:00:42PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Let's turn explicit true/false option into features which can be
> autodetected and turned all enabled/disabled at once.
Is this saying that after the following commits which will turn most
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:44PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 14 +-
> meson_options.txt | 3 +--
> 3 files chang
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:43PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 6 --
> meson_options.txt | 3 +--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
On Mon, Jan 07, 2019 at 12:00:45PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 8 +++-
> meson_options.txt | 3 +--
> 3 files changed, 4 insertions(+), 8 deletions(-)
>
> dif
On Mon, Jan 07, 2019 at 12:00:46PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 15 +--
> meson_options.txt | 3 +--
> 3 files changed, 6 insertions(+), 13 deletions(
On Mon, Jan 07, 2019 at 12:00:47PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 32 +++-
> meson_options.txt | 3 +--
> 2 files changed, 16 insertions(+), 19 deletions(-)
>
> di
Acked-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:48PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 5 +++--
> meson_options.txt | 3 +--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> d
>
> Reviewed-by: Christophe Fergeau
>
Is it an ack or a nack?
> On Mon, Jan 07, 2019 at 12:00:43PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > meson.build | 6 --
> > meson_options.txt | 3 +--
> > 2 f
Missed that one, but
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:36PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> libusb 1.0.16 was released on 11 Jul 2013, that should be long enough.
>
> From the distro we care about, according to repology, Cent
On Mon, Jan 07, 2019 at 12:00:49PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Contrary to spice server dependency, spice-gtk doesn't have a known
> minimum version requirement.
Ideally, we'd still check for some not very old liblz4 to avoid compile
time failures, but
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:50PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 5 +++--
> meson_options.txt | 3 +--
> 3 files changed, 4 insert
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:51PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 5 +++--
> meson_options.txt | 3 +--
> 3 files changed, 4 insert
On Mon, Jan 07, 2019 at 12:00:52PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The desktop-integration code works by attempting to connect to GNOME
> Session Manager. If it is absent, it will print a "Warning no
> automount-inhibiting implementation available" message.
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:53PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> ../src/./spice-audio.h:22:2: warning: #warning "Only can be
> included directly" [-Wcpp]
> #warning "Only can be included directly"
> ^~~
> ...
>
On Mon, Jan 07, 2019 at 12:00:54PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This is based on similar meson code in GStreamer.
> (one of the core meson developer, Nirbheek, is also doing the GStreamer
> meson build support)
>
> This allows me to install a meson-ming
On Mon, Jan 07, 2019 at 12:00:55PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> It makes it non-obvious what that variable actually is.
Reviewed-by: Christophe Fergeau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 9 -
> src/meson.build |
On Mon, Jan 07, 2019 at 12:00:57PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Removed unused vapigen/vapidir variables as well.
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 9 +
> meson_options.txt | 3 +--
> 2 files changed, 6 insertion
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:58PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> src/spice-gstaudio.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/src/spice-gstaudio.c b/src/s
On Mon, Jan 07, 2019 at 12:01:02PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The pulse backend is getting deprecated.
Not sure this is something we should do right before a release rather
than right after the release so that the gstreamer backend on linux gets
a bit
>
> On Wed, Jan 02, 2019 at 02:56:43PM +, Frediano Ziglio wrote:
> > Formatting string should be compatible with GLib.
> > GLib uses formatting types compatible with GNU.
> > For Linux this is not an issue as both systems (like a printf) and
> > GLib one uses the same formatting type. However
On Fri, Jan 04, 2019 at 10:56:23AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> src/udscs.c| 2 ++
> src/vdagent/x11.c | 2 ++
> src/vdagentd/virtio-port.c | 1 +
> 3 files changed, 5 insertions(+)
>
> diff --git a/src/udscs.c b/src/udscs.c
> in
Acked-by: Christophe Fergeau
On Fri, Jan 04, 2019 at 10:56:24AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/vdagent.c | 16
> src/vdagentd/vdagentd.c | 16
> 2 files changed, 24 insertions(+), 8 deletions(-)
>
> Change
Formatting string should be compatible with GLib.
GLib uses formatting types compatible with GNU.
For Linux this is not an issue as both systems (like a printf) and
GLib one uses the same formatting type. However on Windows they
differs potentially causing issues.
This is also make worse as GLib 2
Windows support is useful to use with Qemu under Windows as host or
to implement servers like Xspice.
Mainly SPICE server uses lot of libraries to expose a TCP protocol.
As TCP is implemented with socket library which is quite portable was
not that hard to port.
Beside some minor feature (see REAME
This is a preparatory patch for next portability patches
Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
---
server/dispatcher.c | 2 ++
server/net-utils.c | 2 ++
server/red-channel-client.c | 6 --
server/red-qxl.c | 1 -
s
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red-channel-client.c b/server/red-channel-client.c
index 375a60b3..07f1988d 100644
--- a/server/red-channel-client.c
+++ b/server/red-channel-client.c
@@ -
Signed-off-by: Frediano Ziglio
---
server/sound.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 44b27dec..00b473a8 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -775,14 +775,13 @@ static void record_channel_send_item(RedChan
Signed-off-by: Frediano Ziglio
---
server/red-stream.c | 32 +---
server/red-stream.h | 4 ++--
2 files changed, 19 insertions(+), 17 deletions(-)
diff --git a/server/red-stream.c b/server/red-stream.c
index 57034a64..33086d99 100644
--- a/server/red-stream.c
+++ b/s
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 26 +-
server/dispatcher.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index 3e27f2c2..4cd91f11 100644
--- a/server/dispatcher.c
+++ b/server/di
Signed-off-by: Frediano Ziglio
---
server/red-common.h | 4 +-
server/reds-private.h | 4 +-
server/reds.c | 94 +++
server/reds.h | 2 +-
4 files changed, 56 insertions(+), 48 deletions(-)
diff --git a/server/red-common.h b/server/red
Signed-off-by: Frediano Ziglio
---
server/event-loop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/event-loop.c b/server/event-loop.c
index 413102e8..56200ce5 100644
--- a/server/event-loop.c
+++ b/server/event-loop.c
@@ -153,16 +153,16 @@ static void watch_up
Allows to easier port socketpair.
Windows does not have this function, we need to create a pair
using 2 internet sockets and connecting one to the other.
Signed-off-by: Frediano Ziglio
---
server/sys-socket.c | 75 +
server/sys-socket.h | 7 +
2 f
Signed-off-by: Frediano Ziglio
---
server/tests/basic-event-loop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/tests/basic-event-loop.c b/server/tests/basic-event-loop.c
index 607a5a5e..76b0580e 100644
--- a/server/tests/basic-event-loop.c
+++ b/server/tests/basic
Signed-off-by: Frediano Ziglio
---
server/net-utils.c | 33 +
server/net-utils.h | 10 ++
2 files changed, 27 insertions(+), 16 deletions(-)
diff --git a/server/net-utils.c b/server/net-utils.c
index 802509a4..8a5b62cb 100644
--- a/server/net-utils.c
+++ b
Windows needs some specific setting to use network.
Signed-off-by: Frediano Ziglio
---
configure.ac | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 96e4e66c..43224f8b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -68,6
Signed-off-by: Frediano Ziglio
---
server/tests/test-leaks.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/server/tests/test-leaks.c b/server/tests/test-leaks.c
index 64130c22..98f9cb67 100644
--- a/server/tests/test-leaks.c
+++ b/server/tests/test-leaks.c
@@ -35
These constants are meant to be used in format string for pointers
types. Use them for portability.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
index 9b63d237..488
Between Unix and Windows socket are quite different:
- on Windows sockets have a different namespace from C file
descriptors so you can't use read/write/close or similar functions;
- errors are not stored in errno but you must be read/write the
errors with specific function;
- sometimes sockets
Not supported, %m is a GNU extension of sscanf.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 84e4bb8c..ec7fbc38 100644
--- a/server/reds.c
+++ b/server/reds.c
@
1 - 100 of 138 matches
Mail list logo