Acked-by: Jonathon Jongsma
On Tue, 2019-02-12 at 21:24 +, Frediano Ziglio wrote:
> This was added in bd8771adbcf3ff34d14333cf874191e8d105f612.
> There's no reason to not use reds function instead.
> MainDispatcher needs to listen in the main thread that is the
> one provided by reds_core_*
Looks fine to me.
Insofar as I can ACK a patch that's partially my own code:
Acked-by: Jonathon Jongsma
:)
On Tue, 2019-02-12 at 21:24 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> Signed-off-by: Jonathon Jongsma
> Reviewed-by: Jonathon Jongsma
> ---
>
Instead of scanning the monitor twice (one to compute the size
and another to build the message) use a single function to
marshal the message.
This also fixes big endian machines (which are not supported).
Marshal function is exported to make easier to test (see following
patch).
Signed-off-by:
This was added in bd8771adbcf3ff34d14333cf874191e8d105f612.
There's no reason to not use reds function instead.
MainDispatcher needs to listen in the main thread that is the
one provided by reds_core_* functions.
Signed-off-by: Frediano Ziglio
---
server/main-dispatcher.c | 29
Signed-off-by: Frediano Ziglio
Signed-off-by: Jonathon Jongsma
Reviewed-by: Jonathon Jongsma
---
server/tests/test-stream-device.c | 70 +++
1 file changed, 70 insertions(+)
diff --git a/server/tests/test-stream-device.c
b/server/tests/test-stream-device.c
index
First 2 patches are related.
Changes since v1:
- removed merged ones;
- changed test for monitor ID adding some follow ups (and minor
updated like "recieving" typo and indentation).
Frediano Ziglio (3):
reds: Factor out a function to marshall VDAgentGraphicsDeviceInfo
message
why not
Acked-by: Jonathon Jongsma
On Mon, 2019-02-11 at 11:54 +, Frediano Ziglio wrote:
> Most of the time result is set to AGENT_MSG_FILTER_OK, set at
> the beginning and change if necessary.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/agent-msg-filter.c | 14 +-
> 1
Looks mostly good, but I found an issue and had a couple suggested
improvments. So I sent a couple follow-up patches that you can squash
with this patch if you think they're valid.
Reviewed-by: Jonathon Jongsma
On Mon, 2019-02-11 at 11:54 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano
Rather than showing the expected data in raw format (ascii codes, etc),
which is hard to verify, show the characters themselves, and group them
by structure.
Also add a few more comments.
---
server/tests/test-stream-device.c | 35 +++
1 file changed, 26
Stream devices assume that all QXL devices are registered with the
server before we receive any communications from the stream device. This
is due to the fact that QXL display channel IDs are assigned directly
from the QXL device ID, whereas Stream display channels are assigned
channel IDs based
From: Victor Toso
To keep all dependencies together. Some (small) effort was made to
distinguish what is necessary for Fedora and what is necessary for
Windows builds in order to install only required packages when job is
executing.
Note that we are adding gettext, gettext-devel and glib2-devel
> On Tue, 2019-02-12 at 04:05 -0500, Frediano Ziglio wrote:
> >
> > > Untested, but looks fine.
> > >
> > > Acked-by: Jonathon Jongsma
> > >
> >
> > It's partially tested by following patch. Partially as the new
> > function is
> > tested but the old function to send the message is not but
From: Victor Toso
* On a windows job-build, we don't need to install Fedora dependencies.
This change makes only one dnf install be ran per job.
* On a meson build, we should build spice-protocol with meson too.
Moving this before_script rule to each job makes all of this clear.
So, this
From: Victor Toso
Much better than playing around with shell. Logs should live for week
since the build and CI will try to always upload them.
This patch also adds the logs for tests from builds with autotools
Signed-off-by: Victor Toso
---
.gitlab-ci.yml | 20
1 file
From: Victor Toso
Documentation for gdk_display_get_primary_monitor() says that it
returns "the primary monitor, or NULL if no primary monitor is
configured by the user".
If monitor endup being NULL, we endup using unitialized GdkRectangle
geom later on as gdk_monitor_get_geometry() will fail
> Hi,
>
> On Tue, Feb 12, 2019 at 11:19:16AM -0500, Frediano Ziglio wrote:
> > > > -makecheck-meson:
> > > > +fedora-meson:
> > > >script:
> > > > - - meson build || (cat build/meson-logs/meson-log.txt && exit 1)
> > > > - - ninja -C build
> > > > - - (cd build && meson test) || (cat
From: Victor Toso
Group by target build instead of command. The focus of each job is to
check any regression for given platform, using 'fedora'/'windows' and
'autotools'/'meson' seems more intuitive.
By doing that we are grouping similar jobs together, this is
intentional as we are reducing the
On Tue, 2019-02-12 at 12:24 -0500, Frediano Ziglio wrote:
> > On Tue, 2019-02-12 at 04:05 -0500, Frediano Ziglio wrote:
> > >
> > > > Untested, but looks fine.
> > > >
> > > > Acked-by: Jonathon Jongsma
> > > >
> > >
> > > It's partially tested by following patch. Partially as the new
> > >
From: Victor Toso
Documentation for gdk_display_get_primary_monitor() says that it
returns "the primary monitor, or NULL if no primary monitor is
configured by the user".
If monitor endup being NULL, we endup using unitialized GdkRectangle
geom later on as gdk_monitor_get_geometry() will fail
Hi,
On Tue, Feb 12, 2019 at 11:19:16AM -0500, Frediano Ziglio wrote:
> > > -makecheck-meson:
> > > +fedora-meson:
> > >script:
> > > - - meson build || (cat build/meson-logs/meson-log.txt && exit 1)
> > > - - ninja -C build
> > > - - (cd build && meson test) || (cat
> >
> > From: Victor Toso
> >
> > Group by target build instead of command. The focus of each job is to
> > check any regression for given platform, using 'fedora'/'windows' and
> > 'autotools'/'meson' seems more intuitive.
> >
> > By doing that we are grouping similar jobs together, this is
>
>
> From: Victor Toso
>
> To keep all dependencies together. Some (small) effort was made to
> distinguish what is necessary for Fedora and what is necessary for
> Windows builds in order to install only required packages when job is
> executing.
>
> Note that we are adding gettext,
>
> From: Victor Toso
>
> Group by target build instead of command. The focus of each job is to
> check any regression for given platform, using 'fedora'/'windows' and
> 'autotools'/'meson' seems more intuitive.
>
> By doing that we are grouping similar jobs together, this is
> intentional as
On Tue, Feb 12, 2019 at 3:18 PM Victor Toso wrote:
>
> From: Victor Toso
>
> Group by target build instead of command. The focus of each job is to
> check any regression for given platform, using 'fedora'/'windows' and
> 'autotools'/'meson' seems more intuitive.
>
> By doing that we are grouping
On Tue, Feb 12, 2019 at 3:01 PM Victor Toso wrote:
>
> From: Victor Toso
>
> The usage of testing tool as flatkpak is discouraged by upstream
> developers, see comments from thread:
>
>
> https://lists.freedesktop.org/archives/spice-devel/2019-February/047877.html
>
> One might argue that
From: Victor Toso
Much better than playing around with shell. Logs should live for week
since the build and CI will try to always upload them.
This patch also adds the logs for tests from builds with autotools
Signed-off-by: Victor Toso
---
.gitlab-ci.yml | 20
1 file
From: Victor Toso
* On a windows job-build, we don't need to install Fedora dependencies.
This change makes only one dnf install be ran per job.
* On a meson build, we should build spice-protocol with meson too.
Moving this before_script rule to each job makes all of this clear.
So, this
From: Victor Toso
To keep all dependencies together. Some (small) effort was made to
distinguish what is necessary for Fedora and what is necessary for
Windows builds in order to install only required packages when job is
executing.
Note that we are adding gettext, gettext-devel and glib2-devel
From: Victor Toso
Group by target build instead of command. The focus of each job is to
check any regression for given platform, using 'fedora'/'windows' and
'autotools'/'meson' seems more intuitive.
By doing that we are grouping similar jobs together, this is
intentional as we are reducing the
From: Victor Toso
To keep track of meson builds for windows too.
Note that mingw64-meson requires to be ran inside the folder,
different from common meson. So, some extra steps were done due that.
Signed-off-by: Victor Toso
---
.gitlab-ci.yml | 21 +
1 file changed, 21
From: Victor Toso
From v1, removed flatkpak fixes and autogeneration. Sending this as
still seems to me that using artifacts, grouping some jobs and adding
meson+mingw build is nice-to-have changes. You tell me.
CI Run: https://gitlab.freedesktop.org/victortoso/spice-gtk/pipelines/18709
Victor
From: Victor Toso
The usage of testing tool as flatkpak is discouraged by upstream
developers, see comments from thread:
https://lists.freedesktop.org/archives/spice-devel/2019-February/047877.html
One might argue that keep this might be useful for documentation. For
that, please refer to
>
> Signed-off-by: Christophe Fergeau
Acked the series.
Frediano
> ---
> server/smartcard.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/server/smartcard.c b/server/smartcard.c
> index ff680d8a5..21dc8de5a 100644
> --- a/server/smartcard.c
> +++
Hi,
On Tue, Jan 15, 2019 at 5:11 PM Victor Toso wrote:
>
> From: Victor Toso
>
> SpiceGtkSession::allow-clipboard-managers property is introduced to
> enable other applications in the Client OS to set or fetch clipboard
> data from a spice-gtk-session that is under keyboard-grab, which is
>
>
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
Acked-by: Frediano Ziglio
> ---
> src/channel-display.c | 2 +-
> src/channel-main.h| 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/channel-display.c b/src/channel-display.c
> index
> From: Marc-André Lureau
>
> Use glib preset (from meson v0.37) to catch all our translatable
> strings and use good default settings.
>
> While at it, remove the needless directory argument.
>
> Signed-off-by: Marc-André Lureau
With or without this patch Meson seems to do nothing in the
> On Mon, 2019-02-11 at 16:14 +0200, Snir Sheriber wrote:
> > ---
> > src/channel-display-gst.c | 39 ++---
> > --
> > 1 file changed, 22 insertions(+), 17 deletions(-)
> >
> > diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
> > index
> Untested, but looks fine.
>
> Acked-by: Jonathon Jongsma
>
It's partially tested by following patch. Partially as the new function is
tested but the old function to send the message is not but is changed in
this test.
But I can see data sent to the guest (so I tested that part manually).
Hey,
On Mon, Feb 11, 2019 at 11:51:54PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Mon, Feb 11, 2019 at 6:12 PM Christophe Fergeau
> wrote:
> > I think the main objection is with making spicy too easy to install (and
> > to upgrade). Once we ask someone to test a spicy flatpak and it works
>
39 matches
Mail list logo
