Hi,
My spice server is 0.14.1 and gtk is master in the repository.
I was testing video stream. I set video-streaming to "filter" and played a .mp4
file. The CPU usage of the gtk is about 180%. When I pause the video,
theoretically the stream should be destroyed and no data sould be sent, but
Hi Cédric,
Thank you for this! This is very useful work, and I appreciate you
taking the time to work on it.
I've been through all of the patches, and I think everything looks great.
However, your 02 patch in this sequence has a lot of trailing white
space; could you eliminate that?
Also,
>
> From: Marc-André Lureau
>
> Daniel P. Berrange (24):
> Add named constants for QKeyCode values
> Add ability to generate enums
> Build tests with warnings enabled
> Add Sun/Sparc keyboard keycodes
> Add some missing mappings for USB HID
> Add line for QKey
> From: Marc-André Lureau
>
> Fix gtk-doc warnings such as:
> html/SpiceChannel.html:538: warning: no link for: "api-index-0.20" -> (0.20).
>
> Unfortunately, the generated file is still missing.
>
> Signed-off-by: Marc-André Lureau
Acked-by: Frediano Ziglio
> ---
> doc/reference/spice-gtk
>
> From: Marc-André Lureau
>
> Escape special characters with \, fixes:
> html/SpiceUsbDeviceManager.html:741: warning: no link for: "1" -> ( class="literal">1).
> html/SpiceUsbDeviceManager.html:742: warning: no link for: "2" -> ( class="literal">2).
> html/SpiceUsbDeviceManager.html:743: warn
>
> Signed-off-by: Eduardo Lima (Etrunko)
For the series:
Acked-by: Frediano Ziglio
> ---
> meson.build| 5 ++---
> server/meson.build | 3 ++-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 811099c6..459409f6 100644
> --- a/mes
Make it compatible with spice-common.
Signed-off-by: Eduardo Lima (Etrunko)
---
meson.build | 14 ++
meson_options.txt| 3 +--
subprojects/spice-common | 2 +-
3 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/meson.build b/meson.build
index f822c
Signed-off-by: Eduardo Lima (Etrunko)
---
meson.build| 5 ++---
server/meson.build | 3 ++-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/meson.build b/meson.build
index 811099c6..459409f6 100644
--- a/meson.build
+++ b/meson.build
@@ -4,7 +4,7 @@
project('spice', 'c',
This had already been done for autotools in spice-common commit
924f47a653bd87fbd50229ee34b58d7b9a3f1ec8.
Signed-off-by: Eduardo Lima (Etrunko)
---
meson.build| 15 ++-
server/smartcard.c | 4
2 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/meson.build b
> This version is already required by spice-gtk and is soon to be required
> by spice-server as well, so there is no much sense in keeping it for
> spice-commo.
>
> It is necessary to update the usage of the python module as described in
> the documentation:
>
> https://mesonbuild.com/Release-not
This version is already required by spice-gtk and is soon to be required
by spice-server as well, so there is no much sense in keeping it for
spice-commo.
It is necessary to update the usage of the python module as described in
the documentation:
https://mesonbuild.com/Release-notes-for-0-48-0.ht
> In spice-gtk commit dbdf692909f7a2b272b06a674a38a1aeb4303032, the
> smartcard option has been changed from boolean to feature, which
> actually broke the option yeld, because the option type is incompatible
> between superproject and subproject.
>
> Signed-off-by: Eduardo Lima (Etrunko)
Acke
Sure. It receives the video mode (as any video driver) by
AcquirePostDisplayInfo.
The system knows the video mode from boot time (using GOP protocol).
But when this information is broken by 0.18 driver, BasicDisplay does
not receive anything good and left us with black screen.
(This behavior is doc
The field is only assigned in do_spice_init, surely won't change
in the meanwhile.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index f27e28b9d..fbc21f7be 100644
--- a/s
Avoid to register multiple interface with the same ID.
This would results in issue as 2 channels would have same
(channel_type, channel_id) which should be unique.
Qemu always allocate QXL interface with IDs from 0.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 8
1 file changed, 8
Allows the compiler to catch some additional errors.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 306bb7c6e..f27e28b9d 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -224,11 +224,
> On Wed, 2019-02-13 at 09:19 -0500, Frediano Ziglio wrote:
> > >
> > > Stream devices assume that all QXL devices are registered with the
> > > server before we receive any communications from the stream device.
> > > This
> > > is due to the fact that QXL display channel IDs are assigned
> > > d
On Wed, 2019-02-13 at 09:19 -0500, Frediano Ziglio wrote:
> >
> > Stream devices assume that all QXL devices are registered with the
> > server before we receive any communications from the stream device.
> > This
> > is due to the fact that QXL display channel IDs are assigned
> > directly
> > fr
>
> Stream devices assume that all QXL devices are registered with the
> server before we receive any communications from the stream device. This
> is due to the fact that QXL display channel IDs are assigned directly
> from the QXL device ID, whereas Stream display channels are assigned
> channel
>
> Rather than showing the expected data in raw format (ascii codes, etc),
> which is hard to verify, show the characters themselves, and group them
> by structure.
>
Thanks, I've been really lazy, I just dump, checked and copy&paste,
this patch make it much better.
> Also add a few more comme
20 matches
Mail list logo
